mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues
30,060 Commits
23 Branches
218 Tags
662 MiB
Commit Graph

23105 Commits (f404f3154e51cd592ead7ab80c3ee69a0460eaa3)

Author SHA1 Message Date
Koen Bussemaker 701cb2e9d7 Codechange: Move two way signal EOL to a more logical place 2024-12-06 09:27:32 +01:00
translators ca148022f7 Update: Translations from eints 
english (au): 8 changes by krysclarke
greek: 8 changes by gh658804
russian: 8 changes by Ln-Wolf
finnish: 8 changes by hpiirai
french: 11 changes by glx22
portuguese (brazilian): 8 changes by pasantoro
polish: 8 changes by pAter-exe
 2024-12-06 04:45:53 +00:00
SamuXarick 005c47c322 Codechange: Use Map::Iterate() on CreateDesertOrRainForest routine 2024-12-06 10:33:11 +10:00
SamuXarick 913d6eceb0 Codechange: Use Map::Iterate() on waypoint conversion 
Still maintains the same logic as before when determining valid and invalid waypoints.
 2024-12-06 10:33:11 +10:00
SamuXarick 7d0b1cd002 Codechange: Replace while loop with Map::Iterate() 2024-12-06 10:33:11 +10:00
SamuXarick 10e2d1ca36 Codechange: Use Map::Iterate() to iterate tiles 2024-12-06 10:33:11 +10:00
Peter Nelson cfb995b6e9
Codechange: Reimplement engine sort order with std::rotate. (#13124) 2024-12-05 22:17:40 +00:00
Peter Nelson f56b6756f1 Codechange: Sort EngineOverrideManager for fast lookups. 
Allows quickly finding the EngineID given the type, grfid and local id of an engine, instead a linear scan.

This can reduce loading time when lots of engines are present and also affects performance in-game.
Lookup can be on the order of 10000 times faster.
 2024-12-05 18:17:58 +00:00
Peter Nelson 01d1ea6264 Codechange: Add Slide container helper function. 
This function will move the selected range between first and last to position, rotating elements as necessary.

Returns iterators to the new positions.
 2024-12-05 18:17:58 +00:00
Peter Nelson bc2513975f Codechange: Don't inherit EngineOverrideManager from std::vector. 
Inheriting from std::vector means some operations are needlessly complex, and shouldn't really be done anyway.
 2024-12-05 18:17:58 +00:00
Peter Nelson e73d6fcaac Codechange: Store grfid with entity grfprops. 
This allows using the grfid without having to dereference the grffile pointer.

Uses no extra storage as it fits within otherwise wasted padding space.
 2024-12-05 18:17:58 +00:00
Peter Nelson e750d10cee
Codechange: Use std::array for per-NewGRF rail/road type maps. (#13142) 
This allows initialisation to be simplified.
 2024-12-05 18:17:25 +00:00
translators 7469858f1f Update: Translations from eints 
norwegian (bokmal): 3 changes by eriksorngard
latvian: 3 changes by lexuslatvia
 2024-12-05 04:46:10 +00:00
Peter Nelson 62da507aba
Codechange: Update minimum CMake version to 3.16 for all parts. (#13141) 
The main CMakeList requires 3.16, so bump all other files to match.
 2024-12-04 14:12:57 +00:00
Peter Nelson 6f8e30c55d
Codechange: Use unique_ptr throughout instead of new raw pointer for company news data. (#13148) 
The pointer was already captured and converted to a unqiue_ptr, but hidden within the call stack.

This now makes it clearer that the object passed to Add.*NewsItem will become owned by the news item.
 2024-12-04 12:18:34 +00:00
Peter Nelson 2ff18a4f05
Fix: String parameter not set when determining width of smallmap contour labels. (#13145) 2024-12-04 12:18:17 +00:00
Peter Nelson efcafe49f7
Fix: [NewGRF] New engines did not have a default cargo type set. (#13146) 
Engines defined outside the original range did not have their cargo type/cargo label fields initialised properly.
If these engines are also not assigned a cargo type, they would therefore use the cargo in slot 0 instead of falling back to first refittable.
 2024-12-03 21:59:22 +00:00
Peter Nelson 9e182871c7 Add: Show house information in house placer. 2024-12-02 00:48:46 +00:00
Peter Nelson 041b9181f9 Codechange: Extract code to build cargo acceptance string for re-use. 2024-12-02 00:48:46 +00:00
Peter Nelson 2ede94bc40 Codechange: Adapt functions to get accepted cargo of prototype house. 2024-12-02 00:48:46 +00:00
Peter Nelson 3a158c7609 Change: Call custom house name callback in House Picker. 2024-12-02 00:48:46 +00:00
Peter Nelson 6a07f28103 Codechange: Store animated tile state in map to improve performance. 
This allows animated tiles to be added and removed without searching in the animated tile list, providing a performance improvement when there are lots of animated tiles.

Save game version is bumped so that animated tile state can be converted.
 2024-12-01 21:19:28 +00:00
Peter Nelson 44de8d77bf Codechange: Move station tile flag cached bits from m6 to m3. 
This frees up bits 0..1 of m6 for all tile types.

No savegame bump is needed as these bits are always reset on load.
 2024-12-01 21:19:28 +00:00
Peter Nelson be505ec459 Add: Accessor to test if a tile may be animated. 2024-12-01 21:19:28 +00:00
Peter Nelson 3a310f1802
Codechange: Store GRFConfig parameters in a vector. (#13137) 
All GRFConfigs have space allocated for parameters, but only configured GRFConfigs need them.

Using a vector instead means that space is only used when parameters are used.
 2024-12-01 15:15:21 +00:00
Peter Nelson e28617fda6
Codefix: Avoiding passing new raw pointer into a smart pointer. (#13138) 
Use `std::make_shared` or `std::make_unique` instead of `reset(new ...)`.
 2024-12-01 14:22:41 +00:00
Peter Nelson 46176a81e3
Add #12975: Cargo class bits 13 and 14 now define potable and non-potable. (#12979) 2024-12-01 13:48:18 +00:00
Peter Nelson 910dd65710 Change: Improve news window layouts. 
* Use appropriate container widget nesting with padding, instead of single-sided padding.
* Use layer widget to allow main news message to overlay close box and date widgets, to more closely match the old fixed-pixel layout.
 2024-12-01 09:44:11 +00:00
Peter Nelson 60f1618cc7 Add: Widget layer container widget type, NWID_LAYER. 
This widget allows child widgets to be overlaid on top of each other.

Very similar to NWID_SELECTION except all layers are always visible.
 2024-12-01 09:44:11 +00:00
translators 1885bd7166 Update: Translations from eints 
portuguese: 5 changes by azulcosta
 2024-12-01 04:47:46 +00:00
Peter Nelson 30bda88e97
Codefix: NWidgetStacked::AdjustPaddingForZoom duplicates inherited method. (#13135) 2024-11-30 23:15:17 +00:00
Peter Nelson 568bb1f5da
Change: [UI] Improve visual padding of vehicle news items. (#13134) 2024-11-30 15:29:36 +00:00
Peter Nelson 61cbdef92d
Codechange: Make AyStarStatus an enum class. (#13129) 
This enforces type-safety.
 2024-11-30 14:23:32 +00:00
translators 8d394c697c Update: Translations from eints 
dutch: 2 changes by Afoklala
polish: 2 changes by pAter-exe
 2024-11-30 04:46:18 +00:00
Peter Nelson b6aece5b88
Fix 51bd344f10: Incorrect translation table used for older NewGRFs. (#13131) 
Incorrect logic was used to select the default translation table for older GRFs.
 2024-11-29 07:46:08 +00:00
Peter Nelson fe0afef36f
Codechange: Use unique_ptr instead of raw pointer for string layouts. (#13128) 2024-11-27 23:38:57 +00:00
SamuXarick cf7710fb61
Codechange 8e9603b: Replace int32_t with AyStarStatus (#13127) 2024-11-27 23:26:07 +00:00
Peter Nelson 9bc64b553b
Codechange: Cache callback spritegroups. (#13111) 
Each callback result requires a pool memory allocation, each of which is 24 bytes.

Build a cache of results so that if the same result is used later it refers to the same group.
 2024-11-27 23:25:35 +00:00
Jonathan G Rennison f5a6a31e4a
Codefix: Avoid divide by 0 in div/mod type varaction2 adjusts (#13123) 2024-11-27 23:24:46 +00:00
Peter Nelson 23e252ad40
Codechange: Replace FontMap's std::map with std::vector. (#13126) 2024-11-27 12:36:56 +00:00
Peter Nelson 8b8cd9ae2d Codechange: Use vector for town PSA storage. 2024-11-27 12:35:27 +00:00
Peter Nelson 177e2ebf80 Codechange: Support saveload of reference vectors. 
This uses the same data format as reference lists, but for vectors, so allows data structures to be changed without affecting savegame format.
 2024-11-27 12:35:27 +00:00
translators e7c63de55d Update: Translations from eints 
korean: 2 changes by telk5093
ukrainian: 7 changes by CodyMaster3
 2024-11-27 04:49:29 +00:00
SamuXarick 8e9603bd33
Codechange: Rename and return AyStarStatus instead of int (#13125) 
- Rename enum AystarStatus to AyStarStatus.
- Return AyStarStatus instead of int for AyStar::Main and AyStar::Loop functions.
 2024-11-27 00:10:06 +01:00
translators 7c3b0e5c9c Update: Translations from eints 
polish: 1 change by pAter-exe
 2024-11-26 04:49:08 +00:00
Peter Nelson a3437df7b7
Fix #13121: Crash when clicking on scrollbar if contents don't need scrolling. (#13122) 2024-11-25 08:20:20 +00:00
translators 5b02f51e17 Update: Translations from eints 
galician: 7 changes by pvillaverde
vietnamese: 3 changes by KhoiCanDev
polish: 12 changes by pAter-exe
 2024-11-25 04:48:28 +00:00
Peter Nelson 0446123194
Change: Show company finances column if it has any values in it. (#13112) 
This solves finances not being show if the company inauguration date is in the future.

Current period is now always shown in the same position instead of moving for the first 2 years.
 2024-11-24 11:59:30 +00:00
Peter Nelson 0c04966dc3
Fix #13022: Ensure minimum size of scrollbar slider. (#13119) 
When there are many more items than fit in a list, the scrollbar slider scales to fit but there is no minimum size. It becomes too small to click on and use.

Ensure scrollbar slider is at least the same size as the buttons either end.
 2024-11-24 11:50:04 +00:00
Peter Nelson 0b0b4f50c4
Fix: Crash when exiting game with highscore window open. (#13118) 2024-11-24 10:36:21 +00:00
Peter Nelson fa1849b855 Codechange: Use std::range::find_if where possible. 2024-11-24 10:36:03 +00:00
Peter Nelson 059a4b22f7 Codechange: Use projection-based std::range::find where possible. 
This simplifies matching by class members and avoids wordy lambdas.
 2024-11-24 10:36:03 +00:00
Peter Nelson 876d53282e Codechange: Use std::ranges::count(_if). 2024-11-24 10:36:03 +00:00
Peter Nelson 3be0166801 Codechange: Use std::ranges::find where possible. 
Replace `std::find(range.begin(), range.end(), ...)` with `std::ranges::find(range, ...)`.
 2024-11-24 10:36:03 +00:00
Peter Nelson 1f18894408
Change: Determine industry directory width only on visible rows. (#13097) 
When rebuilding the industry directory list, the width of every item in the list is obtained to get the maximum width required for the horizontal scrollbar. This can take considerable time if there are a lot of industries.

Instead, calculate only for the visible rows, and grow as needed.
 2024-11-24 06:51:58 +00:00
translators 9399a92a4f Update: Translations from eints 
english (au): 2 changes by krysclarke
swedish: 4 changes by joeax910
chinese (traditional): 2 changes by KogentaSan
chinese (simplified): 3 changes by WenSimEHRP
greek: 4 changes by gh658804
russian: 3 changes by Ln-Wolf
finnish: 4 changes by hpiirai
portuguese (brazilian): 3 changes by pasantoro
polish: 46 changes by pAter-exe
 2024-11-24 04:46:32 +00:00
Loïc Guilloux 681b1928b4
Fix #13110: [Script] convert table keys to string when generating JSON (#13113) 2024-11-23 13:46:33 +01:00
Peter Nelson b890dab2b4
Change: Treat recolour sprites as regular sprites in the SpriteCache. (#13107) 
Recolour sprites are loaded when seen, instead of being loaded when needed. This could result in the sprite cache being filled up with recolour sprites, and also mean that replacing recolour sprites didn't release the previously allocated memory.

Instead, allow recolour sprites to be loaded as needed and freed when unneeded, like regular sprites.
 2024-11-23 12:14:46 +00:00
Peter Nelson 00ae20fa02
Codechange: Tidy up GRFParameterInfo. (#13114) 
Use member-initialisation, reorder members to reduce space, and prefer references.

SetValue/GetValue are moved to GRFConfig as they set the config's parameter values.
 2024-11-23 12:13:52 +00:00
Jonathan G Rennison b84a164590 Codechange: Avoid unnecessary re-reads/seeks in RandomAccessFile::ReadBlock 2024-11-23 21:48:22 +10:00
Peter Nelson 653e5e8b63 Codechange: Use std::visit for formatting script strings. 2024-11-23 10:55:41 +00:00
Peter Nelson 43da3e7693 Codechange: Use std::visit for ScriptDataVariant. 2024-11-23 10:55:41 +00:00
Peter Nelson d875ac8947 Add: const operator->() for ScirptObjectRef. 2024-11-23 10:55:41 +00:00
translators 26ae50baf9 Update: Translations from eints 
english (au): 1 change by krysclarke
chinese (traditional): 1 change by KogentaSan
korean: 5 changes by telk5093
greek: 1 change by gh658804
dutch: 1 change by KevinHeijsteeg2
 2024-11-23 04:47:22 +00:00
Peter Nelson a4b4095232
Codechange: Shuffle Engine members around to reduce size. (#13115) 
Reduces overall size of Engine from 752 to 720 bytes.
 2024-11-22 23:58:13 +00:00
Peter Nelson 16038879e4
Codechange: Speed up industry generation using industry-type checks. (#13094) 
Store a list of industries per industry type. This allows industry generation checks which only consider a specific industry type to check a reduced set of industries, leading to a potential performance increase.

This also removes the need to track industry type counts as well.
 2024-11-22 23:17:24 +00:00
Peter Nelson a951896364 Add: Add cargo transported to industry production graph. 2024-11-22 20:47:51 +00:00
Peter Nelson 22035a4f2a Add: Ability to show and filter different datasets on the same graph. 2024-11-22 20:47:51 +00:00
Peter Nelson 598fdf04a4 Codechange: Use vector instead of fixed array for graph data. 2024-11-22 20:47:51 +00:00
felixprigge 67a0fccfad
Fix: [Timetable] Use days as precision in day mode for accurate timetable syncing (#12683) 
Co-authored-by: flowprint <61750128+flowprint@users.noreply.github.com>
 2024-11-21 22:27:07 +00:00
Peter Nelson 6d3adc6169
Codechange: Remove ZeroedMemoryAllocator from ScriptText. (#13108) 
ScriptText is much simplified from its original design. Use member initialisation instead.
 2024-11-20 22:16:14 +00:00
Peter Nelson 13da98dab8
Fix: Error message not set when unable load an old save. (#13106) 2024-11-20 18:24:07 +00:00
translators 1b6a6f1cd2 Update: Translations from eints 
chinese (simplified): 4 changes by WenSimEHRP
danish: 19 changes by bscargo
 2024-11-20 04:46:40 +00:00
Peter Nelson b730f8783e
Fix d450d4743: Division by zero when larger_towns is set to 0. (#13104) 
Universe ended.
 2024-11-20 00:09:02 +00:00
Peter Nelson 9b6b6d50c3
Fix: Network clients incorrectly truncated all strings to NETWORK_COMPANY_NAME_LENGTH. (#13102) 
This should no longer be necessary since we used std::strings.
 2024-11-19 23:44:54 +00:00
SamuXarick 85e9f5745a
Codefix: Replace magic number in Kdtree (#13098) 2024-11-19 20:34:25 +00:00
Peter Nelson 6c09dcdd66
Codechange: Use reference for non-optional StationList parameter. (#13092) 2024-11-19 20:33:32 +00:00
Peter Nelson 640a270ed6
Codefix: Use correct type for IndustryType in several industry functions. (#13096) 2024-11-19 20:32:06 +00:00
Peter Nelson fcac5479f1
Codechange: Use std::visit for SetupCargoForClimate. (#13103) 2024-11-19 20:30:16 +00:00
Peter Nelson fc8685d618
Codechange: Use functor for Kdtree's XYFunc. (#13074) 
Kdtree uses a function pointer and incorrectly calls it a functor. The function pointer needs to be passed on instantiaton.

Instead, use an actual functor. This simplifies instantiation.
 2024-11-19 20:29:56 +00:00
Koen Bussemaker 369ea29e1e Codechange: Remove redundant checks in FindClosestTrainDepot 2024-11-19 20:42:43 +01:00
Peter Nelson f9b5f78b8a Codechange: Use std::visit for GetActiveCargoLabel. 2024-11-19 18:27:19 +00:00
Peter Nelson 25c5a64d39
Codechange: Use std::visit instead of std::get_if for string parameters. (#13100) 
It's tidier and ensures all cases are handled, and doesn't use pointers.
 2024-11-19 18:17:41 +00:00
SamuXarick 60ae50e016
Codechange: Make kdtree member functions const for const-correctness (#13099) 2024-11-19 12:36:56 +00:00
Michael Lutz d2496b6ec4 Add: [NewGRF] Callback for custom refit mask for engines/vehicles. 2024-11-18 22:10:38 +01:00
Michael Lutz a3ee05737f Add: [NewGRF] Vehicle prop that allows refittability based on cargo class intersection. 2024-11-18 22:10:38 +01:00
Peter Nelson c39810ff6a Codechange: Replace path cache queues with vectors. 
Ship and RoadVehicle path caches use a std::deque, which is quite memory hungry, especially for RoadVehicle which has two.
std::deque was used to be able to push/pop from either end.

Change to use a single std::vector each, which is now push/popped from the back.
 2024-11-18 08:59:41 +00:00
Peter Nelson d4f8453c22 Codefix: Clear and reserve storage when loading vectors from savegames. 2024-11-18 08:59:41 +00:00
translators b8f3d0dd68 Update: Translations from eints 
norwegian (bokmal): 4 changes by eriksorngard
 2024-11-18 04:49:46 +00:00
Peter Nelson d903806e59
Codechange: Add VectorSaveLoadHandler to simplify handlers for vectors. (#13093) 
This reduces the duplication needed for each saved complex vector.
 2024-11-17 23:46:32 +00:00
translators a6c526cfa0 Update: Translations from eints 
bulgarian: 4 changes by Alexandar83
 2024-11-17 04:46:16 +00:00
Peter Nelson 04b6dfae48
Cleanup: Remove now-unneeded includes from yapf. (#13088) 2024-11-16 23:23:06 +00:00
Peter Nelson ec1dc434ac
Codechange: Shuffle CommandCost members to reduce size. (#13087) 
Prefer member initialisation as well.
 2024-11-16 21:49:49 +00:00
Jonathan G Rennison 71ea58c6de
Codechange: Remove unused CYapfDestinationTileT (#13086) 2024-11-16 16:12:18 +00:00
Peter Nelson 57ac1cbe0c
Fix: Don't allow right-click to close world generation progress window. (#13084) 2024-11-16 13:54:47 +00:00
translators 8c395ed67c Update: Translations from eints 
vietnamese: 4 changes by KhoiCanDev
 2024-11-16 04:48:13 +00:00
Peter Nelson 14e2839087
Codechange: Let's use this new emplace_back() thing. (#13081) 2024-11-15 20:28:17 +00:00
Peter Nelson 98c8445519
Codechange: Limit house default cargo label lists to original slot counts. (#13079) 
Same as for IndustrySpec and IndustryTileSpec.
 2024-11-15 08:07:02 +00:00
translators d6c2f9edf1 Update: Translations from eints 
polish: 5 changes by pAter-exe
 2024-11-15 04:48:47 +00:00
Peter Nelson 61aff3fa49
Codechange: Limit industry default cargo label lists to original slot counts. (#13072) 
IndustrySpec and IndustryTileSpec cargo label lists are only used for original industries. Original industries can only have up to 2 inputs and 3 outputs. Therefore having space for 16 input/outputs slots is unnecessary

This saves 216 bytes per industry type, and 164 bytes per industry tile type.
 2024-11-14 19:05:18 +00:00
translators 9742038b68 Update: Translations from eints 
chinese (simplified): 2 changes by WenSimEHRP
 2024-11-13 04:45:59 +00:00
Koen Bussemaker 6faf4fa70a Codechange: Simplified YAPF ship region node 2024-11-12 23:17:56 +01:00
Koen Bussemaker 3e195df3c7 Codechange: Cleaned up and renamed NodeList 2024-11-12 21:06:17 +01:00
Peter Nelson bbc1f7b3dc
Add: Show and toggle follow vehicle state in vehicle view window. (#13076) 
* After double-clicking on a location button to follow a vehicle, show that state by drawing the location button in a lowered state.
* Allow cancelling the follow state by clicking on the location button again.
 2024-11-12 17:36:24 +00:00
translators ce64d5f5d9 Update: Translations from eints 
japanese: 56 changes by akaregi
 2024-11-11 04:45:41 +00:00
translators 66198dea46 Update: Translations from eints 
japanese: 50 changes by akaregi
german: 4 changes by SecretIdetity
french: 4 changes by ottdfevr
 2024-11-10 04:45:21 +00:00
translators 5e4f8db7d6 Update: Translations from eints 
latvian: 4 changes by lexuslatvia
 2024-11-09 04:45:00 +00:00
translators 80f628063a Update: Translations from eints 
tamil: 7 changes by merni-ns
 2024-11-08 04:45:16 +00:00
Thomas Winwood b1bba967a1
Add: Improving town-owned bridges increases company rating (#13036) 2024-11-07 08:14:04 -05:00
Jonathan G Rennison 7b3525954c
Fix: x-axis direction of industry production graph (#13062) 2024-11-07 08:13:21 -05:00
translators c9bd21d579 Update: Translations from eints 
chinese (traditional): 4 changes by KogentaSan
 2024-11-07 04:45:57 +00:00
Peter Nelson d54341318e
Fix: VF_LOADING_FINISHED and VF_STOP_LOADING flags tested on wrong vehicle part. (#13063) 
These flags are only set on the front part of a vehicle as they apply to the whole consist.
 2024-11-07 00:25:05 +00:00
Charles Pigott 884b93c4c0
Add: Set application name for SDL2 (#13061) 2024-11-06 19:51:03 +00:00
Peter Nelson 465df3bab1 Change: Don't try to flood buoys or dock tiles. 
This reduces the active flooding water tiles a little more.
 2024-11-06 19:44:14 +00:00
Peter Nelson 8f9836793f Change: Store water tile flooding state in the map. 
This allows water tiles which cannot flood any further to not even try to flood.

On a large map with lots of water tiles this can noticeably reduce game loop processing time.

Mostly ported from JGRPP.
 2024-11-06 19:44:14 +00:00
Tyler Trahan 4cd46e54aa
Fix #12940: Use specific error when overbuilding station on signals (#12943) 2024-11-06 14:13:04 -05:00
Tyler Trahan c3bb512bd9
Remove: Hidden setting for adjacent stations (#12862) 2024-11-06 14:11:07 -05:00
Joan Josep 5d7a7b2955
Codechange: Simplify IsCompanyBuildableVehicleType. (#12868) 2024-11-06 19:09:09 +00:00
Peter Nelson 3b6d3080f2 Add: Apply rail/road type conversion when NewGRFs are updated mid-game. 
This will update the rail/road type of tiles on the map, taking account of tram state, if types are moved around.
 2024-11-06 19:04:44 +00:00
Peter Nelson 8bb6572943 Add: Implement missing road type label conversion. 
This was implemented for rail types but missed for road types.

This lets road type labels to be reordered, allowing for upgrades of NewGRF.
 2024-11-06 19:04:44 +00:00
Peter Nelson 157d028915 Codechange: Simplify testing for railtype map conversion. 
Build the list of railtype conversions at the same time as testing if conversion is needed.

This avoids having two similar loops which need to compare the same things.
 2024-11-06 19:04:44 +00:00
Jonathan G Rennison 36c735ebfa
Codefix: Nullptr dereference in industry var 0xB4 when no cargoes accepted (#13060) 2024-11-06 18:53:48 +00:00
Jonathan G Rennison 59c399c795
Codefix: Documentation comment in IndustryDirectoryWindow (#13059) 2024-11-06 18:52:30 +00:00
translators 29df467d27 Update: Translations from eints 
swedish: 4 changes by joeax910
 2024-11-06 04:47:50 +00:00
translators 9da6cd4817 Update: Translations from eints 
catalan: 4 changes by J0anJosep
 2024-11-05 04:45:21 +00:00
translators 362db76e13 Update: Translations from eints 
norwegian (nynorsk): 32 changes by Abaksle
 2024-11-04 04:47:31 +00:00
Peter Nelson f0f62961e1
Codechange: Make two water functions static. (#13057) 2024-11-03 23:25:51 +00:00
Peter Nelson a91d889646
Fix #13053: Payment transfers incorrect for non-passenger cargos. (#13054) 
CargoPayment required cargo type to be set as state via SetCargo(). This was error prone as CargoPayment is per consist but cargo type can vary per vehicle part. Additionally if SetCargo was not called then the default "uninitialised" state was cargo slot 0, passengers.

Instead of trying to make sure it is set correctly, remove cargo type from CargoPayment and always pass it explicitly to the PayTransfer/PayFinalDelivery methods.
 2024-11-03 18:53:01 +00:00
translators cbde825785 Update: Translations from eints 
korean: 5 changes by telk5093
finnish: 4 changes by hpiirai
 2024-11-03 04:45:28 +00:00
Peter Nelson a1233ee8a1
Codechange: Use span instead of marker terminated array for indexed sprite loading. (#13050) 2024-11-02 14:47:49 +00:00
translators 9193d69e0b Update: Translations from eints 
english (au): 4 changes by krysclarke
english (us): 4 changes by 2TallTyler
chinese (simplified): 4 changes by WenSimEHRP
greek: 4 changes by gh658804
russian: 4 changes by Ln-Wolf
dutch: 4 changes by Afoklala
portuguese: 4 changes by jcteotonio
portuguese (brazilian): 4 changes by pasantoro
 2024-11-02 04:47:18 +00:00
translators 3a76af0909 Update: Translations from eints 2024-11-01 04:46:43 +00:00
Anatoly Eltsov 3fca0cf3ee
Feature: Industry production graph (#10541) 2024-10-31 22:35:04 +00:00
Peter Nelson db1a1c5dd9 Change: Invalidate build toolbars when NewGRFs are changed. 
If NewGRFs are changed while a rail or road toolbar is open, the toolbar could refer to an invalid rail/road type. If so, close it.
 2024-10-31 09:10:01 +00:00
Peter Nelson 6d2b93d3b3 Codechange: Set up rail/road toolbar buttons during window's OnInit event. 
This ensures the buttons are configured without extra initialisation methods.
 2024-10-31 09:10:01 +00:00
Peter Nelson 0e3fdfb1b5 Codechange: Don't store pointer to RoadTypeInfo in road toolbar. 
Always look up via stored RoadType instead. This matches out the rail toolbar behaves, and avoids keeping an non-owned pointer lying around.
 2024-10-31 09:10:01 +00:00
Peter Nelson 552cf72b98
Codefix: Immediately return invalid rail/road type when looking for label 0. (#13045) 
Looking for label 0 would incorrectly return the first undefined type instead of INVALID_RAIL/ROADTYPE, which could potentially cause incorrect behaviour.
 2024-10-31 00:11:16 +00:00
Loïc Guilloux 9dae626237
Codefix: restore _generating_world and nearest town cache when failing to fund a random town (#13042) 2024-10-29 19:56:15 +01:00
Jonathan G Rennison 883be19865 Codefix a6f412c6: Missing this-> in YAPF 2024-10-29 19:07:14 +01:00
Jonathan G Rennison 07e8547eb5
Fix: Terraform of road waypoint tiles (#13040) 2024-10-29 14:08:15 +01:00
Koen Bussemaker 0200bc3720 Codechange: Renamed CHashTableT to HashTable and corrected code style 2024-10-29 08:35:47 +01:00
Peter Nelson 0e13a7d124
Fix 3f81124: Invalid data used for height map curves after first run. (#13039) 
Static variable depended on other non-static variables.
 2024-10-28 23:18:05 +00:00
SamuXarick a96a83e330
Codechange: Code style issues in water regions (#13019) 2024-10-28 10:29:26 -04:00
translators abd89b0748 Update: Translations from eints 
german: 19 changes by Wuzzy2
 2024-10-28 04:47:39 +00:00
Peter Nelson e076aaf740
Codefix: Use SpriteID when passing sprite IDs. (#13037) 2024-10-27 18:54:49 +00:00
Peter Nelson e1697a6ad1
Codechange: Don't use enums for non-enumerated values. (#13031) 
In the past we have used enums to hold an arbitrary values. These values
are not enumerated types, so make them constants instead.
 2024-10-27 18:02:49 +00:00
SamuXarick a86f9dba0f
Codefix: Correct handling of GetDepotOrderType() comparison (#13023) 
In the function where we check the depot order type, using `!=` with GetDepotOrderType() is not ideal because the function can return flag bits.
 2024-10-27 18:47:22 +01:00
Peter Nelson 9cf47e69d6
Fix bb8a0c7641: Skip control codes when sorting strings. (#13035) 
Now that SkipGarbage doesn't skip all multi-byte utf-8 characters, string control codes are not skipped either. This gave unintended sorting when NewGRF names start with colour codes.

Make SkipGarbage UTF-8 aware so that it is able to skip some unicode ranges as well.
 2024-10-27 15:49:09 +00:00
translators 233ee16c44 Update: Translations from eints 
bulgarian: 18 changes by Alexandar83
 2024-10-27 04:47:27 +00:00
Peter Nelson bb8a0c7641
Fix: SkipGarbage() skipped all multi-byte utf-8 characters. (#13032) 
`char` is signed so `str[0] < '0'` applies to all characters higher than 127.
 2024-10-26 21:01:33 +01:00
Peter Nelson 1191efa581
Fix #12914: Fix use of invalidated pointer in viewport drawer. (#12918) 
Use index of last child instead of pointer to update next_child element.

In case there is no child sprite yet, the most recent parent sprite's first_child is updated instead.
 2024-10-26 15:24:41 +01:00
Peter Nelson 4f9c10d35f
Codechange: Simplify storage of WaterTileType in map. (#13030) 2024-10-26 10:17:44 +01:00
Peter Nelson e50c1774fc Codechange: Remove some unnecessary local variables. 2024-10-25 19:01:39 +01:00
Peter Nelson c39554a210 Codechange: Simplify selection between pathfinder functions. 2024-10-25 19:01:39 +01:00
Peter Nelson 1403a55e5d Codechange: Use uppercase naming for YAPF cost constant. 2024-10-25 19:01:39 +01:00
Peter Nelson a171939ec3 Codechange: Remove `m_` prefix from pathfinders. 2024-10-25 19:01:39 +01:00
Peter Nelson a496e9397c Codechange: Prefer member-initialization. 2024-10-25 19:01:39 +01:00
Peter Nelson a6f412c615 Codechange: Add `this->` to YAPF. 2024-10-25 19:01:39 +01:00
Peter Nelson 5b73654f94 Codechange: Add includes to YAPF .hpp files. 2024-10-25 19:01:39 +01:00
Peter Nelson 009e57ee03 Codechange: Use member initializer list. 2024-10-25 19:01:39 +01:00
Rubidium ea6aa4653a Codechange: replace magic numbers with enumeration 2024-10-25 18:37:11 +02:00
Rubidium 4a4c77ff04 Codechange: use functions described in documentation, instead of related other functions 2024-10-25 18:37:11 +02:00
Jonathan G Rennison 8ed983b3cd Codechange: Re-order load update for SLV_139 
It is no longer required to be performed before the first phase
of vehicle updates
 2024-10-25 17:05:59 +02:00
Jonathan G Rennison f19829d029 Fix #12831: Delay vehicle cache init to after map upgrades in load 
Split AfterLoadVehicles into two functions.
Vehicle cache init and other functionality requiring an upgraded and
valid map is now performed later in the load process.
 2024-10-25 17:05:59 +02:00
Rubidium dfb74e25f7 Codechange: remove parameter which value can always be deduced 2024-10-24 22:02:50 +02:00
SamuXarick d5a13fb9f4
Codechange: Use TileOffsByAxis(...) in more places (#13026) 2024-10-24 15:58:15 -04:00
Rubidium c9819f8957 Codechange: split GetRoadDir as bays have DiagDir and drive throughs have Axis 2024-10-24 20:40:32 +02:00
Da-W1nn3r d6aa09f96a Fix #12973: Don't exclude high score after using sandbox 2024-10-24 08:38:16 +02:00
Rubidium ce641af6a9 Codechange: use StationGfx over RoadStopDir + optional offset for drive through stop 2024-10-23 18:19:32 +02:00
Rubidium 38c9eb76a0 Codechange: add and use TileOffsByAxis(...) over TileOffsByDir(DiagDirToAxis(...)) 2024-10-23 18:19:17 +02:00
Peter Nelson 7a71df2952
Codechange: Use fmt::format to convert value to binary string representation. (#13016) 
Avoids manually iterating bits into an array.
 2024-10-22 13:59:08 +01:00
translators 51ffb2a1a3 Update: Translations from eints 
arabic (egypt): 3 changes by Alaadel
 2024-10-22 04:47:27 +00:00
Peter Nelson 01807fa753 Change: Use Markdown for changelog. 
Includes minor changes to how version changes are limited for display.
 2024-10-22 00:34:16 +01:00
Peter Nelson e98407973f Fix #12993: Replace known-bugs text with markdown version. 
This allows a little bit better formatting/display in game.

(No attempt to check if these are still valid known-bugs...)
 2024-10-22 00:34:16 +01:00
Peter Nelson e3bfe2b668
Fix: Don't invalidate water regions on the other side of the map. (#13012) 
When invalidating water regions with a tile at the very edge of the map, the region on the opposite side of the map would also be invalidated.
 2024-10-22 00:33:29 +01:00
Peter Nelson 3eb7901ad9
Codechange: Use template parameter of SetBitIterator instead of casting later. (#13015) 
This removes some manual casting.
 2024-10-21 17:54:54 +01:00
Jonathan G Rennison 6ca9ddcffa Codefix: [Win32] String handling in OTTDStringCompare, Win32StringContains 
Avoid truncation if CompareStringEx is missing
Fix handling of zero length inputs
 2024-10-21 17:34:30 +02:00
Jonathan G Rennison d7a2efd623 Codefix: [Win32] Truncated stack trace symbols were not null-terminated 
SymGetSymFromAddr64/IMAGEHLP_SYMBOL64 do not null-terminate
symbols with lengths >= the name buffer size
 2024-10-21 17:34:03 +02:00
Rubidium 18e8a34081 Codechange: replace "magic" trick with simpler straight forward code 2024-10-20 15:49:32 +02:00
Rubidium 392bcf5c9a Codechange: simplify ToTileIndexDiff by just calling TileDiffXY 2024-10-20 15:49:32 +02:00
Rubidium 1998e94ae7 Codechange: create the TileIndexDiff of the whole translation we want to execute 2024-10-20 15:49:32 +02:00
Rubidium a6b7593a52 Codechange: use TileDiffXY(0, 0) over magic 0 2024-10-20 15:49:32 +02:00
Rubidium 3b0fcf442f Codefix: use actual type instead of int for TileIndexDiff 2024-10-20 15:49:32 +02:00
Jonathan G Rennison 3105f6391c
Fix #13002: Crash due to use of dangling types in picker GUI used/saved lists (#13008) 2024-10-20 09:37:17 +01:00
translators 582f37dc15 Update: Translations from eints 
luxembourgish: 84 changes by phreeze83
 2024-10-20 04:46:58 +00:00
Rubidium 4a359a4aed Fix 8ca417b: drying of (edge) tiles should consider MP_VOID tiles 2024-10-19 23:32:34 +02:00
Peter Nelson 147ac56f11
Fix: ScriptTile::PlantTreeRectangle does not check that the end tile is in bounds. (#13004) 
If the starting tile is near the edge of the map, the width and height could overflow the map boundary.

In some cases this might result in a different area being planted than expected.
 2024-10-19 20:52:02 +01:00
Rubidium 9d2e07b1f6 Codechange: simplify terraform recursion logic 2024-10-19 15:40:36 +02:00
Rubidium 8ca417baa9 Codefix: do not wrap-around the map when flooding tiles 2024-10-19 09:00:21 +02:00
translators 5e8da0479a Update: Translations from eints 
luxembourgish: 23 changes by phreeze83
 2024-10-19 04:45:07 +00:00
Jonathan G Rennison ffcc594ea3 Codefix: Incorrect documentation comments in StringBuilder 2024-10-18 22:29:28 +02:00
Rubidium b074a4d3ce Codefix: remove duplicate typedef 2024-10-18 16:43:17 +02:00
translators 35d37d4768 Update: Translations from eints 
norwegian (nynorsk): 2 changes by Abaksle
luxembourgish: 33 changes by phreeze83
 2024-10-18 04:47:11 +00:00
Peter Nelson 2fda7d8297
Codechange: Simplify Station::train_station iteration when marking tiles dirty. (#13003) 2024-10-17 23:01:04 +01:00
translators ae4a723889 Update: Translations from eints 
norwegian (nynorsk): 8 changes by Abaksle
 2024-10-17 04:47:13 +00:00
Peter Nelson bacd3e83c6 Codechange: Use ScriptObjectRef to handle Event reference counting. 
This removes manual reference counting.
 2024-10-16 21:52:00 +01:00
Peter Nelson 8360fab18a Codechange: Remove CCountedPtr. 
This was originally generic and used by YAPF, but now it is used only by script objects.

CCountedPtr provided much more (untested) functionality than used.

ScriptObjectRef already exists for script objects and does the same thing, so use this instead.
 2024-10-16 21:52:00 +01:00
Koen Bussemaker d8029b1d84 Fix: CHashTableT's Clear function doesn't set number of items back to zero 2024-10-16 22:36:26 +02:00
Peter Nelson d5b57a56f4
Codechange: Use std::unique_ptr for link graph schedule handlers. (#12988) 
This removes manual memory management.
 2024-10-15 02:11:06 +01:00
Rubidium 4a6ac52d8c Cleanup: remove some unused #defines 2024-10-14 21:37:00 +02:00