06bd47af4f
Revert d8771b3: Construction stage wrong for all houses
2024-06-26 16:27:02 -04:00
21813fbe8b
Fix #12818 : during Hostile Takeover, profit was calculated wrongly ( #12819 )
2024-06-26 14:19:53 +00:00
Peter Nelson
209b0320d5
Fix #12735 : Default fonts should use default font size as-is. ( #12814 )
...
Minimum readable font size should only apply to fallback and configured fonts.
2024-06-26 12:45:39 +01:00
88e53dbdc8
Update: Translations from eints
...
english (au): 10 changes by krysclarke
swedish: 13 changes by joeax910
english (us): 10 changes by 2TallTyler
chinese (simplified): 14 changes by WenSimEHRP
russian: 6 changes by Ln-Wolf
catalan: 14 changes by J0anJosep
latvian: 15 changes by lexuslatvia
portuguese (brazilian): 12 changes by pasantoro
2024-06-26 04:44:08 +00:00
a873a952aa
Codefix: Reorder comments of HasPowerOnRoad/Rail and IsCompatibleRail. ( #12813 )
2024-06-25 17:22:53 -04:00
d3c7b1015c
Codefix cff48c0f6: unused variable remained after refactor
2024-06-25 22:26:37 +02:00
705207e2ce
Add: Town window zoom with mouse wheel
2024-06-25 20:48:20 +02:00
a23ff227e7
Add: Industry window zoom with mouse wheel
2024-06-25 20:48:07 +02:00
ff3be45c23
Add: Toggle for showing industry names in small map
2024-06-25 20:43:28 +02:00
a1e94ccddb
Update: Translations from eints
...
english (au): 2 changes by krysclarke
norwegian (bokmal): 2 changes by eriksorngard
english (us): 2 changes by 2TallTyler
russian: 2 changes by Ln-Wolf
finnish: 2 changes by hpiirai
french: 2 changes by ottdfevr
portuguese (brazilian): 2 changes by pasantoro
polish: 2 changes by pAter-exe
2024-06-25 04:41:42 +00:00
9936b3728a
Change: Don't explain what "toggle" means in tooltips ( #12805 )
2024-06-24 16:28:58 -04:00
a43dacd988
Add: NewGRF custom road waypoint support
2024-06-24 22:12:08 +02:00
c35a5e5cb1
Change: Add variable ground types for road waypoints
2024-06-24 22:12:08 +02:00
eebd5e47db
Add: Road waypoint default graphics
2024-06-24 22:12:08 +02:00
9c84e5df3f
Add: Road waypoint functionality
2024-06-24 22:12:08 +02:00
c6387c7784
Codechange: Use filter template struct for nearby station type filtering
2024-06-24 22:12:08 +02:00
05b65703d3
Codechange: Increase size of StationType field in map array
...
Move can station have wires bit to make room
2024-06-24 22:12:08 +02:00
72276e2d3c
Add: Vehicle window zoom with mouse wheel
2024-06-24 21:56:26 +02:00
c3a051a213
Codechange: Referencing enum for 'scroll_mode' setting in gui_settings.ini
2024-06-24 21:56:26 +02:00
c53ed9fad6
Codechange: Creating enum for 'scrollwheel_scrolling' setting
2024-06-24 21:56:26 +02:00
e8be933ee6
Update: Translations from eints
2024-06-24 04:42:12 +00:00
Peter Nelson
e802c1a97f
Add: Show count of towns and industries in their directory window captions. ( #12800 )
...
These windows now show "(<visible> of <total>)" in the caption.
2024-06-23 17:55:37 +01:00
Peter Nelson
7116f143d5
Codefix: Hole in vehicle list window if dimensions are not as expected. ( #12803 )
...
The layouts for these windows assume that push buttons and dropdowns are the same height.
2024-06-23 08:14:06 +01:00
97e9442d5e
Update: Translations from eints
...
norwegian (bokmal): 32 changes by eriksorngard
galician: 2 changes by pvillaverde
2024-06-23 04:42:04 +00:00
Peter Nelson
91fd082e93
Fix: Apply widget's internal padding to scrollbar capacity/position. ( #12801 )
...
For non-WWT_MATRIX widgets, scrollbars need to take account of the internal padding used for the widget.
This is not normally noticeable as framerect padding is only 2 extra pixels
2024-06-22 15:42:13 +00:00
e0bcb54a4b
Change: Allow bribing local authority when other company has exclusive rights ( #12763 )
2024-06-22 07:51:03 -04:00
49d47b3b74
Update: Translations from eints
...
greek: 2 changes by gh658804
dutch: 2 changes by Afoklala
lithuanian: 4 changes by khamper
french: 9 changes by Lishouuu
2024-06-22 04:40:41 +00:00
64781df29f
Update: Translations from eints
...
english (us): 2 changes by 2TallTyler
2024-06-21 04:43:18 +00:00
e3e215b249
Update: Translations from eints
...
german: 3 changes by Wuzzy2
portuguese (brazilian): 4 changes by pasantoro
2024-06-20 04:41:06 +00:00
2dab9ac7a5
Update: Translations from eints
...
swedish: 4 changes by joeax910
catalan: 2 changes by J0anJosep
2024-06-19 04:42:11 +00:00
Peter Nelson
b56775f576
Codechange: Avoid making copies of intermediate layout runs. ( #12796 )
...
The vector of runs is not used after it is passed to the ParagraphLayout class, so pass with std::move to avoid an unnecessary copy.
2024-06-17 22:58:52 +01:00
Peter Nelson
731c56d116
Codefix: Add missing `const` inside script functions. ( #12794 )
...
Scripts do not modify items directly, marking them const enforces this.
2024-06-17 07:19:56 +01:00
7db70f9c3f
Update: Translations from eints
...
english (au): 2 changes by krysclarke
norwegian (bokmal): 6 changes by eriksorngard
korean: 3 changes by telk5093
russian: 2 changes by Ln-Wolf
finnish: 3 changes by hpiirai
portuguese: 2 changes by azulcosta
portuguese (brazilian): 2 changes by pasantoro
polish: 5 changes by pAter-exe
2024-06-17 04:43:34 +00:00
e3156546fa
Codefix: Don't claim to allocate new waypoint when just checking ( #12792 )
2024-06-16 16:07:57 -04:00
Peter Nelson
2f54904bab
Codefix: Incorrect indentation of NWidgetParts in load/save windows. ( #12791 )
...
Fix to use the "standard" layout of 1 tab for nesting widgets and 2 tabs for attributes that wrap on to the next line.
2024-06-16 18:54:19 +01:00
2bc3cc5b67
Codechange: Compiler check for _fios_colours/DetailedFileType ( #12781 )
2024-06-16 08:54:41 +02:00
0e7916a51b
Update: Translations from eints
...
greek: 2 changes by gh658804
lithuanian: 1 change by khamper
2024-06-16 04:41:19 +00:00
b18d8d6574
Fix: ensure revision mismatch also considers random debugging status
2024-06-15 23:14:45 +02:00
0409577277
Add: Setting to disable warning for old vehicles ( #12714 )
2024-06-15 17:14:29 -04:00
d8771b3f68
Change: Don't use house construction states in Scenario Editor ( #12730 )
2024-06-15 17:11:00 -04:00
4cbaac6dac
Fix #10239 : Use elevated snow height for roads on flat foundations ( #12776 )
2024-06-15 17:10:39 -04:00
d7137651f2
Fix #12787 : boostrap doesn't have main vindow ( #12788 )
2024-06-15 20:39:15 +00:00
Peter Nelson
b991a399ef
Codechange: Split MakeNWidget to improve readability. ( #12785 )
...
Split MakeNWidget() into two stages, widget-creation and attribute-applying, to reduce function size and make it clearer.
2024-06-15 20:10:52 +01:00
Peter Nelson
22d70f9334
Codechange: Pass NewGRF ByteReader by reference. ( #12786 )
...
ByteReader must be present and not null, so don't use a pointer.
2024-06-15 10:55:26 +01:00
Peter Nelson
b68172c225
Codechange: Use std::endian instead of TTD_ENDIAN where trivial. ( #12778 )
2024-06-15 10:24:17 +01:00
Peter Nelson
f9f07e9001
Fix #12775 : Text truncated incorrectly on Windows. ( #12782 )
...
Caused by a -1 in the wrong place, which moved glyphs left one pixel.
2024-06-14 16:32:31 +01:00
Peter Nelson
7b7e00123e
Codechange: Shuffle RoadStop members to reduce size.
...
Size is reduced from 40 bytes to 32 bytes on 64 bit platforms.
2024-06-14 13:32:08 +01:00
Peter Nelson
77f62e0c90
Codechange: Shuffle OrderList members to reduce size.
...
Size is reduced from 40 bytes to 32 bytes on 64 bit platforms.
2024-06-14 13:32:08 +01:00
219995c643
Update: Translations from eints
...
polish: 1 change by pAter-exe
2024-06-13 04:42:16 +00:00
Peter Nelson
55314513ce
Codechange: Pass NWidgetParts as span instead of begin/end pointers. ( #12779 )
2024-06-12 23:08:35 +01:00
81b5a7c7c6
Update: Translations from eints
...
german: 62 changes by Wuzzy2
2024-06-12 04:42:02 +00:00
Peter Nelson
4cf6d1dd79
Codechange: Pass WindowDesc by reference instead of pointer. ( #12771 )
...
WindowDesc as passed to Windows is not optional so don't allow to it to be nullptr.
2024-06-11 08:58:03 +01:00
18bce69623
Update: Translations from eints
...
galician: 3 changes by pvillaverde
danish: 1 change by bscargo
polish: 5 changes by pAter-exe
2024-06-10 04:43:42 +00:00
7db756e602
Change: Do not automatically connect double depots with track
2024-06-09 14:50:59 +02:00
fa82dd6096
Fix #12030 : Water infrastructure totals when using DC_FORCE_CLEAR_TILE
...
To remove objects on water
2024-06-09 14:49:09 +02:00
Peter Nelson
b4b2fad8e0
Fix #12648 : Ensure all uses of std::filesystem::path use native encoding. ( #12650 )
...
std::filesystem::path does not expect UTF-8 strings, so they must be converted to native format first (and back to utf-8 after.)
2024-06-09 10:23:47 +01:00
Peter Nelson
fce9361bf2
Change: Position caret on left or right of glyph depending on language direction.
2024-06-09 09:57:20 +01:00
Peter Nelson
5cd81a980e
Codechange: Store both left and right glyph positions in a run.
...
This also allows the end of a run to be known without using an extra position entry.
2024-06-09 09:57:20 +01:00
Peter Nelson
80ddcb9d7d
Codechange: Move GetCharPosInString/GetCharAtPosition to gfx_layout.
...
These functions are related more to layouting than graphics.
2024-06-09 09:57:20 +01:00
Peter Nelson
bbbf2b5282
Codechange: Return read-only span instead of vector from layout run functions.
2024-06-09 09:57:20 +01:00
6bf214af6e
Update: Translations from eints
...
vietnamese: 3 changes by KhoiCanDev
polish: 13 changes by pAter-exe
2024-06-09 04:41:27 +00:00
Peter Nelson
79c1492a73
Codechange: Use unique_ptr in MemoryDumper. ( #12766 )
...
This replaces C-style manual memory management.
2024-06-08 21:59:56 +01:00
af7ad964dd
Codechange: Avoid unnecessary allocation of temporaries in layout line cache ( #12737 )
2024-06-08 21:21:02 +01:00
d7eb29d292
Update: Translations from eints
...
dutch: 2 changes by Afoklala
2024-06-08 04:42:12 +00:00
Peter Nelson
df1b6a933b
Fix #12764 : Crash when opening Detailed performance rating window with no companies. ( #12765 )
2024-06-07 21:57:18 +01:00
79b573704b
Update: Translations from eints
...
french: 1 change by ottdfevr
portuguese: 2 changes by azulcosta
polish: 33 changes by pAter-exe
2024-06-07 04:43:07 +00:00
Peter Nelson
66044472d7
Codechange: Use std::unordered_map for NewGRF language_map.
...
NewGRFs only use a small subset of the available language IDs. Using an unordered_map allows only the reference languages to have space allocated.
This avoids manual new/delete of array.
2024-06-06 19:53:10 +01:00
Peter Nelson
fee73f3253
Codechange: Split types out of newgrf_text.h
2024-06-06 19:53:10 +01:00
fa24a3ec6b
Update: Translations from eints
...
korean: 1 change by telk5093
2024-06-06 04:41:41 +00:00
1f636d94d4
Update: Translations from eints
...
finnish: 2 changes by hpiirai
2024-06-05 04:43:21 +00:00
Peter Nelson
57186d4650
Fix: Editbox behaved improperly with RTL languages. ( #12746 )
...
Text in the editbox was always left-aligned and did not scroll with the caret position.
2024-06-04 23:05:51 +01:00
Peter Nelson
579ce8eae0
Codefix: Find GRF override entries properly. ( #12743 )
...
My naive code from 16 years ago tested for GRF overrides in a way that will create empty 0 entries for each source GRF tested.
2024-06-04 18:06:19 +01:00
342a7cebd6
Update: Translations from eints
...
english (au): 2 changes by krysclarke
chinese (simplified): 2 changes by WenSimEHRP
urdu: 6 changes by haidermazhar
russian: 2 changes by Ln-Wolf
catalan: 3 changes by J0anJosep
latvian: 2 changes by lexuslatvia
portuguese (brazilian): 2 changes by pasantoro
2024-06-04 04:41:49 +00:00
Peter Nelson
5fd23a2d70
Codechange: Pre-reserve vectors during NewGRF loading. ( #12748 )
...
Call reserve when we are given the number of elements up front. This reduces the number of reallocations and over-allocations done during loading.
2024-06-03 18:40:27 +01:00
01c75fc578
Update: Translations from eints
...
urdu: 24 changes by haidermazhar
2024-06-03 04:42:34 +00:00
Peter Nelson
1ab280a27a
Change: Use UK OSK layout for English (UK) ( #12720 )
2024-06-02 15:28:51 +01:00
0d10c5e93c
Update: Translations from eints
...
greek: 1 change by gh658804
2024-06-02 04:41:25 +00:00
Peter Nelson
6d2424c0ef
Codechange: Update each town label dimensions once during map gen. ( #12742 )
...
This avoids re-layouting the label for each change in population as the town is grown.
2024-06-01 16:57:17 +01:00
Peter Nelson
96fc367bcf
Change: [NewGRF] Treat house max year 0xFFFF as MAX_YEAR. ( #12740 )
2024-06-01 12:54:49 +01:00
3827229c74
Update: Translations from eints
...
english (us): 1 change by 2TallTyler
finnish: 1 change by hpiirai
dutch: 1 change by Afoklala
2024-06-01 04:41:17 +00:00
Peter Nelson
7e914a0568
Fix #12738 , de16655f: Fallback font searcher failure since ? substitution removed.
...
Fallback font searcher looked for the substituted ? glyph, which was removed by #12736 .
Instead of comparing against a sprite, test against the font returning a missing glyph.
This should also improve performance of fallback font searching, as previously glyphs were actually rendered while searching.
2024-05-31 21:47:47 +01:00
5bca185923
Update: Translations from eints
...
english (au): 1 change by krysclarke
chinese (simplified): 1 change by WenSimEHRP
russian: 1 change by Ln-Wolf
slovak: 20 changes by Kukoluk
latvian: 1 change by lexuslatvia
portuguese: 1 change by azulcosta
portuguese (brazilian): 1 change by pasantoro
2024-05-31 04:43:36 +00:00
31085230a6
Codechange: use std::vector for the available neighbours
2024-05-30 23:15:38 +02:00
2864f3b3eb
Cleanup: remove C-style hash, binary heap and priority queue
2024-05-30 23:15:38 +02:00
0e75dfd49f
Codechange: migrate aystar to use YAPF's nodelist infrastructure
2024-05-30 23:15:38 +02:00
Peter Nelson
48539992e8
Codechange: Use std::unordered_map for storing TrueTypeFontCache's GlyphEntry.
2024-05-30 20:16:28 +01:00
Peter Nelson
7b717fcccb
Codechange: Replace AllocatorProc with SpriteAllocator class.
...
This allows for state to be passed to or maintained by the allocator.
2024-05-30 20:16:28 +01:00
Peter Nelson
de16655f76
Change: [UI] Remove substitution of missing glyph with '?' glyph. ( #12736 )
...
When a glyph does not exist, we substitute it with the '?' glyph instead, but layouters are not aware of this substitution.
2024-05-30 18:33:58 +01:00
Peter Nelson
9c19cf06e4
Change: [UI] Use SetMinimalTextLines to set label height correctly. ( #12734 )
...
SetMinimalSize does not know about font size, so these labels were incorrectly sized if the font height is different from normal.
2024-05-30 12:31:21 +01:00
Peter Nelson
0f230244fe
Codechange: [UI] Remove redundant SetMinimalSize for WWT_EDITBOX widgets. ( #12733 )
2024-05-30 08:34:26 +01:00
deb77463b0
Fix #12492 : Clarify helptext for "minutes per year" setting ( #12726 )
2024-05-29 14:58:36 -04:00
85918fc23e
Fix: Water infrastructure total when changing owner of object on water
2024-05-29 20:11:43 +02:00
Peter Nelson
2e7819927f
Fix: Invalidate game options window after changing base sounds set. ( #12731 )
2024-05-29 17:05:04 +01:00
51e170a8d0
Update: Translations from eints
...
swedish: 12 changes by sereneavatar
2024-05-29 04:42:57 +00:00
Peter Nelson
f220ed179d
Codechange: Use std::unordered_map for SpriteFontCache's glyph map. ( #12724 )
...
Replaces a C-style malloc'd array and malloc'd contents, and no manual memory clean up is necessary.
2024-05-28 19:34:03 +01:00
Peter Nelson
3d4b98845a
Codechange: Remove initial colour from layouter cache. ( #12728 )
...
Initial colour is now always TC_INVALID, which is substituted with the desired colour when drawing the layout line.
This allows strings which differ only by initial colour to use the same layout cache entry, increasing the efficacy of the cache.
2024-05-28 19:33:44 +01:00
605dff4920
Update: Translations from eints
...
swedish: 9 changes by joeax910
english (us): 2 changes by 2TallTyler
luxembourgish: 4 changes by phreeze83
catalan: 2 changes by J0anJosep
latvian: 27 changes by lexuslatvia
2024-05-28 04:45:37 +00:00
37f68a65ee
Fix #12283 : Vehicle group dropdown shouldn't have default action ( #12727 )
2024-05-27 16:26:07 -04:00
Peter Nelson
f6c5da4cad
Fix: Incorrect dump_info output with labels outside of ascii range. ( #12723 )
...
An unspecified cargo label is 0x00000000, which terminates C-strings.
2024-05-27 12:44:49 +01:00
Peter Nelson
4b81b62b72
Change: Don't reinitialise font caches when setting initial interface scale. ( #12722 )
2024-05-27 12:44:34 +01:00
692943669d
Update: Translations from eints
...
galician: 34 changes by pvillaverde
greek: 3 changes by gh658804
2024-05-27 04:41:33 +00:00
Peter Nelson
517dab35b1
Codechange: Use range-for to iterate base media files. ( #12721 )
2024-05-26 16:46:18 +01:00
Peter Nelson
3c42f701d7
Fix: Allow changing size of default OpenTTD font. ( #12641 )
...
* Fix: Allow changing size of default OpenTTD font.
Size configuration for default font was ignored as a different code path to load the font was followed.
Resolved by removing this additional path and conditionally selecting the default font.
2024-05-26 15:59:25 +01:00
Peter Nelson
2c70ccb137
Add: [NewGRF] Extended custom waypoint classes. ( #12653 )
...
This allows waypoints to be split into categories just like stations, instead of all being lumped together.
Station class labels with the first byte set to 0xFF will be treated in the same way as the 'WAYP' class.
2024-05-26 09:53:33 +01:00
d11823df36
Update: Translations from eints
...
korean: 2 changes by telk5093
2024-05-26 04:42:20 +00:00
6efc1fa250
Codechange: Removed unused yapf PfNodeCachFlush function
2024-05-25 21:49:12 +02:00
c325a2ebd4
Update: Translations from eints
...
estonian: 3 changes by siimsoni
dutch: 2 changes by Afoklala
french: 2 changes by ben20471
portuguese: 2 changes by azulcosta
2024-05-25 04:42:07 +00:00
Peter Nelson
676d64037d
Fix d6ccfdb: GetCharPosition failed for RTL text. ( #12710 )
...
Changes in d6ccfdb
2024-05-24 15:33:30 +01:00
d9cadb49b0
Update: Translations from eints
...
english (au): 2 changes by krysclarke
chinese (simplified): 7 changes by WenSimEHRP
korean: 4 changes by telk5093
russian: 2 changes by Ln-Wolf
finnish: 2 changes by hpiirai
portuguese (brazilian): 2 changes by pasantoro
2024-05-24 04:43:08 +00:00
Peter Nelson
5fefe0b61f
Fix: Reverse left/right keypress when editing RTL text. ( #12711 )
...
When editing RTL text, pressing left should increment instead of decrement the character position to move left, and vice versa.
2024-05-23 21:34:05 +01:00
Peter Nelson
f87c6990b0
Fix: Memory leak in CoreTextFontCache. ( #12662 )
...
Temporary buffer for rendering glyphs was not freed after use. Instead let CGBitmapContextCreate() handle the buffer.
> data may be a pointer to pixels. If you pass NULL, the context will create its own buffer and free that buffer itself later. If you pass your own buffer, the context will not free it; it remains your buffer that you must free after you release the context, hopefully for the last time.
2024-05-23 21:07:11 +01:00
071796660d
Fix: Implement support for secure state coding on macOS
...
Fixes a warning when running on macOS 14 and newer about not officially supporting secure state coding.
2024-05-23 19:32:29 +02:00
b2572c7ca8
Fix #12563 : Race condition setting finish flag in WinHTTP
2024-05-23 19:31:45 +02:00
9f13d3ff2b
Update: Translations from eints
...
chinese (simplified): 2 changes by WenSimEHRP
greek: 11 changes by gh658804
2024-05-23 04:40:46 +00:00
8f6e21617f
Fix #12591 : Give descriptive error when station construction fails due to wrong layout ( #12678 )
2024-05-22 17:56:03 -04:00
b2f1a06def
Change: support listing/updating authorized keys of companies by the admin in the console
2024-05-22 22:20:10 +02:00
fea9ffa808
Codechange: also allow removing clients from the company allow lists
2024-05-22 22:20:10 +02:00
Peter Nelson
8a6745b26f
Codechange: Use PIP instead of spacer widgets for OSK spacing. ( #12709 )
...
This (slightly) simplifies the OSK widget layout.
2024-05-22 19:06:52 +01:00
Peter Nelson
766350bfd2
Fix: Hide empty house 'classes' in house picker. ( #12694 )
...
Picker class list should not list classes with no items. The house picker could break this 'rule' with NewGRFs loaded.
2024-05-22 18:06:59 +01:00
Peter Nelson
7e12b5ff0f
Fix: Crash if interface scale or font size changes with chat box present. ( #12705 )
...
Caused by the chat box being undrawn with the new dimensions, leading to out-of-bounding memory access.
2024-05-22 18:06:34 +01:00
42fc32243d
Fix #12681 : Abstract filetype not set for network client join savegames ( #12701 )
2024-05-22 09:43:01 +01:00
Peter Nelson
19ca4089a1
Codechange: Use std::filesystem::exists instead of access. ( #12702 )
2024-05-22 09:23:01 +01:00
5bc3723bcc
Update: Translations from eints
...
czech: 11 changes by vladoschreiner
2024-05-22 04:42:40 +00:00
Peter Nelson
5442b0dd2d
Fix: Make progress bars obey language direction. ( #12704 )
...
With RTL languages, progress bars should start from the right.
2024-05-21 00:40:08 +01:00
Peter Nelson
28e814f62a
Codechange: Use L"" instead of _T("") ( #12703 )
2024-05-20 17:34:22 +00:00
fb4a370d3f
Update: Translations from eints
...
vietnamese: 13 changes by KhoiCanDev
chinese (simplified): 1 change by WenSimEHRP
finnish: 11 changes by hpiirai
french: 29 changes by ottdfevr
polish: 1 change by aefoes
2024-05-20 04:43:22 +00:00
46d7586ab1
Update: Translations from eints
...
estonian: 8 changes by siimsoni
chinese (simplified): 4 changes by ahyangyi
korean: 13 changes by telk5093
2024-05-19 04:43:16 +00:00
29ce013eda
Codechange: Pass avail(able) as reference instead of pointer since they are never nullptr ( #12696 )
2024-05-18 17:04:16 +02:00
Peter Nelson
ba47d1ca2b
Fix: Allow resolving house parent scope (town) of unbuilt houses. ( #12695 )
...
Return unavailable variable result, instead of nullptr dereference.
2024-05-18 12:33:50 +01:00
Peter Nelson
3f5a354f37
Codechange: Use emplace with ICURun and UniscribeRun. ( #12693 )
2024-05-18 09:17:38 +01:00
Peter Nelson
856ec901ca
Fix #12685 : nullptr dereference when checking for equal loaded/loading groups. ( #12686 )
...
Always treat empty groups as non-equal. Given that the case of both being empty is handled earlier, they cannot both be equal and empty.
Additionally if a loaded or loading set are all the same, only add one reference.
2024-05-18 09:17:06 +01:00
7fd2487c46
Update: Translations from eints
...
swedish: 6 changes by joeax910
chinese (simplified): 2 changes by WenSimEHRP
dutch: 27 changes by Afoklala
2024-05-18 04:40:26 +00:00
Peter Nelson
8d26d032e1
Fix #12497 : [NewGRF] Increase vehicle motion counter for all parts. ( #12561 )
...
NewGRFs relied on the incorrectly motion counter that was 'fixed' in #12229 , so always update v->motion_counter for all vehicle parts.
2024-05-17 20:50:04 +01:00
Peter Nelson
c85481564f
Codechange: Use reusable temporary buffer in Win32FontCache. ( #12666 )
...
This avoids allocating and deleting a temporary buffer for every glyph that is rendered into a sprite.
2024-05-17 08:50:59 +01:00
Peter Nelson
4940b6ff0b
Codefix: Compile warning with newer C++ compiler on MinGW. ( #12689 )
...
> template-id not allowed for constructor in C++20
2024-05-16 12:09:19 +01:00
26113e3622
Update: Translations from eints
...
english (au): 11 changes by krysclarke
swedish: 7 changes by joeax910
english (us): 11 changes by 2TallTyler
chinese (simplified): 11 changes by WenSimEHRP
russian: 11 changes by Ln-Wolf
catalan: 11 changes by J0anJosep
portuguese: 13 changes by azulcosta
portuguese (brazilian): 11 changes by pasantoro
2024-05-16 04:41:07 +00:00
Peter Nelson
ca52da6c95
Fix: Unable to choose a font containing hyphen. ( #12684 )
...
FcNameParse may require some characters be escaped. Instead, pass name as FC_FAMILY.
2024-05-16 00:38:23 +01:00
Peter Nelson
d1b7619822
Change: Ignore min/max years for manual house placer. ( #12687 )
2024-05-15 23:17:58 +01:00
56ea002283
Update: Translations from eints
...
catalan: 16 changes by J0anJosep
latvian: 2 changes by lexuslatvia
2024-05-15 04:41:37 +00:00
Peter Nelson
980dcaac6e
Cleanup: Remove GetFontTable from FontCache. ( #12677 )
...
This interface is no longer used, so does not need to be implemented.
Removes manual memory management with malloc/free.
2024-05-14 21:13:26 +01:00
Peter Nelson
ed67aedabf
Feature: Allow manually placing town buildings in scenario editor.
...
House picker is accessed from the Landscaping toolbar as there is no town toolbar.
Once placed these houses behave like any other and can be removed by players and towns.
Uses the unified picker system, so also supports used/saved favourites. As town building don't have class labels, town zones are use to imitate them.
2024-05-14 21:11:48 +01:00
Peter Nelson
874cfe000b
Codechange: Set underlying type for HouseSpec enums.
2024-05-14 21:11:48 +01:00
Peter Nelson
b731ab0632
Change: Allow sprite resolver to evaluate non-existent houses.
...
This could previous be done but only with a town and tile in mind, but for drawing in the UI, neither of those exist yet.
2024-05-14 21:11:48 +01:00
Peter Nelson
d99c1337a2
Add: Command to build an individual house on a specific tile.
2024-05-14 21:11:48 +01:00
Peter Nelson
f901722066
Codechange: Rename BuildTownHouse to TryBuildTownHouse.
2024-05-14 21:11:48 +01:00
bb77d16e40
Add: Shade button to waypoint picker ( #12682 )
2024-05-14 14:43:56 -04:00
486af1a6fc
Fix: [Admin] #12411 Send Network Welcome Packet to admin port after game creation completed
...
WelcomeAll moved into NetworkOnGameStart
Signed-off-by: Muxy <muxy@goulp.net>
2024-05-14 19:24:31 +02:00
Peter Nelson
460fab920c
Fix #12418 , 338def1b06: Filename extension taken from wrong string. ( #12680 )
2024-05-14 18:18:30 +01:00
00c4b232b3
Fix #12550 : files were not saved in the right location when binary and configuration are in the same folder
2024-05-14 17:01:28 +02:00
3f06aa441b
Update: Translations from eints
...
english (us): 17 changes by 2TallTyler
greek: 147 changes by KyriakosMich
2024-05-14 04:40:19 +00:00
9f63b9f65d
Fix #12594 : Give descriptive error when company takeover fails due to vehicle limit ( #12676 )
2024-05-13 10:10:03 -04:00
870149406a
Update: Translations from eints
...
chinese (simplified): 23 changes by WenSimEHRP
russian: 17 changes by Ln-Wolf
portuguese (brazilian): 8 changes by pasantoro
2024-05-13 04:41:24 +00:00
Peter Nelson
18e56df5e1
Fix #12674 : Non-NewGRF Build Station widgets may not fill window properly. ( #12675 )
...
Allow labels in Build Station window to fill width as needed.
2024-05-13 00:18:07 +00:00
Peter Nelson
f2f7573c3f
Fix #12668 : Crash opening picker window with filter when no results available. ( #12669 )
...
When first opening the picker window, we attempt to find a valid class and type to select. If the picker window was closed with filters enabled, there may not be anything list that is usable.
Resolve this by using callbacks to find the first usable type when no types are listed.
2024-05-12 20:14:29 +01:00
77c188e6da
Codechange: use std::vector instead of malloced array
2024-05-12 12:55:52 +02:00
6cea49c117
Codechange: replace uint with size_t in binary heap
2024-05-12 12:55:52 +02:00
8349203038
Cleanup: remove unused Aystar variables
2024-05-12 10:46:03 +02:00
Peter Nelson
77a7113ba6
Cleanup: Remove unused parameters from FreeTypeFontCache::SetFontSize. ( #12663 )
2024-05-12 08:39:40 +01:00
f939e81bf0
Fix #12655 , 4f6d75f: inconsistent state in client list and potential crash after client leaves
2024-05-12 07:23:40 +02:00
95a89e43b2
Update: Translations from eints
...
english (au): 16 changes by krysclarke
chinese (simplified): 16 changes by XiaoJi-Game
korean: 19 changes by telk5093
russian: 1 change by Ln-Wolf
finnish: 16 changes by hpiirai
lithuanian: 1 change by khamper
portuguese: 17 changes by azulcosta
portuguese (brazilian): 16 changes by pasantoro
2024-05-12 04:41:31 +00:00
Peter Nelson
34da94ffc8
Fix: Use widget resize step instead of window resize step. ( #12659 )
...
Build Picker class list filter could be drawn incorrectly depending on how the window can be resized.
2024-05-11 20:51:44 +01:00
Peter Nelson
d78f39a9df
Cleanup: Remove GetUnitsPerEM and units_per_em. ( #12656 )
...
GetUnitsPerEM is never called.
2024-05-11 14:50:34 +01:00
721cd2b8ad
Update: Translations from eints
...
ukrainian: 1 change by Quantom2
dutch: 5 changes by Afoklala
lithuanian: 1 change by khamper
2024-05-11 04:41:26 +00:00
Peter Nelson
b30fe0d7da
Feature: Ctrl-click to toggle favourites in build-pickers.
...
This allows ctrl-click on a type in a build-picker window to remember it
as a favourite. An new filter button to show only favourites makes it
simpler to use these types.
Favourite types are saved locally in favs.cfg, so are remembered between
games.
2024-05-11 02:12:41 +01:00
Peter Nelson
fde3b35a24
Feature: New filter to show only used types in build-pickers.
...
This filters the build-picker type lists to only show types that have
already been placed in the current game, making it simpler to get to
build matching features.
2024-05-11 02:12:41 +01:00
Peter Nelson
b76517816e
Feature: Add "All" filter to build-picker show types from all classes.
...
Toggling the "All" filter causes the class selection to be ignored, so
that items from all classes can be displayed together. The class text
filter is still applied.
This makes it easier to search amongst types for a feature.
2024-05-11 02:12:41 +01:00
Peter Nelson
cdc356e7bf
Change: Unify station/waypoint/roadstop/object build-picker window code.
...
These windows now share a common code base for choosing and display class and types.
An additional text filter is added to search types by name instead of just classes.
2024-05-11 02:12:41 +01:00
Peter Nelson
d2c8b476b5
Codechange: Add functions to test if a station/roadstop class is a waypoint.
...
This is now checked by class label instead of by index.
2024-05-11 02:12:41 +01:00
Peter Nelson
9f8c9724be
Codechange: Add station/roadstop class labels for DFLT/WAYP.
...
This avoids repeating the same multichar literal value.
2024-05-11 02:12:41 +01:00
Peter Nelson
d5671030b1
Codechange: Add NewGRFSpecsBase class to hold class/index information.
...
Standardises how the class index is stored in the spec, instead of relying ot the Spec structs having the same members.
This allows retrieving class_index and index without searching or using pointer arithmetic.
'cls_id' is renamed to 'class_index' to make it clearer that it is an index rather than the multichar label of the class.
2024-05-11 02:12:41 +01:00
Peter Nelson
733284cc16
Codechange: Return std::vector from GetMusicCatEntryData.
...
Return std::vector instead of pointer to array with manual memory management.
2024-05-11 02:10:41 +01:00
Peter Nelson
31c306c6cd
Codechange: Return std::string from GetMusicCatEntryName.
...
Return std::string instead of pointer to C-string with manual memory management.
2024-05-11 02:10:41 +01:00
dc22edc556
Doc: [Script] Extend API documentation on calendar- vs economy-time
2024-05-10 13:17:19 +01:00
04cc0c8125
Codechange: [Script] Document relation between ScriptErrorType and ErrorMessages enums
2024-05-10 13:17:19 +01:00
40e6230900
Codechange: Add main page to script API documentation
2024-05-10 13:17:19 +01:00
dfa2622153
Codechange: Unify naming of squirrel built-in types in Script API docs
2024-05-10 13:17:19 +01:00
e436e2ef40
Codefix: broken links and syntax issues in script API documentation
2024-05-10 13:17:19 +01:00
64e1f1d4d9
Codefix: Script API documentation about IDs was incomplete
2024-05-10 13:17:19 +01:00
4bf2dc3148
Codefix: Script API did not link simple types correctly
2024-05-10 13:17:19 +01:00
c1375cecf8
Codefix: [Script] script_types was excluded from API documentation
2024-05-10 13:17:19 +01:00
ffe76a0133
Update: Doxyfiles to doxygen 1.9.4
2024-05-10 13:17:19 +01:00
c3ee5e58a3
Cleanup: Move remaining NPF files into pathfinder directory
2024-05-10 10:38:44 +02:00
798ec4184b
Cleanup: Remove unused function InvalidateShipPathCache
...
This was only used in the callback when changing the ship pathfinder setting.
2024-05-10 10:38:44 +02:00
55a7c59d13
Remove: NPF and pathfinder change settings
2024-05-10 10:38:44 +02:00
a5c2543efc
Update: Translations from eints
...
chinese (simplified): 7 changes by WenSimEHRP, 4 changes by ahyangyi
2024-05-10 04:40:29 +00:00
cef9417c9f
Fix: always allow setting company settings, company/president name/face
...
There is a nice feature that synchronises the client settings upon setting up the company. Before
this, those commands would not be executed when no-actions-while-paused is set. This means that,
silently and depending on the server configuration, your wished for configuration might not be
there.
Similarly there is the president's face that's being set while creating a new company and setting
of the president/company name upon creation, when no-actions-while-paused is set.
So, just allow these operations also while paused to get a uniform experience when joining. To
keep the UI somewhat consistent, apply this "freedom" also to the other bits set from the company
UI; specifically company name and company colour.
2024-05-09 21:51:26 +02:00
a313676189
Doc: reason for using ::SendNet over ::Post in few cases
2024-05-09 21:51:26 +02:00
ed888c617b
Codechange: just use ::Post over ::SendNet for creating new companies
2024-05-09 21:51:26 +02:00
59ac27f385
Fix #12643 : _is_water_region_valid is not cleared/reset in AllocateWaterRegions
2024-05-09 20:18:04 +02:00
Peter Nelson
ec61951512
Cleanup: Remove Windows 9x font locale workaround. ( #12644 )
2024-05-09 07:03:02 +01:00
Peter Nelson
5b35fbd6f5
Change: Use button aspect ratio for buttons that show vehicle icons. ( #12636 )
2024-05-09 07:01:56 +01:00
132e226b27
Update: Translations from eints
...
greek: 169 changes by KyriakosMich
lithuanian: 21 changes by khamper
polish: 1 change by pAter-exe
2024-05-09 04:42:47 +00:00
00cfd572ff
Cleanup: Remove unneeded CheckMissingGlyphs call ( #12640 )
2024-05-08 21:42:02 +02:00
cb3f99859c
Update: Translations from eints
...
english (au): 1 change by krysclarke
estonian: 25 changes by siimsoni
korean: 3 changes by telk5093
russian: 1 change by Ln-Wolf
finnish: 1 change by hpiirai
catalan: 5 changes by J0anJosep
latvian: 30 changes by lexuslatvia
lithuanian: 140 changes by khamper
portuguese: 1 change by azulcosta
portuguese (brazilian): 3 changes by pasantoro
2024-05-08 04:40:34 +00:00
Peter Nelson
b74a7e749b
Fix: Console command scrolling did not take account of padding and cursor width. ( #12642 )
2024-05-08 01:52:30 +01:00
Peter Nelson
731d46beb5
Change: Don't include midi file processing in dedicated server build. ( #12632 )
2024-05-08 00:57:52 +01:00
Peter Nelson
9008d793ab
Change: Use per-company group numbers. ( #12297 )
...
This is used by the default group name, replacing the use of group index.
2024-05-07 19:01:28 +00:00
8710e9b8c8
Fix #12608 : SDL keycode to vkey mapping
2024-05-07 18:33:29 +02:00
ab7e2a1883
Update: Translations from eints
...
english (au): 2 changes by krysclarke
english (us): 2 changes by 2TallTyler
greek: 4 changes by gh658804
russian: 2 changes by Ln-Wolf
finnish: 4 changes by hpiirai
danish: 2 changes by bscargo
lithuanian: 170 changes by khamper
french: 1 change by ben20471
portuguese: 2 changes by azulcosta
portuguese (brazilian): 2 changes by pasantoro
polish: 2 changes by pAter-exe
2024-05-07 04:41:01 +00:00
1a3cbaec56
Cleanup: remove warning about server administrators being able to read passwords
2024-05-07 00:03:15 +02:00
849d1fa1b3
Cleanup: remove UI for asking user for company password
2024-05-07 00:03:15 +02:00
457d51fc49
Cleanup: remove company password hashing and anything related to it
2024-05-07 00:03:15 +02:00
a9318cf653
Cleanup: remove UI for changing the password
2024-05-07 00:03:15 +02:00
9dc1fdc385
Cleanup: remove client side password checks when moving to a different company
2024-05-07 00:03:15 +02:00
16639939e9
Cleanup: remove command line option for company password
2024-05-07 00:03:15 +02:00
ca4bef1504
Cleanup: remove company password related network packets
2024-05-07 00:03:15 +02:00
71fc907584
Change: remove company passwords over client allow lists
2024-05-07 00:03:15 +02:00
a002803d1c
Remove: autoclean_unprotected settings; all companies will be protected
2024-05-07 00:03:15 +02:00
4f3db8eeaf
Feature: authorize specific clients to join network company without password
2024-05-07 00:03:15 +02:00
66354ab9eb
Codechange: introduce allow list infrastructure for companies
2024-05-07 00:03:15 +02:00
1250ce8fdc
Codechange: support storing std::string vectors/deques in the savegame
2024-05-07 00:03:15 +02:00
4e9a280ef8
Update: Translations from eints
...
swedish: 2 changes by sereneavatar
norwegian (bokmal): 2 changes by eriksorngard
welsh: 19 changes by Ansbaradigeidfran
english (us): 2 changes by 2TallTyler
czech: 1 change by JsSusenka
lithuanian: 97 changes by khamper
french: 2 changes by Lishouuu
portuguese (brazilian): 1 change by pasantoro
polish: 2 changes by pAter-exe
2024-05-06 04:41:07 +00:00
b9c894b717
Fix: for GUI network servers, name the first company the same as any other company
2024-05-05 22:57:50 +02:00
455e202e03
Fix: server's client is shown incorrectly in some cases
2024-05-05 22:57:50 +02:00
Peter Nelson
4740eeaa43
Add: 'Get Content' buttons next to base set dropdowns in Game Options. ( #12627 )
...
This allows base set content to be downloaded more easily, filtered by type and next to where it is set up.
2024-05-05 16:15:35 +01:00
d2f98440bb
Codechange: Make assert in follow_track easier to understand and debug
2024-05-05 16:30:44 +02:00
Peter Nelson
84ebae0bf5
Codechange: Tweak layout of network client list. ( #12624 )
...
Use PIP spacing instead of spacers and more used of standard WidgetDimensions.
2024-05-05 14:57:17 +01:00
Peter Nelson
cf94bd321d
Codechange: Remove redundant SetMinimalSize of preview buttons. ( #12622 )
...
These widgets are also sized in UpdateWidgetSize where the current bevel width is accounted for as well.
2024-05-05 12:38:00 +01:00
Peter Nelson
72b2840a97
Codechange: Use PIP spacing instead of spacers in tree picker window. ( #12623 )
2024-05-05 12:37:45 +01:00
99f497cb08
Update: Translations from eints
...
english (au): 2 changes by krysclarke
korean: 2 changes by telk5093
russian: 2 changes by Ln-Wolf
finnish: 2 changes by hpiirai
danish: 2 changes by bscargo
lithuanian: 4 changes by dziugas1959
portuguese: 2 changes by azulcosta
portuguese (brazilian): 4 changes by pasantoro
2024-05-05 04:40:50 +00:00
9fe9e4d398
Codechange: use vector instead of manual memory management for decompressing text files
2024-05-04 17:43:02 +02:00
Peter Nelson
d074ab909c
Codechange: Replace Array/FixedSizeArray with std::deque. ( #12409 )
...
Array/FixedSizeArray is actually a resizeable container that allocates space in chunks and allows resizing without invalidating pointers.
This is also a behaviour of std::deque, so use that instead.
2024-05-04 10:55:16 +01:00
Peter Nelson
f629d3c921
Codechange: Use vectors instead of CallocT/free for cache checks. ( #12619 )
...
Vectors are reused for each vehicle chain to save on reallocations.
2024-05-04 09:42:20 +01:00
Peter Nelson
115ac2629b
Cleanup: Remove TileMatrix that hasn't been used for 4+ years. ( #12621 )
...
This 'nice' structure was left around from #8258 just in case it might be used again.
Spoiler alert: it hasn't.
This removes manual memory management. And otherwise unused and untested code.
2024-05-04 09:41:58 +01:00
60cf37e0d1
Update: Translations from eints
2024-05-04 04:41:06 +00:00
Peter Nelson
9a7c30a109
Codechange: Let ClickSliderWidget handle rounding to nearest mark.
2024-05-03 11:48:36 +01:00
Peter Nelson
9d2efd4c96
Codechange: Use callback function to set labels of slider widget marks.
...
Slider widgets can only use a predefined list of values and strings to draw labels. This makes it difficult to vary the display by context.
Instead of providing a predefined list as a std::map, use a callback function instead. This function can decide what text to display, and can call SetDParam to dynamically set up strings.
2024-05-03 11:48:36 +01:00
8b6661d486
Codefix 90029be: build failure for SDL 1.2
2024-05-03 10:45:34 +02:00
e0048d798f
Update: Translations from eints
...
hungarian: 5 changes by egri-nagy
2024-05-03 04:41:54 +00:00
Peter Nelson
90029beb49
Codechange: Ensure SDLK mappings stay in the expected order. ( #12608 )
...
Add a constexpr constructor that ensures at compile-time that the source SDLK range matches the target range.
2024-05-02 23:19:08 +01:00
ef99aa81a3
Codechange: Store validity of water regions in separate vector
2024-05-02 15:03:48 +02:00
Peter Nelson
cf96d49ced
Codechange: Use vector for airport tile layouts. ( #12607 )
...
Simplify AirportSpec data by storing layout information together in a vector, instead of separate arrays.
This removes manual memory management and separate count members.
The default layouts will be copied instead of always referring to the originals.
2024-05-02 11:37:54 +00:00
65c9df49d9
Update: Translations from eints
...
chinese (simplified): 8 changes by XiaoJi-Game
catalan: 3 changes by J0anJosep
2024-05-02 04:41:51 +00:00
2559bdfa6f
Fix 2d27e8e: Update numpad keycodes for SDL2, making it usable ( #12596 )
...
* Fix 2d27e8e: Update numpad keycodes for SDL2, making it usable
* Cleanup: List sdl2 numpad mappings individually
2024-05-01 23:10:01 +02:00
9647fe1d05
Change: [Linkgraph] Improve distance scaling algorithm in demand scaler
...
Improve scaling at values other than 0% and 100%
Fix erratic scaling and increase effect size at large setting values
2024-05-01 22:40:17 +02:00
Peter Nelson
f146680121
Codechange: Use vector for industry random sounds. ( #12606 )
...
Use a vector to store the list of random sounds played for an industry.
The removes manual memory allocation, flags to control memory management, a separate count member, and a try/catch block.
2024-05-01 19:55:00 +00:00
Peter Nelson
7147fe9e7a
Codechange: Use range-for when loading NewGRF deterministic sprite groups. ( #12605 )
2024-05-01 18:59:46 +00:00
Peter Nelson
532ce1a907
Codechange: Use Recv/Send_bytes for md5sum. ( #12602 )
...
Use existing functions to handle serialisation of arrays instead of indexed for-loop.
2024-05-01 18:55:54 +01:00
Peter Nelson
1424a184d8
Codechange: Use vector/span when loading wagon overrides. ( #12604 )
...
Replaces manual memory allocation and passing pointer with size.
2024-05-01 18:23:27 +01:00
96d82b4363
Update: Translations from eints
...
chinese (simplified): 1 change by WenSimEHRP
greek: 52 changes by KyriakosMich
german: 3 changes by Wuzzy2
basque: 36 changes by Porrumentzio
danish: 3 changes by bscargo
2024-05-01 04:41:08 +00:00
4df44fea38
Update: Translations from eints
...
swedish: 3 changes by joeax910
galician: 63 changes by pvillaverde
2024-04-30 04:40:35 +00:00
Peter Nelson
cc6e4768a9
Fix: Out-of-order window set up due to deferred window resize. ( #12592 )
...
Deferred window resize was being applied to the initial window resize event, resulting in some window state (e.g. scroll bar capacity) not being initialised when expected.
2024-04-29 17:05:35 +01:00
b852a3f408
Update: Translations from eints
...
english (us): 3 changes by 2TallTyler
korean: 3 changes by telk5093
hungarian: 2 changes by meskobalazs
2024-04-29 04:40:19 +00:00
fd4cf699e5
Codefix 37a03b5: the return value of maxdim should always be assigned ( #12590 )
2024-04-28 17:42:58 +00:00
98d37338df
Codechange: use ranged for loop instead of one with lengthof
2024-04-28 19:42:44 +02:00
24b6ec80a9
Codechange: use ranged for loop and vector to determine the disaster to deploy
2024-04-28 19:42:44 +02:00
87dbd4a833
Codechange: use ranged for loop to determine widest title
2024-04-28 19:42:44 +02:00
d183d8e587
Codechange: remove INVALID_STRING_ID now drop down uses spans
2024-04-28 18:47:31 +02:00
37a03b513f
Codechange: refactor string list dimension finding into a separate function
2024-04-28 18:47:31 +02:00
546a996d95
Codechange: pass options to ShowDropDownMenu using a span
2024-04-28 18:47:31 +02:00
ad50c4f298
Codechange: inline sorter name definitions and use proper static accessor instead of (implying) this->
2024-04-28 18:47:31 +02:00
Peter Nelson
ef55cc7979
Codechange: Remove support for links in tar files. ( #12571 )
...
This was a feature to support the original 32bpp sprite system and is no longer relevant.
2024-04-28 15:18:24 +01:00
99b74c1064
Fix #12584 : Improved error handling during tar scan ( #12586 )
2024-04-28 16:08:32 +02:00
826deaee57
Codechange: refactor CalcHeightdiff to remove some magic numbers
2024-04-28 16:05:21 +02:00
97a34bf06e
Codechange: use C++ containers for the colour schemes
2024-04-28 16:04:54 +02:00
ee9895a970
Update: Translations from eints
...
norwegian (bokmal): 3 changes by eriksorngard
french: 3 changes by ottdfevr
portuguese: 3 changes by azulcosta
2024-04-28 04:41:11 +00:00
Peter Nelson
440a633fcc
Codechange: Remove shrink_to_fit for more lists.
...
A comment about "will actually do nothing" is out of date as that is not the case with std::vector.
These lists are always short lived (either within a command handler or in a window) so don't shrink_to_fit.
2024-04-27 19:25:34 +01:00
Peter Nelson
33aedc43a5
Codechange: Shrink GUIList vectors less often, reserve before use.
...
After sorting and filter lists for GUI, we often shirnk them to reduce size. However this has very little benefit:
1) The memory has already been allocated, so it doesn't prevent that memory being required.
2) It causes a new allocation and copy when the vector is shrunk, actually using more memory.
3) The list is in window state, so the lifetime is only while the window is open.
4) When a filter is clearer, the original size will be needed again, which will cause another allocation.
In fact it is beneficial to reserve to the known maximum in most cases, so do that instead.
2024-04-27 19:25:34 +01:00
8308998388
Update: Translations from eints
...
english (au): 3 changes by krysclarke
russian: 3 changes by Ln-Wolf
finnish: 6 changes by hpiirai
dutch: 6 changes by Afoklala
portuguese (brazilian): 4 changes by pasantoro
polish: 3 changes by pAter-exe
2024-04-27 04:40:44 +00:00
Peter Nelson
bf8de188ec
Codechange: Use member initialization of GRFFilePropsBase. ( #12581 )
...
Don't blame compilers for our sloppy initialisation.
Removes memset, and lengthof.
2024-04-26 22:58:54 +01:00
Peter Nelson
72c55128d2
Codechange: Remove write-only spec_id from RoadStopSpec. ( #12582 )
...
Comment is incorrect about its value too.
2024-04-26 21:56:30 +01:00
Peter Nelson
a6d401debf
Fix: Properly test for presence of waypoint in NewGRF resolver. ( #12579 )
...
Test whether the BaseStation itself a Station or Waypoint, instead of by the station class ID assigned to it.
2024-04-26 17:47:53 +01:00
a60a81f34e
Update: Translations from eints
...
swedish: 7 changes by joeax910
vietnamese: 15 changes by anmatngu
greek: 31 changes by gh658804, 2 changes by KyriakosMich
hungarian: 2 changes by egri-nagy
portuguese (brazilian): 2 changes by pasantoro
2024-04-26 04:41:25 +00:00
0fdabca605
Codechange: use std::span instead of custom span in TGP
2024-04-26 06:15:29 +02:00
Peter Nelson
f44d8fa2e4
Codechange: Remove CDECL from filter functions. ( #12578 )
...
These functions are not passed to qsort()...
2024-04-25 22:13:23 +01:00
Peter Nelson
0075a95278
Codefix: Make three _filter_funcs definitions distinct. ( #12573 )
...
Rename the GUIList function lists defined as the same symbol.
2024-04-25 21:01:15 +01:00
Peter Nelson
5bc9854be2
Codechange: Make sort list function lists safer. ( #12574 )
...
GUIList has a pointer only to the start of each sort/filter func list, which has the potential for UB as it is unable to validate that the selected sort or filter type is in range.
Use a std::span instead and check if the selected type is in range before using it.
2024-04-25 21:00:49 +01:00
9b747a173d
Fix #12509 : Maintain timer sort invariants when changing period
2024-04-25 20:08:24 +02:00
11ec156b64
Codechange: Add a priority field to TimerGameTick::TPeriod
...
Use this as the primary sort key for TimerGameTick::TPeriod,
to avoid container sort order changes on timer period saveload.
See: #12509
2024-04-25 20:08:24 +02:00
57f5d27427
Doc: Fix documentation of GetDefaultValueCallback
2024-04-25 20:07:54 +02:00
ceb0053dd9
Codechange: Correct return type of GetDefaultValueCallback
2024-04-25 20:07:54 +02:00
339b0ea0ff
Change: Show correct default value and unit for vehicle service interval setting
2024-04-25 20:07:54 +02:00
fd80a1ec66
Fix #11345 : Use correct default button value for vehicle service interval setting
2024-04-25 20:07:54 +02:00
a4071b78d7
Codechange: Add callback to IntSettingDesc to support more default values
2024-04-25 20:07:54 +02:00
e8d25d68b9
Update: Translations from eints
...
russian: 2 changes by George-VB
2024-04-25 04:42:18 +00:00
Peter Nelson
e8249e9075
Codechange: Pass buffers for TarFile's ExtractString as span. ( #12567 )
...
ExtractString does not need to find a string terminator as StrMakeValid already does this, so simply pass the full bounds of the buffer.
Removes lengthof, array indices, and needs only the buffer as a parameter.
2024-04-24 21:34:21 +01:00
Peter Nelson
5159aa81d4
Codechange: Use iterators when enabling industries. ( #12569 )
...
Removes lengthof and array indices.
2024-04-24 21:33:49 +01:00
Peter Nelson
26bb87ebf1
Codechange: Replace SaveLoad var length arrays with switch block and sizeof. ( #12570 )
...
SlCalcConvMemLen(), SlCalcConfFileLen() and CalcOldVarLen() follow a pattern of looking up part of a value in an array.
These function returns the size of bytes of a variable type, but is not very clear. Replace with a switch block instead.
Removes lengthof, array indices, and magic numbers.
2024-04-24 21:33:29 +01:00
Peter Nelson
1dc94d0670
Codechange: Construct string_view with first+last. ( #12568 )
...
Avoids needing to calculate size when we already have last.
2024-04-24 21:29:33 +01:00
Peter Nelson
6a3f50aa72
Codechange: Replace separate EffectVehicle arrays. ( #12565 )
...
Combine 3 separate arrays into a single struct. This keeps related data together, and avoids needing to check that each array is same length.
Use of constexpr construct ensures data in the array is not default-initialised.
Removes lengthof.
2024-04-24 21:29:12 +01:00
Peter Nelson
e20f48799e
Codechange: Make StringToContentType() clearer. ( #12566 )
...
Decouples string to ContentType mapping from position within enum.
Slightly less efficient, but removes lengthof, array indices, and casting.
2024-04-24 21:26:31 +01:00
Peter Nelson
5e689ce25e
Codechange: Store cursor sprites in vector. ( #12564 )
...
Combine two separate fixed length arrays to allow simpler iteration.
No need to check that arrays are all the same length.
No need to separately store the number of sprites to draw.
Removes the upper limit of the number of sprites that can be drawn.
Removes lengthof and array indices.
2024-04-24 21:26:07 +01:00
9121770582
Update: Translations from eints
...
korean: 3 changes by telk5093
catalan: 3 changes by J0anJosep
french: 7 changes by ottdfevr
polish: 7 changes by pAter-exe
2024-04-24 04:40:54 +00:00
Peter Nelson
ac6a945e26
Revert 2408a68910: Remove work around for an MSVC bug from 17 years ago. ( #12557 )
2024-04-23 17:05:08 +01:00
bef11941c6
Change: Allow rail and road depot overbuilding in current orientation in order to connect to rail or road
2024-04-23 13:11:31 +02:00
95de90dd4e
Update: Translations from eints
...
norwegian (bokmal): 7 changes by eriksorngard
danish: 7 changes by bscargo
portuguese (brazilian): 4 changes by pasantoro
2024-04-23 04:40:32 +00:00
Peter Nelson
3814adaba8
Codechange: Simplify GetScrolledItemFromWidget() ( #12556 )
...
Return `auto`, which allows working with const containers, and use std::next instead of std::advance.
2024-04-22 19:00:14 +00:00
c82a2575d7
Update: Translations from eints
...
english (au): 3 changes by krysclarke
english (us): 3 changes by 2TallTyler
greek: 3 changes by gh658804
russian: 3 changes by Ln-Wolf
finnish: 5 changes by hpiirai
turkish: 7 changes by BeratSJ
portuguese: 3 changes by azulcosta
portuguese (brazilian): 3 changes by pasantoro
2024-04-22 04:40:33 +00:00
ded4d63db2
Codechange: simplify access to the current screenshot format
2024-04-21 21:07:05 +02:00
Peter Nelson
d465257dd0
Fix 952d111: Houses and industry tiles could accept incorrect cargo. ( #12547 )
...
Default cargo label was not cleared (set to CT_INVALID) when using older 3-slot acceptance properties for house and industry tiles.
Missed in #12053 and #12062 .
2024-04-21 19:46:05 +01:00
Peter Nelson
3b01d31280
Fix 8746be8: Reinstate current order test when removing road stop. ( #12552 )
...
#12144 replaced pool iteration with FindVehiclesWithOrder, however the test for current_order being OT_GOTO_STATION was erroneously removed.
2024-04-21 19:41:25 +01:00
c073165e34
Update: Translations from eints
...
greek: 5 changes by gh658804
finnish: 2 changes by hpiirai
catalan: 4 changes by J0anJosep
2024-04-21 04:42:00 +00:00
aa895535e6
Fix 5008706: improved scenario editor tooltips in map generation stages are out of place
2024-04-20 21:56:27 +02:00
Peter Nelson
959ced71bb
Codechange: Add constants for original input/output cargo counts. ( #12548 )
...
This replaces some magic 3s and 2s.
2024-04-20 20:50:48 +01:00
Peter Nelson
b4e00fa738
Codechange: Replace C-casts in pool functions. ( #12541 )
2024-04-20 16:50:13 +01:00
c5ef47ee09
Codechange: [Script] Use std::unique_ptr for Company::ai_instance ( #12544 )
2024-04-20 16:58:46 +02:00
1dfd0c19f4
Fix: allow only 255 league tables, as 255 is the invalid id sentinel
2024-04-20 16:53:04 +02:00
c377c4740d
Codechange: replace cpp_lengthof with safe alternatives
2024-04-20 13:36:19 +02:00
Peter Nelson
a1a01e21cf
Change: Use std::make_unique instead of passing new() ( #12539 )
2024-04-20 11:20:49 +01:00
fc7f184dbd
Codechange: move knowledge about 'packed' orders to the saveload code
2024-04-20 11:58:07 +02:00
Tyler Trahan
Patric Stout
Peter Nelson
translators
Joan Josep
rubidium42
Steve Goldman
Edmond Chui
Jonathan G Rennison
Björn Wärmedal
ladysadie
merni-ns
Loïc Guilloux
Koen Bussemaker
yeah-its-gloria
Muxy
frosch
merni-ns
Fen
rubidium42
André Cheng