Doc: Changelog for 13.3

This reverts commit ee6e30ead9.

.dorpsgek.yml

@@ -8,13 +8,9 @@ notifications:
     only:
     - master
     only-by:
-    - eints-sync\[bot\]
+    - DorpsGek
   commit-comment:
   discussion:
   pull-request:
   issue:
   tag-created:
-  workflow-run:
-    only:
-    - .github/workflows/release.yml
-    - .github/workflows/ci-nightly.yml

.editorconfig

@@ -7,471 +7,3 @@ trim_trailing_whitespace = true
 [*.{c,cpp,h,hpp}]
 indent_style = tab
 charset = utf-8
-#indent_size = <integer>
-#tab_width = <integer>
-#end_of_line = <lf, cf, crlf>
-
-### C++ specific editor config rules ###
-## Visual Studio ## https://learn.microsoft.com/en-us/visualstudio/ide/cpp-editorconfig-properties?view=vs-2019 ##
-# Indentation #
-# Do not indent braces
-cpp_indent_braces = false
-# When a new line is typed, it's indented relatively to the innermost open parenthesis
-cpp_indent_multi_line_relative_to = innermost_parenthesis
-# Indent new lines within parenthesis
-cpp_indent_within_parentheses = indent
-# In existing code, do not use the setting for alignment of new lines within parentheses
-cpp_indent_preserve_within_parentheses = true
-# Indent case contents
-cpp_indent_case_contents = true
-# Indent case labels
-cpp_indent_case_labels = true
-# Do not indent braces following a case statement
-cpp_indent_case_contents_when_block = false
-# Do not indent braces of lambdas used as parameters
-cpp_indent_lambda_braces_when_parameter = false
-# No override for "Position of goto labels" (Unspecified)
-#cpp_indent_goto_labels
-# Move preprocessor directives to the leftmost column
-cpp_indent_preprocessor = leftmost_column
-# Do not indent access specifiers
-cpp_indent_access_specifiers = false
-# Indent namespace contents
-cpp_indent_namespace_contents = true
-# Preserve indentation of comments
-cpp_indent_preserve_comments = true
-
-# Newline #
-# Keep open braces for namespaces on the same line, but add a space before the brace
-cpp_new_line_before_open_brace_namespace = same_line
-# Keep open braces for types/classes on the same line, but add a space before the brace
-cpp_new_line_before_open_brace_type = same_line
-# Move open braces for functions to a new line
-cpp_new_line_before_open_brace_function = new_line
-# Keep open braces for control blocks on the same line, but add a space before the brace
-cpp_new_line_before_open_brace_block = same_line
-# Keep open braces for lambdas on the same line, but add a space before the brace
-cpp_new_line_before_open_brace_lambda = same_line
-# Place scope braces on separate lines
-cpp_new_line_scope_braces_on_separate_lines = true
-# Do not move closing braces to the same line as opening braces for empty types
-cpp_new_line_close_brace_same_line_empty_type = false
-# Do not move closing braces to the same line as opening braces for empty function bodies
-cpp_new_line_close_brace_same_line_empty_function = false
-# Do not place 'catch' and similar keywords on a new line
-cpp_new_line_before_catch = false
-# Do not place 'else' on a new line
-cpp_new_line_before_else = false
-# Do not place 'while' in a do-while loop on a new line
-cpp_new_line_before_while_in_do_while = false
-
-# Spacing #
-# Remove spaces between function names and opening parentheses of argument lists
-cpp_space_before_function_open_parenthesis = remove
-# Do not insert a space within parentheses of an argument list
-cpp_space_within_parameter_list_parentheses = false
-# Do not insert a space between parentheses when argument list is empty
-cpp_space_between_empty_parameter_list_parentheses = false
-# Insert space between keyword and opening parenthesis in control flow statements
-cpp_space_after_keywords_in_control_flow_statements = true
-# Do not insert a space within parentheses of a control statement
-cpp_space_within_control_flow_statement_parentheses = false
-# Do not insert a space before opening parenthesis of lambda argument lists
-cpp_space_before_lambda_open_parenthesis = false
-# Do not insert a space within parentheses of a C-style cast
-cpp_space_within_cast_parentheses = false
-# Do not insert a space after closing parenthesis of C-style cast
-cpp_space_after_cast_close_parenthesis = false
-# Do not insert a space within parentheses of a parenthesized expression
-cpp_space_within_expression_parentheses = false
-# Insert space before opening brace of blocks
-cpp_space_before_block_open_brace = true
-# Do not insert a space between empty braces
-cpp_space_between_empty_braces = false
-# Do not insert a space before opening brace of uniform initialization and initializer lists
-cpp_space_before_initializer_list_open_brace = false
-# No override for "Insert space within braces of uniform initialization and initializer lists" (Spacing for this varies)
-#cpp_space_within_initializer_list_braces
-# Preserve spaces inside uniform initialization and initializer lists
-cpp_space_preserve_in_initializer_list = true
-# Do not insert space before opening square brackets
-cpp_space_before_open_square_bracket = false
-# Do not insert space within square bracket
-cpp_space_within_square_brackets = false
-# Do not insert space before empty square brackets
-cpp_space_before_empty_square_brackets = false
-# Do not insert space between empty square brackets
-cpp_space_between_empty_square_brackets = false
-# Group square brackets for multi-dimensional arrays together
-cpp_space_group_square_brackets = true
-# Do not insert space within square brackets for lambdas
-cpp_space_within_lambda_brackets = false
-# Do not insert space between empty lambda brackets
-cpp_space_between_empty_lambda_brackets = false
-# Do not insert space before commas
-cpp_space_before_comma = false
-# Insert space after commas
-cpp_space_after_comma = true
-# Remove spaces before and after member operators
-cpp_space_remove_around_member_operators = true
-# Insert space before colon for base in type declarations
-cpp_space_before_inheritance_colon = true
-# Insert space before colon for constructors
-cpp_space_before_constructor_colon = true
-# Remove space before semicolons
-cpp_space_remove_before_semicolon = true
-# No override for "Insert space after semicolons" (Depends on if loop is unconditional)
-#cpp_space_after_semicolon
-# Remove spaces between unary operators and their operands
-cpp_space_remove_around_unary_operator = true
-# Insert spaces before and after binary operators
-cpp_space_around_binary_operator = insert
-# Insert spaces around assignment operators
-cpp_space_around_assignment_operator = insert
-# Align pointer/reference symbol to the right
-cpp_space_pointer_reference_alignment = right
-# Insert spaces around conditional operators
-cpp_space_around_ternary_operator = insert
-
-# Wrapping #
-# Always apply New Lines settings for blocks
-cpp_wrap_preserve_blocks = never
-
-
-
-## Rider & ReSharper ## https://www.jetbrains.com/help/resharper/EditorConfig_CPP_CppBlankLinesPageScheme.html ##
-# Blank Lines #
-# No override for "Max blank lines in declarations" (Unspecified; Not consistent across source code)
-#cpp_keep_blank_lines_in_declarations
-# No override for "Max blank lines in rest of source code" (Unspecified; Not consistent across source code)
-#cpp_keep_blank_lines_in_code
-# No override for "Number of blank lines around class/struct/enum definition" (Unspecified; Not consistent across source code)
-#cpp_blank_lines_around_class_definition
-# No override for "Number of blank lines around function declarations" (Unspecified; Not consistent across source code)
-#cpp_blank_lines_around_function_declaration
-# No override for "Number of blank lines around function definitions" (Unspecified; Not consistent across source code)
-#cpp_blank_lines_around_function_definition
-# No override for "Number of blank lines around single line function definitions" (Unspecified; Not consistent across source code)
-#cpp_blank_lines_around_single_line_function_definition
-# No override for "Number of blank lines around namespaces" (Unspecified; Not consistent across source code)
-#cpp_blank_lines_around_namespace
-# No override for "Number of blank lines around other definitions and declarations" (Unspecified; Not consistent across source code)
-#cpp_blank_lines_around_other_declaration
-
-# Braces Layout #
-# Keep open braces for namespace declarations on the same line, but add a space before the brace
-cpp_namespace_declaration_braces = end_of_line
-# Keep open braces for linkage declarations on the same line, but add a space before the brace
-cpp_linkage_specification_braces = end_of_line
-# Keep open braces for types/classes on the same line, but add a space before the brace
-cpp_type_declaration_braces = end_of_line
-# Keep open braces for namespace definitions on the same line (does not modify spacing before the brace)
-cpp_place_namespace_definitions_on_same_line = true
-# Move open braces for functions to a new line
-cpp_invocable_declaration_braces = next_line
-# Keep open braces for lambdas on the same line, but add a space before the brace
-cpp_anonymous_method_declaration_braces = end_of_line
-# Keep open braces for case blocks on the same line, but add a space before the brace
-cpp_case_block_braces = end_of_line
-# No override for "Requires expression braces" style (requires expressions are a C++20 feature)
-#cpp_requires_expression_braces
-# Keep open braces for all other blocks on the same line, but add a space before the brace
-cpp_other_braces = end_of_line
-# Only indent the insides of multi-line expression braces
-cpp_expression_braces = inside
-# Place the braces of empty blocks together and on the same line
-cpp_empty_block_style = together_same_line
-# Force line breaks within simple compound statements
-cpp_simple_block_style = line_break
-# No override for "Regular expression for macros starting a block" (Marco blocks aren't used)
-#cpp_macro_block_begin
-# No override for "Regular expression for macros ending a block" (Marco blocks aren't used)
-#cpp_macro_block_end
-
-# Tabs and indents #
-# Redundant override (Already overriden globally by 'indent_style')
-#cpp_indent_style
-# Redundant override (Already overriden globally by 'indent_size')
-#cpp_indent_size
-# Redundant override (Already overriden globally by 'tab_width')
-#cpp_tab_width
-# Use spaces instead of tabs as indentation for precise alignment
-cpp_alignment_tab_fill_style = use_spaces
-# Allow alignment even if construct is located too far to the right, more than 2/3 of 'Hard wrap at' limit
-cpp_allow_far_alignment = true
-
-# Indentation and Alignment #
-# No override for "Continuous line indent" (Varies throughout source code)
-#cpp_continuous_line_indent
-# Do not use continuous line indent in function declaration and invocation parentheses
-cpp_use_continuous_line_indent_in_method_pars = false
-# Do not use continuous line indent in initializer lists
-cpp_use_continuous_line_indent_in_expression_braces = false
-# Indent namespace members (including nested ones)
-cpp_namespace_indentation = all
-# No override for "Indent linkage specification block members" (Unspecified)
-#cpp_linkage_specification_indentation
-# Do not indent access specifier from class
-cpp_indent_access_specifiers_from_class = false
-# Indent class member from access specifier
-cpp_indent_class_members_from_access_specifiers = true
-# Do not indent if a function definition or declaration is wrapped after the type
-cpp_indent_wrapped_function_names = false
-# Indent 'case' labels from 'switch'
-cpp_indent_switch_labels = true
-# No override for "Indent function declarations' parentheses" (Varies throughout source code)
-#cpp_indent_method_decl_pars
-# No override for "Indent method calls' parentheses" (Varies throughout source code)
-#cpp_indent_invocation_pars
-# No override for "Indent statement (if, while, for, etc) parentheses" (Varies throughout source code)
-#cpp_indent_statement_pars
-# Do not change preprocessor directives indenting
-cpp_indent_preprocessor_directives = do_not_change
-# No override for "Indent C++/CLI generic constraints" (C++/CLI is not used)
-#cpp_indent_type_constraints
-# Align/indent comments started at the first column
-cpp_indent_comment = true
-# Comments that comment out code will use the indentation level of the commented code.
-cpp_place_comments_at_first_column = false
-# Align multiline declarators in declaration
-cpp_align_multiple_declaration = true
-# Align multiline function parameters
-cpp_align_multiline_parameter = true
-# Align multiline call arguments
-cpp_align_multiline_argument = true
-# Do not align first of multiline call arguments with the opening parentheses
-cpp_align_first_arg_by_paren = false
-# Align multiline initializer list arguments
-cpp_align_multiline_expression_brace = true
-# No override for "Align multiline template parameters in template declaration" (Unspecified)
-#cpp_align_multiline_type_parameter
-# No override for "Align multiline template arguments" (Unspecified)
-#cpp_align_multiline_type_argument
-# Align multiline base classes in class base clause
-cpp_align_multiline_extends_list = true
-# Align multiline member initializers in member initializer lists
-cpp_align_multiline_ctor_init = true
-# Outdent commas placed on new line
-cpp_outdent_commas = true
-# Do not align multiline ?: operator with first line (since alignment is incorrect)
-cpp_align_ternary = none
-# Do not indent aligned ?: operator (since indentation varies)
-cpp_indent_aligned_ternary = false
-# No override for "Align multiline chained method calls" (Unspecified)
-#cpp_align_multiline_calls_chain
-# No override for "Outdent '.' and '->' in chained method calls on new lines" (Unspecified)
-#cpp_outdent_dots
-# Do not align multiline chained binary expressions
-cpp_align_multiline_binary_expressions_chain = false
-# Fix column alignment in adjacent lines
-cpp_int_align_fix_in_adjacent = true
-# Align assignments with adjacent assignments
-cpp_int_align_eq = true
-# Do not align declaration names with adjacent declaration names
-cpp_int_align_declaration_names = false
-# Align end-of-line comments with adjacent end-of-line comments
-cpp_int_align_comments = true
-
-# Spaces #
-# Do not put space before ANY commas
-cpp_space_before_comma = false
-# Put space after ALL commas
-cpp_space_after_comma = true
-# Put space before ptr in declaration of variable
-cpp_space_before_ptr_in_data_member = true
-# Do not put space after ptr in declaration of variable
-cpp_space_after_ptr_in_data_member = false
-# Put space before ptr in declaration of multiple variables
-cpp_space_before_ptr_in_data_members = true
-# Do not put space after ptr in declaration of multiple variables
-cpp_space_after_ptr_in_data_members = false
-# Put space before ptr in return type of function
-cpp_space_before_ptr_in_method = true
-# Do not put space after ptr in return type of function
-cpp_space_after_ptr_in_method = false
-# Do not put space before ptr in abstract declaration
-cpp_space_before_ptr_in_abstract_decl = false
-# Put space before ref in declaration of variable
-cpp_space_before_ref_in_data_member = true
-# Do not put space after ref in declaration of variable
-cpp_space_after_ref_in_data_member = false
-# Put space before ref in declaration of multiple variables
-cpp_space_before_ref_in_data_members = true
-# Do not put space after ref in declaration of multiple variables
-cpp_space_after_ref_in_data_members = false
-# Do not put space before ref in return type of function
-cpp_space_before_ref_in_method = false
-# Put space after ref in return type of function
-cpp_space_after_ref_in_method = true
-# Do not put space before ref in abstract declaration
-cpp_space_before_ref_in_abstract_decl = false
-# Do not put space before parentheses in function parameters
-cpp_space_between_method_declaration_name_and_open_parenthesis = false
-# Do not put space before parentheses in lambda parameters
-cpp_space_before_lambda_parentheses = false
-# Do not put space within parentheses in function parameters
-cpp_space_between_method_declaration_parameter_list_parentheses = false
-# Do not put space within empty parentheses in function parameters
-cpp_space_between_method_declaration_empty_parameter_list_parentheses = false
-# Do not put space before angle brackets in template parameters
-cpp_space_before_template_params = false
-# Do not put space within angle brackets in template parameters
-cpp_space_within_template_params = false
-# Do not put space within empty angle brackets in template parameters
-cpp_space_within_empty_template_params = false
-# Do not put space before angle brackets in template arguments
-cpp_space_before_template_args = false
-# Do not put space within angle brackets in template arguments
-cpp_space_within_template_args = false
-# Do not put space between closing angle brackets in template arguments
-cpp_space_between_closing_angle_brackets_in_template_args = false
-# Put space around '=' in alias declaration and namespace alias
-cpp_space_around_alias_eq = true
-# Do not put space around '->' in trailing return types
-cpp_space_around_deref_in_trailing_return_type = false
-# Put space before base types list colon
-cpp_space_before_colon_in_inheritance_clause = true
-# Put space after base types list colon
-cpp_space_after_colon_in_inheritance_clause = true
-# No override for "Before C++/CLI generic constraint colon" (Unspecified)
-#cpp_space_before_type_parameter_constraint_colon
-# No override for "After C++/CLI generic constraint colon" (Unspecified)
-#cpp_space_after_type_parameter_constraint_colon
-# Put space before parentheses of control statements
-cpp_space_after_keywords_in_control_flow_statements = true
-# Do not put space within parentheses of control statements
-cpp_space_between_parentheses_of_control_flow_statements = false
-# Do not put space before semicolon in 'for' statements
-cpp_space_before_semicolon_in_for_statement = false
-# Put space after semicolon in 'for' statements
-cpp_space_after_semicolon_in_for_statement = true
-# Put space before ':' in range-based for loop
-cpp_space_before_for_colon = true
-# Put space after ':' in range-based for loop
-cpp_space_after_for_colon = true
-# Do not put space before colon in switch case or label statement
-cpp_space_before_colon_in_case = false
-# Put space after colon in switch case or label statement
-cpp_space_after_colon_in_case = true
-# Put space around binary operator
-cpp_space_around_binary_operator = true
-# Put space around assignment operator
-cpp_space_around_assignment_operator = true
-# Do not put space around dot, '->', '.*' and '->.'
-cpp_space_around_member_access_operator = false
-# Do not put space within any parentheses
-cpp_space_within_parentheses = false
-# Do not put space before array subscript brackets
-cpp_space_before_open_square_brackets = false
-# Do not put space within array subscript brackets
-cpp_space_between_square_brackets = false
-# Do not put space before empty parentheses in function call and initialization
-cpp_space_between_method_call_name_and_opening_parenthesis = false
-# Do not put space within parentheses in cast expressions
-cpp_space_between_typecast_parentheses = false
-# Do not put space after parentheses in cast expressions
-cpp_space_after_cast = false
-# Do not put space within parentheses in function call and initialization
-cpp_space_between_method_call_parameter_list_parentheses = false
-# Do not put space within empty parentheses in function call and initialization
-cpp_space_between_method_call_empty_parameter_list_parentheses = false
-# Put space in ternary operator '? :' before '?'
-cpp_space_before_ternary_quest = true
-# Put space in ternary operator '? :' after '?'
-cpp_space_after_ternary_quest = true
-# Put space in ternary operator '? :' before ':'
-cpp_space_before_ternary_colon = true
-# Put space in ternary operator '? :' after ':'
-cpp_space_after_ternary_colon = true
-# Do not put space before uniform initialization braces
-cpp_space_before_initializer_braces = false
-# Do not put space within uniform initialization braces
-cpp_space_within_initializer_braces = false
-# Do not put space within empty uniform initialization braces
-cpp_space_within_empty_initializer_braces = false
-# Put space before end of line comment
-cpp_space_before_trailing_comment = true
-# Preserve spaces before end of line comment
-cpp_disable_space_changes_before_trailing_comment = true
-
-# Line breaks and Wrapping #
-# Redundant override (Already overriden globally by 'insert_final_newline')
-#cpp_insert_final_newline
-# Redundant override (Already overriden earlier in Visual Studio section)
-#cpp_new_line_before_else
-# Do not place 'while' in a do-while loop on a new line
-cpp_new_line_before_while = false
-# Redundant override (Already overriden earlier in Visual Studio section)
-#cpp_new_line_before_catch
-# Do not change the line breaks of single embedded statements
-cpp_simple_embedded_statement_style = do_not_change
-# Do not change the line breaks of simple 'case' statement
-cpp_simple_case_statement_style = do_not_change
-# Put member function definition return type on same line
-cpp_function_definition_return_type_style = on_single_line
-# Put top-level function definition return type on same line
-cpp_toplevel_function_definition_return_type_style = on_single_line
-# Put member function declaration return type on same line
-cpp_function_declaration_return_type_style = on_single_line
-# Put top-level function declaration return type on same line
-cpp_toplevel_function_declaration_return_type_style = on_single_line
-# Force template<...> of a template declaration on new line
-cpp_break_template_declaration = line_break
-# No override for "Break line before the requires-clause" (requires-clause is a C++20 feature)
-#cpp_line_break_before_requires_clause
-# Do not change the line break before the colon in member initializer lists
-cpp_member_initializer_list_style = do_not_change
-# Do not change the line break after the colon in member initializer lists
-cpp_line_break_after_colon_in_member_initializer_lists = do_not_change
-# No override for "Break line before comma in member initializer lists" (Varies throughout source code)
-#cpp_line_break_before_comma_in_member_initializer_lists
-# No override for "Break line after comma in member initializer lists" (Varies throughout source code)
-#cpp_line_break_after_comma_in_member_initializer_lists
-# No override for "Allow C++/CLI generic constraints on the same line" (C++/CLI is not used)
-#cpp_place_type_constraints_on_same_line
-# No override for "Keep existing line breaks" (Varies throughout source code; depends on developer preference)
-#cpp_keep_user_linebreaks
-# No override for "Hard wrap at _ characters" (Unspecified)
-#cpp_max_line_length
-# Do not prefer wrap before ','
-cpp_wrap_before_comma = false
-# Do not prefer wrap before ',' in base clause
-cpp_wrap_before_comma_in_base_clause = false
-# No override for "Wrap ternary expression" (Varies throughout source code)
-#cpp_wrap_ternary_expr_style
-# No override for "Prefer wrap before '?' and ':' in ternary expressions" (Varies throughout source code)
-#cpp_wrap_before_ternary_opsigns
-# No override for "Prefer wrap before ':'" (Varies throughout source code)
-#cpp_wrap_before_colon
-# No override for "Prefer wrap before first C++/CLI generic constraint" (C++/CLI is not used)
-#cpp_wrap_before_first_type_parameter_constraint
-# No override for "Wrap multiple C++/CLI generic constraints" (C++/CLI is not used)
-#cpp_wrap_multiple_type_parameter_constraints_style
-# No override for "Wrap enum definition" (Varies throughout source code)
-#cpp_wrap_enumeration_style
-# No override for "Wrap braced initializer list" (Varies throughout source code)
-#cpp_wrap_braced_init_list_style
-# No override for "Wrap base classes list" (Varies throughout source code)
-#cpp_wrap_base_clause_style
-# No override for "Wrap constructor initializer" (Varies throughout source code)
-#cpp_wrap_ctor_initializer_style
-# No override for "Wrap formal parameters" (Varies throughout source code)
-#cpp_wrap_parameters_style
-# Do not prefer wrap before '(' in declaration
-cpp_wrap_before_declaration_lpar = false
-# Prefer wrap after '(' in declaration
-cpp_wrap_after_declaration_lpar = true
-# Do not prefer wrap before ')' in declaration
-cpp_wrap_before_declaration_rpar = false
-# No override for "Wrap invocation arguments" (Varies throughout source code)
-#cpp_wrap_arguments_style
-# Do not prefer wrap before '(' in invocation
-cpp_wrap_before_invocation_lpar = false
-# Prefer wrap after '(' in invocation
-cpp_wrap_after_invocation_lpar = true
-# Do not prefer wrap before ')' in invocation
-cpp_wrap_before_invocation_rpar = false
-# Prefer wrap after '{' in initializer lists
-cpp_wrap_after_expression_lbrace = true
-# Do not prefer wrap before '}' in initializer lists
-cpp_wrap_before_expression_rbrace = false

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,13 +1,3 @@
-<!--
-Commit message:
-
-- Please use Feature / Add / Change / Fix for player-facing changes. E.g.: "Feature: My cool new feature".
-- Please use Feature / Add / Change / Fix followed by "[NewGRF]" or "[Script]" for moddable changes. E.g.: "Feature: [NewGRF] My cool new NewGRF addition".
-- Please use Codechange / Codefix for developer-facing changes. E.g.: "Codefix #1234: Validate against nullptr properly".
-
-See https://github.com/OpenTTD/OpenTTD/blob/master/CODINGSTYLE.md#commit-message for more details.
--->
-
 ## Motivation / Problem
 
 <!--
@@ -52,7 +42,7 @@ Some things are not automated, and forgotten often. This list is a reminder for
 * This PR touches english.txt or translations? Check the [guidelines](https://github.com/OpenTTD/OpenTTD/blob/master/docs/eints.md)
 * This PR affects the save game format? (label 'savegame upgrade')
 * This PR affects the GS/AI API? (label 'needs review: Script API')
-    * ai_changelog.hpp, game_changelog.hpp need updating.
+    * ai_changelog.hpp, gs_changelog.hpp need updating.
     * The compatibility wrappers (compat_*.nut) need updating.
 * This PR affects the NewGRF API? (label 'needs review: NewGRF')
     * newgrf_debug_data.h may need updating.

.github/changelog.sh

@@ -5,8 +5,8 @@ tag=$(git name-rev --name-only --tags --no-undefined HEAD 2>/dev/null | sed 's@\
 # If we are a tag, show the part of the changelog till (but excluding) the last stable
 if [ -n "$tag" ]; then
     grep='^[0-9]\+\.[0-9]\+[^-]'
-    next=$(cat changelog.md | grep '^[0-9]' | awk 'BEGIN { show="false" } // { if (show=="true") print $0; if ($1=="'$tag'") show="true"} ' | grep "$grep" | head -n1 | sed 's/ .*//')
-    cat changelog.md | awk 'BEGIN { show="false" } /^[0-9]+.[0-9]+/ { if ($1=="'$next'") show="false"; if ($1=="'$tag'") show="true";} // { if (show=="true") print $0 }'
+    next=$(cat changelog.txt | grep '^[0-9]' | awk 'BEGIN { show="false" } // { if (show=="true") print $0; if ($1=="'$tag'") show="true"} ' | grep "$grep" | head -n1 | sed 's/ .*//')
+    cat changelog.txt | awk 'BEGIN { show="false" } /^[0-9]+.[0-9]+/ { if ($1=="'$next'") show="false"; if ($1=="'$tag'") show="true";} // { if (show=="true") print $0 }'
     exit 0
 fi
 

.github/codeql/codeql-config.yml

@@ -1,12 +0,0 @@
-name: openttd
-queries:
-- uses: security-and-quality
-query-filters:
-- exclude:
-    id:
-    # Only feasible way is to move away from fopen; fopen_s is optional C11 and not implemented on most platforms.
-    - cpp/world-writable-file-creation
-    # Basically OpenTTD's coding style for adding things like ..._INVALID to enumerations
-    - cpp/irregular-enum-init
-    # Our GUI code tends to use switches for OnClick handlers, DrawWidget, and UpdateWidgetSize. Sometimes GUIs just don't have many elements, but we want to keep consistency.
-    - cpp/trivial-switch

.github/dependabot.yml

@@ -1,10 +0,0 @@
-version: 2
-updates:
-- package-ecosystem: "github-actions"
-  directory: "/"
-  schedule:
-    interval: "monthly"
-  groups:
-    actions:
-      patterns:
-      - "*"

.github/script-missing-mode-enforcement.py

@@ -1,71 +0,0 @@
-"""
-Script to scan the OpenTTD's script API for functions that miss checks for the
-function being called from the right mode (deity or company mode).
-
-When a function calls either ScriptObject::Command or ScriptObject::GetCompany
-then the function is considered dangerous. When one of the mode enforcement
-macros from script_error.hpp, i.e. EnforceDeityMode, EnforceCompanyModeValid or
-EnforceDeityOrCompanyModeValid, are called in the function, then we consider
-that the function has mode enforcement.
-
-Any dangerous function for which no enforcement is found are emitted as errors.
-"""
-
-import glob
-import re
-import sys
-
-
-def check_mode_enforcement(path):
-    errors = []
-    with open(path, "r") as reader:
-        mode_enforcement_found = False
-        dangerous_function = False
-        for line in reader:
-            # Line does not start with a tab and have <word>::<word>. That looks like the begin of a function, so reset the state.
-            if re.match(r"^[^\t].*\w::\w", line):
-                mode_enforcement_found = False
-                dangerous_function = False
-                currentFunction = line
-                continue
-
-            if re.match(
-                r"\t(EnforceDeityMode|EnforceCompanyModeValid|EnforceCompanyModeValid_Void|EnforceDeityOrCompanyModeValid|EnforceDeityOrCompanyModeValid_Void)\(",
-                line,
-            ):
-                # Mode enforcement macro found
-                mode_enforcement_found = True
-                continue
-
-            if re.match(r".*(ScriptObject::Command|ScriptObject::GetCompany).*", line):
-                # Dangerous function found
-                dangerous_function = True
-                continue
-
-            # Line with only a closing bracket. That looks like the end of a function, so check for the dangerous function without mode enforcement
-            if re.match(r"^}$", line) and dangerous_function and not mode_enforcement_found:
-                function_name = currentFunction.rstrip("\n").replace("/* static */ ", "")
-                errors.append(f"{path}: {function_name}")
-
-    return errors
-
-
-def main():
-    errors = []
-    for path in sorted(glob.glob("src/script/api/*.cpp")):
-        # Skip a number of files that yield only false positives
-        if path.endswith(("script_object.cpp", "script_companymode.cpp", "script_controller.cpp", "script_game.cpp")):
-            continue
-
-        errors.extend(check_mode_enforcement(path))
-
-    if errors:
-        print("Mode enforcement was expected in the following files/functions:")
-        print("\n".join(errors))
-        sys.exit(1)
-
-    print("OK")
-
-
-if __name__ == "__main__":
-    main()

.github/unused-strings.py

@@ -39,6 +39,7 @@ def read_language_file(filename, strings_found, errors):
     skip = SkipType.NONE
     length = 0
     common_prefix = ""
+    last_tiny_string = ""
 
     with open(filename) as fp:
         for line in fp.readlines():
@@ -113,6 +114,17 @@ def read_language_file(filename, strings_found, errors):
             name = line.split(":")[0].strip()
             strings_defined.append(name)
 
+            # If a string ends on _TINY or _SMALL, it can be the {TINY} variant.
+            # Check for this by some fuzzy matching.
+            if name.endswith(("_SMALL", "_TINY")):
+                last_tiny_string = name
+            elif last_tiny_string:
+                matching_name = "_".join(last_tiny_string.split("_")[:-1])
+                if name == matching_name:
+                    strings_found.add(last_tiny_string)
+            else:
+                last_tiny_string = ""
+
             if skip == SkipType.EXTERNAL:
                 strings_found.add(name)
                 skip = SkipType.LENGTH
@@ -198,10 +210,11 @@ def main():
             errors.append(f"ERROR: {string} is (possibly) no longer needed.")
 
     if errors:
-        print("\n".join(errors))
+        for error in errors:
+            print(error)
         sys.exit(1)
-
-    print("OK")
+    else:
+        print("OK")
 
 
 if __name__ == "__main__":

.github/workflows/ci-build.yml

@@ -1,4 +1,4 @@
-name: CI - Build
+name: CI
 
 on:
   pull_request:
@@ -9,87 +9,398 @@ on:
 env:
   CTEST_OUTPUT_ON_FAILURE: 1
 
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
-
 jobs:
   emscripten:
     name: Emscripten
 
-    uses: ./.github/workflows/ci-emscripten.yml
-    secrets: inherit
+    runs-on: ubuntu-20.04
+    container:
+      # If you change this version, change the number in the cache step too.
+      image: emscripten/emsdk:3.1.28
+
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+
+    - name: Setup cache
+      uses: actions/cache@v3
+      with:
+        path: /emsdk/upstream/emscripten/cache
+        key: 3.1.28-${{ runner.os }}
+
+    - name: Patch Emscripten to support LZMA
+      run: |
+        cd /emsdk/upstream/emscripten
+        patch -p1 < ${GITHUB_WORKSPACE}/os/emscripten/emsdk-liblzma.patch
+
+    - name: Build (host tools)
+      run: |
+        mkdir build-host
+        cd build-host
+
+        echo "::group::CMake"
+        cmake .. -DOPTION_TOOLS_ONLY=ON
+        echo "::endgroup::"
+
+        echo "::group::Build"
+        echo "Running on $(nproc) cores"
+        cmake --build . -j $(nproc) --target tools
+        echo "::endgroup::"
+
+    - name: Install GCC problem matcher
+      uses: ammaraskar/gcc-problem-matcher@master
+
+    - name: Build
+      run: |
+        mkdir build
+        cd build
+
+        echo "::group::CMake"
+        emcmake cmake .. -DHOST_BINARY_DIR=../build-host
+        echo "::endgroup::"
+
+        echo "::group::Build"
+        echo "Running on $(nproc) cores"
+        cmake --build . -j $(nproc)
+        echo "::endgroup::"
 
   linux:
+    name: Linux
+
     strategy:
       fail-fast: false
       matrix:
         include:
-        - name: Clang
-          compiler: clang
+        - compiler: clang
           cxxcompiler: clang++
-          libraries: libsdl2-dev
-        - name: GCC - SDL2
-          compiler: gcc
+          libsdl: libsdl2-dev
+        - compiler: gcc
           cxxcompiler: g++
-          libraries: libsdl2-dev
-        - name: GCC - Dedicated
-          compiler: gcc
+          libsdl: libsdl2-dev
+        - compiler: gcc
           cxxcompiler: g++
-          libraries: grfcodec
-          extra-cmake-parameters: -DOPTION_DEDICATED=ON -DCMAKE_CXX_FLAGS_INIT="-DRANDOM_DEBUG" -DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON
-          # Compile without SDL / SDL2, as that should compile fine too.
+          libsdl: libsdl1.2-dev
+        - compiler: gcc
+          cxxcompiler: g++
+          extra-cmake-parameters: -DOPTION_DEDICATED=ON -DCMAKE_CXX_FLAGS_INIT="-DRANDOM_DEBUG"
 
-    name: Linux (${{ matrix.name }})
+    runs-on: ubuntu-20.04
+    env:
+      CC: ${{ matrix.compiler }}
+      CXX: ${{ matrix.cxxcompiler }}
 
-    uses: ./.github/workflows/ci-linux.yml
-    secrets: inherit
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
 
-    with:
-      compiler: ${{ matrix.compiler }}
-      cxxcompiler: ${{ matrix.cxxcompiler }}
-      libraries: ${{ matrix.libraries }}
-      extra-cmake-parameters: ${{ matrix.extra-cmake-parameters }}
+    - name: Install dependencies
+      run: |
+        echo "::group::Update apt"
+        sudo apt-get update
+        echo "::endgroup::"
+
+        echo "::group::Install dependencies"
+        sudo apt-get install -y --no-install-recommends \
+          liballegro4-dev \
+          libfontconfig-dev \
+          libicu-dev \
+          liblzma-dev \
+          liblzo2-dev \
+          ${{ matrix.libsdl }} \
+          zlib1g-dev \
+          # EOF
+        echo "::endgroup::"
+      env:
+        DEBIAN_FRONTEND: noninteractive
+
+    - name: Get OpenGFX
+      run: |
+        mkdir -p ~/.local/share/openttd/baseset
+        cd ~/.local/share/openttd/baseset
+
+        echo "::group::Download OpenGFX"
+        curl -L https://cdn.openttd.org/opengfx-releases/0.6.0/opengfx-0.6.0-all.zip -o opengfx-all.zip
+        echo "::endgroup::"
+
+        echo "::group::Unpack OpenGFX"
+        unzip opengfx-all.zip
+        echo "::endgroup::"
+
+        rm -f opengfx-all.zip
+
+    - name: Install GCC problem matcher
+      uses: ammaraskar/gcc-problem-matcher@master
+
+    - name: Build
+      run: |
+        mkdir build
+        cd build
+
+        echo "::group::CMake"
+        cmake .. ${{ matrix.extra-cmake-parameters }}
+        echo "::endgroup::"
+
+        echo "::group::Build"
+        echo "Running on $(nproc) cores"
+        cmake --build . -j $(nproc)
+        echo "::endgroup::"
+
+    - name: Test
+      run: |
+        cd build
+        ctest -j $(nproc) --timeout 120
 
   macos:
+    name: Mac OS
+
     strategy:
       fail-fast: false
       matrix:
         include:
-        - name: arm64 - Debug
-          arch: arm64
-          full_arch: arm64
-          extra-cmake-parameters: -DCMAKE_BUILD_TYPE=Debug
-        - name: arm64 - Release
-          arch: arm64
-          full_arch: arm64
-          extra-cmake-parameters: -DCMAKE_BUILD_TYPE=RelWithDebInfo -DOPTION_USE_ASSERTS=OFF
+        - arch: x64
+          full_arch: x86_64
 
-    name: Mac OS (${{ matrix.name }})
+    runs-on: macos-latest
+    env:
+      MACOSX_DEPLOYMENT_TARGET: 10.13
 
-    uses: ./.github/workflows/ci-macos.yml
-    secrets: inherit
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
 
-    with:
-      arch: ${{ matrix.arch }}
-      full_arch: ${{ matrix.full_arch }}
-      extra-cmake-parameters: ${{ matrix.extra-cmake-parameters }}
+    - name: Install dependencies
+      env:
+        HOMEBREW_NO_AUTO_UPDATE: 1
+        HOMEBREW_NO_INSTALL_CLEANUP: 1
+      run: |
+        brew install \
+          pkg-config \
+          # EOF
+
+    - name: Prepare cache key
+      id: key
+      run: |
+        echo "image=$ImageOS-$ImageVersion" >> $GITHUB_OUTPUT
+
+    - name: Enable vcpkg cache
+      uses: actions/cache@v3
+      with:
+        path: /usr/local/share/vcpkg/installed
+        key: ${{ steps.key.outputs.image }}-vcpkg-${{ matrix.arch }}-0 # Increase the number whenever dependencies are modified
+        restore-keys: |
+          ${{ steps.key.outputs.image }}-vcpkg-${{ matrix.arch }}
+
+    - name: Prepare vcpkg
+      run: |
+        vcpkg install --triplet=${{ matrix.arch }}-osx \
+          liblzma \
+          libpng \
+          lzo \
+          zlib \
+          # EOF
+
+    - name: Install OpenGFX
+      run: |
+        mkdir -p ~/Documents/OpenTTD/baseset
+        cd ~/Documents//OpenTTD/baseset
+
+        echo "::group::Download OpenGFX"
+        curl -L https://cdn.openttd.org/opengfx-releases/0.6.0/opengfx-0.6.0-all.zip -o opengfx-all.zip
+        echo "::endgroup::"
+
+        echo "::group::Unpack OpenGFX"
+        unzip opengfx-all.zip
+        echo "::endgroup::"
+
+        rm -f opengfx-all.zip
+
+    - name: Install GCC problem matcher
+      uses: ammaraskar/gcc-problem-matcher@master
+
+    - name: Build
+      run: |
+        mkdir build
+        cd build
+
+        echo "::group::CMake"
+        cmake ${GITHUB_WORKSPACE} \
+          -DCMAKE_OSX_ARCHITECTURES=${{ matrix.full_arch }} \
+          -DVCPKG_TARGET_TRIPLET=${{ matrix.arch }}-osx \
+          -DCMAKE_TOOLCHAIN_FILE=/usr/local/share/vcpkg/scripts/buildsystems/vcpkg.cmake \
+          # EOF
+        echo "::endgroup::"
+
+        echo "::group::Build"
+        echo "Running on $(sysctl -n hw.logicalcpu) cores"
+        cmake --build . -j $(sysctl -n hw.logicalcpu)
+        echo "::endgroup::"
+
+    - name: Test
+      run: |
+        cd build
+        ctest -j $(sysctl -n hw.logicalcpu) --timeout 120
 
   windows:
+    name: Windows
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [windows-latest, windows-2019]
+        arch: [x86, x64]
+
+    runs-on: ${{ matrix.os }}
+
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
+
+    - name: Prepare cache key
+      id: key
+      shell: powershell
+      run: |
+        # Work around caching failure with GNU tar
+        New-Item -Type Junction -Path vcpkg -Target c:\vcpkg
+
+        Write-Output "image=$env:ImageOS-$env:ImageVersion" >> $env:GITHUB_OUTPUT
+
+    - name: Enable vcpkg cache
+      uses: actions/cache@v3
+      with:
+        path: vcpkg/installed
+        key: ${{ steps.key.outputs.image }}-vcpkg-${{ matrix.arch }}-0 # Increase the number whenever dependencies are modified
+        restore-keys: |
+          ${{ steps.key.outputs.image }}-vcpkg-${{ matrix.arch }}
+
+    - name: Prepare vcpkg
+      shell: bash
+      run: |
+        vcpkg install --triplet=${{ matrix.arch }}-windows-static \
+          liblzma \
+          libpng \
+          lzo \
+          zlib \
+          # EOF
+
+    - name: Install OpenGFX
+      shell: bash
+      run: |
+        mkdir -p "C:/Users/Public/Documents/OpenTTD/baseset"
+        cd "C:/Users/Public/Documents/OpenTTD/baseset"
+
+        echo "::group::Download OpenGFX"
+        curl -L https://cdn.openttd.org/opengfx-releases/0.6.0/opengfx-0.6.0-all.zip -o opengfx-all.zip
+        echo "::endgroup::"
+
+        echo "::group::Unpack OpenGFX"
+        unzip opengfx-all.zip
+        echo "::endgroup::"
+
+        rm -f opengfx-all.zip
+
+    - name: Install MSVC problem matcher
+      uses: ammaraskar/msvc-problem-matcher@master
+
+    - name: Configure developer command prompt for ${{ matrix.arch }}
+      uses: ilammy/msvc-dev-cmd@v1
+      with:
+        arch: ${{ matrix.arch }}
+
+    - name: Build
+      shell: bash
+      run: |
+        mkdir build
+        cd build
+
+        echo "::group::CMake"
+        cmake .. \
+          -GNinja \
+          -DVCPKG_TARGET_TRIPLET=${{ matrix.arch }}-windows-static \
+          -DCMAKE_TOOLCHAIN_FILE="c:\vcpkg\scripts\buildsystems\vcpkg.cmake" \
+          # EOF
+        echo "::endgroup::"
+
+        echo "::group::Build"
+        cmake --build .
+        echo "::endgroup::"
+
+    - name: Test
+      shell: bash
+      run: |
+        cd ${GITHUB_WORKSPACE}/build
+        ctest --timeout 120
+
+
+  msys2:
+    name: msys2
+
     strategy:
       fail-fast: false
       matrix:
         include:
-        - arch: x86
-        - arch: x64
+          - msystem: MINGW64
+            arch: x86_64
+          - msystem: MINGW32
+            arch: i686
 
-    name: Windows (${{ matrix.arch }})
+    runs-on: windows-latest
 
-    uses: ./.github/workflows/ci-windows.yml
-    secrets: inherit
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v3
 
-    with:
-      arch: ${{ matrix.arch }}
+    - name: Setup MSYS2
+      uses: msys2/setup-msys2@v2
+      with:
+        msystem: ${{ matrix.msystem }}
+        release: false
+        install: >-
+          git
+          make
+          mingw-w64-${{ matrix.arch }}-cmake
+          mingw-w64-${{ matrix.arch }}-gcc
+          mingw-w64-${{ matrix.arch }}-lzo2
+          mingw-w64-${{ matrix.arch }}-libpng
+
+    - name: Install OpenGFX
+      shell: bash
+      run: |
+        mkdir -p "C:/Users/Public/Documents/OpenTTD/baseset"
+        cd "C:/Users/Public/Documents/OpenTTD/baseset"
+
+        echo "::group::Download OpenGFX"
+        curl -L https://cdn.openttd.org/opengfx-releases/0.6.0/opengfx-0.6.0-all.zip -o opengfx-all.zip
+        echo "::endgroup::"
+
+        echo "::group::Unpack OpenGFX"
+        unzip opengfx-all.zip
+        echo "::endgroup::"
+
+        rm -f opengfx-all.zip
+
+    - name: Install GCC problem matcher
+      uses: ammaraskar/gcc-problem-matcher@master
+
+    - name: Build
+      shell: msys2 {0}
+      run: |
+        mkdir build
+        cd build
+
+        echo "::group::CMake"
+        cmake .. -G"MSYS Makefiles"
+        echo "::endgroup::"
+
+        echo "::group::Build"
+        echo "Running on $(nproc) cores"
+        cmake --build . -j $(nproc)
+        echo "::endgroup::"
+
+    - name: Test
+      shell: msys2 {0}
+      run: |
+        cd build
+        ctest -j $(nproc) --timeout 120
 
   check_annotations:
     name: Check Annotations
@@ -98,6 +409,7 @@ jobs:
     - linux
     - macos
     - windows
+    - msys2
 
     if: always() && github.event_name == 'pull_request'
 
@@ -105,4 +417,4 @@ jobs:
 
     steps:
     - name: Check annotations
-      uses: OpenTTD/actions/annotation-check@v5
+      uses: OpenTTD/actions/annotation-check@v3

.github/workflows/ci-emscripten.yml

@@ -1,65 +0,0 @@
-name: CI (Emscripten)
-
-on:
-  workflow_call:
-
-env:
-  CTEST_OUTPUT_ON_FAILURE: 1
-
-jobs:
-  emscripten:
-    name: CI
-
-    runs-on: ubuntu-latest
-    container:
-      # If you change this version, change the number in the cache step too.
-      image: emscripten/emsdk:3.1.57
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Fix dubious ownership
-      run: |
-        git config --global --add safe.directory ${GITHUB_WORKSPACE}
-
-    - name: Setup cache
-      uses: actions/cache@v4
-      with:
-        path: /emsdk/upstream/emscripten/cache
-        key: 3.1.57-${{ runner.os }}
-
-    - name: Add liblzma support
-      run: |
-        cp ${GITHUB_WORKSPACE}/os/emscripten/ports/liblzma.py /emsdk/upstream/emscripten/tools/ports/contrib/
-
-    - name: Build (host tools)
-      run: |
-        mkdir build-host
-        cd build-host
-
-        echo "::group::CMake"
-        cmake .. -DOPTION_TOOLS_ONLY=ON
-        echo "::endgroup::"
-
-        echo "::group::Build"
-        echo "Running on $(nproc) cores"
-        cmake --build . -j $(nproc) --target tools
-        echo "::endgroup::"
-
-    - name: Install GCC problem matcher
-      uses: ammaraskar/gcc-problem-matcher@master
-
-    - name: Build
-      run: |
-        mkdir build
-        cd build
-
-        echo "::group::CMake"
-        emcmake cmake .. -DHOST_BINARY_DIR=../build-host
-        echo "::endgroup::"
-
-        echo "::group::Build"
-        echo "Running on $(nproc) cores"
-        cmake --build . -j $(nproc) --target openttd
-        echo "::endgroup::"

.github/workflows/ci-linux.yml

@@ -1,126 +0,0 @@
-name: CI (Linux)
-
-on:
-  workflow_call:
-    inputs:
-      compiler:
-        required: true
-        type: string
-      cxxcompiler:
-        required: true
-        type: string
-      libraries:
-        required: true
-        type: string
-      extra-cmake-parameters:
-        required: true
-        type: string
-
-env:
-  CTEST_OUTPUT_ON_FAILURE: 1
-
-jobs:
-  linux:
-    name: CI
-
-    runs-on: ubuntu-24.04
-    env:
-      CC: ${{ inputs.compiler }}
-      CXX: ${{ inputs.cxxcompiler }}
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Setup vcpkg caching
-      uses: actions/github-script@v7
-      with:
-        script: |
-          core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
-          core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-          core.exportVariable('VCPKG_BINARY_SOURCES', 'clear;x-gha,readwrite')
-
-    - name: Install vcpkg
-      run: |
-        git clone https://github.com/microsoft/vcpkg ${{ runner.temp }}/vcpkg
-        ${{ runner.temp }}/vcpkg/bootstrap-vcpkg.sh -disableMetrics
-
-    - name: Install dependencies
-      run: |
-        echo "::group::Update apt"
-        sudo apt-get update
-        echo "::endgroup::"
-
-        echo "::group::Install dependencies"
-        sudo apt-get install -y --no-install-recommends \
-          liballegro4-dev \
-          libcurl4-openssl-dev \
-          libfontconfig-dev \
-          libharfbuzz-dev \
-          libicu-dev \
-          liblzma-dev \
-          liblzo2-dev \
-          libogg-dev \
-          libopus-dev \
-          libopusfile-dev \
-          ${{ inputs.libraries }} \
-          zlib1g-dev \
-          # EOF
-
-        echo "::group::Install vcpkg dependencies"
-
-        # Disable vcpkg integration, as we mostly use system libraries.
-        mv vcpkg.json vcpkg-disabled.json
-
-        # We only use breakpad from vcpkg, as its CMake files
-        # are a bit special. So the Ubuntu's variant doesn't work.
-        ${{ runner.temp }}/vcpkg/vcpkg install breakpad
-
-        echo "::endgroup::"
-      env:
-        DEBIAN_FRONTEND: noninteractive
-
-    - name: Get OpenGFX
-      run: |
-        mkdir -p ~/.local/share/openttd/baseset
-        cd ~/.local/share/openttd/baseset
-
-        echo "::group::Download OpenGFX"
-        curl -L https://cdn.openttd.org/opengfx-releases/0.6.0/opengfx-0.6.0-all.zip -o opengfx-all.zip
-        echo "::endgroup::"
-
-        echo "::group::Unpack OpenGFX"
-        unzip opengfx-all.zip
-        echo "::endgroup::"
-
-        rm -f opengfx-all.zip
-
-    - name: Install GCC problem matcher
-      uses: ammaraskar/gcc-problem-matcher@master
-
-    - name: Build
-      run: |
-        mkdir build
-        cd build
-
-        echo "::group::CMake"
-        cmake .. -DCMAKE_TOOLCHAIN_FILE=${{ runner.temp }}/vcpkg/scripts/buildsystems/vcpkg.cmake ${{ inputs.extra-cmake-parameters }}
-        echo "::endgroup::"
-
-        echo "::group::Build"
-        echo "Running on $(nproc) cores"
-        cmake --build . -j $(nproc)
-        echo "::endgroup::"
-
-    - name: Test
-      run: |
-        (
-          cd build
-          ctest -j $(nproc) --timeout 120
-        )
-
-        # Re-enable vcpkg.
-        mv vcpkg-disabled.json vcpkg.json
-
-        # Check no tracked files have been modified.
-        git diff --exit-code

.github/workflows/ci-macos.yml

@@ -1,90 +0,0 @@
-name: CI (MacOS)
-
-on:
-  workflow_call:
-    inputs:
-      arch:
-        required: true
-        type: string
-      full_arch:
-        required: true
-        type: string
-      extra-cmake-parameters:
-        required: false
-        type: string
-        default: ""
-
-env:
-  CTEST_OUTPUT_ON_FAILURE: 1
-
-jobs:
-  macos:
-    name: CI
-
-    runs-on: macos-latest
-    env:
-      MACOSX_DEPLOYMENT_TARGET: 10.13
-
-    steps:
-    - name: Setup Xcode version
-      uses: maxim-lobanov/setup-xcode@v1
-      with:
-        xcode-version: latest-stable
-
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Setup vcpkg caching
-      uses: actions/github-script@v7
-      with:
-        script: |
-          core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
-          core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-          core.exportVariable('VCPKG_BINARY_SOURCES', 'clear;x-gha,readwrite')
-
-    - name: Install vcpkg
-      run: |
-        git clone https://github.com/microsoft/vcpkg ${{ runner.temp }}/vcpkg
-        ${{ runner.temp }}/vcpkg/bootstrap-vcpkg.sh -disableMetrics
-
-    - name: Install OpenGFX
-      run: |
-        mkdir -p ~/Documents/OpenTTD/baseset
-        cd ~/Documents/OpenTTD/baseset
-
-        echo "::group::Download OpenGFX"
-        curl -L https://cdn.openttd.org/opengfx-releases/0.6.0/opengfx-0.6.0-all.zip -o opengfx-all.zip
-        echo "::endgroup::"
-
-        echo "::group::Unpack OpenGFX"
-        unzip opengfx-all.zip
-        echo "::endgroup::"
-
-        rm -f opengfx-all.zip
-
-    - name: Install GCC problem matcher
-      uses: ammaraskar/gcc-problem-matcher@master
-
-    - name: Build
-      run: |
-        mkdir build
-        cd build
-
-        echo "::group::CMake"
-        cmake .. \
-          -DCMAKE_OSX_ARCHITECTURES=${{ inputs.full_arch }} \
-          -DVCPKG_TARGET_TRIPLET=${{ inputs.arch }}-osx \
-          -DCMAKE_TOOLCHAIN_FILE=${{ runner.temp }}/vcpkg/scripts/buildsystems/vcpkg.cmake \
-          ${{ inputs.extra-cmake-parameters }} \
-          # EOF
-        echo "::endgroup::"
-
-        echo "::group::Build"
-        echo "Running on $(sysctl -n hw.logicalcpu) cores"
-        cmake --build . -j $(sysctl -n hw.logicalcpu)
-        echo "::endgroup::"
-
-    - name: Test
-      run: |
-        cd build
-        ctest -j $(sysctl -n hw.logicalcpu) --timeout 120

.github/workflows/ci-mingw.yml

@@ -1,86 +0,0 @@
-name: CI (MinGW)
-
-on:
-  workflow_call:
-    inputs:
-      arch:
-        required: true
-        type: string
-      msystem:
-        required: true
-        type: string
-
-env:
-  CTEST_OUTPUT_ON_FAILURE: 1
-
-jobs:
-  mingw:
-    name: CI
-
-    runs-on: windows-latest
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Setup MSYS2
-      uses: msys2/setup-msys2@v2
-      with:
-        msystem: ${{ inputs.msystem }}
-        release: false
-        install: >-
-          git
-          make
-          mingw-w64-${{ inputs.arch }}-cmake
-          mingw-w64-${{ inputs.arch }}-gcc
-          mingw-w64-${{ inputs.arch }}-lzo2
-          mingw-w64-${{ inputs.arch }}-libpng
-          mingw-w64-${{ inputs.arch }}-lld
-          mingw-w64-${{ inputs.arch }}-ninja
-          mingw-w64-${{ inputs.arch }}-libogg
-          mingw-w64-${{ inputs.arch }}-opus
-          mingw-w64-${{ inputs.arch }}-opusfile
-
-    - name: Install OpenGFX
-      shell: bash
-      run: |
-        mkdir -p "C:/Users/Public/Documents/OpenTTD/baseset"
-        cd "C:/Users/Public/Documents/OpenTTD/baseset"
-
-        echo "::group::Download OpenGFX"
-        curl -L https://cdn.openttd.org/opengfx-releases/0.6.0/opengfx-0.6.0-all.zip -o opengfx-all.zip
-        echo "::endgroup::"
-
-        echo "::group::Unpack OpenGFX"
-        unzip opengfx-all.zip
-        echo "::endgroup::"
-
-        rm -f opengfx-all.zip
-
-    - name: Install GCC problem matcher
-      uses: ammaraskar/gcc-problem-matcher@master
-
-    - name: Build
-      shell: msys2 {0}
-      env:
-        NINJA_STATUS: "[%f/%t -- %e] " # [finished_edges/total_edges -- elapsed_time], default value is "[%f/%t] "
-      run: |
-        mkdir build
-        cd build
-
-        echo "::group::CMake"
-        cmake .. \
-          -GNinja \
-          -DCMAKE_CXX_FLAGS="-fuse-ld=lld" \
-          # EOF
-        echo "::endgroup::"
-
-        echo "::group::Build"
-        cmake --build .
-        echo "::endgroup::"
-
-    - name: Test
-      shell: msys2 {0}
-      run: |
-        cd build
-        ctest --timeout 120

.github/workflows/ci-nightly.yml

@@ -1,82 +0,0 @@
-name: CI - Nightly
-
-on:
-  schedule:
-  - cron: '0 3 * * *'
-  workflow_dispatch:
-
-env:
-  CTEST_OUTPUT_ON_FAILURE: 1
-
-jobs:
-  linux:
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-        - name: GCC - SDL1.2
-          compiler: gcc
-          cxxcompiler: g++
-          libraries: libsdl1.2-dev
-
-    name: Linux (${{ matrix.name }})
-
-    uses: ./.github/workflows/ci-linux.yml
-    secrets: inherit
-
-    with:
-      compiler: ${{ matrix.compiler }}
-      cxxcompiler: ${{ matrix.cxxcompiler }}
-      libraries: ${{ matrix.libraries }}
-      extra-cmake-parameters:
-
-  macos:
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-        - arch: x64
-          full_arch: x86_64
-
-    name: Mac OS (${{ matrix.arch }})
-
-    uses: ./.github/workflows/ci-macos.yml
-    secrets: inherit
-
-    with:
-      arch: ${{ matrix.arch }}
-      full_arch: ${{ matrix.full_arch }}
-
-  mingw:
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-        - msystem: MINGW64
-          arch: x86_64
-        - msystem: MINGW32
-          arch: i686
-
-    name: MinGW (${{ matrix.arch }})
-
-    uses: ./.github/workflows/ci-mingw.yml
-    secrets: inherit
-
-    with:
-      msystem: ${{ matrix.msystem }}
-      arch: ${{ matrix.arch }}
-
-  check_annotations:
-    name: Check Annotations
-    needs:
-    - linux
-    - macos
-    - mingw
-
-    if: always()
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Check annotations
-      uses: OpenTTD/actions/annotation-check@v5

.github/workflows/ci-windows.yml

@@ -1,84 +0,0 @@
-name: CI (Windows)
-
-on:
-  workflow_call:
-    inputs:
-      arch:
-        required: true
-        type: string
-
-env:
-  CTEST_OUTPUT_ON_FAILURE: 1
-
-jobs:
-  windows:
-    name: CI
-
-    runs-on: windows-latest
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Setup vcpkg caching
-      uses: actions/github-script@v7
-      with:
-        script: |
-          core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
-          core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-          core.exportVariable('VCPKG_BINARY_SOURCES', 'clear;x-gha,readwrite')
-
-    - name: Install vcpkg
-      run: |
-        git clone https://github.com/microsoft/vcpkg ${{ runner.temp }}\vcpkg
-        ${{ runner.temp }}\vcpkg\bootstrap-vcpkg.bat -disableMetrics
-
-    - name: Install OpenGFX
-      shell: bash
-      run: |
-        mkdir -p "C:/Users/Public/Documents/OpenTTD/baseset"
-        cd "C:/Users/Public/Documents/OpenTTD/baseset"
-
-        echo "::group::Download OpenGFX"
-        curl -L https://cdn.openttd.org/opengfx-releases/0.6.0/opengfx-0.6.0-all.zip -o opengfx-all.zip
-        echo "::endgroup::"
-
-        echo "::group::Unpack OpenGFX"
-        unzip opengfx-all.zip
-        echo "::endgroup::"
-
-        rm -f opengfx-all.zip
-
-    - name: Install MSVC problem matcher
-      uses: ammaraskar/msvc-problem-matcher@master
-
-    - name: Configure developer command prompt for ${{ inputs.arch }}
-      uses: ilammy/msvc-dev-cmd@v1
-      with:
-        arch: ${{ inputs.arch }}
-
-    - name: Build
-      shell: bash
-      env:
-        NINJA_STATUS: "[%f/%t -- %e] " # [finished_edges/total_edges -- elapsed_time], default value is "[%f/%t] "
-      run: |
-        mkdir build
-        cd build
-
-        echo "::group::CMake"
-        cmake .. \
-          -GNinja \
-          -DVCPKG_TARGET_TRIPLET=${{ inputs.arch }}-windows-static \
-          -DCMAKE_TOOLCHAIN_FILE="${{ runner.temp }}\vcpkg\scripts\buildsystems\vcpkg.cmake" \
-          # EOF
-        echo "::endgroup::"
-
-        echo "::group::Build"
-        cmake --build .
-        echo "::endgroup::"
-
-    - name: Test
-      shell: bash
-      run: |
-        cd build
-        ctest --timeout 120

.github/workflows/codeql.yml

@@ -1,121 +0,0 @@
-name: CodeQL
-
-on:
-  push:
-    branches:
-    - master
-  pull_request:
-    # The branches below must be a subset of the branches above
-    branches:
-    - master
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
-
-jobs:
-  analyze:
-    name: Analyze
-    runs-on: ubuntu-latest
-    permissions:
-      actions: read
-      contents: read
-      security-events: write
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Setup vcpkg caching
-      uses: actions/github-script@v7
-      with:
-        script: |
-          core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
-          core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-          core.exportVariable('VCPKG_BINARY_SOURCES', 'clear;x-gha,readwrite')
-
-    - name: Install vcpkg
-      run: |
-        git clone https://github.com/microsoft/vcpkg ${{ runner.temp }}/vcpkg
-        ${{ runner.temp }}/vcpkg/bootstrap-vcpkg.sh -disableMetrics
-
-    - name: Install dependencies
-      run: |
-        echo "::group::Update apt"
-        sudo apt-get update
-        echo "::endgroup::"
-
-        echo "::group::Install dependencies"
-        sudo apt-get install -y --no-install-recommends \
-          liballegro4-dev \
-          libcurl4-openssl-dev \
-          libfontconfig-dev \
-          libharfbuzz-dev \
-          libicu-dev \
-          liblzma-dev \
-          liblzo2-dev \
-          libopus-dev \
-          libopusfile-dev \
-          libsdl2-dev \
-          zlib1g-dev \
-          # EOF
-
-        echo "::group::Install vcpkg dependencies"
-
-        # Disable vcpkg integration, as we mostly use system libraries.
-        mv vcpkg.json vcpkg-disabled.json
-
-        # We only use breakpad from vcpkg, as its CMake files
-        # are a bit special. So the Ubuntu's variant doesn't work.
-        ${{ runner.temp }}/vcpkg/vcpkg install breakpad
-
-        echo "::endgroup::"
-      env:
-        DEBIAN_FRONTEND: noninteractive
-
-    - name: Prepare build
-      run: |
-        mkdir build
-        cd build
-
-        echo "::group::CMake"
-        cmake .. -DCMAKE_TOOLCHAIN_FILE=${{ runner.temp }}/vcpkg/scripts/buildsystems/vcpkg.cmake
-        echo "::endgroup::"
-
-    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v3
-      with:
-        languages: cpp
-        config-file: ./.github/codeql/codeql-config.yml
-
-    - name: Build
-      run: |
-        cd build
-
-        echo "::group::Build"
-        echo "Running on $(nproc) cores"
-        cmake --build . -j $(nproc)
-        echo "::endgroup::"
-
-    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v3
-      with:
-        category: /language:cpp
-        upload: False
-        output: sarif-results
-
-    - name: Filter out table & generated code
-      uses: advanced-security/filter-sarif@v1
-      with:
-        patterns: |
-          +**/*.*
-          -**/table/*.*
-          -**/generated/**/*.*
-          -**/tests/*.*
-        input: sarif-results/cpp.sarif
-        output: sarif-results/cpp.sarif
-
-    - name: Upload results
-      uses: github/codeql-action/upload-sarif@v3
-      with:
-        sarif_file: sarif-results/cpp.sarif

.github/workflows/commit-checker.yml

@@ -3,10 +3,6 @@ name: Commit checker
 on:
   pull_request:
 
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
-
 jobs:
   commit-checker:
     name: Commit checker
@@ -14,12 +10,12 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v3
       with:
         fetch-depth: 4
 
     - name: Get pull-request commits
-      uses: OpenTTD/actions/checkout-pull-request@v5
+      uses: OpenTTD/actions/checkout-pull-request@v2
 
     - name: Check commits
       uses: OpenTTD/OpenTTD-git-hooks@main

.github/workflows/preview-build.yml

@@ -1,102 +0,0 @@
-name: Preview build
-
-on:
-  workflow_call:
-    secrets:
-      PREVIEW_CLOUDFLARE_API_TOKEN:
-        description: API token to upload a preview to Cloudflare Pages
-        required: true
-      PREVIEW_CLOUDFLARE_ACCOUNT_ID:
-        description: Account ID to upload a preview to Cloudflare Pages
-        required: true
-
-jobs:
-  preview:
-    name: Build preview
-
-    environment:
-      name: preview
-      url: https://preview.openttd.org/pr${{ github.event.pull_request.number }}/
-
-    runs-on: ubuntu-latest
-    container:
-      # If you change this version, change the number in the cache step too.
-      image: emscripten/emsdk:3.1.57
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-      with:
-        ref: ${{ github.event.pull_request.head.sha }}
-
-    - name: Name branch
-      run: |
-        git config --global --add safe.directory ${GITHUB_WORKSPACE}
-        git checkout -b pr${{ github.event.pull_request.number }}
-
-    - name: Setup cache
-      uses: actions/cache@v4
-      with:
-        path: /emsdk/upstream/emscripten/cache
-        key: 3.1.57-${{ runner.os }}
-
-    - name: Add liblzma support
-      run: |
-        cp ${GITHUB_WORKSPACE}/os/emscripten/ports/liblzma.py /emsdk/upstream/emscripten/tools/ports/contrib/
-
-    - name: Build (host tools)
-      run: |
-        mkdir build-host
-        cd build-host
-
-        echo "::group::CMake"
-        cmake .. -DOPTION_TOOLS_ONLY=ON
-        echo "::endgroup::"
-
-        echo "::group::Build"
-        echo "Running on $(nproc) cores"
-        make -j$(nproc) tools
-        echo "::endgroup::"
-
-    - name: Install GCC problem matcher
-      uses: ammaraskar/gcc-problem-matcher@master
-
-    - name: Build
-      run: |
-        mkdir build
-        cd build
-
-        echo "::group::CMake"
-        emcmake cmake .. \
-          -DHOST_BINARY_DIR=../build-host \
-          -DCMAKE_BUILD_TYPE=Release \
-          # EOF
-        echo "::endgroup::"
-
-        echo "::group::Build"
-        echo "Running on $(nproc) cores"
-        cmake --build . -j $(nproc) --target openttd
-        echo "::endgroup::"
-
-    - name: Prepare preview
-      run: |
-        mkdir public
-
-        cp build/openttd.data public/
-        cp build/openttd.html public/
-        cp build/openttd.js public/
-        cp build/openttd.wasm public/
-
-        # Ensure we use the latest version of npm; the one we get with current
-        # emscripten doesn't allow running "npx wrangler" as root.
-        # Current emscripten can't install npm>=10.0.0 because node is too old.
-        npm install -g npm@9
-
-    - name: Publish preview
-      uses: cloudflare/pages-action@v1
-      with:
-        apiToken: ${{ secrets.PREVIEW_CLOUDFLARE_API_TOKEN }}
-        accountId: ${{ secrets.PREVIEW_CLOUDFLARE_ACCOUNT_ID }}
-        projectName: ${{ vars.PREVIEW_CLOUDFLARE_PROJECT_NAME }}
-        directory: public
-        branch: pr${{ github.event.pull_request.number }}

.github/workflows/preview.yml

@@ -1,21 +0,0 @@
-name: Preview
-
-on:
-  pull_request_target:
-    types:
-    - labeled
-    - synchronize
-    branches:
-    - master
-    - release/**
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
-  cancel-in-progress: true
-
-jobs:
-  preview:
-    if: ${{ (github.event.action == 'labeled' && github.event.label.name == 'preview') || (github.event.action != 'labeled' && contains(github.event.pull_request.labels.*.name, 'preview')) }}
-    name: Preview
-    uses: ./.github/workflows/preview-build.yml
-    secrets: inherit

.github/workflows/preview_build.yml

@@ -0,0 +1,133 @@
+name: Preview build
+
+on:
+  repository_dispatch:
+    types:
+    - Preview*
+
+jobs:
+  preview:
+    name: Build preview
+
+    runs-on: ubuntu-20.04
+    container:
+      # If you change this version, change the number in the cache step too.
+      image: emscripten/emsdk:3.1.28
+
+    steps:
+    - name: Update deployment status to in progress
+      uses: octokit/request-action@v2.x
+      with:
+        route: POST /repos/{owner}/{repo}/deployments/{deployment_id}/statuses
+        mediaType: |
+          previews:
+          - ant-man
+          - flash
+        owner: ${{ github.event.repository.owner.login }}
+        repo: ${{ github.event.repository.name }}
+        deployment_id: ${{ github.event.client_payload.deployment_id }}
+        state: in_progress
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+
+    - name: Checkout
+      uses: actions/checkout@v3
+      with:
+        ref: ${{ github.event.client_payload.sha }}
+
+    - name: Name branch
+      run: |
+        name=$(echo "${{ github.event.client_payload.folder }}")
+        git checkout -b ${name}
+
+    - name: Setup cache
+      uses: actions/cache@v3
+      with:
+        path: /emsdk/upstream/emscripten/cache
+        key: 3.1.28-${{ runner.os }}
+
+    - name: Patch Emscripten to support LZMA
+      run: |
+        cd /emsdk/upstream/emscripten
+        patch -p1 < ${GITHUB_WORKSPACE}/os/emscripten/emsdk-liblzma.patch
+
+    - name: Build (host tools)
+      run: |
+        mkdir build-host
+        cd build-host
+
+        echo "::group::CMake"
+        cmake .. -DOPTION_TOOLS_ONLY=ON
+        echo "::endgroup::"
+
+        echo "::group::Build"
+        echo "Running on $(nproc) cores"
+        make -j$(nproc) tools
+        echo "::endgroup::"
+
+    - name: Install GCC problem matcher
+      uses: ammaraskar/gcc-problem-matcher@master
+
+    - name: Build
+      run: |
+        mkdir build
+        cd build
+
+        echo "::group::CMake"
+        emcmake cmake .. \
+          -DHOST_BINARY_DIR=../build-host \
+          -DCMAKE_BUILD_TYPE=Release \
+          # EOF
+        echo "::endgroup::"
+
+        echo "::group::Build"
+        echo "Running on $(nproc) cores"
+        emmake make -j$(nproc)
+        echo "::endgroup::"
+
+    - name: Publish preview
+      run: |
+        pip3 install awscli
+
+        aws s3 cp --only-show-errors build/openttd.data s3://${{ secrets.PREVIEW_S3_BUCKET }}/${{ github.event.client_payload.folder }}/
+        aws s3 cp --only-show-errors build/openttd.html s3://${{ secrets.PREVIEW_S3_BUCKET }}/${{ github.event.client_payload.folder }}/
+        aws s3 cp --only-show-errors build/openttd.js s3://${{ secrets.PREVIEW_S3_BUCKET }}/${{ github.event.client_payload.folder }}/
+        aws s3 cp --only-show-errors build/openttd.wasm s3://${{ secrets.PREVIEW_S3_BUCKET }}/${{ github.event.client_payload.folder }}/
+
+        # Invalidate the cache of the CloudFront distribution
+        aws cloudfront create-invalidation --distribution-id ${{ secrets.PREVIEW_CF_DISTRIBUTION_ID }} --paths "/${{ github.event.client_payload.folder }}/*"
+      env:
+        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+
+    - name: Update deployment status to success
+      uses: octokit/request-action@v2.x
+      with:
+        route: POST /repos/{owner}/{repo}/deployments/{deployment_id}/statuses
+        mediaType: |
+          previews:
+          - ant-man
+          - flash
+        owner: ${{ github.event.repository.owner.login }}
+        repo: ${{ github.event.repository.name }}
+        deployment_id: ${{ github.event.client_payload.deployment_id }}
+        state: success
+        environment_url: https://preview.openttd.org/${{ github.event.client_payload.folder }}/
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+
+    - if: failure()
+      name: Update deployment status to failure
+      uses: octokit/request-action@v2.x
+      with:
+        route: POST /repos/{owner}/{repo}/deployments/{deployment_id}/statuses
+        mediaType: |
+          previews:
+          - ant-man
+          - flash
+        owner: ${{ github.event.repository.owner.login }}
+        repo: ${{ github.event.repository.name }}
+        deployment_id: ${{ github.event.client_payload.deployment_id }}
+        state: failure
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}

.github/workflows/preview_label.yml

@@ -0,0 +1,66 @@
+name: Preview label
+
+on:
+  pull_request_target:
+    types:
+    - labeled
+
+env:
+  TEAM_CORE_DEVELOPER: core-developers
+
+jobs:
+  check_preview_label:
+    name: Check for preview label
+    if: github.event.action == 'labeled' && github.event.label.name == 'preview'
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Check if label was added by core developer
+      id: core_developer
+      continue-on-error: true
+      uses: octokit/request-action@v2.x
+      with:
+        route: GET /orgs/OpenTTD/teams/${{ env.TEAM_CORE_DEVELOPER }}/memberships/${{ github.event.sender.login }}
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+
+    - if: steps.core_developer.outcome == 'failure'
+      name: Remove preview label if not core developer
+      uses: octokit/request-action@v2.x
+      with:
+        route: DELETE /repos/{owner}/{repo}/issues/{issue_number}/labels/preview
+        owner: ${{ github.event.repository.owner.login }}
+        repo: ${{ github.event.repository.name }}
+        issue_number: ${{ github.event.number }}
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+
+    - if: steps.core_developer.outcome == 'success'
+      name: Create deployment
+      id: deployment
+      uses: octokit/request-action@v2.x
+      with:
+        route: POST /repos/{owner}/{repo}/deployments
+        mediaType: |
+          previews:
+          - ant-man
+          - flash
+        owner: ${{ github.event.repository.owner.login }}
+        repo: ${{ github.event.repository.name }}
+        ref: ${{ github.event.pull_request.head.sha }}
+        task: deploy:preview
+        auto_merge: false
+        required_contexts: "[]"
+        environment: preview-pr-${{ github.event.number }}
+        description: "Preview for Pull Request #${{ github.event.number }}"
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+
+    - if: steps.core_developer.outcome == 'success'
+      name: Trigger 'preview build'
+      uses: peter-evans/repository-dispatch@v2
+      with:
+        token: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+        event-type: "Preview build #${{ github.event.number }}"
+        client-payload: '{"folder": "pr${{ github.event.number }}", "sha": "${{ github.event.pull_request.head.sha }}", "deployment_id": "${{ fromJson(steps.deployment.outputs.data).id }}"}'

.github/workflows/preview_push.yml

@@ -0,0 +1,66 @@
+name: Preview push
+
+on:
+  pull_request_target:
+    types:
+    - synchronize
+
+jobs:
+  check_new_preview:
+    name: Check preview needs update
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Check if earlier preview exists
+      id: earlier_preview
+      uses: octokit/request-action@v2.x
+      with:
+        route: GET /repos/{owner}/{repo}/deployments
+        owner: ${{ github.event.repository.owner.login }}
+        repo: ${{ github.event.repository.name }}
+        environment: preview-pr-${{ github.event.number }}
+        per_page: 1
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+
+    - if: toJson(fromJson(steps.earlier_preview.outputs.data)) != '[]'
+      name: Check for preview label
+      id: preview_label
+      uses: octokit/request-action@v2.x
+      with:
+        route: GET /repos/{owner}/{repo}/issues/{issue_number}/labels
+        owner: ${{ github.event.repository.owner.login }}
+        repo: ${{ github.event.repository.name }}
+        issue_number: ${{ github.event.number }}
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+
+    - if: toJson(fromJson(steps.earlier_preview.outputs.data)) != '[]' && contains(fromJson(steps.preview_label.outputs.data).*.name, 'preview')
+      name: Create deployment
+      id: deployment
+      uses: octokit/request-action@v2.x
+      with:
+        route: POST /repos/{owner}/{repo}/deployments
+        mediaType: |
+          previews:
+          - ant-man
+          - flash
+        owner: ${{ github.event.repository.owner.login }}
+        repo: ${{ github.event.repository.name }}
+        ref: ${{ github.event.pull_request.head.sha }}
+        task: deploy:preview
+        auto_merge: false
+        required_contexts: "[]"
+        environment: preview-pr-${{ github.event.number }}
+        description: "Preview for Pull Request #${{ github.event.number }}"
+      env:
+        GITHUB_TOKEN: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+
+    - if: toJson(fromJson(steps.earlier_preview.outputs.data)) != '[]' && contains(fromJson(steps.preview_label.outputs.data).*.name, 'preview')
+      name: Trigger 'preview build'
+      uses: peter-evans/repository-dispatch@v2
+      with:
+        token: ${{ secrets.PREVIEW_GITHUB_TOKEN }}
+        event-type: "Preview build #${{ github.event.number }}"
+        client-payload: '{"folder": "pr${{ github.event.number }}", "sha": "${{ github.event.pull_request.head.sha }}", "deployment_id": "${{ fromJson(steps.deployment.outputs.data).id }}"}'

.github/workflows/release-docs.yml

@@ -11,11 +11,11 @@ jobs:
   docs:
     name: Docs
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
 
     steps:
     - name: Download source
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v3
       with:
         name: internal-source
 
@@ -78,7 +78,7 @@ jobs:
         echo "::endgroup::"
 
     - name: Store bundles
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: openttd-docs
         path: build/bundles/*.tar.xz

.github/workflows/release-linux.yml

@@ -2,26 +2,20 @@ name: Release (Linux)
 
 on:
   workflow_call:
-    inputs:
-      survey_key:
-        required: false
-        type: string
-        default: ""
 
 jobs:
   linux:
     name: Linux (Generic)
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     container:
-      # manylinux_2_28 is based on AlmaLinux 8, and already has a lot of things
+      # manylinux2014 is based on CentOS 7, but already has a lot of things
       # installed and preconfigured. It makes it easier to build OpenTTD.
-      # This distro is based on glibc 2.28, released in 2018.
-      image: quay.io/pypa/manylinux_2_28_x86_64
+      image: quay.io/pypa/manylinux2014_x86_64
 
     steps:
     - name: Download source
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v3
       with:
         name: internal-source
 
@@ -29,102 +23,40 @@ jobs:
       run: |
         tar -xf source.tar.gz --strip-components=1
 
-    - name: Install Rust toolchain
-      uses: dtolnay/rust-toolchain@stable
-
-    - name: Enable Rust cache
-      uses: Swatinem/rust-cache@v2
-
-    - name: Setup vcpkg caching
-      uses: actions/github-script@v7
-      with:
-        script: |
-          core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
-          core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-          core.exportVariable('VCPKG_BINARY_SOURCES', 'clear;x-gha,readwrite')
-
     - name: Install dependencies
       run: |
-        echo "::group::Install system dependencies"
-        # perl-IPC-Cmd, wget, and zip are needed to run vcpkg.
-        # autoconf-archive is needed to build ICU.
+        echo "::group::Install dependencies"
         yum install -y \
-          autoconf-archive \
-          perl-IPC-Cmd \
+          fontconfig-devel \
+          freetype-devel \
+          libicu-devel \
+          libpng-devel \
+          lzo-devel \
+          SDL2-devel \
           wget \
-          zip \
+          xz-devel \
+          zlib-devel \
           # EOF
-
-        # aclocal looks first in /usr/local/share/aclocal, and if that doesn't
-        # exist only looks in /usr/share/aclocal. We have files in both that
-        # are important. So copy the latter to the first, and we are good to
-        # go.
-        cp /usr/share/aclocal/* /usr/local/share/aclocal/
         echo "::endgroup::"
 
         # The yum variant of fluidsynth depends on all possible audio drivers,
         # like jack, ALSA, pulseaudio, etc. This is not really useful for us,
         # as we route the output of fluidsynth back via our sound driver, and
-        # as such do not use these audio driver outputs at all.
-        # The vcpkg variant of fluidsynth depends on ALSA. Similar issue here.
-        # So instead, we compile fluidsynth ourselves, with as few
-        # dependencies as possible. We do it before anything else is installed,
-        # to make sure it doesn't pick up on any of the drivers.
+        # as such do not use these audio driver outputs at all. So instead,
+        # we compile fluidsynth ourselves, with as little dependencies as
+        # possible. This currently means it picks up SDL2, but this is fine,
+        # as we need SDL2 anyway.
         echo "::group::Install fluidsynth"
-        wget https://github.com/FluidSynth/fluidsynth/archive/v2.3.3.tar.gz
-        tar xf v2.3.3.tar.gz
+        wget https://github.com/FluidSynth/fluidsynth/archive/v2.1.6.tar.gz
+        tar xf v2.1.6.tar.gz
         (
-          cd fluidsynth-2.3.3
+          cd fluidsynth-2.1.6
           mkdir build
           cd build
           cmake .. -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_INSTALL_PREFIX=/usr
           cmake --build . -j $(nproc)
           cmake --install .
         )
-
-        echo "::group::Install audio drivers"
-        # These audio libs are to make sure the SDL version of vcpkg adds
-        # sound-support; these libraries are not added to the resulting
-        # binary, but the headers are used to enable them in SDL.
-        yum install -y \
-          alsa-lib-devel \
-          pulseaudio-libs-devel \
-          # EOF
-        echo "::endgroup::"
-
-        echo "::group::Install video drivers"
-        # These video libs are to make sure the SDL version of vcpkg adds
-        # video-support; these libraries are not added to the resulting
-        # binary, but the headers are used to enable them in SDL.
-        yum install -y \
-          libX11-devel \
-          libXcursor-devel \
-          libXext-devel \
-          libXfixes-devel \
-          libXi-devel \
-          libxkbcommon-devel \
-          libXrandr-devel \
-          libXScrnSaver-devel \
-          mesa-libEGL-devel \
-          mesa-libGL-devel \
-          mesa-libGLES-devel \
-          wayland-devel \
-          wayland-protocols-devel \
-          # EOF
-        echo "::endgroup::"
-
-        # We use vcpkg for our dependencies, to get more up-to-date version.
-        echo "::group::Install vcpkg and dependencies"
-
-        git clone https://github.com/microsoft/vcpkg /vcpkg
-
-        (
-          cd /vcpkg
-          ./bootstrap-vcpkg.sh -disableMetrics
-        )
-
-        echo "::group::Install breakpad dependencies"
-        cargo install --locked dump_syms
         echo "::endgroup::"
 
     - name: Install GCC problem matcher
@@ -137,23 +69,16 @@ jobs:
 
         echo "::group::CMake"
         cmake ${GITHUB_WORKSPACE} \
-          -DCMAKE_TOOLCHAIN_FILE=/vcpkg/scripts/buildsystems/vcpkg.cmake \
           -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-          -DOPTION_SURVEY_KEY=${{ inputs.survey_key }} \
           -DOPTION_PACKAGE_DEPENDENCIES=ON \
           # EOF
         echo "::endgroup::"
 
         echo "::group::Build"
         echo "Running on $(nproc) cores"
-        cmake --build . -j $(nproc) --target openttd
+        cmake --build . -j $(nproc)
         echo "::endgroup::"
 
-    - name: Create breakpad symbols
-      run: |
-        cd build
-        dump_syms ./openttd --inlines --store symbols
-
     - name: Create bundles
       run: |
         cd ${GITHUB_WORKSPACE}/build
@@ -168,15 +93,8 @@ jobs:
         echo "::endgroup::"
 
     - name: Store bundles
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: openttd-linux-generic
         path: build/bundles
         retention-days: 5
-
-    - name: Store symbols
-      uses: actions/upload-artifact@v4
-      with:
-        name: symbols-linux-generic
-        path: build/symbols
-        retention-days: 5

.github/workflows/release-macos.yml

@@ -2,28 +2,18 @@ name: Release (MacOS)
 
 on:
   workflow_call:
-    inputs:
-      survey_key:
-        required: false
-        type: string
-        default: ""
 
 jobs:
   macos:
     name: MacOS
 
-    runs-on: macos-latest
+    runs-on: macos-11
     env:
       MACOSX_DEPLOYMENT_TARGET: 10.13
 
     steps:
-    - name: Setup Xcode version
-      uses: maxim-lobanov/setup-xcode@v1
-      with:
-        xcode-version: latest-stable
-
     - name: Download source
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v3
       with:
         name: internal-source
 
@@ -31,39 +21,42 @@ jobs:
       run: |
         tar -xf source.tar.gz --strip-components=1
 
-    - name: Install Rust toolchain
-      uses: dtolnay/rust-toolchain@stable
-
-    - name: Enable Rust cache
-      uses: Swatinem/rust-cache@v2
-
-    - name: Setup vcpkg caching
-      uses: actions/github-script@v7
-      with:
-        script: |
-          core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
-          core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-          core.exportVariable('VCPKG_BINARY_SOURCES', 'clear;x-gha,readwrite')
-
-    - name: Install vcpkg
-      run: |
-        git clone https://github.com/microsoft/vcpkg ${{ runner.temp }}/vcpkg
-        ${{ runner.temp }}/vcpkg/bootstrap-vcpkg.sh -disableMetrics
-
     - name: Install dependencies
       env:
         HOMEBREW_NO_AUTO_UPDATE: 1
         HOMEBREW_NO_INSTALL_CLEANUP: 1
       run: |
-        echo "::group::Install brew dependencies"
         brew install \
           pandoc \
+          pkg-config \
           # EOF
-        echo "::endgroup::"
 
-        echo "::group::Install breakpad dependencies"
-        cargo install --locked dump_syms
-        echo "::endgroup::"
+    - name: Prepare cache key
+      id: key
+      run: |
+        echo "image=$ImageOS-$ImageVersion" >> $GITHUB_OUTPUT
+
+    - name: Enable vcpkg cache
+      uses: actions/cache@v3
+      with:
+        path: /usr/local/share/vcpkg/installed
+        key: ${{ steps.key.outputs.image }}-vcpkg-release-0 # Increase the number whenever dependencies are modified
+        restore-keys: |
+          ${{ steps.key.outputs.image }}-vcpkg-release
+          ${{ steps.key.outputs.image }}-vcpkg-x64
+
+    - name: Prepare vcpkg
+      run: |
+        vcpkg install \
+          liblzma:x64-osx \
+          liblzma:arm64-osx \
+          libpng:x64-osx \
+          libpng:arm64-osx \
+          lzo:x64-osx \
+          lzo:arm64-osx \
+          zlib:x64-osx \
+          zlib:arm64-osx \
+          # EOF
 
     - name: Install GCC problem matcher
       uses: ammaraskar/gcc-problem-matcher@master
@@ -86,7 +79,7 @@ jobs:
         echo "::endgroup::"
 
     - name: Import code signing certificates
-      uses: Apple-Actions/import-codesign-certs@v3
+      uses: Apple-Actions/import-codesign-certs@v2
       with:
         # The certificates in a PKCS12 file encoded as a base64 string
         p12-file-base64: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_P12_BASE64 }}
@@ -104,16 +97,15 @@ jobs:
         cmake ${GITHUB_WORKSPACE} \
           -DCMAKE_OSX_ARCHITECTURES=arm64 \
           -DVCPKG_TARGET_TRIPLET=arm64-osx \
-          -DCMAKE_TOOLCHAIN_FILE=${{ runner.temp }}/vcpkg/scripts/buildsystems/vcpkg.cmake \
+          -DCMAKE_TOOLCHAIN_FILE=/usr/local/share/vcpkg/scripts/buildsystems/vcpkg.cmake \
           -DHOST_BINARY_DIR=${GITHUB_WORKSPACE}/build-host \
           -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-          -DOPTION_SURVEY_KEY=${{ inputs.survey_key }} \
           # EOF
         echo "::endgroup::"
 
         echo "::group::Build"
         echo "Running on $(sysctl -n hw.logicalcpu) cores"
-        cmake --build . -j $(sysctl -n hw.logicalcpu) --target openttd
+        cmake --build . -j $(sysctl -n hw.logicalcpu)
         echo "::endgroup::"
 
     - name: Build x64
@@ -125,10 +117,9 @@ jobs:
         cmake ${GITHUB_WORKSPACE} \
           -DCMAKE_OSX_ARCHITECTURES=x86_64 \
           -DVCPKG_TARGET_TRIPLET=x64-osx \
-          -DCMAKE_TOOLCHAIN_FILE=${{ runner.temp }}/vcpkg/scripts/buildsystems/vcpkg.cmake \
+          -DCMAKE_TOOLCHAIN_FILE=/usr/local/share/vcpkg/scripts/buildsystems/vcpkg.cmake \
           -DHOST_BINARY_DIR=${GITHUB_WORKSPACE}/build-host \
           -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-          -DOPTION_SURVEY_KEY=${{ inputs.survey_key }} \
           -DCPACK_BUNDLE_APPLE_CERT_APP=${{ secrets.APPLE_DEVELOPER_CERTIFICATE_ID }} \
           "-DCPACK_BUNDLE_APPLE_CODESIGN_PARAMETER=--deep -f --options runtime" \
           -DAPPLE_UNIVERSAL_PACKAGE=1 \
@@ -137,21 +128,9 @@ jobs:
 
         echo "::group::Build"
         echo "Running on $(sysctl -n hw.logicalcpu) cores"
-        cmake --build . -j $(sysctl -n hw.logicalcpu) --target openttd
+        cmake --build . -j $(sysctl -n hw.logicalcpu)
         echo "::endgroup::"
 
-    - name: Create breakpad symbols
-      run: |
-        cd build-x64
-        mkdir dSYM
-        dsymutil ./openttd -o dSYM/openttd
-        dump_syms ./dSYM/openttd --inlines --store symbols
-
-        cd ../build-arm64
-        mkdir dSYM
-        dsymutil ./openttd -o dSYM/openttd
-        dump_syms ./dSYM/openttd --inlines --store ../build-x64/symbols
-
     - name: Create bundles
       run: |
         cd build-x64
@@ -172,19 +151,19 @@ jobs:
         rm -f bundles/*.sha256
         echo "::endgroup::"
 
+    - name: Install gon
+      env:
+        HOMEBREW_NO_AUTO_UPDATE: 1
+        HOMEBREW_NO_INSTALL_CLEANUP: 1
+      run: |
+        brew tap mitchellh/gon
+        brew install mitchellh/gon/gon
+
     - name: Notarize
       env:
         AC_USERNAME: ${{ secrets.APPLE_DEVELOPER_APP_USERNAME }}
         AC_PASSWORD: ${{ secrets.APPLE_DEVELOPER_APP_PASSWORD }}
-        AC_TEAM_ID: ${{ secrets.APPLE_DEVELOPER_TEAM_ID }}
       run: |
-        if [ -z "${AC_USERNAME}" ]; then
-            # We may be running on a fork that doesn't have notarization secrets set up; skip this step
-            echo No notarization secrets set up, skipping.
-            exit 0
-        fi
-
-        xcrun notarytool store-credentials --apple-id "${AC_USERNAME}" --password "${AC_PASSWORD}" --team-id "${AC_TEAM_ID}" openttd
         cd build-x64
         ../os/macosx/notarize.sh
 
@@ -212,15 +191,8 @@ jobs:
         mv _CPack_Packages/*/Bundle/openttd-*.zip bundles/
 
     - name: Store bundles
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: openttd-macos-universal
         path: build-x64/bundles
         retention-days: 5
-
-    - name: Store symbols
-      uses: actions/upload-artifact@v4
-      with:
-        name: symbols-macos-universal
-        path: build-x64/symbols
-        retention-days: 5

.github/workflows/release-source.yml

@@ -11,33 +11,30 @@ on:
         value: ${{ jobs.source.outputs.trigger_type }}
       folder:
         value: ${{ jobs.source.outputs.folder }}
-      survey_key:
-        value: ${{ jobs.source.outputs.survey_key }}
 
 jobs:
   source:
     name: Source
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
 
     outputs:
       version: ${{ steps.metadata.outputs.version }}
       is_tag: ${{ steps.metadata.outputs.is_tag }}
       trigger_type: ${{ steps.metadata.outputs.trigger_type }}
       folder: ${{ steps.metadata.outputs.folder }}
-      survey_key: ${{ steps.survey_key.outputs.survey_key }}
 
     steps:
     - name: Checkout (Release)
       if: github.event_name == 'release'
-      uses: actions/checkout@v4
+      uses: actions/checkout@v3
       with:
         # We generate a changelog; for this we need the full git log.
         fetch-depth: 0
 
     - name: Checkout (Manual)
       if: github.event_name == 'workflow_dispatch'
-      uses: actions/checkout@v4
+      uses: actions/checkout@v3
       with:
         ref: ${{ github.event.inputs.ref }}
         # We generate a changelog; for this we need the full git log.
@@ -45,7 +42,7 @@ jobs:
 
     - name: Checkout (Trigger)
       if: github.event_name == 'repository_dispatch'
-      uses: actions/checkout@v4
+      uses: actions/checkout@v3
       with:
         ref: ${{ github.event.client_payload.ref }}
         # We generate a changelog; for this we need the full git log.
@@ -127,7 +124,7 @@ jobs:
         fi
 
         mkdir -p build/bundles
-        cp .changelog build/bundles/changelog.md
+        cp .changelog build/bundles/changelog.txt
         cp .release_date build/bundles/released.txt
         cp README.md build/bundles/README.md
         echo "::endgroup::"
@@ -149,24 +146,6 @@ jobs:
         FOLDER_NIGHTLIES: openttd-nightlies
         FOLDER_BRANCHES: openttd-branches
 
-    - name: Generate survey key
-      id: survey_key
-      run: |
-        if [ -z "${{ vars.SURVEY_TYPE }}" ]; then
-          echo "SURVEY_TYPE variable not found; most likely running in a fork. Skipping step."
-          SURVEY_KEY=""
-        else
-          PAYLOAD='{"version":"${{ steps.metadata.outputs.version }}","type":"${{ vars.SURVEY_TYPE }}"}'
-
-          echo "${{ secrets.SURVEY_SIGNING_KEY }}" > survey_signing_key.pem
-          SIGNATURE=$(echo -n "${PAYLOAD}" | openssl dgst -sha256 -sign survey_signing_key.pem | base64 -w0)
-          rm -f survey_signing_key.pem
-
-          SURVEY_KEY=$(curl -f -s -X POST -d "${PAYLOAD}" -H "Content-Type: application/json" -H "X-Signature: ${SIGNATURE}" https://survey-participate.openttd.org/create-survey-key/${{ vars.SURVEY_TYPE }})
-        fi
-
-        echo "survey_key=${SURVEY_KEY}" >> $GITHUB_OUTPUT
-
     - name: Remove VCS information
       run: |
         rm -rf .git
@@ -193,14 +172,14 @@ jobs:
         echo "::endgroup::"
 
     - name: Store bundles
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: openttd-source
         path: build/bundles/*
         retention-days: 5
 
     - name: Store source (for other jobs)
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: internal-source
         path: source.tar.gz

.github/workflows/release-windows-store.yml

@@ -15,7 +15,7 @@ jobs:
 
     steps:
     - name: Download source
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v3
       with:
         name: internal-source
 
@@ -25,17 +25,17 @@ jobs:
         tar -xf source.tar.gz --strip-components=1
 
     - name: Download x86 build
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v3
       with:
         name: openttd-windows-x86
 
     - name: Download x64 build
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v3
       with:
         name: openttd-windows-x64
 
     - name: Download arm64 build
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v3
       with:
         name: openttd-windows-arm64
 
@@ -185,7 +185,7 @@ jobs:
         move output\OpenTTD.appxbundle bundles\internal\openttd-${{ inputs.version }}-windows-store.appxbundle
 
     - name: Store bundles
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: openttd-windows-store
         path: builds/bundles

.github/workflows/release-windows.yml

@@ -3,16 +3,14 @@ name: Release (Windows)
 on:
   workflow_call:
     inputs:
-      survey_key:
-        required: false
-        type: string
-        default: ""
       is_tag:
         required: true
         type: string
 
 jobs:
   windows:
+    name: Windows
+
     strategy:
       fail-fast: false
       matrix:
@@ -24,13 +22,11 @@ jobs:
         - arch: arm64
           host: x64_arm64
 
-    name: Windows (${{ matrix.arch }})
-
     runs-on: windows-latest
 
     steps:
     - name: Download source
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v3
       with:
         name: internal-source
 
@@ -39,35 +35,37 @@ jobs:
       run: |
         tar -xf source.tar.gz --strip-components=1
 
-    - name: Install Rust toolchain
-      uses: dtolnay/rust-toolchain@stable
-
-    - name: Enable Rust cache
-      uses: Swatinem/rust-cache@v2
-
-    - name: Setup vcpkg caching
-      uses: actions/github-script@v7
-      with:
-        script: |
-          core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
-          core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
-          core.exportVariable('VCPKG_BINARY_SOURCES', 'clear;x-gha,readwrite')
-
-    - name: Install vcpkg
-      run: |
-        git clone https://github.com/microsoft/vcpkg ${{ runner.temp }}\vcpkg
-        ${{ runner.temp }}\vcpkg\bootstrap-vcpkg.bat -disableMetrics
-
     - name: Install dependencies
       shell: bash
       run: |
-        echo "::group::Install choco dependencies"
         choco install pandoc
-        echo "::endgroup::"
 
-        echo "::group::Install breakpad dependencies"
-        cargo install --locked dump_syms
-        echo "::endgroup::"
+    - name: Prepare cache key
+      id: key
+      shell: powershell
+      run: |
+        # Work around caching failure with GNU tar
+        New-Item -Type Junction -Path vcpkg -Target c:\vcpkg
+
+        Write-Output "image=$env:ImageOS-$env:ImageVersion" >> $env:GITHUB_OUTPUT
+
+    - name: Enable vcpkg cache
+      uses: actions/cache@v3
+      with:
+        path: vcpkg/installed
+        key: ${{ steps.key.outputs.image }}-vcpkg-${{ matrix.arch }}-0 # Increase the number whenever dependencies are modified
+        restore-keys: |
+          ${{ steps.key.outputs.image }}-vcpkg-${{ matrix.arch }}
+
+    - name: Prepare vcpkg
+      shell: bash
+      run: |
+        vcpkg install --triplet=${{ matrix.arch }}-windows-static \
+          liblzma \
+          libpng \
+          lzo \
+          zlib \
+          # EOF
 
     - name: Install MSVC problem matcher
       uses: ammaraskar/msvc-problem-matcher@master
@@ -100,6 +98,21 @@ jobs:
       with:
         arch: ${{ matrix.host }}
 
+    - name: Import code signing certificate
+      shell: powershell
+      # If this is run on a fork, there may not be a certificate set up - continue in this case
+      continue-on-error: true
+      run: |
+        $tempFile = [System.IO.Path]::GetTempFileName()
+        $bytes = [System.Convert]::FromBase64String($env:WINDOWS_CERTIFICATE_P12)
+        [IO.File]::WriteAllBytes($tempFile, $bytes)
+        $pwd = ConvertTo-SecureString $env:WINDOWS_CERTIFICATE_PASSWORD -AsPlainText -Force
+        Import-PfxCertificate -FilePath $tempFile -CertStoreLocation Cert:\CurrentUser\My -Password $pwd
+        Remove-Item $tempFile
+      env:
+        WINDOWS_CERTIFICATE_P12: ${{ secrets.WINDOWS_CERTIFICATE_P12 }}
+        WINDOWS_CERTIFICATE_PASSWORD: ${{ secrets.WINDOWS_CERTIFICATE_PASSWORD }}
+
     - name: Build (with installer)
       if: inputs.is_tag == 'true'
       shell: bash
@@ -111,24 +124,19 @@ jobs:
         cmake ${GITHUB_WORKSPACE} \
           -GNinja \
           -DVCPKG_TARGET_TRIPLET=${{ matrix.arch }}-windows-static \
-          -DCMAKE_TOOLCHAIN_FILE="${{ runner.temp }}\vcpkg\scripts\buildsystems\vcpkg.cmake" \
+          -DCMAKE_TOOLCHAIN_FILE="c:\vcpkg\scripts\buildsystems\vcpkg.cmake" \
           -DOPTION_USE_NSIS=ON \
           -DHOST_BINARY_DIR=${GITHUB_WORKSPACE}/build-host \
           -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-          -DOPTION_SURVEY_KEY=${{ inputs.survey_key }} \
+          -DWINDOWS_CERTIFICATE_COMMON_NAME="${WINDOWS_CERTIFICATE_COMMON_NAME}" \
           # EOF
         echo "::endgroup::"
 
         echo "::group::Build"
-        cmake --build . --target openttd
+        cmake --build .
         echo "::endgroup::"
       env:
-        AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
-        AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
-        AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
-        AZURE_CODESIGN_ACCOUNT_NAME: ${{ secrets.AZURE_CODESIGN_ACCOUNT_NAME }}
-        AZURE_CODESIGN_ENDPOINT: ${{ secrets.AZURE_CODESIGN_ENDPOINT }}
-        AZURE_CODESIGN_PROFILE_NAME: ${{ secrets.AZURE_CODESIGN_PROFILE_NAME }}
+        WINDOWS_CERTIFICATE_COMMON_NAME: ${{ secrets.WINDOWS_CERTIFICATE_COMMON_NAME }}
 
     - name: Build (without installer)
       if: inputs.is_tag != 'true'
@@ -141,29 +149,18 @@ jobs:
         cmake ${GITHUB_WORKSPACE} \
           -GNinja \
           -DVCPKG_TARGET_TRIPLET=${{ matrix.arch }}-windows-static \
-          -DCMAKE_TOOLCHAIN_FILE="${{ runner.temp }}\vcpkg\scripts\buildsystems\vcpkg.cmake" \
+          -DCMAKE_TOOLCHAIN_FILE="c:\vcpkg\scripts\buildsystems\vcpkg.cmake" \
           -DHOST_BINARY_DIR=${GITHUB_WORKSPACE}/build-host \
           -DCMAKE_BUILD_TYPE=RelWithDebInfo \
-          -DOPTION_SURVEY_KEY=${{ inputs.survey_key }} \
+          -DWINDOWS_CERTIFICATE_COMMON_NAME="${WINDOWS_CERTIFICATE_COMMON_NAME}" \
           # EOF
         echo "::endgroup::"
 
         echo "::group::Build"
-        cmake --build . --target openttd
+        cmake --build .
         echo "::endgroup::"
       env:
-        AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
-        AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
-        AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
-        AZURE_CODESIGN_ACCOUNT_NAME: ${{ secrets.AZURE_CODESIGN_ACCOUNT_NAME }}
-        AZURE_CODESIGN_ENDPOINT: ${{ secrets.AZURE_CODESIGN_ENDPOINT }}
-        AZURE_CODESIGN_PROFILE_NAME: ${{ secrets.AZURE_CODESIGN_PROFILE_NAME }}
-
-    - name: Create breakpad symbols
-      shell: bash
-      run: |
-        cd build
-        dump_syms openttd.pdb --inlines --store symbols
+        WINDOWS_CERTIFICATE_COMMON_NAME: ${{ secrets.WINDOWS_CERTIFICATE_COMMON_NAME }}
 
     - name: Create bundles
       shell: bash
@@ -173,13 +170,10 @@ jobs:
         cpack
         echo "::endgroup::"
 
-        echo "::group::Move PDB and exe to symbols"
-        PDB_FOLDER=$(find symbols -mindepth 2 -type d)
-        cp openttd.pdb ${PDB_FOLDER}/
-
-        EXE_FOLDER=symbols/openttd.exe/$(grep "INFO CODE_ID" symbols/*/*/openttd.sym | cut -d\  -f3)
-        mkdir -p ${EXE_FOLDER}
-        cp openttd.exe ${EXE_FOLDER}/
+        echo "::group::Prepare PDB to be bundled"
+        PDB=$(ls bundles/*.zip | cut -d/ -f2 | sed 's/.zip$/.pdb/')
+        cp openttd.pdb bundles/${PDB}
+        xz -9 bundles/${PDB}
         echo "::endgroup::"
 
         echo "::group::Cleanup"
@@ -191,26 +185,17 @@ jobs:
     - name: Sign installer
       if: inputs.is_tag == 'true'
       shell: bash
+      # If this is run on a fork, there may not be a certificate set up - continue in this case
+      continue-on-error: true
       run: |
-        ${GITHUB_WORKSPACE}/os/windows/sign.bat "${GITHUB_WORKSPACE}/build/bundles"
+        cd ${GITHUB_WORKSPACE}/build/bundles
+        ../../os/windows/sign.bat *.exe "${WINDOWS_CERTIFICATE_COMMON_NAME}"
       env:
-        AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
-        AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
-        AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
-        AZURE_CODESIGN_ACCOUNT_NAME: ${{ secrets.AZURE_CODESIGN_ACCOUNT_NAME }}
-        AZURE_CODESIGN_ENDPOINT: ${{ secrets.AZURE_CODESIGN_ENDPOINT }}
-        AZURE_CODESIGN_PROFILE_NAME: ${{ secrets.AZURE_CODESIGN_PROFILE_NAME }}
+        WINDOWS_CERTIFICATE_COMMON_NAME: ${{ secrets.WINDOWS_CERTIFICATE_COMMON_NAME }}
 
     - name: Store bundles
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v3
       with:
         name: openttd-windows-${{ matrix.arch }}
         path: build/bundles
         retention-days: 5
-
-    - name: Store symbols
-      uses: actions/upload-artifact@v4
-      with:
-        name: symbols-windows-${{ matrix.arch }}
-        path: build/symbols
-        retention-days: 5

.github/workflows/release.yml

@@ -38,9 +38,6 @@ jobs:
     uses: ./.github/workflows/release-linux.yml
     secrets: inherit
 
-    with:
-      survey_key: ${{ needs.source.outputs.survey_key }}
-
   macos:
     name: MacOS
     needs: source
@@ -48,9 +45,6 @@ jobs:
     uses: ./.github/workflows/release-macos.yml
     secrets: inherit
 
-    with:
-      survey_key: ${{ needs.source.outputs.survey_key }}
-
   windows:
     name: Windows
     needs: source
@@ -60,7 +54,6 @@ jobs:
 
     with:
       is_tag: ${{ needs.source.outputs.is_tag }}
-      survey_key: ${{ needs.source.outputs.survey_key }}
 
   windows-store:
     name: Windows Store
@@ -76,8 +69,8 @@ jobs:
     with:
       version: ${{ needs.source.outputs.version }}
 
-  upload:
-    name: Upload
+  upload-aws:
+    name: Upload (AWS)
     needs:
     - source
     - docs
@@ -90,26 +83,7 @@ jobs:
     # The always() makes sure the rest is always evaluated.
     if: always() && needs.source.result == 'success' && needs.docs.result == 'success' && needs.linux.result == 'success' && needs.macos.result == 'success' && needs.windows.result == 'success' && (needs.windows-store.result == 'success' || needs.windows-store.result == 'skipped')
 
-    runs-on: ubuntu-latest
-
-    # This job is empty, but ensures no upload job starts before all targets finished and are successful.
-    steps:
-    - name: Build completed
-      run: |
-        true
-
-  upload-cdn:
-    name: Upload (CDN)
-    needs:
-    - source
-    - upload
-
-    # As windows-store is condition, we need to check ourselves if we need to run.
-    # The always() makes sure the rest is always evaluated.
-    # Yes, you even need to do this if you yourself don't depend on the condition.
-    if: always() && needs.source.result == 'success' && needs.upload.result == 'success'
-
-    uses: ./.github/workflows/upload-cdn.yml
+    uses: ./.github/workflows/upload-aws.yml
     secrets: inherit
 
     with:
@@ -121,13 +95,11 @@ jobs:
     name: Upload (Steam)
     needs:
     - source
-    - upload
+    - linux
+    - macos
+    - windows
 
-    # As windows-store is condition, we need to check ourselves if we need to run.
-    # The always() makes sure the rest is always evaluated.
-    # Yes, you even need to do this if you yourself don't depend on the condition.
-    # Additionally, only nightlies and releases go to Steam; not PRs.
-    if: always() && needs.source.result == 'success' && needs.upload.result == 'success' && (needs.source.outputs.trigger_type == 'new-master' || needs.source.outputs.trigger_type == 'new-tag')
+    if: needs.source.outputs.trigger_type == 'new-master' || needs.source.outputs.trigger_type == 'new-tag'
 
     uses: ./.github/workflows/upload-steam.yml
     secrets: inherit
@@ -140,13 +112,11 @@ jobs:
     name: Upload (GOG)
     needs:
     - source
-    - upload
+    - linux
+    - macos
+    - windows
 
-    # As windows-store is condition, we need to check ourselves if we need to run.
-    # The always() makes sure the rest is always evaluated.
-    # Yes, you even need to do this if you yourself don't depend on the condition.
-    # Additionally, only releases go to GOG; not nightlies or PRs.
-    if: always() && needs.source.result == 'success' && needs.upload.result == 'success' && needs.source.outputs.trigger_type == 'new-tag'
+    if: needs.source.outputs.trigger_type == 'new-tag'
 
     uses: ./.github/workflows/upload-gog.yml
     secrets: inherit

.github/workflows/script-missing-mode-enforcement.yml

@@ -1,22 +0,0 @@
-name: Script missing mode enforcement
-
-on:
-  pull_request:
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
-
-jobs:
-  script-missing-mode-enforcement:
-    name: Script missing mode enforcement
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Checkout
-      uses: actions/checkout@v4
-
-    - name: Check for finding script functions that require company/deity mode enforcement/checks
-      run: |
-        set -ex
-        python3 .github/script-missing-mode-enforcement.py

.github/workflows/unused-strings.yml

@@ -3,10 +3,6 @@ name: Unused strings
 on:
   pull_request:
 
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
-
 jobs:
   unused-strings:
     name: Unused strings
@@ -14,7 +10,7 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v3
 
     - name: Check for unused strings
       run: |

.github/workflows/upload-aws.yml

@@ -0,0 +1,76 @@
+name: Upload (AWS)
+
+on:
+  workflow_call:
+    inputs:
+      version:
+        required: true
+        type: string
+      folder:
+        required: true
+        type: string
+      trigger_type:
+        required: true
+        type: string
+
+jobs:
+  upload:
+    name: Upload (AWS)
+
+    runs-on: ubuntu-20.04
+
+    steps:
+    - name: Download all bundles
+      uses: actions/download-artifact@v3
+
+    - name: Calculate checksums
+      run: |
+        echo "::group::Move bundles to a single folder"
+        mkdir bundles
+        mv openttd-*/* bundles/
+        echo "::endgroup::"
+
+        cd bundles
+        for i in $(ls openttd-*); do
+          echo "::group::Calculating checksums for ${i}"
+          openssl dgst -r -md5 -hex $i > $i.md5sum
+          openssl dgst -r -sha1 -hex $i > $i.sha1sum
+          openssl dgst -r -sha256 -hex $i > $i.sha256sum
+          echo "::endgroup::"
+        done
+
+        # Some targets generate files that are meant for our-eyes-only.
+        # They are stored in the "internal" folder, and contains bundles
+        # for targets like Windows Store. No user has a benefit of knowing
+        # they exist, hence: internal.
+        if [ -e internal ]; then
+          cd internal
+          for i in $(ls openttd-*); do
+            echo "::group::Calculating checksums for ${i}"
+            openssl dgst -r -md5 -hex $i > $i.md5sum
+            openssl dgst -r -sha1 -hex $i > $i.sha1sum
+            openssl dgst -r -sha256 -hex $i > $i.sha256sum
+            echo "::endgroup::"
+          done
+        fi
+
+    - name: Upload bundles to AWS
+      run: |
+        aws s3 cp --recursive --only-show-errors bundles/ s3://${{ secrets.CDN_S3_BUCKET }}/${{ inputs.folder }}/${{ inputs.version }}/
+
+        # We do not invalidate the CloudFront distribution here. The trigger
+        # for "New OpenTTD release" first updated the manifest files and
+        # creates an index.html. We invalidate after that, so everything
+        # becomes visible at once.
+      env:
+        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+        AWS_DEFAULT_REGION: ${{ secrets.AWS_REGION }}
+
+    - name: Trigger 'New OpenTTD release'
+      uses: peter-evans/repository-dispatch@v2
+      with:
+        token: ${{ secrets.DEPLOYMENT_TOKEN }}
+        repository: OpenTTD/workflows
+        event-type: ${{ inputs.trigger_type }}
+        client-payload: '{"version": "${{ inputs.version }}", "folder": "${{ inputs.folder }}"}'

.github/workflows/upload-cdn.yml

@@ -1,138 +0,0 @@
-name: Upload (CDN)
-
-on:
-  workflow_call:
-    inputs:
-      version:
-        required: true
-        type: string
-      folder:
-        required: true
-        type: string
-      trigger_type:
-        required: true
-        type: string
-
-jobs:
-  prepare:
-    name: Prepare
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Download all bundles
-      uses: actions/download-artifact@v4
-
-    - name: Calculate checksums
-      run: |
-        echo "::group::Move bundles to a single folder"
-        mkdir bundles
-        mv openttd-*/* bundles/
-        echo "::endgroup::"
-
-        cd bundles
-        for i in $(ls openttd-*); do
-          echo "::group::Calculating checksums for ${i}"
-          openssl dgst -r -md5 -hex $i > $i.md5sum
-          openssl dgst -r -sha1 -hex $i > $i.sha1sum
-          openssl dgst -r -sha256 -hex $i > $i.sha256sum
-          echo "::endgroup::"
-        done
-
-        # Some targets generate files that are meant for our-eyes-only.
-        # They are stored in the "internal" folder, and contains bundles
-        # for targets like Windows Store. No user has a benefit of knowing
-        # they exist, hence: internal.
-        if [ -e internal ]; then
-          cd internal
-          for i in $(ls openttd-*); do
-            echo "::group::Calculating checksums for ${i}"
-            openssl dgst -r -md5 -hex $i > $i.md5sum
-            openssl dgst -r -sha1 -hex $i > $i.sha1sum
-            openssl dgst -r -sha256 -hex $i > $i.sha256sum
-            echo "::endgroup::"
-          done
-        fi
-
-    - name: Merge symbols
-      run: |
-        mkdir symbols
-        cp -R symbols-*/* symbols/
-
-        # Compress all files as gzip, to reduce cost of storage on the CDN.
-        for i in $(find symbols -mindepth 2 -type f); do
-          gzip ${i}
-        done
-
-        # Leave a mark in each folder what version actually created the symbol file.
-        for i in $(find symbols -mindepth 2 -type d); do
-          touch ${i}/.${{ inputs.version }}.txt
-        done
-
-    - name: Store bundles
-      uses: actions/upload-artifact@v4
-      with:
-        name: cdn-bundles
-        path: bundles/*
-        retention-days: 5
-
-    - name: Store breakpad symbols
-      uses: actions/upload-artifact@v4
-      with:
-        name: cdn-symbols
-        path: symbols/*
-        retention-days: 5
-
-  publish-bundles:
-    needs:
-    - prepare
-
-    name: Publish bundles
-    uses: OpenTTD/actions/.github/workflows/rw-cdn-upload.yml@v5
-    secrets:
-      CDN_SIGNING_KEY: ${{ secrets.CDN_SIGNING_KEY }}
-      DEPLOYMENT_APP_ID: ${{ secrets.DEPLOYMENT_APP_ID }}
-      DEPLOYMENT_APP_PRIVATE_KEY: ${{ secrets.DEPLOYMENT_APP_PRIVATE_KEY }}
-    with:
-      artifact-name: cdn-bundles
-      folder: ${{ inputs.folder }}
-      version: ${{ inputs.version }}
-
-  publish-symbols:
-    needs:
-    - prepare
-
-    name: Publish symbols
-    uses: OpenTTD/actions/.github/workflows/rw-symbols-upload.yml@v5
-    secrets:
-      SYMBOLS_SIGNING_KEY: ${{ secrets.SYMBOLS_SIGNING_KEY }}
-    with:
-      artifact-name: cdn-symbols
-      repository: OpenTTD
-
-  docs:
-    if: ${{ inputs.trigger_type == 'new-master' }}
-    needs:
-    - publish-bundles
-
-    name: Publish docs
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Generate access token
-      id: generate_token
-      uses: tibdex/github-app-token@v2
-      with:
-        app_id: ${{ secrets.DEPLOYMENT_APP_ID }}
-        private_key: ${{ secrets.DEPLOYMENT_APP_PRIVATE_KEY }}
-        installation_retrieval_mode: "repository"
-        installation_retrieval_payload: "OpenTTD/workflows"
-
-    - name: Trigger 'Publish Docs'
-      uses: peter-evans/repository-dispatch@v3
-      with:
-        token: ${{ steps.generate_token.outputs.token }}
-        repository: OpenTTD/workflows
-        event-type: publish-docs
-        client-payload: '{"version": "${{ inputs.version }}", "folder": "${{ inputs.folder }}"}'

.github/workflows/upload-gog.yml

@@ -11,38 +11,11 @@ jobs:
   upload:
     name: Upload (GOG)
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
 
     steps:
-    - name: Download source
-      uses: actions/download-artifact@v4
-      with:
-        name: internal-source
-        path: internal-source
-
-    - name: Download bundle (Windows x86)
-      uses: actions/download-artifact@v4
-      with:
-        name: openttd-windows-x86
-        path: openttd-windows-x86
-
-    - name: Download bundle (Windows x64)
-      uses: actions/download-artifact@v4
-      with:
-        name: openttd-windows-x64
-        path: openttd-windows-x64
-
-    - name: Download bundle (MacOS)
-      uses: actions/download-artifact@v4
-      with:
-        name: openttd-macos-universal
-        path: openttd-macos-universal
-
-    - name: Download bundle (Linux)
-      uses: actions/download-artifact@v4
-      with:
-        name: openttd-linux-generic
-        path: openttd-linux-generic
+    - name: Download all bundles
+      uses: actions/download-artifact@v3
 
     - name: Install GOG Galaxy Build Creator
       run: |

.github/workflows/upload-steam.yml

@@ -14,38 +14,11 @@ jobs:
   upload:
     name: Upload (Steam)
 
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
 
     steps:
-    - name: Download source
-      uses: actions/download-artifact@v4
-      with:
-        name: internal-source
-        path: internal-source
-
-    - name: Download bundle (Windows x86)
-      uses: actions/download-artifact@v4
-      with:
-        name: openttd-windows-x86
-        path: openttd-windows-x86
-
-    - name: Download bundle (Windows x64)
-      uses: actions/download-artifact@v4
-      with:
-        name: openttd-windows-x64
-        path: openttd-windows-x64
-
-    - name: Download bundle (MacOS)
-      uses: actions/download-artifact@v4
-      with:
-        name: openttd-macos-universal
-        path: openttd-macos-universal
-
-    - name: Download bundle (Linux)
-      uses: actions/download-artifact@v4
-      with:
-        name: openttd-linux-generic
-        path: openttd-linux-generic
+    - name: Download all bundles
+      uses: actions/download-artifact@v3
 
     - name: Setup steamcmd
       uses: CyberAndrii/setup-steamcmd@v1

.gitignore

@@ -5,4 +5,3 @@ docs/aidocs/*
 docs/gamedocs/*
 docs/source/*
 /out
-/vcpkg_installed

CMakeLists.txt

@@ -1,12 +1,11 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.9)
 
 if(NOT BINARY_NAME)
     set(BINARY_NAME openttd)
 endif()
 
 project(${BINARY_NAME}
-    VERSION 15.0
-    LANGUAGES CXX
+    VERSION 13.3
 )
 
 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
@@ -23,7 +22,7 @@ if (EMSCRIPTEN)
 endif()
 
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake")
-set(CMAKE_OSX_DEPLOYMENT_TARGET 10.15)
+set(CMAKE_OSX_DEPLOYMENT_TARGET 10.13)
 
 # Use GNUInstallDirs to allow customisation
 # but set our own default data and bin dir
@@ -42,7 +41,7 @@ set_directory_options()
 include(Static)
 set_static_if_needed()
 
-set(CMAKE_CXX_STANDARD 20)
+set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED YES)
 set(CMAKE_CXX_EXTENSIONS NO)
 
@@ -125,19 +124,6 @@ find_package(LibLZMA)
 find_package(LZO)
 find_package(PNG)
 
-if(WIN32 OR EMSCRIPTEN)
-    # Windows uses WinHttp for HTTP requests.
-    # Emscripten uses Javascript for HTTP requests.
-else()
-    # All other targets use libcurl.
-    find_package(CURL)
-endif()
-
-# Breakpad doesn't support emscripten.
-if(NOT EMSCRIPTEN)
-    find_package(unofficial-breakpad)
-endif()
-
 if(NOT OPTION_DEDICATED)
     if(NOT WIN32)
         find_package(Allegro)
@@ -148,18 +134,12 @@ if(NOT OPTION_DEDICATED)
                 find_package(SDL)
             endif()
             find_package(Fluidsynth)
-            if(Freetype_FOUND)
-                find_package(Fontconfig)
-            endif()
-            find_package(Harfbuzz)
-            find_package(ICU OPTIONAL_COMPONENTS i18n uc)
+            find_package(Fontconfig)
+            find_package(ICU OPTIONAL_COMPONENTS i18n lx)
         endif()
     endif()
-    find_package(OpusFile)
 endif()
 if(APPLE)
-    enable_language(OBJCXX)
-
     find_package(Iconv)
 
     find_library(AUDIOTOOLBOX_LIBRARY AudioToolbox)
@@ -190,12 +170,6 @@ if(UNIX AND NOT APPLE AND NOT OPTION_DEDICATED)
     if(NOT SDL_FOUND AND NOT SDL2_FOUND AND NOT ALLEGRO_FOUND)
         message(FATAL_ERROR "SDL, SDL2 or Allegro is required for this platform")
     endif()
-    if(HARFBUZZ_FOUND AND NOT ICU_i18n_FOUND)
-        message(WARNING "HarfBuzz depends on ICU i18n to function; HarfBuzz will be disabled")
-    endif()
-    if(NOT HARFBUZZ_FOUND)
-        message(WARNING "Without HarfBuzz and ICU i18n the game will not be able to render right-to-left languages correctly")
-    endif()
 endif()
 if(APPLE)
     if(NOT AUDIOTOOLBOX_LIBRARY)
@@ -233,7 +207,6 @@ if(OPTION_PACKAGE_DEPENDENCIES)
     set(CMAKE_BUILD_WITH_INSTALL_RPATH ON)
 endif()
 
-include(CTest)
 include(SourceList)
 
 # Needed by rev.cpp
@@ -243,31 +216,15 @@ include_directories(${CMAKE_SOURCE_DIR}/src/3rdparty/squirrel/include)
 
 include(MSVCFilters)
 
-add_library(openttd_lib OBJECT ${GENERATED_SOURCE_FILES})
-add_executable(openttd WIN32)
-add_executable(openttd_test)
+add_executable(openttd WIN32 ${GENERATED_SOURCE_FILES})
 set_target_properties(openttd PROPERTIES OUTPUT_NAME "${BINARY_NAME}")
 # All other files are added via target_sources()
 
 if(MSVC)
     # Add DPI manifest to project; other WIN32 targets get this via ottdres.rc
     target_sources(openttd PRIVATE "${CMAKE_SOURCE_DIR}/os/windows/openttd.manifest")
-
-    # If target -static is used, switch our project to static (/MT) too.
-    # If the target ends on -static-md, it will remain dynamic (/MD).
-    if(VCPKG_TARGET_TRIPLET MATCHES "-static" AND NOT VCPKG_TARGET_TRIPLET MATCHES "-md")
-        set_property(TARGET openttd_lib PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
-        set_property(TARGET openttd PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
-        set_property(TARGET openttd_test PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
-     endif()
 endif()
 
-target_precompile_headers(openttd_lib
-    PRIVATE
-    src/stdafx.h
-    src/core/format.hpp
-)
-
 add_subdirectory(${CMAKE_SOURCE_DIR}/bin)
 add_subdirectory(${CMAKE_SOURCE_DIR}/src)
 add_subdirectory(${CMAKE_SOURCE_DIR}/media)
@@ -275,29 +232,17 @@ add_subdirectory(${CMAKE_SOURCE_DIR}/media)
 add_dependencies(openttd
     find_version)
 
-target_link_libraries(openttd_lib
+target_link_libraries(openttd
     openttd::languages
     openttd::settings
+    openttd::media
+    openttd::basesets
     openttd::script_api
     Threads::Threads
 )
 
-target_link_libraries(openttd
-    openttd_lib
-    openttd::media
-    openttd::basesets
-)
-
-target_link_libraries(openttd_test PRIVATE openttd_lib)
-if(ANDROID)
-    target_link_libraries(openttd_test PRIVATE log)
-endif()
-
-include(Catch)
-catch_discover_tests(openttd_test)
-
 if(HAIKU)
-    target_link_libraries(openttd_lib "be" "network" "midi")
+    target_link_libraries(openttd "be" "network" "midi")
 endif()
 
 if(IPO_FOUND)
@@ -314,15 +259,6 @@ link_package(ZLIB TARGET ZLIB::ZLIB ENCOURAGED)
 link_package(LIBLZMA TARGET LibLZMA::LibLZMA ENCOURAGED)
 link_package(LZO)
 
-if(NOT WIN32 AND NOT EMSCRIPTEN)
-    link_package(CURL ENCOURAGED)
-    target_link_libraries(openttd_lib ${CMAKE_DL_LIBS})
-endif()
-
-if(NOT EMSCRIPTEN)
-    link_package(unofficial-breakpad TARGET unofficial::breakpad::libbreakpad_client ENCOURAGED)
-endif()
-
 if(NOT OPTION_DEDICATED)
     link_package(Fluidsynth)
     link_package(SDL)
@@ -330,10 +266,8 @@ if(NOT OPTION_DEDICATED)
     link_package(Allegro)
     link_package(FREETYPE TARGET Freetype::Freetype)
     link_package(Fontconfig TARGET Fontconfig::Fontconfig)
-    link_package(Harfbuzz TARGET harfbuzz::harfbuzz)
+    link_package(ICU_lx)
     link_package(ICU_i18n)
-    link_package(ICU_uc)
-    link_package(OpusFile TARGET OpusFile::opusfile)
 
     if(SDL2_FOUND AND OPENGL_FOUND AND UNIX)
         # SDL2 dynamically loads OpenGL if needed, so do not link to OpenGL when
@@ -346,12 +280,12 @@ if(NOT OPTION_DEDICATED)
     endif()
 endif()
 
-include(3rdparty/llvm/CheckAtomic)
+include(CheckAtomic)
 
 if(APPLE)
     link_package(Iconv TARGET Iconv::Iconv)
 
-    target_link_libraries(openttd_lib
+    target_link_libraries(openttd
         ${AUDIOTOOLBOX_LIBRARY}
         ${AUDIOUNIT_LIBRARY}
         ${COCOA_LIBRARY}
@@ -370,7 +304,6 @@ if(EMSCRIPTEN)
     target_link_libraries(WASM::WASM INTERFACE "-s ALLOW_MEMORY_GROWTH=1")
     target_link_libraries(WASM::WASM INTERFACE "-s INITIAL_MEMORY=33554432")
     target_link_libraries(WASM::WASM INTERFACE "-s DISABLE_EXCEPTION_CATCHING=0")
-    target_link_libraries(WASM::WASM INTERFACE "-s WASM_BIGINT")
     add_definitions(-s DISABLE_EXCEPTION_CATCHING=0)
 
     # Export functions to Javascript.
@@ -386,23 +319,6 @@ if(EMSCRIPTEN)
     target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_BINARY_DIR}/lang/english.lng@/lang/english.lng")
     target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/bin/ai@/ai")
     target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/bin/game@/game")
-    # Documentation files for the in-game text file viewer
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/README.md@/README.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/CREDITS.md@/CREDITS.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/CONTRIBUTING.md@/CONTRIBUTING.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/COPYING.md@/COPYING.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/known-bugs.md@/known-bugs.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/changelog.md@/changelog.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/admin_network.md@/docs/admin_network.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/debugging_desyncs.md@/docs/debugging_desyncs.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/desync.md@/docs/desync.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/directory_structure.md@/docs/directory_structure.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/eints.md@/docs/eints.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/linkgraph.md@/docs/linkgraph.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/logging_and_performance_metrics.md@/docs/logging_and_performance_metrics.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/multiplayer.md@/docs/multiplayer.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/savegame_format.md@/docs/savegame_format.md")
-    target_link_libraries(WASM::WASM INTERFACE "--preload-file ${CMAKE_SOURCE_DIR}/docs/symbol_server.md@/docs/symbol_server.md")
 
     # We use IDBFS for persistent storage.
     target_link_libraries(WASM::WASM INTERFACE "-lidbfs.js")
@@ -448,14 +364,12 @@ if(WIN32)
         -DPSAPI_VERSION=1
     )
 
-    target_link_libraries(openttd_lib
+    target_link_libraries(openttd
         ws2_32
         winmm
         imm32
         usp10
         psapi
-        winhttp
-        bcrypt
     )
 endif()
 
@@ -463,9 +377,8 @@ if(CMAKE_SIZEOF_VOID_P EQUAL 8)
     add_definitions(-DPOINTER_IS_64BIT)
 endif()
 
-enable_testing()
-
-add_subdirectory(regression)
+include(CreateRegression)
+create_regression()
 
 if(APPLE OR WIN32)
     find_package(Pandoc)

CODINGSTYLE.md

@@ -1,543 +0,0 @@
-**Why a set coding style is important** <br>
-This project is an open source project. To get open source working as intended, many people should be able to comprehend the code. This implies that there is a well documented and uniform flow of code.
-That does not necessarily mean that a contributor should not write optimised yet cryptic code - one should always care about performance.  However, other developers need to understand the code which means complicated parts of code **must** have good documentation.
-
-**Why we require that EVERYTHING is documented**<br>
-What is simple to some might appear very complicated to others. Documentation helps these others. Anyone should be able to improve the code. But the main reason is, that when patch contributors want their patches added to the common codebase, the code needs to be reviewed by one or more developers. Documentation makes reviewing much easier.
-
-## Coding style for OpenTTD
-### Functions
-* Function names use [CamelCase](http://www.wikipedia.org/wiki/Camelcase) without underscores.
-* Opening curly bracket **{** for a function starts on the next line.
-* Use Foo() instead of Foo(void).
-```c++
-void ThisIsAFunction()
-{
-}
-```
-
-### Variables
-* Variable names are all lowercase, and use "_" as separator.
-* Global variables are preceded by an underscore. ("_") Use descriptive names because leading underscores are often used for system / compiler variables.
-* Own members of classes should always be referenced using "this->"
-* Pointers and references should have their reference symbol next to the name (compatibility with current code).
-* Variables that are declared below one another should have their type, name or reference operator, and assignment operator aligned by spaces.
-* There are set names for many variables. Those are (but not limited to): Vehicle *u, *v, *w; Station *st; Town *t; Window *w; Engine *e.
-* For multiple instances, use numbers "*t1, *t2" or postfixes "*st_from, *st_to".
-* Declare variables upon first usage.
-* Declare iterators in their loop.
-* There is a space between '*' and 'const' in "const pointers"
-```c++
-int     number         = 10;
-Vehicle *u_first_wagon = v->next;
-int     value          = v->value;
-
-uint32 _global_variable = 3750;
-
-static const char * const _global_array[] = {
-	"first string",
-	"second string",
-	"another string",
-	"last string followed by comma",
-};
-
-protected:
-	char protected_array[10];
-
-for (int i = 0;;);
-```
-
-* Give the variables expedient names, this increases the readability of the code
-```c++
-bool is_maglev_train = true;
-if (!is_maglev_train) DoSomething();
-```
-
-* Some people like to introduce copies of variables to increase readability, which can waste memory. However, in some cases, especially in code pieces which are often called, it makes sense to cache some calculated variables.
-```c++
-/* Unoptimized code:
- * foo is not touched inside the loop!
- */
-for (uint8 i = 0; i < 100000; i++) {
-	/* Do something */
-	if (value_to_check == (foo * 4) % 5 + 6) DoSomething();
-	/* Do something else */
-}
-
-/* Better:
- * The used value of foo is calculated outside the loop.
- */
-const uint32 bar = (foo * 4) % 5 + 6;
-for (uint8 i = 0; i < 100000; i++) {
-	/* Do something */
-	if (value_to_check == bar) DoSomething();
-	/* Do something else */
-}
-```
-
-### Enumerations / static consts
-* Enumerations store integers that belong logically together (railtypes, string IDs, etc.).
-* Enumeration names also use CamelCase.
-* Unscoped enumerators are all caps with "_" between the words.
-* Scoped enumerators are use CamelCase.
-* Enums are not used to store single numbers.
-* Enums have consecutive numbers OR
-* Enums have consecutive powers of two. Powers of two (bits) are written in hex or with the shift operator.
-* Enums may have special enumerators: "_BEGIN", "\_END", and "INVALID\_").  See example.
-* The invalid always has 0xFF, 0xFFFF, 0xFFFFFFFF as a value.
-* Other special values are consecutively less than the invalid.
-* Variables that hold enumerators should have the type of the enumeration.
-```c++
-enum DiagDirection {
-	DIAGDIR_BEGIN = 0,
-	DIAGDIR_NE  = 0,
-	DIAGDIR_SE  = 1,
-	DIAGDIR_SW  = 2,
-	DIAGDIR_NW  = 3,
-	DIAGDIR_END,
-	INVALID_DIAGDIR = 0xFF,
-	BROKEN_DIAGDIR = 0xFE,
-};
-
-enum {
-	DEPOT_SERVICE       = (1 << 0),
-	DEPOT_MASS_SEND     = (1 << 1),
-	DEPOT_DONT_CANCEL   = (1 << 2),
-	DEPOT_LOCATE_HANGAR = (1 << 3),
-};
-
-DiagDirection enterdir = DIAGDIR_NE;
-```
-
-* Numbers that store single or uncorrelated data are static consts. Those may use the naming conventions of enums.
-Example:
-```c++
-static const int MAXIMUM_STATIONS = 42;
-```
-
-* Enums are useful in GUI code: When widgets are enumerated, they are easier to access during many operations. Additionally changes caused by modified widget sequences require less code adapting. If a widget is used like this, its enum name should be present in a comment behind the corresponding widget definition.
-```c++
-/** Enum referring to the widgets of the build rail depot window */
-enum BuildRailDepotWidgets {
-	BRDW_CLOSEBOX = 0,
-	BRDW_CAPTION,
-	BRDW_BACKGROUND,
-	BRDW_DEPOT_NE,
-	BRDW_DEPOT_SE,
-	BRDW_DEPOT_SW,
-	BRDW_DEPOT_NW,
-};
-/* ... */
-/** Widget definition of the build rail depot window */
-static const Widget _build_depot_widgets[] = {
-{   WWT_CLOSEBOX,   RESIZE_NONE,     7,     0,    10,     0,    13, STR_00C5, STR_..},   // BRDW_CLOSEBOX
-{    WWT_CAPTION,   RESIZE_NONE,     7,    11,   139,     0,    13, STR_...,  STR_...},  // BRDW_CAPTION
-{      WWT_PANEL,   RESIZE_NONE,     7,     0,   139,    14,   121, 0x0,      STR_NULL}, // BRDW_BACKGROUND
-{      WWT_PANEL,   RESIZE_NONE,    14,    71,   136,    17,    66, 0x0,      STR_..},   // BRDW_DEPOT_NE
-{      WWT_PANEL,   RESIZE_NONE,    14,    71,   136,    69,   118, 0x0,      STR_..},   // BRDW_DEPOT_SE
-{      WWT_PANEL,   RESIZE_NONE,    14,     3,    68,    69,   118, 0x0,      STR_..},   // BRDW_DEPOT_SW
-{      WWT_PANEL,   RESIZE_NONE,    14,     3,    68,    17,    66, 0x0,      STR_..},   // BRDW_DEPOT_NW
-{   WIDGETS_END},
-};
-```
-
-* Comments on the enum values should start with "///<" to enable doxygen documentation
-```c++
-enum SomeEnumeration {
-	SE_BEGIN = 0,        ///< Begin of the enumeration, used for iterations
-	SE_FOO = 0,          ///< Used for xy
-	SE_BAR,              ///< Another value of the enumeration
-	SE_SUB,              ///< Special case for z
-	SE_END,              ///< End of the enumeration, used for iterations
-};
-```
-
-### Control flow
-* Put a space before the parentheses in **if**, **switch**, **for** and **while** statements.
-* Use curly braces and put the contained statements on their own lines (e.g., don't put them directly after the **if**).
-* Opening curly bracket **{** stays on the first line, closing curly bracket **}** gets a line to itself (except for the **}** preceding an **else**, which should be on the same line as the **else**).
-* When only a single statement is contained, the brackets can be omitted. In this case, put the single statement on the same line as the preceding keyword (**if**, **while**, etc.). Note that this is only allowed for if statements without an **else** clause.
-* Non-trivial fall throughs must be documented, using a `[[fallthrough]]` attribute.
-* The NOT_REACHED() macro can be used in default constructs that should never be reached.
-* Unconditional loops are written with **`for (;;) {`**
-
-```c++
-if (a == b) {
-	Foo();
-} else {
-	Bar();
-}
-
-if (very_large_checks &&
-		spread_over_two_lines) {
-	Foo();
-}
-
-if (a == b) Foo();
-
-switch (a) {
-	case 0: DoSomethingShort(); break;
-
-	case 1:
-		DoSomething();
-		[[fallthrough]];
-
-	case 2:
-		DoMore();
-		b = a;
-		break;
-
-	case 3: {
-		int r = 2;
-
-		DoEvenMore(a);
-		[[fallthrough]];
-	}
-
-	case 4: {
-		int q = 345;
-
-		DoIt();
-		break;
-	}
-
-	default:
-		NOT_REACHED();
-}
-
-for (int i = 0; i < 10; i++) {
-	Foo();
-	Bar();
-}
-```
-
-### Classes
-* Classes names also use CamelCase.
-* Classes should have "public", "protected", and "private" sections.
-* Within these section the order is: types, static const members, static members, members, constructors / destructors, static methods, methods.
-* Deviations from above order are allowed when the code dictates it (e.g. a static const is needed for a typedef)
-* Methods and members ought to be grouped logically.
-* All those sorting rules sometimes conflict which one another. Please use common sense what increases legibility of the code in such a case.
-* The method implementation should indicate if it is virtual or similar by using a comment.
-* Very short methods can have one-line definition (if defined in the class scope).
-```c++
-class ThisIsAClass {
-public:
-	typedef Titem_   *ItemPtr;
-private:
-	static const int MAX_SIZE = 500;
-	int              size;
-	ItemPtr          *items;
-
-public:
-	explicit ThisIsAClass();
-	~ThisIsAClass();
-
-	int GetSize() { return this->size; }
-	virtual void Method();
-};
-
-/*virtual*/ void Class::Method()
-{
-	this->size *= 2;
-}
-```
-
-### Templates
-Templates are a very powerful C++ tool, but they can easily confuse beginners. Thus:
-* Templates are to be documented in a very clear and verbose manner. Never assume anything in the documentation.
-* the template keyword and the template layout get a separate line. typenames are either "T" or preceded by a "T", integers get a single capital letter or a descriptive name preceded by "T".
-```c++
-template <typename T, typename Tsomething, int N, uint8_t Tnumber_of_something>
-int Func();
-```
-
-* If you are writing one or more template class in the dedicated header file, use file.hpp for its name instead of file.h. This will let others know that it is template library (includes also implementation), not just header with declarations.
-
-### Code Comment Vertical Alignment
-
-When adding code or comments to an existing formatted section, follow the existing style if possible without editing the preexisting lines.
-
-If your addition cannot be aligned with existing code, do not align the comments with anything and use only a single space between the code and the comment.
-
-Good:
-
-```c++
-enum Vehicle {
-	BUS,  ///< Take the bus.
-+	CAR,  ///< Drive your car.
-	BIKE, ///< Ride your bike
-+	TRAIN, ///< Catch the train.
-}
-```
-
-"Car" is shorter than Bike which allows you to easily align the new comment. "Train" is longer.  It is *NOT* desirable to change the vertical comment alignment of this enum.
-
-Bad:
-
-```c++
-enum Vehicle {
--	BUS,  ///< Take the bus.
--	BIKE, ///< Ride your bike
-+	BUS,   ///< Take the bus.
-+	CAR,   ///< Drive your car.
-+	BIKE,  ///< Ride your bike
-+	TRAIN, ///< Catch the train.
-}
-```
-
-OpenTTD used to vertically-align inline Doxygen comments as shown above. OpenTTD has since stopped strictly following this rule to keep diffs smaller and reduce pollution to the git blame history for non-functional changes.
-
-### Other important rules
-* Put a space before and after binary operators: "a + b", "a == b", "a & b", "a <<= b", etc.. Exceptions are ".", "->" and "[]" (no spaces) and "," (just space after it).
-* Put parenthesis where it improves readability: "*(b++)" instead of "*b++", and "if ((a & b) && c == 2)" instead of "if (a & b && c == 2)".
-* Do not put external declarations in implementation (i.e. cpp) files.
-* Use const where possible.
-* Do not typedef enums and structs.
-* Don't treat non-flags as flags: use "if (char_pointer != nullptr && *char_pointer != '\0')", not "if (char_pointer && *char_pointer)".
-* Use "free(p)" instead of "if (p != nullptr) free(p)". "free(nullptr)" doesn't hurt anyone.
-* No trailing whitespace. The Github workflows will not allow tabs or space on the end of lines.
-* Only use tabs to indent from the start of the line.
-* Line length is unlimited. In practice it may be useful to split a long line. When splitting, add two tabs in front of the second part.
-* The '#' of preprocessor instructions goes into the first column of a line. Indenting is done after the '#' (using tabs again).
-* Use /* */ for single line comments.
-* Use // at the end of a command line to indicate comments.
-** However, use /* */ after # preprocessor statements as // causes warnings in some compilers and/or might have unwanted side effects.
-* C++ is defined using the ASCII character set. Do not use other character sets, not even in comments.
-* OpenTTD includes some Objective-C sources (*.mm, used by OSX), which has a special object method invocation syntax: "[ obj doStuff:foo ]". Please use spaces on the inside of the brackets to differentiate from the C array syntax.
-
-## Documentation
-We use [Doxygen](http://doxygen.org/) to automatically generate documentation from the source code. It scans the source files for *recognizable* comments.
-* **Make your comments recognizable.**
-Doxygen only comments starting with the following style:
-```c++
-/**
-///<
-```
-
-Use /** for multi-line comment blocks. Use ///< for single line comments for variables. Use //!< for single-line comments in the NoAI .hpp files.
-For comments blocks inside a function always use /* */ or //. Use // only if the comment is on the same line as an instruction, otherwise use /* */.
-
-### Files
-* Put a @file command in a JavaDoc style comment at the start of the file, followed by a description.
-```c++
-/**
- * @file
- * This is the brief description.
- * This is the detailed description here and on the following lines.
- */
-```
-> ### Warning
-> If a file lacks a **file comment block** then NO entities in that file will be documented by Doxygen!
-
-### Functions
-* The documentation should be as close to the actual code as possible to maximise the chance of staying in sync.
-	* Comments for functions go in the .cpp file.
-	* Comments for inlines go in the .h/.hpp file.
-* Small inlines can have a short 3 or 4 line JavaDoc style comment.
-* Completely document larger functions.
-* Document obvious parameters and return values too!
-
-```c++
-/**
- * A brief explanation of what the function does and/or what purpose it serves.
- * Then follows a more detailed explanation of the function that can span multiple lines.
- *
- * @param foo Explanation of the foo parameter
- * @param bar Explanation of the bar parameter
- * @return The sum of foo and bar (@return can be omitted if the return type is void)
- *
- * @see SomeOtherFunc()
- * @see SOME_ENUM
- *
- * @bug Some bug description
- * @bug Another bug description which continues in the next line
- *           and ends with the following blank line
- *
- * @todo Some to-do entry
- */
-static int FooBar(int foo, int bar)
-{
-	return foo + bar;
-}
-```
-
-### Classes
-* Document structs similarly to functions:
-```c++
-/**
- * A short description of the struct.
- * More detailed description of the its usage.
- *
- * @see [link to anything of interest]
- */
-struct foo {
-}
-```
-
-### JavaDoc structural commands
-
-This table shows the commands you should use with OpenTTD.  The full list is [here](http://www.stack.nl/~dimitri/doxygen/commands.html).
-
-| Command | Action | Example |
-| ------- | -------- | ------- |
-| **@attention** | Starts a paragraph where a message that needs attention may be entered. The paragraph will be indented. | @attention Whales crossing! |
-| **@brief** | Starts a paragraph that serves as a brief description. For classes and files the brief description will be used in lists and at the start of the documentation page. For class and file members, the brief description will be placed at the declaration of the member and prepended to the detailed description. A brief description may span several lines (although it is advised to keep it brief!). | @brief This is the brief description. |
-| **@bug** | Starts a paragraph where one or more bugs may be reported. The paragraph will be indented. Multiple adjacent @bug commands will be joined into a single paragraph. Each bug description will start on a new line. Alternatively, one @bug command may mention several bugs. | @bug Memory leak in here? |
-| **@note** | Starts a paragraph where a note can be entered. The paragraph will be indented. | @note Might be slow |
-| **@todo** | Starts a paragraph where a TODO item is described. The description will also add an item to a separate TODO list. The two instances of the description will be cross-referenced. Each item in the TODO list will be preceded by a header that indicates the origin of the item. | @todo Better error checking |
-| **@warning** | Starts a paragraph where one or more warning messages may be entered. The paragraph will be indented. | @warning Not thread safe! |
-| | <small>**Function related commands**</small> | |
-| **@return** | Starts a return value description for a function. | @return a character pointer |
-| **@param** | Starts a parameter description for a function parameter with name <parameter-name>. Followed by a description of the parameter. The existence of the parameter is checked and a warning is given if the documentation of this (or any other) parameter is missing or not present in the function declaration or definition.<br><br>The @param command has an optional attribute specifying the direction of the attribute. Possible values are "in" and "out". | @param  n    The number of bytes to copy<br>@param[out] dest The memory area to copy to.<br>@param[in]  src  The memory area to copy from. |
-| **@see** | Starts a paragraph where one or more cross-references to classes, functions, methods, variables, files or URL may be specified. Two names joined by either :: or # are understood as referring to a class and one of its members. One of several overloaded methods or constructors may be selected by including a parenthesized list of argument types after the method name. [Here](http://www.stack.nl/~dimitri/doxygen/autolink.html) you can find detailed information about this feature. | @see OtherFunc() |
-| **@b** | Displays the following word using a bold font. Equivalent to &lt;b&gt;word&lt;/b&gt;. To put multiple words in bold use &lt;b&gt;multiple words&lt;/b&gt;.| ...@b this and @b that... |
-| **@c / @p** | Displays the parameter <word> using a typewriter font. You can use this command to refer to member function parameters in the running text. To have multiple words in typewriter font use &lt;tt&gt;multiple words&lt;/tt&gt;. | ... the @p x and @p y coordinates are used to... |
-| **@arg / @li** | This command has one argument that continues until the first blank line or until another @arg / @li is encountered. The command can be used to generate a simple, not nested list of arguments. Each argument should start with an @arg / @li command. | @arg @c AlignLeft left alignment.<br>@arg @c AlignCenter center alignment.<br>@arg @c AlignRight right alignment |
-| **@n** | Forces a new line. Equivalent to and inspired by the printf function. |@n |
-
-### More on Doxygen and JavaDoc
-
-Doxygen knows two different kinds of comments:
-* *Brief descriptions*: one-liners that describe the function roughly ([example](http://docs.openttd.org/annotated.html))
-* *Detailed descriptions*: as the name suggests, these contain the detailed function/purpose of the entity they describe ([example](http://docs.openttd.org/structBridge.html))
-
-You can omit either one or put them into different places but there's only one brief and one detailed description allowed for the same entity.
-
-Doxygen knows three modes for documenting an entity:
-* Before the entity
-* After the entity
-* In a different file
-
-The latter is a little harder to maintain since the prototype of the entity it describes then is stored in several places (e.g. the .h file and the file with the descriptions). Also while it makes the code easier to read it also makes it easier to omit the important step of updating the description of an entity if it was changed - and we all know why that shouldn't happen ;)<br>
-Because of those reasons, we will only use the first two documentation schemes.
-
-
-Doxygen supports both Qt and JavaDoc comment styles:
-* Qt style example: **int i; //!< The counter for the main loop**
-* JavaDoc style example: **int i; /*\*< The counter for the main loop \*/**
-
-It also supports more comment styles but those two are the ones which are standardized. For OTTD we'll be using the JavaDoc style. One of the reasons is that it has a feature that the Qt style doesn't offer: JavaDoc style comment blocks will automatically start a brief description which ends at the first dot followed by a space or new line. Everything after that will also be part of the detailed description.
-
-The general structure of a JavaDoc style comment is
-```c++
-/**
- * This is the brief description. And this sentence contains some further explanations that will appear in the detailed description only.
- */
-```
-
-and the resulting descriptions of that block would be:
-* *Brief description*: This is the brief description.
-* *Detailed description*: This is the brief description. And this sentence contains some further explanations that will appear in the detailed description only.
-
-The distinction between the brief and detailed descriptions is made by the dot followed by a space/newline, so if you want to use that inside the brief description you need to escape the space/newline:
-```c++
-/**
- * This is a brief description (e.g.\ using only a few words). Details go here.
- */
-```
-
-If you're doing a one-line comment, use:
-```c++
-int i; ///< This is the description.
-```
-
-Also in the comment block you can include so-called structural commands which tell Doxygen what follows. In general, their area of effect begins after the command word and ends when a blank line or some other command is encountered. Also, multiple occurrences of the same structural command within a comment block or the referring entity will be joined in the documentation output usually.
-
-## Commit message
-To achieve a coherent whole and to make changelog writing easier, here are some guidelines for commit messages.
-There is a check-script on the git server (also available for clients, see below) to make sure we all follow those rules.
-
-The first line of a message must match:
-```
-<keyword>( #<issue>|<commit>(, (#<issue>|<commit>))*)?: ([<component>])? <details>
-```
-
-Keywords can either be player-facing, NewGRF / Script author-facing, or developer-facing.
-
-For player-facing changes, we have these keywords:
-* Feature: Adding a significant new functionality to the game. This can be small in code-size, but is meant for the bigger things from a player perspective.
-* Add: Similar to Feature, but for small functionalities.
-* Change: Changing existing behaviour to an extent the player needs to know about it.
-* Fix: Fixing an issue with the game (as seen by the player).
-* Remove: Completely removing a functionality.
-* Revert: Reverting an earlier Feature / Add / Change / Fix / Remove.
-* Doc: Update to (player-facing) documentation, like in the `docs/` folder etc.
-* Update: Translator commits.
-
-For NewGRF / Script author-facing changes, we use the same keywords as player-facing changes, followed by `[NewGRF]` / `[Script]` component.
-This also means the commit is aimed (and worded) towards the NewGRF / Script authors, rather than players.
-
-For developer-facing changes, we have these keywords:
-* Codechange: Changes to the code the player is not going to notice. Refactors, modernization, etc.
-* Cleanup: Similar to Codechange, but when it is more about removing old code, rather than an actual change.
-* Codefix: Fixing problems in earlier commits that the player is not actually going to notice. Wrong comments, missing files, CI changes.
-
-If you commit a `Fix` for an [issue](https://github.com/OpenTTD/OpenTTD/issues), add the corresponding issue number in the form of #NNNNN.
-
-In the case of `Fix`es, if you know the hash of the commit in which the bug was introduced (eg regression), please mention that hash (the first 7 characters) as well just after the keyword (or, if present, after the issue number).
-Finding the trouble-causing commit is highly encouraged as it makes backporting / branching / releases that much easier.
-
-Do not mention two keywords; if two apply, pick one that best represents the commit (for example, "Fix #123" is mostly always better than "Revert", even if both are true).
-
-The `<details>` part starts with a capital and does not end with a dot.
-Try to be descriptive to what the player will notice, not to what is actually being changed in the code.
-See `changelog.md` for inspiration.
-
-To further structure the changelog, you can add components. Example are:
-* "Network" for network specific changes.
-* "NewGRF" for NewGRF additions.
-* "Script" for AI / GS additions.
-* "YAPF", "NPF", for changes in these features.
-* "MacOS", "Linux", "Windows", for OS-specific changes.
-* "CI", "CMake", for changes to the (build) infrastructure.
-
-Further explanations, more details, etc. don't go into the first line. Use a new line for those.
-
-Complete examples:
-* `Fix: [YAPF] Infinite loop in pathfinder`
-* `Fix #5926: [YAPF] Infinite loop in pathfinder`
-* `Codefix 80dffae: Warning about unsigned unary minus`
-* `Fix #6673, 99bb3a9: Store the map variety setting in the savegame`
-* `Codefix #5922: ClientSizeChanged is only called via WndProcGdi which already has the mutex`
-* `Codechange #1264, #2037, #2038, #2110: Rewrite the autoreplace kernel`
-
-
-## Other tips
-### Remove trailing whitespace
-To find out if/where you have trailing whitespace, you can use the following (unix/bash) command:
-```
-grep -n -R --include "*.[ch]" '[ 	]$' * | grep --invert-match ".diff" | grep --invert-match ".patch"
-```
-Automatically removing whitespace is also possible with the following shell script (Note that it only checks .c, .cpp, .h, .hpp and .mm files):
-```
-#!/bin/sh
-IFS='
-'
-for i in Makefile `find . -name \*.c -o -name \*.cpp -o -name \*.h -o -name \*.hpp -o -name \*.mm`
-do
-  (
-	echo '%s/[ 	]\{1,\}$/'
-	echo w
-	echo q
-  ) | ed $i 2> /dev/null > /dev/null
-done
-```
-
-### Install the client-side git commit hooks
-
-The client-side hooks perform various checks when you commit changes locally.
-* Whitespace and indentation checks.
-* **Coding style** checks.
-
-Get the hooks:
-```
-git clone https://github.com/OpenTTD/OpenTTD-git-hooks.git openttd_hooks
-```
-
-Install the hooks, assuming "openttd" is your work tree folder:
-```
-cd openttd/.git/hooks
-ln -s -t . ../../../openttd_hooks/hooks/*
-```
-

COMPILING.md

@@ -4,32 +4,27 @@
 
 OpenTTD makes use of the following external libraries:
 
-- (encouraged) breakpad: creates minidumps on crash
 - (encouraged) zlib: (de)compressing of old (0.3.0-1.0.5) savegames, content downloads,
    heightmaps
 - (encouraged) liblzma: (de)compressing of savegames (1.1.0 and later)
 - (encouraged) libpng: making screenshots and loading heightmaps
 - (optional) liblzo2: (de)compressing of old (pre 0.3.0) savegames
 
-For Linux, the following additional libraries are used:
+For Linux, the following additional libraries are used (for non-dedicated only):
 
-- (encouraged) libcurl: content downloads
 - libSDL2: hardware access (video, sound, mouse)
 - libfreetype: loading generic fonts and rendering them
 - libfontconfig: searching for fonts, resolving font names to actual fonts
-- harfbuzz: handling of right-to-left scripts (e.g. Arabic and Persian) (required libicu)
 - libicu: handling of right-to-left scripts (e.g. Arabic and Persian) and
    natural sorting of strings
 
-If you are building a dedicated-server only, you don't need the last four.
-
 OpenTTD does not require any of the libraries to be present, but without
 liblzma you cannot open most recent savegames and without zlib you cannot
 open most older savegames or use the content downloading system.
 
 ## Windows
 
-You need Microsoft Visual Studio 2022 or more recent.
+You need Microsoft Visual Studio 2017 or more recent.
 
 You can download the free Visual Studio Community Edition from Microsoft at
 https://visualstudio.microsoft.com/vs/community/.
@@ -38,7 +33,7 @@ OpenTTD needs the Platform SDK, if it isn't installed already. This can be
 done during installing Visual Studio, by selecting
 `Visual C++ MFC for x86 and x64` (and possibly
 `Visual C++ ATL for x86 and x64` depending on your version). If not, you
-can get download it as [MS Windows Platform SDK](https://developer.microsoft.com/en-us/windows/downloads/windows-sdk).
+can get download it as [MS Windows Platform SDK](https://developer.microsoft.com/en-US/windows/downloads/windows-10-sdk).
 
 Install the SDK by following the instructions as given.
 
@@ -50,7 +45,6 @@ by following the `Quick Start` instructions of their
 After this, you can install the dependencies OpenTTD needs. We advise to use
 the `static` versions, and OpenTTD currently needs the following dependencies:
 
-- breakpad
 - liblzma
 - libpng
 - lzo
@@ -59,13 +53,13 @@ the `static` versions, and OpenTTD currently needs the following dependencies:
 To install both the x64 (64bit) and x86 (32bit) variants (though only one is necessary), you can use:
 
 ```ps
-.\vcpkg install --triplet=x64-windows-static
-.\vcpkg install --triplet=x86-windows-static
+.\vcpkg install liblzma:x64-windows-static libpng:x64-windows-static lzo:x64-windows-static zlib:x64-windows-static
+.\vcpkg install liblzma:x86-windows-static libpng:x86-windows-static lzo:x86-windows-static zlib:x86-windows-static
 ```
 
 You can open the folder (as a CMake project). CMake will be detected, and you can compile from there.
 If libraries are installed but not found, you need to set VCPKG_TARGET_TRIPLET in CMake parameters.
-For Visual Studio 2022 you also need to set CMAKE_TOOLCHAIN_FILE.
+For Visual Studio 2017 you also need to set CMAKE_TOOLCHAIN_FILE.
 (Typical values are shown in the MSVC project file command line example)
 
 Alternatively, you can create a MSVC project file via CMake. For this
@@ -75,7 +69,7 @@ that comes with vcpkg. After that, you can run something similar to this:
 ```powershell
 mkdir build
 cd build
-cmake.exe .. -G"Visual Studio 17 2022" -DCMAKE_TOOLCHAIN_FILE="<location of vcpkg>\vcpkg\scripts\buildsystems\vcpkg.cmake" -DVCPKG_TARGET_TRIPLET="x64-windows-static"
+cmake.exe .. -G"Visual Studio 16 2019" -DCMAKE_TOOLCHAIN_FILE="<location of vcpkg>\vcpkg\scripts\buildsystems\vcpkg.cmake" -DVCPKG_TARGET_TRIPLET="x64-windows-static"
 ```
 
 Change `<location of vcpkg>` to where you have installed vcpkg. After this
@@ -83,7 +77,7 @@ in the build folder are MSVC project files. MSVC can rebuild the project
 files himself via the `ZERO_CHECK` project.
 
 ## All other platforms
-Minimum required version of CMake is 3.16.
+Minimum required version of CMake is 3.9.
 By default this produces a Debug build with assertations enabled.
 This is a far slower build than release builds.
 
@@ -103,21 +97,24 @@ Via CMake, several options can be influenced to get different types of
 builds.
 
 - `-DCMAKE_BUILD_TYPE=RelWithDebInfo`: build a release build. This is
-   significantly faster than a debug build, but has far less useful information
+   significant faster than a debug build, but has far less useful information
    in case of a crash.
 - `-DOPTION_DEDICATED=ON`: build OpenTTD without a GUI. Useful if you are
    running a headless server, as it requires less libraries to operate.
 - `-DOPTION_USE_ASSERTS=OFF`: disable asserts. Use with care, as assert
    statements capture early signs of trouble. Release builds have them
    disabled by default.
+- `-DOPTION_USE_THREADS=OFF`: disable the use of threads. This will block
+   the interface in many places, and in general gives a worse experience of
+   the game. Use with care.
 - `-DOPTION_TOOLS_ONLY=ON`: only build tools like `strgen`. Does not build
    the game itself. Useful for cross-compiling.
 
 ## Supported compilers
 
-Every compiler that is supported by CMake and supports C++20, should be
+Every compiler that is supported by CMake and supports C++17, should be
 able to compile OpenTTD. As the exact list of compilers changes constantly,
-we refer to the compiler manual to see if it supports C++20, and to CMake
+we refer to the compiler manual to see if it supports C++17, and to CMake
 to see if it supports your compiler.
 
 ## Compilation of base sets

CONTRIBUTING.md

@@ -14,7 +14,7 @@ In return, they should reciprocate that respect in addressing your issue or asse
 The [issue tracker](https://github.com/OpenTTD/OpenTTD/issues) is the preferred channel for [bug reports](#bug-reports), but please respect the following restrictions:
 
 * Please **do not** use the issue tracker for help playing or using OpenTTD.
-Please try [irc](https://wiki.openttd.org/en/Development/IRC%20channel), [Discord](https://discord.gg/openttd), or the [forums](https://www.tt-forums.net/)
+Please try [irc](https://wiki.openttd.org/en/Development/IRC%20channel), or the [forums](https://www.tt-forums.net/)
 
 * Please **do not** derail or troll issues. Keep the discussion on topic and respect the opinions of others.
 
@@ -23,7 +23,7 @@ Use [GitHub's "reactions" feature](https://github.com/blog/2119-add-reactions-to
 We reserve the right to delete comments which violate this rule.
 
 * Please **do not** open issues or pull requests regarding add-on content in NewGRF, GameScripts, AIs, etc.
-These are created by third-parties.  Please try [irc](https://wiki.openttd.org/en/Development/IRC%20channel), [Discord](https://discord.gg/openttd), or the [forums](https://www.tt-forums.net/) to discuss these.
+These are created by third-parties.  Please try [irc](https://wiki.openttd.org/en/Development/IRC%20channel) or the [forums](https://www.tt-forums.net/) to discuss these.
 
 * Please use [the web translator](https://translator.openttd.org/) to submit corrections and improvements to translations of the game.
 
@@ -108,11 +108,11 @@ Pull requests should fit with the [goals of the project](./CONTRIBUTING.md#proje
 
 Every pull request should have a clear scope, with no unrelated commits.
 
-[Code style](./CODINGSTYLE.md) must be complied with for pull requests to be accepted; this also includes [commit message format](./CODINGSTYLE.md#commit-message).
+[Code style](https://wiki.openttd.org/en/Development/Coding%20style) must be complied with for pull requests to be accepted; this also includes [commit message format](https://wiki.openttd.org/en/Development/Coding%20style#commit-message).
 
 Adhering to the following process is the best way to get your work included in the project:
 
-1. [Fork](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo) the project, clone your fork, and configure the remotes:
+1. [Fork](https://help.github.com/fork-a-repo/) the project, clone your fork, and configure the remotes:
 
 ```bash
 git clone https://github.com/<your-username>/OpenTTD.git openttd
@@ -136,7 +136,7 @@ contain your feature, change, or fix:
 git checkout upstream/master -b <topic-branch-name>
 ```
 
-4. Commit your changes in logical chunks. Please adhere to these [git commit message guidelines](./CODINGSTYLE.md#commit-message) or your code is unlikely to be merged into the main project.
+4. Commit your changes in logical chunks. Please adhere to these [git commit message guidelines](https://wiki.openttd.org/en/Development/Coding%20style#commit-message) or your code is unlikely to be merged into the main project.
 Use Git's [interactive rebase](https://docs.github.com/en/get-started/using-git/about-git-rebase) feature to tidy up your commits before making them public.
 
 5. Locally rebase the upstream development branch into your topic branch:
@@ -172,7 +172,7 @@ The results of the CI tests will show on your pull request.
 By clicking on Details you can further zoom in; in case of a failure it will show you why it failed.
 In case of success it will report how awesome you were.
 
-Tip: [commit message format](./CODINGSTYLE.md#commit-message) is a common reason for pull requests to fail validation.
+Tip: [commit message format](https://wiki.openttd.org/en/Development/Coding%20style#commit-message) is a common reason for pull requests to fail validation.
 
 
 ### Are there any development docs?
@@ -182,16 +182,6 @@ There is no single source for OpenTTD development docs. It's a complex project w
 A good entry point is [Development](https://wiki.openttd.org/en/Development/) on the OpenTTD wiki; this provides links to wiki documentation and other sources.
 
 The GitHub repo also includes some non-comprehensive documentation in [/docs](./docs).
-These include:
-- When to [change other languages and when not to](./docs/eints.md).
-- The [savegame format](./docs/savegame_format.md).
-- The [release process](./docs/releasing_openttd.md).
-- Some [notes on the link graph algorithm](./docs/linkgraph.md).
-- The [network game coordinator](./docs/game_coordinator.md).
-- How to use [the admin port for network games](./docs/admin_network.md), also useful for multiplayer server hosts.
-- The [performance metrics and logging features](./docs/logging_and_performance_metrics.md), also useful for add-on developers.
-- How [symbol server and analysis works](./docs/symbol_server.md).
-- And several miscellaneous files detailing internal data structures and graphics measurements and palettes.
 
 You may also want the guide to [compiling OpenTTD](./COMPILING.md).
 
@@ -266,7 +256,7 @@ This is inevitable, because it is a main feature of git.
 If you are concerned about your privacy, we strongly recommend to use "Anonymous &lt;anonymous@openttd.org&gt;" as the git commit author. We might refuse anonymous contributions if malicious intent is suspected.
 
 Please note that the contributor identity, once given, is used for copyright verification and to provide proof should a malicious commit be made.
-As such, the [EU GDPR](https://gdpr.eu) "right to be forgotten" does not apply, as this is an overriding legitimate interest.
+As such, the [EU GDPR](https://www.eugdpr.org/key-changes.html) "right to be forgotten" does not apply, as this is an overriding legitimate interest.
 
 Please also note that your commit is public and as such will potentially be processed by many third-parties.
 Git's distributed nature makes it impossible to track where exactly your commit, and thus your personal data, will be stored and be processed.

COPYING.md

@@ -1,5 +1,5 @@
 This is the license which applies to OpenTTD with the exception of some
-3rd party modules. See [our readme](./README.md) for details
+3rd party modules. See [./README.md](./README.md) for details
 
 GNU General Public License
 ==========================

CREDITS.md

@@ -3,15 +3,14 @@
 - Matthijs Kooijman (blathijs) - Pathfinder-guru, Debian port (since 0.3)
 - Christoph Elsenhans (frosch) - General coding (since 0.6)
 - Loïc Guilloux (glx) - General / Windows Expert (since 0.4.5)
-- Koen Bussemaker (Kuhnovic) - General / Ship pathfinder (since 14)
 - Charles Pigott (LordAro) - General / Correctness police (since 1.9)
 - Michael Lutz (michi_cc) - General / Path based signals (since 0.7)
 - Niels Martin Hansen (nielsm) - Music system, general coding (since 1.9)
 - Owen Rudge (orudge) - Forum host, OS/2 port (since 0.1)
-- Peter Nelson (peter1138) - Spiritual descendant from NewGRF gods (since 0.4.5)
+- Peter Nelson (peter1138) - Spiritual descendant from newGRF gods (since 0.4.5)
 - Remko Bijker (Rubidium) - Coder and way more (since 0.4.5)
 - Patric Stout (TrueBrain) - NoProgrammer (since 0.3), sys op
-- Tyler Trahan (2TallTyler) - General / Time Lord (since 13)
+- Tyler Trahan (2TallTyler) - General coding (since 13)
 
 ### Inactive Developers:
 
@@ -57,7 +56,6 @@
 - George - Canal/Lock graphics
 - Andrew Parkhouse (andythenorth) - River graphics
 - David Dallaston (Pikka) - Tram tracks
-- Richard Wheeler (zephyris) - OpenTTD TrueType font
 - All Translators - For their support to make OpenTTD a truly international game
 - Bug Reporters - Thanks for all bug reports
 - Chris Sawyer - For an amazing game!

Doxyfile.in

@@ -3,8 +3,6 @@
 # OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 # See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
 
-# Doxyfile 1.9.4
-
 #---------------------------------------------------------------------------
 # Project related configuration options
 #---------------------------------------------------------------------------
@@ -15,7 +13,6 @@ PROJECT_BRIEF          =
 PROJECT_LOGO           =
 OUTPUT_DIRECTORY       = ${CPACK_BINARY_DIR}/docs/source/
 CREATE_SUBDIRS         = YES
-CREATE_SUBDIRS_LEVEL   = 8
 ALLOW_UNICODE_NAMES    = NO
 OUTPUT_LANGUAGE        = English
 BRIEF_MEMBER_DESC      = YES
@@ -38,10 +35,8 @@ STRIP_FROM_PATH        = ./
 STRIP_FROM_INC_PATH    =
 SHORT_NAMES            = NO
 JAVADOC_AUTOBRIEF      = YES
-JAVADOC_BANNER         = NO
 QT_AUTOBRIEF           = NO
 MULTILINE_CPP_IS_BRIEF = NO
-PYTHON_DOCSTRING       = YES
 INHERIT_DOCS           = YES
 SEPARATE_MEMBER_PAGES  = NO
 TAB_SIZE               = 2
@@ -50,7 +45,6 @@ OPTIMIZE_OUTPUT_FOR_C  = YES
 OPTIMIZE_OUTPUT_JAVA   = NO
 OPTIMIZE_FOR_FORTRAN   = NO
 OPTIMIZE_OUTPUT_VHDL   = NO
-OPTIMIZE_OUTPUT_SLICE  = NO
 EXTENSION_MAPPING      =
 MARKDOWN_SUPPORT       = YES
 TOC_INCLUDE_HEADINGS   = 0
@@ -66,19 +60,16 @@ INLINE_GROUPED_CLASSES = NO
 INLINE_SIMPLE_STRUCTS  = NO
 TYPEDEF_HIDES_STRUCT   = NO
 LOOKUP_CACHE_SIZE      = 0
-NUM_PROC_THREADS       = 1
 #---------------------------------------------------------------------------
 # Build related configuration options
 #---------------------------------------------------------------------------
 EXTRACT_ALL            = NO
 EXTRACT_PRIVATE        = YES
-EXTRACT_PRIV_VIRTUAL   = NO
 EXTRACT_PACKAGE        = NO
 EXTRACT_STATIC         = YES
 EXTRACT_LOCAL_CLASSES  = YES
 EXTRACT_LOCAL_METHODS  = YES
 EXTRACT_ANON_NSPACES   = YES
-RESOLVE_UNNAMED_PARAMS = YES
 HIDE_UNDOC_MEMBERS     = NO
 HIDE_UNDOC_CLASSES     = NO
 HIDE_FRIEND_COMPOUNDS  = NO
@@ -87,7 +78,6 @@ INTERNAL_DOCS          = NO
 CASE_SENSE_NAMES       = YES
 HIDE_SCOPE_NAMES       = NO
 HIDE_COMPOUND_REFERENCE= NO
-SHOW_HEADERFILE        = YES
 SHOW_INCLUDE_FILES     = YES
 SHOW_GROUPED_MEMB_INC  = NO
 FORCE_LOCAL_INCLUDES   = NO
@@ -117,11 +107,9 @@ QUIET                  = NO
 WARNINGS               = YES
 WARN_IF_UNDOCUMENTED   = YES
 WARN_IF_DOC_ERROR      = YES
-WARN_IF_INCOMPLETE_DOC = YES
 WARN_NO_PARAMDOC       = NO
 WARN_AS_ERROR          = NO
 WARN_FORMAT            = "$file:$line: $text"
-WARN_LINE_FORMAT       = "at line $line of file $file"
 WARN_LOGFILE           =
 #---------------------------------------------------------------------------
 # Configuration options related to the input files
@@ -162,10 +150,6 @@ REFERENCES_LINK_SOURCE = YES
 SOURCE_TOOLTIPS        = YES
 USE_HTAGS              = NO
 VERBATIM_HEADERS       = YES
-CLANG_ASSISTED_PARSING = NO
-CLANG_ADD_INC_PATHS    = YES
-CLANG_OPTIONS          =
-CLANG_DATABASE_PATH    =
 #---------------------------------------------------------------------------
 # Configuration options related to the alphabetical class index
 #---------------------------------------------------------------------------
@@ -191,7 +175,6 @@ HTML_DYNAMIC_SECTIONS  = NO
 HTML_INDEX_NUM_ENTRIES = 100
 GENERATE_DOCSET        = NO
 DOCSET_FEEDNAME        = "Doxygen generated docs"
-DOCSET_FEEDURL         =
 DOCSET_BUNDLE_ID       = org.doxygen.Project
 DOCSET_PUBLISHER_ID    = org.doxygen.Publisher
 DOCSET_PUBLISHER_NAME  = Publisher
@@ -214,17 +197,12 @@ GENERATE_ECLIPSEHELP   = NO
 ECLIPSE_DOC_ID         = org.doxygen.Project
 DISABLE_INDEX          = NO
 GENERATE_TREEVIEW      = YES
-FULL_SIDEBAR           = NO
 ENUM_VALUES_PER_LINE   = 4
 TREEVIEW_WIDTH         = 250
 EXT_LINKS_IN_WINDOW    = NO
-OBFUSCATE_EMAILS       = YES
-HTML_FORMULA_FORMAT    = png
 FORMULA_FONTSIZE       = 10
 FORMULA_TRANSPARENT    = YES
-FORMULA_MACROFILE      =
 USE_MATHJAX            = NO
-MATHJAX_VERSION        = MathJax_2
 MATHJAX_FORMAT         = HTML-CSS
 MATHJAX_RELPATH        = https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.2/
 MATHJAX_EXTENSIONS     =
@@ -243,7 +221,6 @@ GENERATE_LATEX         = NO
 LATEX_OUTPUT           = latex
 LATEX_CMD_NAME         = latex
 MAKEINDEX_CMD_NAME     = makeindex
-LATEX_MAKEINDEX_CMD    = makeindex
 COMPACT_LATEX          = NO
 PAPER_TYPE             = a4
 EXTRA_PACKAGES         =
@@ -255,9 +232,9 @@ PDF_HYPERLINKS         = NO
 USE_PDFLATEX           = NO
 LATEX_BATCHMODE        = NO
 LATEX_HIDE_INDICES     = NO
+LATEX_SOURCE_CODE      = NO
 LATEX_BIB_STYLE        = plain
 LATEX_TIMESTAMP        = NO
-LATEX_EMOJI_DIRECTORY  =
 #---------------------------------------------------------------------------
 # Configuration options related to the RTF output
 #---------------------------------------------------------------------------
@@ -267,6 +244,7 @@ COMPACT_RTF            = NO
 RTF_HYPERLINKS         = NO
 RTF_STYLESHEET_FILE    =
 RTF_EXTENSIONS_FILE    =
+RTF_SOURCE_CODE        = NO
 #---------------------------------------------------------------------------
 # Configuration options related to the man page output
 #---------------------------------------------------------------------------
@@ -281,12 +259,12 @@ MAN_LINKS              = NO
 GENERATE_XML           = NO
 XML_OUTPUT             = xml
 XML_PROGRAMLISTING     = YES
-XML_NS_MEMB_FILE_SCOPE = NO
 #---------------------------------------------------------------------------
 # Configuration options related to the DOCBOOK output
 #---------------------------------------------------------------------------
 GENERATE_DOCBOOK       = NO
 DOCBOOK_OUTPUT         = docbook
+DOCBOOK_PROGRAMLISTING = NO
 #---------------------------------------------------------------------------
 # Configuration options for the AutoGen Definitions output
 #---------------------------------------------------------------------------
@@ -314,8 +292,8 @@ PREDEFINED             = WITH_ZLIB \
                          WITH_PNG \
                          WITH_FONTCONFIG \
                          WITH_FREETYPE \
-                         WITH_HARFBUZZ \
                          WITH_ICU_I18N \
+                         WITH_ICU_LX \
                          UNICODE \
                          _UNICODE \
                          _GNU_SOURCE \
@@ -333,6 +311,7 @@ EXTERNAL_PAGES         = YES
 #---------------------------------------------------------------------------
 # Configuration options related to the dot tool
 #---------------------------------------------------------------------------
+CLASS_DIAGRAMS         = YES
 DIA_PATH               =
 HIDE_UNDOC_RELATIONS   = YES
 HAVE_DOT               = NO
@@ -345,8 +324,6 @@ COLLABORATION_GRAPH    = YES
 GROUP_GRAPHS           = YES
 UML_LOOK               = NO
 UML_LIMIT_NUM_FIELDS   = 10
-DOT_UML_DETAILS        = NO
-DOT_WRAP_THRESHOLD     = 17
 TEMPLATE_RELATIONS     = NO
 INCLUDE_GRAPH          = YES
 INCLUDED_BY_GRAPH      = YES
@@ -354,7 +331,6 @@ CALL_GRAPH             = NO
 CALLER_GRAPH           = NO
 GRAPHICAL_HIERARCHY    = YES
 DIRECTORY_GRAPH        = YES
-DIR_GRAPH_MAX_DEPTH    = 1
 DOT_IMAGE_FORMAT       = png
 INTERACTIVE_SVG        = NO
 DOT_PATH               =

README.md

@@ -11,10 +11,9 @@
     - 1.6) [OpenTTD directories](#16-openttd-directories)
     - 1.7) [Compiling OpenTTD](#17-compiling-openttd)
 - 2.0) [Contact and community](#20-contact-and-community)
-    - 2.1) [Multiplayer games](#21-multiplayer-games)
-    - 2.2) [Contributing to OpenTTD](#22-contributing-to-openttd)
-    - 2.3) [Reporting bugs](#23-reporting-bugs)
-    - 2.4) [Translating](#24-translating)
+    - 2.1) [Contributing to OpenTTD](#21-contributing-to-openttd)
+    - 2.2) [Reporting bugs](#22-reporting-bugs)
+    - 2.3) [Translating](#23-translating)
 - 3.0) [Licensing](#30-licensing)
 - 4.0) [Credits](#40-credits)
 
@@ -78,9 +77,9 @@ For some platforms, you will need to refer to [the installation guide](https://w
 The free data files, split into OpenGFX for graphics, OpenSFX for sounds and
 OpenMSX for music can be found at:
 
-- [OpenGFX](https://www.openttd.org/downloads/opengfx-releases/latest)
-- [OpenSFX](https://www.openttd.org/downloads/opensfx-releases/latest)
-- [OpenMSX](https://www.openttd.org/downloads/openmsx-releases/latest)
+- https://www.openttd.org/downloads/opengfx-releases/latest for OpenGFX
+- https://www.openttd.org/downloads/opensfx-releases/latest for OpenSFX
+- https://www.openttd.org/downloads/openmsx-releases/latest for OpenMSX
 
 Please follow the readme of these packages about the installation procedure.
 The Windows installer can optionally download and install these packages.
@@ -118,15 +117,6 @@ Most types of add-on content can be downloaded within OpenTTD via the 'Check Onl
 Add-on content can also be installed manually, but that's more complicated; the [OpenTTD wiki](https://wiki.openttd.org/) may offer help with that, or the [OpenTTD directory structure guide](./docs/directory_structure.md).
 
 
-### 1.5.1) Social Integration
-
-OpenTTD has the ability to load plugins to integrate with Social Platforms like Steam, Discord, etc.
-
-To enable such integration, the plugin for the specific platform has to be downloaded and stored in the `social_integration` folder.
-
-See [OpenTTD's website](https://www.openttd.org), under Downloads, for what plugins are available.
-
-
 ### 1.6) OpenTTD directories
 
 OpenTTD uses its own directory structure to store game data, add-on content etc.
@@ -154,19 +144,12 @@ If you want to compile OpenTTD from source, instructions can be found in [COMPIL
 - the OpenTTD wiki has a [page listing OpenTTD communities](https://wiki.openttd.org/en/Community/Community) including some in languages other than English
 
 
-### 2.1) Multiplayer games
-
-You can play OpenTTD with others, either cooperatively or competitively.
-
-See the [multiplayer documentation](./docs/multiplayer.md) for more details.
-
-
-### 2.2) Contributing to OpenTTD
+### 2.1) Contributing to OpenTTD
 
 We welcome contributors to OpenTTD.  More information for contributors can be found in [CONTRIBUTING.md](./CONTRIBUTING.md)
 
 
-### 2.3) Reporting bugs
+### 2.2) Reporting bugs
 
 Good bug reports are very helpful.  We have a [guide to reporting bugs](./CONTRIBUTING.md#bug-reports) to help with this.
 
@@ -174,7 +157,7 @@ Desyncs in multiplayer are complex to debug and report (some software developmen
 Instructions can be found in [debugging and reporting desyncs](./docs/debugging_desyncs.md).
 
 
-### 2.4) Translating
+### 2.3) Translating
 
 OpenTTD is translated into many languages.  Translations are added and updated via the [online translation tool](https://translator.openttd.org).
 
@@ -191,29 +174,12 @@ See `src/3rdparty/squirrel/COPYRIGHT` for the complete license text.
 The md5 implementation in `src/3rdparty/md5` is licensed under the Zlib license.
 See the comments in the source files in `src/3rdparty/md5` for the complete license text.
 
+The implementations of Posix `getaddrinfo` and `getnameinfo` for OS/2 in `src/3rdparty/os2` are distributed partly under the GNU Lesser General Public License 2.1, and partly under the (3-clause) BSD license.
+The exact licensing terms can be found in `src/3rdparty/os2/getaddrinfo.c` resp. `src/3rdparty/os2/getnameinfo.c`.
+
 The fmt implementation in `src/3rdparty/fmt` is licensed under the MIT license.
 See `src/3rdparty/fmt/LICENSE.rst` for the complete license text.
 
-The nlohmann json implementation in `src/3rdparty/nlohmann` is licensed under the MIT license.
-See `src/3rdparty/nlohmann/LICENSE.MIT` for the complete license text.
-
-The OpenGL API in `src/3rdparty/opengl` is licensed under the MIT license.
-See `src/3rdparty/opengl/khrplatform.h` for the complete license text.
-
-The catch2 implementation in `src/3rdparty/catch2` is licensed under the Boost Software License, Version 1.0.
-See `src/3rdparty/catch2/LICENSE.txt` for the complete license text.
-
-The icu scriptrun implementation in `src/3rdparty/icu` is licensed under the Unicode license.
-See `src/3rdparty/icu/LICENSE` for the complete license text.
-
-The monocypher implementation in `src/3rdparty/monocypher` is licensed under the 2-clause BSD and CC-0 license.
-See `src/3rdparty/monocypher/LICENSE.md` for the complete license text.
-
-The OpenTTD Social Integration API in `src/3rdparty/openttd_social_integration_api` is licensed under the MIT license.
-See `src/3rdparty/openttd_social_integration_api/LICENSE` for the complete license text.
-
-The atomic datatype support detection in `cmake/3rdparty/llvm/CheckAtomic.cmake` is licensed under the Apache 2.0 license.
-See `cmake/3rdparty/llvm/LICENSE.txt` for the complete license text.
 
 ## 4.0 Credits
 

bin/ai/CMakeLists.txt

@@ -14,8 +14,6 @@ set(AI_COMPAT_SOURCE_FILES
 	${CMAKE_CURRENT_SOURCE_DIR}/compat_1.11.nut
 	${CMAKE_CURRENT_SOURCE_DIR}/compat_12.nut
 	${CMAKE_CURRENT_SOURCE_DIR}/compat_13.nut
-	${CMAKE_CURRENT_SOURCE_DIR}/compat_14.nut
-	${CMAKE_CURRENT_SOURCE_DIR}/compat_15.nut
 )
 
 foreach(AI_COMPAT_SOURCE_FILE IN LISTS AI_COMPAT_SOURCE_FILES)

bin/ai/compat_13.nut

@@ -4,5 +4,3 @@
  * OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
  * See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
  */
-
-AILog.Info("13 API compatibility in effect.");

bin/ai/compat_14.nut

@@ -1,8 +0,0 @@
-/*
- * This file is part of OpenTTD.
- * OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
- * OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- * See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
- */
-
-AILog.Info("14 API compatibility in effect.");

bin/ai/compat_15.nut

@@ -1,6 +0,0 @@
-/*
- * This file is part of OpenTTD.
- * OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
- * OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- * See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
- */

bin/game/CMakeLists.txt

@@ -11,8 +11,6 @@ set(GS_COMPAT_SOURCE_FILES
 	${CMAKE_CURRENT_SOURCE_DIR}/compat_1.11.nut
 	${CMAKE_CURRENT_SOURCE_DIR}/compat_12.nut
 	${CMAKE_CURRENT_SOURCE_DIR}/compat_13.nut
-	${CMAKE_CURRENT_SOURCE_DIR}/compat_14.nut
-	${CMAKE_CURRENT_SOURCE_DIR}/compat_15.nut
 )
 
 foreach(GS_COMPAT_SOURCE_FILE IN LISTS GS_COMPAT_SOURCE_FILES)

bin/game/compat_13.nut

@@ -4,5 +4,3 @@
  * OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
  * See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
  */
-
-GSLog.Info("13 API compatibility in effect.");

bin/game/compat_14.nut

@@ -1,8 +0,0 @@
-/*
- * This file is part of OpenTTD.
- * OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
- * OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- * See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
- */
-
-GSLog.Info("14 API compatibility in effect.");

bin/game/compat_15.nut

@@ -1,6 +0,0 @@
-/*
- * This file is part of OpenTTD.
- * OpenTTD is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, version 2.
- * OpenTTD is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
- * See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenTTD. If not, see <http://www.gnu.org/licenses/>.
- */

cmake/3rdparty/llvm/LICENSE.txt

@@ -1,279 +0,0 @@
-==============================================================================
-The LLVM Project is under the Apache License v2.0 with LLVM Exceptions:
-==============================================================================
-
-                                 Apache License
-                           Version 2.0, January 2004
-                        http://www.apache.org/licenses/
-
-    TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
-
-    1. Definitions.
-
-      "License" shall mean the terms and conditions for use, reproduction,
-      and distribution as defined by Sections 1 through 9 of this document.
-
-      "Licensor" shall mean the copyright owner or entity authorized by
-      the copyright owner that is granting the License.
-
-      "Legal Entity" shall mean the union of the acting entity and all
-      other entities that control, are controlled by, or are under common
-      control with that entity. For the purposes of this definition,
-      "control" means (i) the power, direct or indirect, to cause the
-      direction or management of such entity, whether by contract or
-      otherwise, or (ii) ownership of fifty percent (50%) or more of the
-      outstanding shares, or (iii) beneficial ownership of such entity.
-
-      "You" (or "Your") shall mean an individual or Legal Entity
-      exercising permissions granted by this License.
-
-      "Source" form shall mean the preferred form for making modifications,
-      including but not limited to software source code, documentation
-      source, and configuration files.
-
-      "Object" form shall mean any form resulting from mechanical
-      transformation or translation of a Source form, including but
-      not limited to compiled object code, generated documentation,
-      and conversions to other media types.
-
-      "Work" shall mean the work of authorship, whether in Source or
-      Object form, made available under the License, as indicated by a
-      copyright notice that is included in or attached to the work
-      (an example is provided in the Appendix below).
-
-      "Derivative Works" shall mean any work, whether in Source or Object
-      form, that is based on (or derived from) the Work and for which the
-      editorial revisions, annotations, elaborations, or other modifications
-      represent, as a whole, an original work of authorship. For the purposes
-      of this License, Derivative Works shall not include works that remain
-      separable from, or merely link (or bind by name) to the interfaces of,
-      the Work and Derivative Works thereof.
-
-      "Contribution" shall mean any work of authorship, including
-      the original version of the Work and any modifications or additions
-      to that Work or Derivative Works thereof, that is intentionally
-      submitted to Licensor for inclusion in the Work by the copyright owner
-      or by an individual or Legal Entity authorized to submit on behalf of
-      the copyright owner. For the purposes of this definition, "submitted"
-      means any form of electronic, verbal, or written communication sent
-      to the Licensor or its representatives, including but not limited to
-      communication on electronic mailing lists, source code control systems,
-      and issue tracking systems that are managed by, or on behalf of, the
-      Licensor for the purpose of discussing and improving the Work, but
-      excluding communication that is conspicuously marked or otherwise
-      designated in writing by the copyright owner as "Not a Contribution."
-
-      "Contributor" shall mean Licensor and any individual or Legal Entity
-      on behalf of whom a Contribution has been received by Licensor and
-      subsequently incorporated within the Work.
-
-    2. Grant of Copyright License. Subject to the terms and conditions of
-      this License, each Contributor hereby grants to You a perpetual,
-      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
-      copyright license to reproduce, prepare Derivative Works of,
-      publicly display, publicly perform, sublicense, and distribute the
-      Work and such Derivative Works in Source or Object form.
-
-    3. Grant of Patent License. Subject to the terms and conditions of
-      this License, each Contributor hereby grants to You a perpetual,
-      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
-      (except as stated in this section) patent license to make, have made,
-      use, offer to sell, sell, import, and otherwise transfer the Work,
-      where such license applies only to those patent claims licensable
-      by such Contributor that are necessarily infringed by their
-      Contribution(s) alone or by combination of their Contribution(s)
-      with the Work to which such Contribution(s) was submitted. If You
-      institute patent litigation against any entity (including a
-      cross-claim or counterclaim in a lawsuit) alleging that the Work
-      or a Contribution incorporated within the Work constitutes direct
-      or contributory patent infringement, then any patent licenses
-      granted to You under this License for that Work shall terminate
-      as of the date such litigation is filed.
-
-    4. Redistribution. You may reproduce and distribute copies of the
-      Work or Derivative Works thereof in any medium, with or without
-      modifications, and in Source or Object form, provided that You
-      meet the following conditions:
-
-      (a) You must give any other recipients of the Work or
-          Derivative Works a copy of this License; and
-
-      (b) You must cause any modified files to carry prominent notices
-          stating that You changed the files; and
-
-      (c) You must retain, in the Source form of any Derivative Works
-          that You distribute, all copyright, patent, trademark, and
-          attribution notices from the Source form of the Work,
-          excluding those notices that do not pertain to any part of
-          the Derivative Works; and
-
-      (d) If the Work includes a "NOTICE" text file as part of its
-          distribution, then any Derivative Works that You distribute must
-          include a readable copy of the attribution notices contained
-          within such NOTICE file, excluding those notices that do not
-          pertain to any part of the Derivative Works, in at least one
-          of the following places: within a NOTICE text file distributed
-          as part of the Derivative Works; within the Source form or
-          documentation, if provided along with the Derivative Works; or,
-          within a display generated by the Derivative Works, if and
-          wherever such third-party notices normally appear. The contents
-          of the NOTICE file are for informational purposes only and
-          do not modify the License. You may add Your own attribution
-          notices within Derivative Works that You distribute, alongside
-          or as an addendum to the NOTICE text from the Work, provided
-          that such additional attribution notices cannot be construed
-          as modifying the License.
-
-      You may add Your own copyright statement to Your modifications and
-      may provide additional or different license terms and conditions
-      for use, reproduction, or distribution of Your modifications, or
-      for any such Derivative Works as a whole, provided Your use,
-      reproduction, and distribution of the Work otherwise complies with
-      the conditions stated in this License.
-
-    5. Submission of Contributions. Unless You explicitly state otherwise,
-      any Contribution intentionally submitted for inclusion in the Work
-      by You to the Licensor shall be under the terms and conditions of
-      this License, without any additional terms or conditions.
-      Notwithstanding the above, nothing herein shall supersede or modify
-      the terms of any separate license agreement you may have executed
-      with Licensor regarding such Contributions.
-
-    6. Trademarks. This License does not grant permission to use the trade
-      names, trademarks, service marks, or product names of the Licensor,
-      except as required for reasonable and customary use in describing the
-      origin of the Work and reproducing the content of the NOTICE file.
-
-    7. Disclaimer of Warranty. Unless required by applicable law or
-      agreed to in writing, Licensor provides the Work (and each
-      Contributor provides its Contributions) on an "AS IS" BASIS,
-      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-      implied, including, without limitation, any warranties or conditions
-      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
-      PARTICULAR PURPOSE. You are solely responsible for determining the
-      appropriateness of using or redistributing the Work and assume any
-      risks associated with Your exercise of permissions under this License.
-
-    8. Limitation of Liability. In no event and under no legal theory,
-      whether in tort (including negligence), contract, or otherwise,
-      unless required by applicable law (such as deliberate and grossly
-      negligent acts) or agreed to in writing, shall any Contributor be
-      liable to You for damages, including any direct, indirect, special,
-      incidental, or consequential damages of any character arising as a
-      result of this License or out of the use or inability to use the
-      Work (including but not limited to damages for loss of goodwill,
-      work stoppage, computer failure or malfunction, or any and all
-      other commercial damages or losses), even if such Contributor
-      has been advised of the possibility of such damages.
-
-    9. Accepting Warranty or Additional Liability. While redistributing
-      the Work or Derivative Works thereof, You may choose to offer,
-      and charge a fee for, acceptance of support, warranty, indemnity,
-      or other liability obligations and/or rights consistent with this
-      License. However, in accepting such obligations, You may act only
-      on Your own behalf and on Your sole responsibility, not on behalf
-      of any other Contributor, and only if You agree to indemnify,
-      defend, and hold each Contributor harmless for any liability
-      incurred by, or claims asserted against, such Contributor by reason
-      of your accepting any such warranty or additional liability.
-
-    END OF TERMS AND CONDITIONS
-
-    APPENDIX: How to apply the Apache License to your work.
-
-      To apply the Apache License to your work, attach the following
-      boilerplate notice, with the fields enclosed by brackets "[]"
-      replaced with your own identifying information. (Don't include
-      the brackets!)  The text should be enclosed in the appropriate
-      comment syntax for the file format. We also recommend that a
-      file or class name and description of purpose be included on the
-      same "printed page" as the copyright notice for easier
-      identification within third-party archives.
-
-    Copyright [yyyy] [name of copyright owner]
-
-    Licensed under the Apache License, Version 2.0 (the "License");
-    you may not use this file except in compliance with the License.
-    You may obtain a copy of the License at
-
-       http://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing, software
-    distributed under the License is distributed on an "AS IS" BASIS,
-    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-    See the License for the specific language governing permissions and
-    limitations under the License.
-
-
----- LLVM Exceptions to the Apache 2.0 License ----
-
-As an exception, if, as a result of your compiling your source code, portions
-of this Software are embedded into an Object form of such source code, you
-may redistribute such embedded portions in such Object form without complying
-with the conditions of Sections 4(a), 4(b) and 4(d) of the License.
-
-In addition, if you combine or link compiled forms of this Software with
-software that is licensed under the GPLv2 ("Combined Software") and if a
-court of competent jurisdiction determines that the patent provision (Section
-3), the indemnity provision (Section 9) or other Section of the License
-conflicts with the conditions of the GPLv2, you may retroactively and
-prospectively choose to deem waived or otherwise exclude such Section(s) of
-the License, but only in their entirety and only with respect to the Combined
-Software.
-
-==============================================================================
-Software from third parties included in the LLVM Project:
-==============================================================================
-The LLVM Project contains third party software which is under different license
-terms. All such code will be identified clearly using at least one of two
-mechanisms:
-1) It will be in a separate directory tree with its own `LICENSE.txt` or
-   `LICENSE` file at the top containing the specific license and restrictions
-   which apply to that software, or
-2) It will contain specific license and restriction terms at the top of every
-   file.
-
-==============================================================================
-Legacy LLVM License (https://llvm.org/docs/DeveloperPolicy.html#legacy):
-==============================================================================
-University of Illinois/NCSA
-Open Source License
-
-Copyright (c) 2003-2019 University of Illinois at Urbana-Champaign.
-All rights reserved.
-
-Developed by:
-
-    LLVM Team
-
-    University of Illinois at Urbana-Champaign
-
-    http://llvm.org
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of
-this software and associated documentation files (the "Software"), to deal with
-the Software without restriction, including without limitation the rights to
-use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
-of the Software, and to permit persons to whom the Software is furnished to do
-so, subject to the following conditions:
-
-    * Redistributions of source code must retain the above copyright notice,
-      this list of conditions and the following disclaimers.
-
-    * Redistributions in binary form must reproduce the above copyright notice,
-      this list of conditions and the following disclaimers in the
-      documentation and/or other materials provided with the distribution.
-
-    * Neither the names of the LLVM Team, University of Illinois at
-      Urbana-Champaign, nor the names of its contributors may be used to
-      endorse or promote products derived from this Software without specific
-      prior written permission.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
-FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
-CONTRIBUTORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS WITH THE
-SOFTWARE.
-

cmake/Catch.cmake

@@ -1,206 +0,0 @@
-# Distributed under the OSI-approved BSD 3-Clause License.  See accompanying
-# file Copyright.txt or https://cmake.org/licensing for details.
-
-#[=======================================================================[.rst:
-Catch
------
-
-This module defines a function to help use the Catch test framework.
-
-The :command:`catch_discover_tests` discovers tests by asking the compiled test
-executable to enumerate its tests.  This does not require CMake to be re-run
-when tests change.  However, it may not work in a cross-compiling environment,
-and setting test properties is less convenient.
-
-This command is intended to replace use of :command:`add_test` to register
-tests, and will create a separate CTest test for each Catch test case.  Note
-that this is in some cases less efficient, as common set-up and tear-down logic
-cannot be shared by multiple test cases executing in the same instance.
-However, it provides more fine-grained pass/fail information to CTest, which is
-usually considered as more beneficial.  By default, the CTest test name is the
-same as the Catch name; see also ``TEST_PREFIX`` and ``TEST_SUFFIX``.
-
-.. command:: catch_discover_tests
-
-  Automatically add tests with CTest by querying the compiled test executable
-  for available tests::
-
-    catch_discover_tests(target
-                         [TEST_SPEC arg1...]
-                         [EXTRA_ARGS arg1...]
-                         [WORKING_DIRECTORY dir]
-                         [TEST_PREFIX prefix]
-                         [TEST_SUFFIX suffix]
-                         [PROPERTIES name1 value1...]
-                         [TEST_LIST var]
-                         [REPORTER reporter]
-                         [OUTPUT_DIR dir]
-                         [OUTPUT_PREFIX prefix}
-                         [OUTPUT_SUFFIX suffix]
-    )
-
-  ``catch_discover_tests`` sets up a post-build command on the test executable
-  that generates the list of tests by parsing the output from running the test
-  with the ``--list-test-names-only`` argument.  This ensures that the full
-  list of tests is obtained.  Since test discovery occurs at build time, it is
-  not necessary to re-run CMake when the list of tests changes.
-  However, it requires that :prop_tgt:`CROSSCOMPILING_EMULATOR` is properly set
-  in order to function in a cross-compiling environment.
-
-  Additionally, setting properties on tests is somewhat less convenient, since
-  the tests are not available at CMake time.  Additional test properties may be
-  assigned to the set of tests as a whole using the ``PROPERTIES`` option.  If
-  more fine-grained test control is needed, custom content may be provided
-  through an external CTest script using the :prop_dir:`TEST_INCLUDE_FILES`
-  directory property.  The set of discovered tests is made accessible to such a
-  script via the ``<target>_TESTS`` variable.
-
-  The options are:
-
-  ``target``
-    Specifies the Catch executable, which must be a known CMake executable
-    target.  CMake will substitute the location of the built executable when
-    running the test.
-
-  ``TEST_SPEC arg1...``
-    Specifies test cases, wildcarded test cases, tags and tag expressions to
-    pass to the Catch executable with the ``--list-test-names-only`` argument.
-
-  ``EXTRA_ARGS arg1...``
-    Any extra arguments to pass on the command line to each test case.
-
-  ``WORKING_DIRECTORY dir``
-    Specifies the directory in which to run the discovered test cases.  If this
-    option is not provided, the current binary directory is used.
-
-  ``TEST_PREFIX prefix``
-    Specifies a ``prefix`` to be prepended to the name of each discovered test
-    case.  This can be useful when the same test executable is being used in
-    multiple calls to ``catch_discover_tests()`` but with different
-    ``TEST_SPEC`` or ``EXTRA_ARGS``.
-
-  ``TEST_SUFFIX suffix``
-    Similar to ``TEST_PREFIX`` except the ``suffix`` is appended to the name of
-    every discovered test case.  Both ``TEST_PREFIX`` and ``TEST_SUFFIX`` may
-    be specified.
-
-  ``PROPERTIES name1 value1...``
-    Specifies additional properties to be set on all tests discovered by this
-    invocation of ``catch_discover_tests``.
-
-  ``TEST_LIST var``
-    Make the list of tests available in the variable ``var``, rather than the
-    default ``<target>_TESTS``.  This can be useful when the same test
-    executable is being used in multiple calls to ``catch_discover_tests()``.
-    Note that this variable is only available in CTest.
-
-  ``REPORTER reporter``
-    Use the specified reporter when running the test case. The reporter will
-    be passed to the Catch executable as ``--reporter reporter``.
-
-  ``OUTPUT_DIR dir``
-    If specified, the parameter is passed along as
-    ``--out dir/<test_name>`` to Catch executable. The actual file name is the
-    same as the test name. This should be used instead of
-    ``EXTRA_ARGS --out foo`` to avoid race conditions writing the result output
-    when using parallel test execution.
-
-  ``OUTPUT_PREFIX prefix``
-    May be used in conjunction with ``OUTPUT_DIR``.
-    If specified, ``prefix`` is added to each output file name, like so
-    ``--out dir/prefix<test_name>``.
-
-  ``OUTPUT_SUFFIX suffix``
-    May be used in conjunction with ``OUTPUT_DIR``.
-    If specified, ``suffix`` is added to each output file name, like so
-    ``--out dir/<test_name>suffix``. This can be used to add a file extension to
-    the output e.g. ".xml".
-
-#]=======================================================================]
-
-#------------------------------------------------------------------------------
-function(catch_discover_tests TARGET)
-  cmake_parse_arguments(
-    ""
-    ""
-    "TEST_PREFIX;TEST_SUFFIX;WORKING_DIRECTORY;TEST_LIST;REPORTER;OUTPUT_DIR;OUTPUT_PREFIX;OUTPUT_SUFFIX"
-    "TEST_SPEC;EXTRA_ARGS;PROPERTIES"
-    ${ARGN}
-  )
-
-  if(NOT _WORKING_DIRECTORY)
-    set(_WORKING_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}")
-  endif()
-  if(NOT _TEST_LIST)
-    set(_TEST_LIST ${TARGET}_TESTS)
-  endif()
-
-  ## Generate a unique name based on the extra arguments
-  string(SHA1 args_hash "${_TEST_SPEC} ${_EXTRA_ARGS} ${_REPORTER} ${_OUTPUT_DIR} ${_OUTPUT_PREFIX} ${_OUTPUT_SUFFIX}")
-  string(SUBSTRING ${args_hash} 0 7 args_hash)
-
-  # Define rule to generate test list for aforementioned test executable
-  set(ctest_include_file "${CMAKE_CURRENT_BINARY_DIR}/${TARGET}_include-${args_hash}.cmake")
-  set(ctest_tests_file "${CMAKE_CURRENT_BINARY_DIR}/${TARGET}_tests-${args_hash}.cmake")
-  get_property(crosscompiling_emulator
-    TARGET ${TARGET}
-    PROPERTY CROSSCOMPILING_EMULATOR
-  )
-  add_custom_command(
-    TARGET ${TARGET} POST_BUILD
-    BYPRODUCTS "${ctest_tests_file}"
-    COMMAND "${CMAKE_COMMAND}"
-            -D "TEST_TARGET=${TARGET}"
-            -D "TEST_EXECUTABLE=$<TARGET_FILE:${TARGET}>"
-            -D "TEST_EXECUTOR=${crosscompiling_emulator}"
-            -D "TEST_WORKING_DIR=${_WORKING_DIRECTORY}"
-            -D "TEST_SPEC=${_TEST_SPEC}"
-            -D "TEST_EXTRA_ARGS=${_EXTRA_ARGS}"
-            -D "TEST_PROPERTIES=${_PROPERTIES}"
-            -D "TEST_PREFIX=${_TEST_PREFIX}"
-            -D "TEST_SUFFIX=${_TEST_SUFFIX}"
-            -D "TEST_LIST=${_TEST_LIST}"
-            -D "TEST_REPORTER=${_REPORTER}"
-            -D "TEST_OUTPUT_DIR=${_OUTPUT_DIR}"
-            -D "TEST_OUTPUT_PREFIX=${_OUTPUT_PREFIX}"
-            -D "TEST_OUTPUT_SUFFIX=${_OUTPUT_SUFFIX}"
-            -D "CTEST_FILE=${ctest_tests_file}"
-            -P "${_CATCH_DISCOVER_TESTS_SCRIPT}"
-    VERBATIM
-  )
-
-  file(WRITE "${ctest_include_file}"
-    "if(EXISTS \"${ctest_tests_file}\")\n"
-    "  include(\"${ctest_tests_file}\")\n"
-    "else()\n"
-    "  add_test(${TARGET}_NOT_BUILT-${args_hash} ${TARGET}_NOT_BUILT-${args_hash})\n"
-    "endif()\n"
-  )
-
-  if(NOT ${CMAKE_VERSION} VERSION_LESS "3.10.0")
-    # Add discovered tests to directory TEST_INCLUDE_FILES
-    set_property(DIRECTORY
-      APPEND PROPERTY TEST_INCLUDE_FILES "${ctest_include_file}"
-    )
-  else()
-    # Add discovered tests as directory TEST_INCLUDE_FILE if possible
-    get_property(test_include_file_set DIRECTORY PROPERTY TEST_INCLUDE_FILE SET)
-    if (NOT ${test_include_file_set})
-      set_property(DIRECTORY
-        PROPERTY TEST_INCLUDE_FILE "${ctest_include_file}"
-      )
-    else()
-      message(FATAL_ERROR
-        "Cannot set more than one TEST_INCLUDE_FILE"
-      )
-    endif()
-  endif()
-
-endfunction()
-
-###############################################################################
-
-set(_CATCH_DISCOVER_TESTS_SCRIPT
-  ${CMAKE_CURRENT_LIST_DIR}/CatchAddTests.cmake
-  CACHE INTERNAL "Catch2 full path to CatchAddTests.cmake helper file"
-)

cmake/CatchAddTests.cmake

@@ -1,135 +0,0 @@
-# Distributed under the OSI-approved BSD 3-Clause License.  See accompanying
-# file Copyright.txt or https://cmake.org/licensing for details.
-
-set(prefix "${TEST_PREFIX}")
-set(suffix "${TEST_SUFFIX}")
-set(spec ${TEST_SPEC})
-set(extra_args ${TEST_EXTRA_ARGS})
-set(properties ${TEST_PROPERTIES})
-set(reporter ${TEST_REPORTER})
-set(output_dir ${TEST_OUTPUT_DIR})
-set(output_prefix ${TEST_OUTPUT_PREFIX})
-set(output_suffix ${TEST_OUTPUT_SUFFIX})
-set(script)
-set(suite)
-set(tests)
-
-function(add_command NAME)
-  set(_args "")
-  # use ARGV* instead of ARGN, because ARGN splits arrays into multiple arguments
-  math(EXPR _last_arg ${ARGC}-1)
-  foreach(_n RANGE 1 ${_last_arg})
-    set(_arg "${ARGV${_n}}")
-    if(_arg MATCHES "[^-./:a-zA-Z0-9_]")
-      set(_args "${_args} [==[${_arg}]==]") # form a bracket_argument
-    else()
-      set(_args "${_args} ${_arg}")
-    endif()
-  endforeach()
-  set(script "${script}${NAME}(${_args})\n" PARENT_SCOPE)
-endfunction()
-
-# Run test executable to get list of available tests
-if(NOT EXISTS "${TEST_EXECUTABLE}")
-  message(FATAL_ERROR
-    "Specified test executable '${TEST_EXECUTABLE}' does not exist"
-  )
-endif()
-execute_process(
-  COMMAND ${TEST_EXECUTOR} "${TEST_EXECUTABLE}" ${spec} --list-test-names-only
-  OUTPUT_VARIABLE output
-  RESULT_VARIABLE result
-  WORKING_DIRECTORY "${TEST_WORKING_DIR}"
-)
-# Catch --list-test-names-only reports the number of tests, so 0 is... surprising
-if(${result} EQUAL 0)
-  message(WARNING
-    "Test executable '${TEST_EXECUTABLE}' contains no tests!\n"
-  )
-elseif(${result} LESS 0)
-  message(FATAL_ERROR
-    "Error running test executable '${TEST_EXECUTABLE}':\n"
-    "  Result: ${result}\n"
-    "  Output: ${output}\n"
-  )
-endif()
-
-string(REPLACE "\n" ";" output "${output}")
-
-# Run test executable to get list of available reporters
-execute_process(
-  COMMAND ${TEST_EXECUTOR} "${TEST_EXECUTABLE}" ${spec} --list-reporters
-  OUTPUT_VARIABLE reporters_output
-  RESULT_VARIABLE reporters_result
-  WORKING_DIRECTORY "${TEST_WORKING_DIR}"
-)
-if(${reporters_result} EQUAL 0)
-  message(WARNING
-    "Test executable '${TEST_EXECUTABLE}' contains no reporters!\n"
-  )
-elseif(${reporters_result} LESS 0)
-  message(FATAL_ERROR
-    "Error running test executable '${TEST_EXECUTABLE}':\n"
-    "  Result: ${reporters_result}\n"
-    "  Output: ${reporters_output}\n"
-  )
-endif()
-string(FIND "${reporters_output}" "${reporter}" reporter_is_valid)
-if(reporter AND ${reporter_is_valid} EQUAL -1)
-  message(FATAL_ERROR
-    "\"${reporter}\" is not a valid reporter!\n"
-  )
-endif()
-
-# Prepare reporter
-if(reporter)
-  set(reporter_arg "--reporter ${reporter}")
-endif()
-
-# Prepare output dir
-if(output_dir AND NOT IS_ABSOLUTE ${output_dir})
-  set(output_dir "${TEST_WORKING_DIR}/${output_dir}")
-  if(NOT EXISTS ${output_dir})
-    file(MAKE_DIRECTORY ${output_dir})
-  endif()
-endif()
-
-# Parse output
-foreach(line ${output})
-  set(test ${line})
-  # Escape characters in test case names that would be parsed by Catch2
-  set(test_name ${test})
-  foreach(char , [ ])
-    string(REPLACE ${char} "\\${char}" test_name ${test_name})
-  endforeach(char)
-  # ...add output dir
-  if(output_dir)
-    string(REGEX REPLACE "[^A-Za-z0-9_]" "_" test_name_clean ${test_name})
-    set(output_dir_arg "--out ${output_dir}/${output_prefix}${test_name_clean}${output_suffix}")
-  endif()
-
-  # ...and add to script
-  add_command(add_test
-    "${prefix}${test}${suffix}"
-    ${TEST_EXECUTOR}
-    "${TEST_EXECUTABLE}"
-    "${test_name}"
-    ${extra_args}
-    "${reporter_arg}"
-    "${output_dir_arg}"
-  )
-  add_command(set_tests_properties
-    "${prefix}${test}${suffix}"
-    PROPERTIES
-    WORKING_DIRECTORY "${TEST_WORKING_DIR}"
-    ${properties}
-  )
-  list(APPEND tests "${prefix}${test}${suffix}")
-endforeach()
-
-# Create a list of all discovered tests, which users may use to e.g. set
-# properties on the tests
-add_command(set ${TEST_LIST} ${tests})
-
-# Write CTest script
-file(WRITE "${CTEST_FILE}" "${script}")

cmake/CheckAtomic.cmake

@@ -1,11 +1,3 @@
-#
-# This was originally part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-# See (https://llvm.org/)LICENSE.txt for license information.
-# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-#
-# Modifications have been made to suit building OpenTTD.
-#
-
 # atomic builtins are required for threading support.
 
 INCLUDE(CheckCXXSourceCompiles)
@@ -56,8 +48,6 @@ else()
   check_working_cxx_atomics(HAVE_CXX_ATOMICS_WITHOUT_LIB)
   # If not, check if the library exists, and atomics work with it.
   if(NOT HAVE_CXX_ATOMICS_WITHOUT_LIB)
-    # check_library_exists requires the C-compiler as the atomic functions are built-in declared.
-    enable_language(C)
     check_library_exists(atomic __atomic_fetch_add_4 "" HAVE_LIBATOMIC)
     if(HAVE_LIBATOMIC)
       list(APPEND CMAKE_REQUIRED_LIBRARIES "atomic")
@@ -79,8 +69,6 @@ else()
   check_working_cxx_atomics64(HAVE_CXX_ATOMICS64_WITHOUT_LIB)
   # If not, check if the library exists, and atomics work with it.
   if(NOT HAVE_CXX_ATOMICS64_WITHOUT_LIB)
-    # check_library_exists requires the C-compiler as the atomic functions are built-in declared.
-    enable_language(C)
     check_library_exists(atomic __atomic_load_8 "" HAVE_CXX_LIBATOMICS64)
     if(HAVE_CXX_LIBATOMICS64)
       list(APPEND CMAKE_REQUIRED_LIBRARIES "atomic")
@@ -95,5 +83,5 @@ else()
 endif()
 
 if(HAVE_CXX_ATOMICS_WITH_LIB OR HAVE_CXX_ATOMICS64_WITH_LIB)
-  target_link_libraries(openttd_lib atomic)
+  target_link_libraries(openttd atomic)
 endif()

cmake/CompileFlags.cmake

@@ -4,26 +4,35 @@
 #
 macro(compile_flags)
     if(MSVC)
+        if(VCPKG_TARGET_TRIPLET MATCHES "-static" AND NOT VCPKG_TARGET_TRIPLET MATCHES "-md")
+            # Switch to MT (static) instead of MD (dynamic) binary
+
+            # For MSVC two generators are available
+            # - a command line generator (Ninja) using CMAKE_BUILD_TYPE to specify the
+            #   configuration of the build tree
+            # - an IDE generator (Visual Studio) using CMAKE_CONFIGURATION_TYPES to
+            #   specify all configurations that will be available in the generated solution
+            list(APPEND MSVC_CONFIGS "${CMAKE_BUILD_TYPE}" "${CMAKE_CONFIGURATION_TYPES}")
+
+            # Set usage of static runtime for all configurations
+            foreach(MSVC_CONFIG ${MSVC_CONFIGS})
+                string(TOUPPER "CMAKE_CXX_FLAGS_${MSVC_CONFIG}" MSVC_FLAGS)
+                string(REPLACE "/MD" "/MT" ${MSVC_FLAGS} "${${MSVC_FLAGS}}")
+            endforeach()
+        endif()
+
         # "If /Zc:rvalueCast is specified, the compiler follows section 5.4 of the
         # C++11 standard". We need C++11 for the way we use threads.
         add_compile_options(/Zc:rvalueCast)
 
         if(NOT CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
             add_compile_options(
-                /Zc:preprocessor # Needed for __VA_OPT__() in macros.
                 /MP # Enable multi-threaded compilation.
                 /FC # Display the full path of source code files passed to the compiler in diagnostics.
             )
         endif()
     endif()
 
-    # Our strings are UTF-8.
-    if(MSVC)
-        add_compile_options(/utf-8)
-    else()
-        add_compile_options(-finput-charset=utf-8)
-    endif()
-
     # Add some -D flags for Debug builds. We cannot use add_definitions(), because
     # it does not appear to support the $<> tags.
     add_compile_options(
@@ -46,21 +55,12 @@ macro(compile_flags)
     set(IS_STABLE_RELEASE "$<AND:$<NOT:$<CONFIG:Debug>>,$<NOT:$<BOOL:${OPTION_USE_ASSERTS}>>>")
 
     if(MSVC)
-        add_compile_options(
-            /W3
-            /w34100 # 'identifier' : unreferenced formal parameter
-            /w34189 # 'identifier' : local variable is initialized but not referenced
-        )
-        if(MSVC_VERSION GREATER 1929 AND MSVC_VERSION LESS 1937 AND CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
-            # Starting with version 19.30 (fixed in version 19.37), there is an optimisation bug, see #9966 for details
+        add_compile_options(/W3)
+        if(MSVC_VERSION GREATER 1929 AND CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
+            # Starting with version 19.30, there is an optimisation bug, see #9966 for details
             # This flag disables the broken optimisation to work around the bug
             add_compile_options(/d2ssa-rse-)
         endif()
-        if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-            add_compile_options(
-                -Wno-multichar
-            )
-        endif()
     elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
         add_compile_options(
             -W
@@ -76,12 +76,35 @@ macro(compile_flags)
             -Wformat=2
             -Winit-self
             -Wnon-virtual-dtor
-            -Wsuggest-override
 
+            # Often parameters are unused, which is fine.
+            -Wno-unused-parameter
             # We use 'ABCD' multichar for SaveLoad chunks identifiers
             -Wno-multichar
+
+            # Compilers complains about that we break strict-aliasing.
+            #  On most places we don't see how to fix it, and it doesn't
+            #  break anything. So disable strict-aliasing to make the
+            #  compiler all happy.
+            -fno-strict-aliasing
         )
 
+        # When we are a stable release (Release build + USE_ASSERTS not set),
+        # assertations are off, which trigger a lot of warnings. We disable
+        # these warnings for these releases.
+        if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+            add_compile_options(
+                "$<${IS_STABLE_RELEASE}:-Wno-unused-variable>"
+                "$<${IS_STABLE_RELEASE}:-Wno-unused-but-set-parameter>"
+                "$<${IS_STABLE_RELEASE}:-Wno-unused-but-set-variable>"
+            )
+        else()
+            add_compile_options(
+                "$<${IS_STABLE_RELEASE}:-Wno-unused-variable>"
+                "$<${IS_STABLE_RELEASE}:-Wno-unused-parameter>"
+            )
+        endif()
+
         # Ninja processes the output so the output from the compiler
         # isn't directly to a terminal; hence, the default is
         # non-coloured output. We can override this to get nicely

cmake/CreateGrfCommand.cmake

@@ -1,13 +1,16 @@
 # Macro which contains all bits and pieces to create a single grf file based
 # on NFO and PNG files.
 #
-# create_grf_command(NFO_SOURCE_FILES nfo_file1 ... PNG_SOURCE_FILES png_file1 ...)
+# create_grf_command()
 #
 function(create_grf_command)
-    cmake_parse_arguments(GRF "" "" "NFO_SOURCE_FILES;PNG_SOURCE_FILES" ${ARGN})
+    set(EXTRA_PNG_SOURCE_FILES ${ARGV})
 
     get_filename_component(GRF_SOURCE_FOLDER_NAME "${CMAKE_CURRENT_SOURCE_DIR}" NAME)
     get_filename_component(GRF_BINARY_FILE ${CMAKE_CURRENT_SOURCE_DIR}/../${GRF_SOURCE_FOLDER_NAME}.grf ABSOLUTE)
+    file(GLOB_RECURSE GRF_PNG_SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/*.png)
+    file(GLOB_RECURSE GRF_NFO_SOURCE_FILES ${CMAKE_CURRENT_SOURCE_DIR}/*.nfo)
+    set(GRF_PNG_SOURCE_FILES ${GRF_PNG_SOURCE_FILES} ${EXTRA_PNG_SOURCE_FILES})
 
     # Copy over all the PNG files to the correct folder
     foreach(GRF_PNG_SOURCE_FILE IN LISTS GRF_PNG_SOURCE_FILES)
@@ -25,13 +28,12 @@ function(create_grf_command)
         list(APPEND GRF_PNG_BINARY_FILES ${GRF_PNG_BINARY_FILE})
     endforeach()
 
-    add_custom_command(OUTPUT ${GRF_BINARY_FILE} ${GRF_BINARY_FILE}.hash
+    add_custom_command(OUTPUT ${GRF_BINARY_FILE}
             COMMAND ${CMAKE_COMMAND}
                     -DGRF_SOURCE_FOLDER=${CMAKE_CURRENT_SOURCE_DIR}
                     -DGRF_BINARY_FILE=${GRF_BINARY_FILE}
                     -DNFORENUM_EXECUTABLE=${NFORENUM_EXECUTABLE}
                     -DGRFCODEC_EXECUTABLE=${GRFCODEC_EXECUTABLE}
-                    -DGRFID_EXECUTABLE=${GRFID_EXECUTABLE}
                     -P ${CMAKE_SOURCE_DIR}/cmake/scripts/CreateGRF.cmake
             MAIN_DEPENDENCY ${CMAKE_SOURCE_DIR}/cmake/scripts/CreateGRF.cmake
             DEPENDS ${GRF_PNG_BINARY_FILES}

cmake/CreateRegression.cmake

@@ -3,15 +3,20 @@
 # 'ctest'. The first is prefered, as it is more verbose, and takes care of
 # dependencies correctly.
 #
-# create_regression(file1 ...)
+# create_regression()
 #
 macro(create_regression)
-    set(REGRESSION_SOURCE_FILES ${ARGN})
-
+    # Find all the files in the regression folder; they need to be copied to the
+    # build folder before we can run the regression
+    file(GLOB_RECURSE REGRESSION_SOURCE_FILES ${CMAKE_SOURCE_DIR}/regression/*)
     foreach(REGRESSION_SOURCE_FILE IN LISTS REGRESSION_SOURCE_FILES)
         string(REPLACE "${CMAKE_SOURCE_DIR}/regression/" "" REGRESSION_SOURCE_FILE_NAME "${REGRESSION_SOURCE_FILE}")
         string(CONCAT REGRESSION_BINARY_FILE "${CMAKE_BINARY_DIR}/ai/" "${REGRESSION_SOURCE_FILE_NAME}")
 
+        if("${REGRESSION_SOURCE_FILE_NAME}" STREQUAL "regression.cfg")
+            continue()
+        endif()
+
         add_custom_command(OUTPUT ${REGRESSION_BINARY_FILE}
                 COMMAND ${CMAKE_COMMAND} -E copy
                         ${REGRESSION_SOURCE_FILE}
@@ -23,36 +28,59 @@ macro(create_regression)
         list(APPEND REGRESSION_BINARY_FILES ${REGRESSION_BINARY_FILE})
     endforeach()
 
-    get_filename_component(REGRESSION_TEST_NAME "${CMAKE_CURRENT_SOURCE_DIR}" NAME)
+    # Copy the regression configuration in a special folder, so all autogenerated
+    # folders end up in the same place after running regression.
+    add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/regression/regression.cfg
+            COMMAND ${CMAKE_COMMAND} -E copy
+                    ${CMAKE_SOURCE_DIR}/regression/regression.cfg
+                    ${CMAKE_BINARY_DIR}/regression/regression.cfg
+            MAIN_DEPENDENCY ${CMAKE_SOURCE_DIR}/regression/regression.cfg
+            COMMENT "Copying ${REGRESSION_SOURCE_FILE_NAME} regression file"
+    )
+    list(APPEND REGRESSION_BINARY_FILES ${CMAKE_BINARY_DIR}/regression/regression.cfg)
 
-    # Create a new target which copies regression files
-    add_custom_target(regression_${REGRESSION_TEST_NAME}_files
+    # Create a new target which copies all regression files
+    add_custom_target(regression_files
+            ALL  # this is needed because 'make test' doesn't resolve dependencies, and otherwise this is never executed
             DEPENDS
             ${REGRESSION_BINARY_FILES}
     )
 
-    add_dependencies(regression_files regression_${REGRESSION_TEST_NAME}_files)
+    enable_testing()
 
-    add_custom_target(regression_${REGRESSION_TEST_NAME}
-            COMMAND ${CMAKE_COMMAND}
-                    -DOPENTTD_EXECUTABLE=$<TARGET_FILE:openttd>
-                    -DEDITBIN_EXECUTABLE=${EDITBIN_EXECUTABLE}
-                    -DREGRESSION_TEST=${REGRESSION_TEST_NAME}
-                    -P "${CMAKE_SOURCE_DIR}/cmake/scripts/Regression.cmake"
-            DEPENDS openttd regression_${REGRESSION_TEST_NAME}_files
-            WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
-            COMMENT "Running regression test ${REGRESSION_TEST_NAME}"
-    )
+    # Find all the tests we have, and create a target for them
+    file(GLOB REGRESSION_TESTS ${CMAKE_SOURCE_DIR}/regression/*)
+    foreach(REGRESSION_TEST IN LISTS REGRESSION_TESTS)
+        get_filename_component(REGRESSION_TEST_NAME "${REGRESSION_TEST}" NAME)
 
-    # Also make sure that 'make test' runs the regression
-    add_test(NAME regression_${REGRESSION_TEST_NAME}
-            COMMAND ${CMAKE_COMMAND}
-                    -DOPENTTD_EXECUTABLE=$<TARGET_FILE:openttd>
-                    -DEDITBIN_EXECUTABLE=${EDITBIN_EXECUTABLE}
-                    -DREGRESSION_TEST=${REGRESSION_TEST_NAME}
-                    -P "${CMAKE_SOURCE_DIR}/cmake/scripts/Regression.cmake"
-            WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
-    )
+        if("${REGRESSION_TEST_NAME}" STREQUAL "regression.cfg")
+            continue()
+        endif()
 
-    add_dependencies(regression regression_${REGRESSION_TEST_NAME})
+        add_custom_target(regression_${REGRESSION_TEST_NAME}
+                COMMAND ${CMAKE_COMMAND}
+                        -DOPENTTD_EXECUTABLE=$<TARGET_FILE:openttd>
+                        -DEDITBIN_EXECUTABLE=${EDITBIN_EXECUTABLE}
+                        -DREGRESSION_TEST=${REGRESSION_TEST_NAME}
+                        -P "${CMAKE_SOURCE_DIR}/cmake/scripts/Regression.cmake"
+                DEPENDS openttd regression_files
+                WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
+                COMMENT "Running regression test ${REGRESSION_TEST_NAME}"
+                )
+
+        # Also make sure that 'make test' runs the regression
+        add_test(NAME regression_${REGRESSION_TEST_NAME}
+                COMMAND ${CMAKE_COMMAND}
+                        -DOPENTTD_EXECUTABLE=$<TARGET_FILE:openttd>
+                        -DEDITBIN_EXECUTABLE=${EDITBIN_EXECUTABLE}
+                        -DREGRESSION_TEST=${REGRESSION_TEST_NAME}
+                        -P "${CMAKE_SOURCE_DIR}/cmake/scripts/Regression.cmake"
+                WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
+
+        list(APPEND REGRESSION_TARGETS regression_${REGRESSION_TEST_NAME})
+    endforeach()
+
+    # Create a new target which runs the regression
+    add_custom_target(regression
+            DEPENDS ${REGRESSION_TARGETS})
 endmacro()

cmake/FindGrfcodec.cmake

@@ -2,7 +2,6 @@
 #
 
 find_program(GRFCODEC_EXECUTABLE grfcodec)
-find_program(GRFID_EXECUTABLE grfid)
 find_program(NFORENUM_EXECUTABLE nforenum)
 
 include(FindPackageHandleStandardArgs)
@@ -10,6 +9,5 @@ find_package_handle_standard_args(Grfcodec
     FOUND_VAR GRFCODEC_FOUND
     REQUIRED_VARS
         GRFCODEC_EXECUTABLE
-        GRFID_EXECUTABLE
         NFORENUM_EXECUTABLE
 )

cmake/FindHarfbuzz.cmake

@@ -1,65 +0,0 @@
-#[=======================================================================[.rst:
-FindHarfBuzz
--------
-
-Finds the harfbuzz library.
-
-Result Variables
-^^^^^^^^^^^^^^^^
-
-This will define the following variables:
-
-``Harfbuzz_FOUND``
-  True if the system has the harfbuzz library.
-``Harfbuzz_INCLUDE_DIRS``
-  Include directories needed to use harfbuzz.
-``Harfbuzz_LIBRARIES``
-  Libraries needed to link to harfbuzz.
-``Harfbuzz_VERSION``
-  The version of the harfbuzz library which was found.
-
-Cache Variables
-^^^^^^^^^^^^^^^
-
-The following cache variables may also be set:
-
-``Harfbuzz_INCLUDE_DIR``
-  The directory containing ``hb.h``.
-``Harfbuzz_LIBRARY``
-  The path to the harfbuzz library.
-
-#]=======================================================================]
-
-find_package(PkgConfig QUIET)
-pkg_check_modules(PC_Harfbuzz QUIET harfbuzz)
-
-find_path(Harfbuzz_INCLUDE_DIR
-    NAMES hb.h
-    PATHS ${PC_Harfbuzz_INCLUDE_DIRS}
-)
-
-find_library(Harfbuzz_LIBRARY
-    NAMES harfbuzz
-    PATHS ${PC_Harfbuzz_LIBRARY_DIRS}
-)
-
-set(Harfbuzz_VERSION ${PC_Harfbuzz_VERSION})
-
-include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(Harfbuzz
-    FOUND_VAR Harfbuzz_FOUND
-    REQUIRED_VARS
-        Harfbuzz_LIBRARY
-        Harfbuzz_INCLUDE_DIR
-    VERSION_VAR Harfbuzz_VERSION
-)
-
-if(Harfbuzz_FOUND)
-    set(Harfbuzz_LIBRARIES ${Harfbuzz_LIBRARY})
-    set(Harfbuzz_INCLUDE_DIRS ${Harfbuzz_INCLUDE_DIR})
-endif()
-
-mark_as_advanced(
-    Harfbuzz_INCLUDE_DIR
-    Harfbuzz_LIBRARY
-)

cmake/FindICU.cmake

@@ -9,7 +9,7 @@ FindICU
 
 Finds components of the ICU library.
 
-Accepted components are: uc, i18n, le, lx, io, data
+Accepted components are: uc, i18n, le, lx, io
 
 Result Variables
 ^^^^^^^^^^^^^^^^
@@ -31,7 +31,7 @@ This will define the following variables:
 
 find_package(PkgConfig QUIET)
 
-set(ICU_KNOWN_COMPONENTS "uc" "i18n" "le" "lx" "io" "data")
+set(ICU_KNOWN_COMPONENTS "uc" "i18n" "le" "lx" "io")
 
 foreach(MOD_NAME IN LISTS ICU_FIND_COMPONENTS)
     if(NOT MOD_NAME IN_LIST ICU_KNOWN_COMPONENTS)

cmake/FindLZO.cmake

@@ -55,7 +55,7 @@ find_library(LZO_LIBRARY
 # name as the optimized file. This is not always the case, but so far
 # experiences has shown that in those case vcpkg CMake files do the right
 # thing.
-if(VCPKG_TOOLCHAIN AND LZO_LIBRARY AND LZO_LIBRARY MATCHES "${VCPKG_INSTALLED_DIR}")
+if(VCPKG_TOOLCHAIN AND LZO_LIBRARY)
     if(LZO_LIBRARY MATCHES "/debug/")
         set(LZO_LIBRARY_DEBUG ${LZO_LIBRARY})
         string(REPLACE "/debug/lib/" "/lib/" LZO_LIBRARY_RELEASE ${LZO_LIBRARY})

cmake/FindOgg.cmake

@@ -1,37 +0,0 @@
-include(FindPackageHandleStandardArgs)
-
-find_library(Ogg_LIBRARY
-    NAMES ogg
-)
-
-set(Ogg_COMPILE_OPTIONS "" CACHE STRING "Extra compile options of ogg")
-
-set(Ogg_LINK_LIBRARIES "" CACHE STRING "Extra link libraries of ogg")
-
-set(Ogg_LINK_FLAGS "" CACHE STRING "Extra link flags of ogg")
-
-find_path(Ogg_INCLUDE_PATH
-    NAMES ogg.h
-    PATH_SUFFIXES ogg
-)
-
-find_package_handle_standard_args(Ogg
-    REQUIRED_VARS Ogg_LIBRARY Ogg_INCLUDE_PATH
-)
-
-if (Ogg_FOUND)
-    set(Ogg_dirs ${Ogg_INCLUDE_PATH})
-    if(EXISTS "${Ogg_INCLUDE_PATH}/ogg")
-        list(APPEND Ogg_dirs "${Ogg_INCLUDE_PATH}/ogg")
-    endif()
-    if (NOT TARGET Ogg::ogg)
-        add_library(Ogg::ogg UNKNOWN IMPORTED)
-        set_target_properties(Ogg::ogg PROPERTIES
-            IMPORTED_LOCATION "${Ogg_LIBRARY}"
-            INTERFACE_INCLUDE_DIRECTORIES "${Ogg_dirs}"
-            INTERFACE_COMPILE_OPTIONS "${Ogg_COMPILE_OPTIONS}"
-            INTERFACE_LINK_LIBRARIES "${Ogg_LINK_LIBRARIES}"
-            INTERFACE_LINK_FLAGS "${Ogg_LINK_FLAGS}"
-        )
-    endif()
-endif()

cmake/FindOpus.cmake

@@ -1,37 +0,0 @@
-include(FindPackageHandleStandardArgs)
-
-find_library(Opus_LIBRARY
-    NAMES opus
-)
-
-set(Opus_COMPILE_OPTIONS "" CACHE STRING "Extra compile options of opus")
-
-set(Opus_LINK_LIBRARIES "" CACHE STRING "Extra link libraries of opus")
-
-set(Opus_LINK_FLAGS "" CACHE STRING "Extra link flags of opus")
-
-find_path(Opus_INCLUDE_PATH
-    NAMES opus.h
-    PATH_SUFFIXES opus
-)
-
-find_package_handle_standard_args(Opus
-    REQUIRED_VARS Opus_LIBRARY Opus_INCLUDE_PATH
-)
-
-if (Opus_FOUND)
-    set(Opus_dirs ${Opus_INCLUDE_PATH})
-    if(EXISTS "${Opus_INCLUDE_PATH}/opus")
-        list(APPEND Opus_dirs "${Opus_INCLUDE_PATH}/opus")
-    endif()
-    if (NOT TARGET Opus::opus)
-        add_library(Opus::opus UNKNOWN IMPORTED)
-        set_target_properties(Opus::opus PROPERTIES
-            IMPORTED_LOCATION "${Opus_LIBRARY}"
-            INTERFACE_INCLUDE_DIRECTORIES "${Opus_dirs}"
-            INTERFACE_COMPILE_OPTIONS "${Opus_COMPILE_OPTIONS}"
-            INTERFACE_LINK_LIBRARIES "${Opus_LINK_LIBRARIES}"
-            INTERFACE_LINK_FLAGS "${Opus_LINK_FLAGS}"
-        )
-    endif()
-endif()

cmake/FindOpusFile.cmake

@@ -1,40 +0,0 @@
-include(FindPackageHandleStandardArgs)
-
-find_library(OpusFile_LIBRARY
-    NAMES opusfile
-)
-
-set(OpusFile_COMPILE_OPTIONS "" CACHE STRING "Extra compile options of opusfile")
-
-set(OpusFile_LINK_LIBRARIES "" CACHE STRING "Extra link libraries of opusfile")
-
-set(OpusFile_LINK_FLAGS "" CACHE STRING "Extra link flags of opusfile")
-
-find_path(OpusFile_INCLUDE_PATH
-    NAMES opusfile.h
-    PATH_SUFFIXES opus
-)
-
-find_package_handle_standard_args(OpusFile
-    REQUIRED_VARS OpusFile_LIBRARY OpusFile_INCLUDE_PATH
-)
-
-find_package(Ogg)
-find_package(Opus)
-
-if (OpusFile_FOUND)
-    set(OpusFile_dirs ${OpusFile_INCLUDE_PATH})
-    if(EXISTS "${OpusFile_INCLUDE_PATH}/opus")
-        list(APPEND OpusFile_dirs "${OpusFile_INCLUDE_PATH}/opus")
-    endif()
-    if (NOT TARGET OpusFile::opusfile)
-        add_library(OpusFile::opusfile UNKNOWN IMPORTED)
-        set_target_properties(OpusFile::opusfile PROPERTIES
-            IMPORTED_LOCATION "${OpusFile_LIBRARY}"
-            INTERFACE_INCLUDE_DIRECTORIES "${OpusFile_dirs}"
-            INTERFACE_COMPILE_OPTIONS "${OpusFile_COMPILE_OPTIONS}"
-            INTERFACE_LINK_LIBRARIES "Ogg::ogg;Opus::opus;${OpusFile_LINK_LIBRARIES}"
-            INTERFACE_LINK_FLAGS "${OpusFile_LINK_FLAGS}"
-        )
-    endif()
-endif()

cmake/InstallAndPackage.cmake

@@ -23,55 +23,24 @@ install(TARGETS openttd
             COMPONENT Runtime
         )
 
-if (NOT EMSCRIPTEN)
-    # Emscripten embeds these files in openttd.data.
-    # See CMakeLists.txt in the root.
-    install(DIRECTORY
-                    ${CMAKE_BINARY_DIR}/lang
-                    ${CMAKE_BINARY_DIR}/baseset
-                    ${CMAKE_BINARY_DIR}/ai
-                    ${CMAKE_BINARY_DIR}/game
-                    ${CMAKE_SOURCE_DIR}/bin/scripts
-            DESTINATION ${DATA_DESTINATION_DIR}
-            COMPONENT language_files
-            REGEX "ai/[^\.]+$" EXCLUDE # Ignore subdirs in ai dir
-    )
-else()
-    install(FILES
-                ${CMAKE_BINARY_DIR}/openttd.js
-                ${CMAKE_BINARY_DIR}/openttd.wasm
-                ${CMAKE_BINARY_DIR}/openttd.data
-            DESTINATION ${BINARY_DESTINATION_DIR}
-            COMPONENT Runtime
-    )
-endif()
+install(DIRECTORY
+                ${CMAKE_BINARY_DIR}/lang
+                ${CMAKE_BINARY_DIR}/baseset
+                ${CMAKE_BINARY_DIR}/ai
+                ${CMAKE_BINARY_DIR}/game
+                ${CMAKE_SOURCE_DIR}/bin/scripts
+        DESTINATION ${DATA_DESTINATION_DIR}
+        COMPONENT language_files
+        REGEX "ai/[^\.]+$" EXCLUDE # Ignore subdirs in ai dir
+)
 
 install(FILES
                 ${CMAKE_SOURCE_DIR}/COPYING.md
                 ${CMAKE_SOURCE_DIR}/README.md
-                ${CMAKE_SOURCE_DIR}/CREDITS.md
-                ${CMAKE_SOURCE_DIR}/CONTRIBUTING.md
-                ${CMAKE_SOURCE_DIR}/changelog.md
-                ${CMAKE_SOURCE_DIR}/known-bugs.md
-        DESTINATION ${DOCS_DESTINATION_DIR}
-        COMPONENT docs)
-
-install(FILES
-                ${CMAKE_SOURCE_DIR}/docs/admin_network.md
-                ${CMAKE_SOURCE_DIR}/docs/debugging_desyncs.md
-                ${CMAKE_SOURCE_DIR}/docs/desync.md
-                ${CMAKE_SOURCE_DIR}/docs/directory_structure.md
-                ${CMAKE_SOURCE_DIR}/docs/eints.md
-                ${CMAKE_SOURCE_DIR}/docs/game_coordinator.md
-                ${CMAKE_SOURCE_DIR}/docs/linkgraph.md
-                ${CMAKE_SOURCE_DIR}/docs/logging_and_performance_metrics.md
+                ${CMAKE_SOURCE_DIR}/changelog.txt
                 ${CMAKE_SOURCE_DIR}/docs/multiplayer.md
-                ${CMAKE_SOURCE_DIR}/docs/savegame_format.md
-                ${CMAKE_SOURCE_DIR}/docs/symbol_server.md
-                ${CMAKE_SOURCE_DIR}/docs/obg_format.txt
-                ${CMAKE_SOURCE_DIR}/docs/obm_format.txt
-                ${CMAKE_SOURCE_DIR}/docs/obs_format.txt
-        DESTINATION ${DOCS_DESTINATION_DIR}/docs
+                ${CMAKE_SOURCE_DIR}/known-bugs.txt
+        DESTINATION ${DOCS_DESTINATION_DIR}
         COMPONENT docs)
 
 # A Linux manual only makes sense when using FHS. Otherwise it is a very odd
@@ -91,7 +60,7 @@ if(OPTION_INSTALL_FHS)
             COMPONENT manual)
 endif()
 
-if(UNIX AND NOT APPLE AND NOT EMSCRIPTEN)
+if(UNIX AND NOT APPLE)
     install(DIRECTORY
                     ${CMAKE_BINARY_DIR}/media/icons
                     ${CMAKE_BINARY_DIR}/media/pixmaps
@@ -172,10 +141,10 @@ elseif(WIN32)
 
     set(CPACK_PACKAGE_FILE_NAME "openttd-#CPACK_PACKAGE_VERSION#-windows-${CPACK_SYSTEM_NAME}")
 
-    if(DEFINED ENV{AZURE_CODESIGN_PROFILE_NAME})
+    if(WINDOWS_CERTIFICATE_COMMON_NAME)
       add_custom_command(TARGET openttd
         POST_BUILD
-        COMMAND "${CMAKE_SOURCE_DIR}/os/windows/sign.bat" "${BINARY_DESTINATION_DIR}"
+        COMMAND "${CMAKE_SOURCE_DIR}/os/windows/sign.bat" "$<TARGET_FILE:openttd>" "${WINDOWS_CERTIFICATE_COMMON_NAME}"
       )
     endif()
 elseif(UNIX)
@@ -195,7 +164,7 @@ elseif(UNIX)
             OUTPUT_STRIP_TRAILING_WHITESPACE
         )
         if(LSB_RELEASE_ID)
-            if(LSB_RELEASE_ID STREQUAL "Ubuntu" OR LSB_RELEASE_ID STREQUAL "Debian" OR LSB_RELEASE_ID STREQUAL "Linuxmint")
+            if(LSB_RELEASE_ID STREQUAL "Ubuntu" OR LSB_RELEASE_ID STREQUAL "Debian")
                 execute_process(COMMAND ${LSB_RELEASE_EXEC} -cs
                     OUTPUT_VARIABLE LSB_RELEASE_CODENAME
                     OUTPUT_STRIP_TRAILING_WHITESPACE
@@ -204,10 +173,6 @@ elseif(UNIX)
 
                 set(CPACK_GENERATOR "DEB")
                 include(PackageDeb)
-            elseif(LSB_RELEASE_ID STREQUAL "Fedora")
-                set(PLATFORM "fedora")
-                set(CPACK_GENERATOR "RPM")
-                include(PackageRPM)
             else()
                 set(UNSUPPORTED_PLATFORM_NAME "LSB-based Linux distribution '${LSB_RELEASE_ID}'")
             endif()

cmake/LinkPackage.cmake

@@ -3,21 +3,18 @@ function(link_package NAME)
 
     if(${NAME}_FOUND)
         string(TOUPPER "${NAME}" UCNAME)
-        # Some libraries have a dash, which is not allowed in a preprocessor macro.
-        string(REPLACE "-" "_" UCNAME "${UCNAME}")
-
         add_definitions(-DWITH_${UCNAME})
         # Some libraries' cmake packages (looking at you, SDL2) leave trailing whitespace in the link commands,
         # which (later) cmake considers to be an error. Work around this with by stripping the incoming string.
         if(LP_TARGET AND TARGET ${LP_TARGET})
             string(STRIP "${LP_TARGET}" LP_TARGET)
-            target_link_libraries(openttd_lib ${LP_TARGET})
+            target_link_libraries(openttd ${LP_TARGET})
             message(STATUS "${NAME} found -- -DWITH_${UCNAME} -- ${LP_TARGET}")
         else()
             string(STRIP "${${NAME}_LIBRARY}" ${NAME}_LIBRARY)
             string(STRIP "${${NAME}_LIBRARIES}" ${NAME}_LIBRARIES)
             include_directories(${${NAME}_INCLUDE_DIRS} ${${NAME}_INCLUDE_DIR})
-            target_link_libraries(openttd_lib ${${NAME}_LIBRARIES} ${${NAME}_LIBRARY})
+            target_link_libraries(openttd ${${NAME}_LIBRARIES} ${${NAME}_LIBRARY})
             message(STATUS "${NAME} found -- -DWITH_${UCNAME} -- ${${NAME}_INCLUDE_DIRS} ${${NAME}_INCLUDE_DIR} -- ${${NAME}_LIBRARIES} ${${NAME}_LIBRARY}")
         endif()
     elseif(LP_ENCOURAGED)

cmake/Options.cmake

@@ -56,17 +56,21 @@ function(set_options)
 
     option(OPTION_DEDICATED "Build dedicated server only (no GUI)" OFF)
     option(OPTION_INSTALL_FHS "Install with Filesystem Hierarchy Standard folders" ${DEFAULT_OPTION_INSTALL_FHS})
-    option(OPTION_USE_ASSERTS "Use assertions; leave enabled for nightlies, betas, and RCs" ON)
+    option(OPTION_USE_ASSERTS "Use assertions; leave enabled for nightlies, betas, and RCs" OFF)
+    if(EMSCRIPTEN)
+        # Although pthreads is supported, it is not in a way yet that is
+        # useful for us.
+        option(OPTION_USE_THREADS "Use threads" OFF)
+    else()
+        option(OPTION_USE_THREADS "Use threads" ON)
+    endif()
     option(OPTION_USE_NSIS "Use NSIS to create windows installer; enable only for stable releases" OFF)
     option(OPTION_TOOLS_ONLY "Build only tools target" OFF)
     option(OPTION_DOCS_ONLY "Build only docs target" OFF)
-    option(OPTION_ALLOW_INVALID_SIGNATURE "Allow loading of content with invalid signatures" OFF)
 
     if (OPTION_DOCS_ONLY)
         set(OPTION_TOOLS_ONLY ON PARENT_SCOPE)
     endif()
-
-    option(OPTION_SURVEY_KEY "Survey-key to use for the opt-in survey (empty if you have none)" "")
 endfunction()
 
 # Show the values of the generic options.
@@ -78,18 +82,8 @@ function(show_options)
     message(STATUS "Option Dedicated - ${OPTION_DEDICATED}")
     message(STATUS "Option Install FHS - ${OPTION_INSTALL_FHS}")
     message(STATUS "Option Use assert - ${OPTION_USE_ASSERTS}")
+    message(STATUS "Option Use threads - ${OPTION_USE_THREADS}")
     message(STATUS "Option Use NSIS - ${OPTION_USE_NSIS}")
-
-    if(OPTION_SURVEY_KEY)
-        message(STATUS "Option Survey Key - USED")
-    else()
-        message(STATUS "Option Survey Key - NOT USED")
-    endif()
-
-    if(OPTION_ALLOW_INVALID_SIGNATURE)
-        message(STATUS "Option Allow Invalid Signature - USED")
-        message(WARNING "Ignoring invalid signatures is a security risk! Use with care!")
-    endif()
 endfunction()
 
 # Add the definitions for the options that are selected.
@@ -101,17 +95,13 @@ function(add_definitions_based_on_options)
         add_definitions(-DDEDICATED)
     endif()
 
+    if(NOT OPTION_USE_THREADS)
+        add_definitions(-DNO_THREADS)
+    endif()
+
     if(OPTION_USE_ASSERTS)
         add_definitions(-DWITH_ASSERT)
     else()
         add_definitions(-DNDEBUG)
     endif()
-
-    if(OPTION_SURVEY_KEY)
-        add_definitions(-DSURVEY_KEY="${OPTION_SURVEY_KEY}")
-    endif()
-
-    if(OPTION_ALLOW_INVALID_SIGNATURE)
-        add_definitions(-DALLOW_INVALID_SIGNATURE)
-    endif()
 endfunction()

cmake/PackageBundle.cmake

@@ -4,7 +4,6 @@ set(CPACK_BUNDLE_NAME "OpenTTD")
 set(CPACK_BUNDLE_ICON "${CMAKE_SOURCE_DIR}/os/macosx/openttd.icns")
 set(CPACK_BUNDLE_PLIST "${CMAKE_CURRENT_BINARY_DIR}/Info.plist")
 set(CPACK_DMG_BACKGROUND_IMAGE "${CMAKE_SOURCE_DIR}/os/macosx/splash.png")
-set(CPACK_BUNDLE_APPLE_ENTITLEMENTS "${CMAKE_SOURCE_DIR}/os/macosx/openttd.entitlements")
 set(CPACK_DMG_FORMAT "UDBZ")
 
 # Create a temporary Info.plist.in, where we will fill in the version via

cmake/SourceList.cmake

@@ -1,4 +1,12 @@
-function(_add_files_tgt tgt)
+# Add a file to be compiled.
+#
+# add_files([file1 ...] CONDITION condition [condition ...])
+#
+# CONDITION is a complete statement that can be evaluated with if().
+# If it evaluates true, the source files will be added; otherwise not.
+# For example: ADD_IF SDL_FOUND AND Allegro_FOUND
+#
+function(add_files)
     cmake_parse_arguments(PARAM "" "" "CONDITION" ${ARGN})
     set(PARAM_FILES "${PARAM_UNPARSED_ARGUMENTS}")
 
@@ -9,44 +17,10 @@ function(_add_files_tgt tgt)
     endif()
 
     foreach(FILE IN LISTS PARAM_FILES)
-        # Some IDEs are not happy with duplicated filenames, so we detect that before adding the file.
-        get_target_property(${tgt}_FILES ${tgt} SOURCES)
-        if(${tgt}_FILES MATCHES "/${FILE}(;|$)")
-            string(REGEX REPLACE "(^|.+;)([^;]+/${FILE})(;.+|$)" "\\2" RES "${${tgt}_FILES}")
-            # Ignore header files duplicates in 3rdparty.
-            if(NOT (${FILE} MATCHES "\.h" AND (${RES} MATCHES "3rdparty" OR ${CMAKE_CURRENT_SOURCE_DIR} MATCHES "3rdparty")))
-                message(FATAL_ERROR "${tgt}: ${CMAKE_CURRENT_SOURCE_DIR}/${FILE} filename is a duplicate of ${RES}")
-            endif()
-        endif()
-
-        target_sources(${tgt} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/${FILE})
+        target_sources(openttd PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/${FILE})
     endforeach()
 endfunction()
 
-# Add a file to be compiled.
-#
-# add_files([file1 ...] CONDITION condition [condition ...])
-#
-# CONDITION is a complete statement that can be evaluated with if().
-# If it evaluates true, the source files will be added; otherwise not.
-# For example: ADD_IF SDL_FOUND AND Allegro_FOUND
-#
-function(add_files)
-    _add_files_tgt(openttd_lib ${ARGV})
-endfunction()
-
-# Add a test file to be compiled.
-#
-# add_test_files([file1 ...] CONDITION condition [condition ...])
-#
-# CONDITION is a complete statement that can be evaluated with if().
-# If it evaluates true, the source files will be added; otherwise not.
-# For example: ADD_IF SDL_FOUND AND Allegro_FOUND
-#
-function(add_test_files)
-    _add_files_tgt(openttd_test ${ARGV})
-endfunction()
-
 # This function works around an 'issue' with CMake, where
 # set_source_files_properties() only works in the scope of the file. We want
 # to set properties for the source file on a more global level. To solve this,

cmake/scripts/Baseset.cmake

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 #
 # Create a single baseset meta file with the correct translations.
@@ -58,7 +58,6 @@ list(SORT ${PLACE_HOLDER})
 string(REPLACE ";" "\n" ${PLACE_HOLDER} "${${PLACE_HOLDER}}")
 
 # Get the grf md5
-file(READ ${BASESET_EXTRAGRF_FILE}.hash ORIG_EXTRA_GRF_MD5)
-string(STRIP ${ORIG_EXTRA_GRF_MD5} ORIG_EXTRA_GRF_MD5)
+file(MD5 ${BASESET_EXTRAGRF_FILE} ORIG_EXTRA_GRF_MD5)
 
 configure_file(${BASESET_SOURCE_FILE} ${BASESET_BINARY_FILE})

cmake/scripts/CreateGRF.cmake

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 #
 # Create a single GRF file based on sprites/<grfname>.nfo and sprites/*.png
@@ -11,9 +11,6 @@ endif()
 if(NOT GRFCODEC_EXECUTABLE)
     message(FATAL_ERROR "Script needs GRFCODEC_EXECUTABLE defined")
 endif()
-if(NOT GRFID_EXECUTABLE)
-    message(FATAL_ERROR "Script needs GRFID_EXECUTABLE defined")
-endif()
 if(NOT GRF_SOURCE_FOLDER)
     message(FATAL_ERROR "Script needs GRF_SOURCE_FOLDER defined")
 endif()
@@ -21,9 +18,6 @@ if(NOT GRF_BINARY_FILE)
     message(FATAL_ERROR "Script needs GRF_BINARY_FILE defined")
 endif()
 
-# Remove the existing output so failures never go unnoticed
-file(REMOVE ${GRF_BINARY_FILE} ${GRF_BINARY_FILE}.hash)
-
 get_filename_component(GRF_SOURCE_FOLDER_NAME "${GRF_SOURCE_FOLDER}" NAME)
 
 file(WRITE sprites/${GRF_SOURCE_FOLDER_NAME}.nfo "")
@@ -53,7 +47,7 @@ if(RESULT)
     message(FATAL_ERROR "NFORenum failed")
 endif()
 
-execute_process(COMMAND ${GRFCODEC_EXECUTABLE} -n -s -e -g2 -p1 ${GRF_SOURCE_FOLDER_NAME}.grf RESULT_VARIABLE RESULT)
+execute_process(COMMAND ${GRFCODEC_EXECUTABLE} -n -s -e -p1 ${GRF_SOURCE_FOLDER_NAME}.grf RESULT_VARIABLE RESULT)
 if(RESULT)
     if(NOT RESULT MATCHES "^[0-9]*$")
         message(FATAL_ERROR "Failed to run GRFCodec (${RESULT}), please check GRFCODEC_EXECUTABLE variable")
@@ -61,15 +55,4 @@ if(RESULT)
     message(FATAL_ERROR "GRFCodec failed")
 endif()
 
-execute_process(COMMAND ${GRFID_EXECUTABLE} -m ${GRF_SOURCE_FOLDER_NAME}.grf OUTPUT_VARIABLE GRFID_HASH RESULT_VARIABLE RESULT)
-if(RESULT)
-    if(NOT RESULT MATCHES "^[0-9]*$")
-        message(FATAL_ERROR "Failed to run GRFID (${RESULT}), please check GRFID_EXECUTABLE variable")
-    endif()
-    message(FATAL_ERROR "GRFID failed")
-endif()
-
-file(WRITE ${GRF_BINARY_FILE}.hash ${GRFID_HASH})
-
-# Copy build files back to the source directory.
 execute_process(COMMAND ${CMAKE_COMMAND} -E copy ${GRF_SOURCE_FOLDER_NAME}.grf ${GRF_BINARY_FILE})

cmake/scripts/Desktop.cmake

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 #
 # Create a desktop file with the correct translations.

cmake/scripts/FindVersion.cmake

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 if(NOT REV_MAJOR)
     set(REV_MAJOR 0)
@@ -49,14 +49,14 @@ if(GIT_FOUND AND EXISTS "${CMAKE_SOURCE_DIR}/.git")
     string(SUBSTRING "${FULLHASH}" 0 10 SHORTHASH)
 
     # Get the last commit date
-    set(ENV{TZ} "UTC0")
-    execute_process(COMMAND ${GIT_EXECUTABLE} show -s --date=iso-local --pretty=format:%cd HEAD
+    execute_process(COMMAND ${GIT_EXECUTABLE} show -s --pretty=format:%ci HEAD
                     OUTPUT_VARIABLE COMMITDATE
                     OUTPUT_STRIP_TRAILING_WHITESPACE
                     WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
     )
     string(REGEX REPLACE "([0-9]+)-([0-9]+)-([0-9]+).*" "\\1\\2\\3" COMMITDATE "${COMMITDATE}")
     set(REV_ISODATE "${COMMITDATE}")
+    string(SUBSTRING "${REV_ISODATE}" 0 4 REV_YEAR)
 
     # Get the branch
     execute_process(COMMAND ${GIT_EXECUTABLE} symbolic-ref -q HEAD
@@ -113,6 +113,7 @@ elseif(EXISTS "${CMAKE_SOURCE_DIR}/.ottdrev")
     list(GET OTTDREV 3 REV_HASH)
     list(GET OTTDREV 4 REV_ISTAG)
     list(GET OTTDREV 5 REV_ISSTABLETAG)
+    list(GET OTTDREV 6 REV_YEAR)
 else()
     message(WARNING "No version detected; this build will NOT be network compatible")
     set(REV_VERSION "norev0000")
@@ -121,19 +122,14 @@ else()
     set(REV_HASH "unknown")
     set(REV_ISTAG 0)
     set(REV_ISSTABLETAG 0)
+    set(REV_YEAR "1970")
 endif()
 
-# Extract REV_YEAR and REV_DATE from REV_ISODATE
-string(SUBSTRING "${REV_ISODATE}" 0 4 REV_YEAR)
-string(SUBSTRING "${REV_ISODATE}" 4 4 REV_DATE)
-# Drop leading 0 in REV_DATE if any
-string(REGEX REPLACE "^0?([0-9]+)" "\\1" REV_DATE "${REV_DATE}")
-
 message(STATUS "Version string: ${REV_VERSION}")
 
 if(GENERATE_OTTDREV)
     message(STATUS "Generating .ottdrev")
-    file(WRITE ${CMAKE_SOURCE_DIR}/.ottdrev "${REV_VERSION}\t${REV_ISODATE}\t${REV_MODIFIED}\t${REV_HASH}\t${REV_ISTAG}\t${REV_ISSTABLETAG}\n")
+    file(WRITE ${CMAKE_SOURCE_DIR}/.ottdrev "${REV_VERSION}\t${REV_ISODATE}\t${REV_MODIFIED}\t${REV_HASH}\t${REV_ISTAG}\t${REV_ISSTABLETAG}\t${REV_YEAR}\n")
 else()
     message(STATUS "Generating rev.cpp")
     configure_file("${CMAKE_SOURCE_DIR}/src/rev.cpp.in"

cmake/scripts/GenerateWidget.cmake

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 #
 # CMake script to automatically generate the enums in script_window.hpp
@@ -56,14 +56,11 @@ foreach(ENUM IN LISTS ENUM_LINES)
             endif()
 
             # Check for enum match
-            if("${LINE}" MATCHES "^	*enum *${ENUM_PATTERN}( *: *[^ ]*)? *\{")
+            if("${LINE}" MATCHES "^	*enum *${ENUM_PATTERN} *\{")
                 # REGEX REPLACE does a REGEX MATCHALL and fails if an empty string is matched
                 string(REGEX MATCH "[^	]*" RESULT "${LINE}")
                 string(REPLACE "${RESULT}" "" RM_INDENT "${LINE}")
 
-                string(REGEX MATCH " *: *[^ ]*" RESULT "${LINE}")
-                string(REPLACE "${RESULT}" "" LINE "${LINE}")
-
                 set(ACTIVE 1)
                 if(ACTIVE_COMMENT GREATER 0)
                      string(APPEND ${PLACE_HOLDER} "\n${COMMENT}")

cmake/scripts/Regression.cmake

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 #
 # Runs a single regressoion test
@@ -34,6 +34,7 @@ execute_process(COMMAND ${OPENTTD_EXECUTABLE}
                         -mnull
                         -vnull:ticks=30000
                         -d script=2
+                        -d misc=9
                         -Q
                 OUTPUT_VARIABLE REGRESSION_OUTPUT
                 ERROR_VARIABLE REGRESSION_RESULT
@@ -53,27 +54,16 @@ string(REPLACE "0x(nil)" "0x00000000" REGRESSION_RESULT "${REGRESSION_RESULT}")
 string(REPLACE "0x0000000000000000" "0x00000000" REGRESSION_RESULT "${REGRESSION_RESULT}")
 string(REPLACE "0x0x0" "0x00000000" REGRESSION_RESULT "${REGRESSION_RESULT}")
 
-# Convert path separators
-string(REPLACE "\\" "/" REGRESSION_RESULT "${REGRESSION_RESULT}")
-
 # Remove timestamps if any
-string(REGEX REPLACE "\\\[[0-9-]+ [0-9:]+\\\] " "" REGRESSION_RESULT "${REGRESSION_RESULT}")
-
-# Remove log level
-string(REGEX REPLACE "\\\[script:[0-9]\\\]" "" REGRESSION_RESULT "${REGRESSION_RESULT}")
+string(REGEX REPLACE "\[[0-9-]+ [0-9:]+\] " "" REGRESSION_RESULT "${REGRESSION_RESULT}")
 
 # Convert the output to a format that is expected (and more readable) by result.txt
-string(REPLACE "dbg:  " "ERROR: " REGRESSION_RESULT "${REGRESSION_RESULT}")
-string(REPLACE "ERROR: [1] " "" REGRESSION_RESULT "${REGRESSION_RESULT}")
-string(REPLACE "[P] " "" REGRESSION_RESULT "${REGRESSION_RESULT}")
-string(REPLACE "[S] " "" REGRESSION_RESULT "${REGRESSION_RESULT}")
+string(REPLACE "\ndbg: [script]" "\n" REGRESSION_RESULT "${REGRESSION_RESULT}")
+string(REPLACE "\n " "\nERROR: " REGRESSION_RESULT "${REGRESSION_RESULT}")
+string(REPLACE "\nERROR: [1] " "\n" REGRESSION_RESULT "${REGRESSION_RESULT}")
+string(REPLACE "\n[P] " "\n" REGRESSION_RESULT "${REGRESSION_RESULT}")
 string(REGEX REPLACE "dbg: ([^\n]*)\n?" "" REGRESSION_RESULT "${REGRESSION_RESULT}")
 
-# Remove duplicate script info
-string(REGEX REPLACE "ERROR: Registering([^\n]*)\n?" "" REGRESSION_RESULT "${REGRESSION_RESULT}")
-string(REGEX REPLACE "ERROR:   [12]([^\n]*)\n?" "" REGRESSION_RESULT "${REGRESSION_RESULT}")
-string(REGEX REPLACE "ERROR: The first([^\n]*)\n?" "" REGRESSION_RESULT "${REGRESSION_RESULT}")
-
 # Read the expected result
 file(READ ai/${REGRESSION_TEST}/result.txt REGRESSION_EXPECTED)
 
@@ -97,7 +87,7 @@ foreach(RESULT IN LISTS REGRESSION_RESULT)
 
     if(NOT RESULT STREQUAL EXPECTED)
         message("${ARGC}: - ${EXPECTED}")
-        message("${ARGC}: + ${RESULT}")
+        message("${ARGC}: + ${RESULT}'")
         set(ERROR YES)
     endif()
 endforeach()

cmake/scripts/SquirrelExport.cmake

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 if(NOT SCRIPT_API_SOURCE_FILE)
     message(FATAL_ERROR "Script needs SCRIPT_API_SOURCE_FILE defined")
@@ -28,27 +28,25 @@ endmacro()
 macro(dump_class_templates NAME)
     string(REGEX REPLACE "^Script" "" REALNAME ${NAME})
 
-    string(APPEND SQUIRREL_EXPORT "\n	template <> struct Param<${NAME} *> { static inline ${NAME} *Get(HSQUIRRELVM vm, int index) { SQUserPointer instance; sq_getinstanceup(vm, index, &instance, nullptr); return  (${NAME} *)instance; } };")
-    string(APPEND SQUIRREL_EXPORT "\n	template <> struct Param<${NAME} &> { static inline ${NAME} &Get(HSQUIRRELVM vm, int index) { SQUserPointer instance; sq_getinstanceup(vm, index, &instance, nullptr); return *(${NAME} *)instance; } };")
-    string(APPEND SQUIRREL_EXPORT "\n	template <> struct Param<const ${NAME} *> { static inline const ${NAME} *Get(HSQUIRRELVM vm, int index) { SQUserPointer instance; sq_getinstanceup(vm, index, &instance, nullptr); return  (${NAME} *)instance; } };")
-    string(APPEND SQUIRREL_EXPORT "\n	template <> struct Param<const ${NAME} &> { static inline const ${NAME} &Get(HSQUIRRELVM vm, int index) { SQUserPointer instance; sq_getinstanceup(vm, index, &instance, nullptr); return *(${NAME} *)instance; } };")
+    string(APPEND SQUIRREL_EXPORT "\n	template <> inline ${NAME} *GetParam(ForceType<${NAME} *>, HSQUIRRELVM vm, int index, SQAutoFreePointers *ptr) { SQUserPointer instance; sq_getinstanceup(vm, index, &instance, nullptr); return  (${NAME} *)instance; }")
+    string(APPEND SQUIRREL_EXPORT "\n	template <> inline ${NAME} &GetParam(ForceType<${NAME} &>, HSQUIRRELVM vm, int index, SQAutoFreePointers *ptr) { SQUserPointer instance; sq_getinstanceup(vm, index, &instance, nullptr); return *(${NAME} *)instance; }")
+    string(APPEND SQUIRREL_EXPORT "\n	template <> inline const ${NAME} *GetParam(ForceType<const ${NAME} *>, HSQUIRRELVM vm, int index, SQAutoFreePointers *ptr) { SQUserPointer instance; sq_getinstanceup(vm, index, &instance, nullptr); return  (${NAME} *)instance; }")
+    string(APPEND SQUIRREL_EXPORT "\n	template <> inline const ${NAME} &GetParam(ForceType<const ${NAME} &>, HSQUIRRELVM vm, int index, SQAutoFreePointers *ptr) { SQUserPointer instance; sq_getinstanceup(vm, index, &instance, nullptr); return *(${NAME} *)instance; }")
     if("${NAME}" STREQUAL "ScriptEvent")
-        string(APPEND SQUIRREL_EXPORT "\n	template <> struct Return<${NAME} *> { static inline int Set(HSQUIRRELVM vm, ${NAME} *res) { if (res == nullptr) { sq_pushnull(vm); return 1; } Squirrel::CreateClassInstanceVM(vm, \"${REALNAME}\", res, nullptr, DefSQDestructorCallback<${NAME}>, true); return 1; } };")
+        string(APPEND SQUIRREL_EXPORT "\n	template <> inline int Return<${NAME} *>(HSQUIRRELVM vm, ${NAME} *res) { if (res == nullptr) { sq_pushnull(vm); return 1; } Squirrel::CreateClassInstanceVM(vm, \"${REALNAME}\", res, nullptr, DefSQDestructorCallback<${NAME}>, true); return 1; }")
     elseif("${NAME}" STREQUAL "ScriptText")
         string(APPEND SQUIRREL_EXPORT "\n")
-        string(APPEND SQUIRREL_EXPORT "\n	template <> struct Param<Text *> {")
-        string(APPEND SQUIRREL_EXPORT "\n		static inline Text *Get(HSQUIRRELVM vm, int index) {")
-        string(APPEND SQUIRREL_EXPORT "\n			if (sq_gettype(vm, index) == OT_INSTANCE) {")
-        string(APPEND SQUIRREL_EXPORT "\n				return Param<ScriptText *>::Get(vm, index);")
-        string(APPEND SQUIRREL_EXPORT "\n			}")
-        string(APPEND SQUIRREL_EXPORT "\n			if (sq_gettype(vm, index) == OT_STRING) {")
-        string(APPEND SQUIRREL_EXPORT "\n				return new RawText(Param<const std::string &>::Get(vm, index));")
-        string(APPEND SQUIRREL_EXPORT "\n			}")
-        string(APPEND SQUIRREL_EXPORT "\n			return nullptr;")
+        string(APPEND SQUIRREL_EXPORT "\n	template <> inline Text *GetParam(ForceType<Text *>, HSQUIRRELVM vm, int index, SQAutoFreePointers *ptr) {")
+        string(APPEND SQUIRREL_EXPORT "\n		if (sq_gettype(vm, index) == OT_INSTANCE) {")
+        string(APPEND SQUIRREL_EXPORT "\n			return GetParam(ForceType<ScriptText *>(), vm, index, ptr);")
         string(APPEND SQUIRREL_EXPORT "\n		}")
-        string(APPEND SQUIRREL_EXPORT "\n	};")
+        string(APPEND SQUIRREL_EXPORT "\n		if (sq_gettype(vm, index) == OT_STRING) {")
+        string(APPEND SQUIRREL_EXPORT "\n			return new RawText(GetParam(ForceType<const char *>(), vm, index, ptr));")
+        string(APPEND SQUIRREL_EXPORT "\n		}")
+        string(APPEND SQUIRREL_EXPORT "\n		return nullptr;")
+        string(APPEND SQUIRREL_EXPORT "\n	}")
     else()
-        string(APPEND SQUIRREL_EXPORT "\n	template <> struct Return<${NAME} *> { static inline int Set(HSQUIRRELVM vm, ${NAME} *res) { if (res == nullptr) { sq_pushnull(vm); return 1; } res->AddRef(); Squirrel::CreateClassInstanceVM(vm, \"${REALNAME}\", res, nullptr, DefSQDestructorCallback<${NAME}>, true); return 1; } };")
+        string(APPEND SQUIRREL_EXPORT "\n	template <> inline int Return<${NAME} *>(HSQUIRRELVM vm, ${NAME} *res) { if (res == nullptr) { sq_pushnull(vm); return 1; } res->AddRef(); Squirrel::CreateClassInstanceVM(vm, \"${REALNAME}\", res, nullptr, DefSQDestructorCallback<${NAME}>, true); return 1; }")
     endif()
 endmacro()
 
@@ -71,23 +69,13 @@ reset_reader()
 
 file(STRINGS "${SCRIPT_API_FILE}" SOURCE_LINES)
 
-set(NUM_LINE 0)
-macro(doxygen_check)
-    if(NOT "${DOXYGEN_SKIP}" STREQUAL "")
-        message(FATAL_ERROR "${SCRIPT_API_FILE}:${NUM_LINE}: a DOXYGEN_API block was not properly closed")
-    endif()
-endmacro()
-
 foreach(LINE IN LISTS SOURCE_LINES)
-    math(EXPR NUM_LINE "${NUM_LINE} + 1")
     # Ignore special doxygen blocks
     if("${LINE}" MATCHES "^#ifndef DOXYGEN_API")
-        doxygen_check()
         set(DOXYGEN_SKIP "next")
         continue()
     endif()
     if("${LINE}" MATCHES "^#ifdef DOXYGEN_API")
-        doxygen_check()
         set(DOXYGEN_SKIP "true")
         continue()
     endif()
@@ -96,10 +84,10 @@ foreach(LINE IN LISTS SOURCE_LINES)
         continue()
     endif()
     if("${LINE}" MATCHES "^#else")
-        if(DOXYGEN_SKIP STREQUAL "next")
+        if("${DOXYGEN_SKIP}" STREQUAL "next")
             set(DOXYGEN_SKIP "true")
-        elseif(DOXYGEN_SKIP STREQUAL "true")
-            set(DOXYGEN_SKIP "false")
+        else()
+            unset(DOXYGEN_SKIP)
         endif()
         continue()
     endif()
@@ -309,8 +297,8 @@ foreach(LINE IN LISTS SOURCE_LINES)
                 endif()
                 string(APPEND SQUIRREL_EXPORT "\n	/* Allow enums to be used as Squirrel parameters */")
                 foreach(ENUM IN LISTS ENUMS)
-                    string(APPEND SQUIRREL_EXPORT "\n	template <> struct Param<${ENUM}> { static inline ${ENUM} Get(HSQUIRRELVM vm, int index) { SQInteger tmp; sq_getinteger(vm, index, &tmp); return (${ENUM})tmp; } };")
-                    string(APPEND SQUIRREL_EXPORT "\n	template <> struct Return<${ENUM}> { static inline int Set(HSQUIRRELVM vm, ${ENUM} res) { sq_pushinteger(vm, res); return 1; } };")
+                    string(APPEND SQUIRREL_EXPORT "\n	template <> inline ${ENUM} GetParam(ForceType<${ENUM}>, HSQUIRRELVM vm, int index, SQAutoFreePointers *ptr) { SQInteger tmp; sq_getinteger(vm, index, &tmp); return (${ENUM})tmp; }")
+                    string(APPEND SQUIRREL_EXPORT "\n	template <> inline int Return<${ENUM}>(HSQUIRRELVM vm, ${ENUM} res) { sq_pushinteger(vm, (int32)res); return 1; }")
                 endforeach()
             endif()
 
@@ -342,13 +330,13 @@ foreach(LINE IN LISTS SOURCE_LINES)
         endif()
 
         string(APPEND SQUIRREL_EXPORT "\n")
-        string(APPEND SQUIRREL_EXPORT "\ntemplate <> const char *GetClassName<${CLS}, ScriptType::${APIUC}>() { return \"${API_CLS}\"; }")
+        string(APPEND SQUIRREL_EXPORT "\ntemplate <> const char *GetClassName<${CLS}, ST_${APIUC}>() { return \"${API_CLS}\"; }")
         string(APPEND SQUIRREL_EXPORT "\n")
 
         # Then do the registration functions of the class.
         string(APPEND SQUIRREL_EXPORT "\nvoid SQ${API_CLS}_Register(Squirrel *engine)")
         string(APPEND SQUIRREL_EXPORT "\n{")
-        string(APPEND SQUIRREL_EXPORT "\n	DefSQClass<${CLS}, ScriptType::${APIUC}> SQ${API_CLS}(\"${API_CLS}\");")
+        string(APPEND SQUIRREL_EXPORT "\n	DefSQClass<${CLS}, ST_${APIUC}> SQ${API_CLS}(\"${API_CLS}\");")
         if("${SUPER_CLS}" STREQUAL "Text" OR "${SUPER_CLS}" STREQUAL "ScriptObject" OR "${SUPER_CLS}" STREQUAL "AIAbstractiveList::Valuator")
             string(APPEND SQUIRREL_EXPORT "\n	SQ${API_CLS}.PreRegister(engine);")
         else()
@@ -637,12 +625,10 @@ foreach(LINE IN LISTS SOURCE_LINES)
                     string(APPEND TYPES "p")
                 elseif("${PARAM}" MATCHES "^Array")
                     string(APPEND TYPES "a")
-                elseif("${PARAM}" MATCHES "^const Array")
+                elseif("${PARAM}" MATCHES "^struct Array")
                     string(APPEND TYPES "a")
                 elseif("${PARAM}" MATCHES "^Text")
                     string(APPEND TYPES ".")
-                elseif("${PARAM}" MATCHES "^std::string")
-                    string(APPEND TYPES ".")
                 else()
                     string(APPEND TYPES "x")
                 endif()
@@ -678,6 +664,4 @@ foreach(LINE IN LISTS SOURCE_LINES)
     endif()
 endforeach()
 
-doxygen_check()
-
 configure_file(${SCRIPT_API_SOURCE_FILE} ${SCRIPT_API_BINARY_FILE})

cmake/scripts/SquirrelIncludes.cmake

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.5)
 
 if(NOT INCLUDES_SOURCE_FILE)
     message(FATAL_ERROR "Script needs INCLUDES_SOURCE_FILE defined")

docs/admin_network.md

@@ -1,6 +1,6 @@
 # OpenTTD's admin network
 
-Last updated:    2024-03-26
+Last updated:    2011-01-20
 
 
 ## Table of contents
@@ -49,29 +49,10 @@ Last updated:    2024-03-26
   Create a TCP connection to the server on port 3977. The application is
   expected to authenticate within 10 seconds.
 
-  To authenticate send either an `ADMIN_PACKET_ADMIN_JOIN` or an
-  `ADMIN_PACKET_ADMIN_JOIN_SECURE` packet.
+  To authenticate send a `ADMIN_PACKET_ADMIN_JOIN` packet.
 
-  The `ADMIN_PACKET_ADMIN_JOIN` packet sends the password without any
-  encryption or safeguards over the connection, and as such has been disabled
-  by default.
-
-  The `ADMIN_PACKET_ADMIN_JOIN_SECURE` packet initiates a key exchange
-  authentication schema which tells te server which methods the client
-  supports and the server makes a choice. The server will then send an
-  `ADMIN_PACKET_SERVER_AUTH_REQUEST` packet to which the client has to respond
-  with an `ADMIN_PACKET_ADMIN_AUTH_RESPONSE` packet.
-
-  The current choices for secure authentication are authorized keys, where
-  the client has a private key and the server a list of authorized public
-  keys, and a so-called password-authenticated key exchange which allows to
-  authenticate using a password without actually sending the password.
-  The server falls back to password authentication when the client's key is
-  not in the list of authorized keys.
-
-  When authentication has succeeded for either of the `JOIN` schemas, the
-  server will reply with `ADMIN_PACKET_SERVER_PROTOCOL` followed directly
-  by `ADMIN_PACKET_SERVER_WELCOME`.
+  The server will reply with `ADMIN_PACKET_SERVER_PROTOCOL` followed directly by
+  `ADMIN_PACKET_SERVER_WELCOME`.
 
   `ADMIN_PACKET_SERVER_PROTOCOL` contains details about the protocol version.
   It is the job of your application to check this number and decide whether

docs/debugging_desyncs.md

@@ -53,7 +53,4 @@ Do NOT remove the dmp_cmds savegames of a desync you have reported until the
 desync has been fixed; if you, by accident, send us the wrong savegames we
 will not be able to reproduce the desync and thus will be unable to fix it.
 
-## More information
 
-You can find more theory on the causes and debugging of desyncs in the
-[desync documentation](./desync.md).

docs/desync.md

@@ -195,11 +195,10 @@ Last updated: 2014-02-23
      'src/network/network_func.h'.
      (DEBUG_FAILED_DUMP_COMMANDS is explained later)
    - Put the 'commands-out.log' into the root save folder, and rename
-      it to 'commands.log'. Strip everything and including the "newgame"
-      entry from the log.
-   - Run 'openttd -D -d desync=0 -g startsavegame.sav'.
-     This replays the server log. Use "-d desync=3" to also create a
-     new 'commands-out.log' and 'dmp_cmds_*.sav' in your autosave folder.
+      it to 'commands.log'.
+   - Run 'openttd -D -d desync=3 -g startsavegame.sav'.
+     This replays the server log and creates new 'commands-out.log'
+     and 'dmp_cmds_*.sav' in your autosave folder.
 
 ## 3.2) Evaluation of the replay
 
@@ -227,7 +226,7 @@ Last updated: 2014-02-23
   savegames with your own ones from the replay. You can also comment/disable
   the 'NOT_REACHED' mentioned above, to get another 'dmp_cmds_*.sav' from
   the replay after the mismatch has already been detected.
-  See Section 3.3 on how to compare savegames.
+  See Section 3.2 on how to compare savegames.
   If the saves differ you have located the Desync between the last dmp_cmds
   that match and the first one that does not. The difference of the saves
   may point you in the direction of what causes it.
@@ -253,14 +252,16 @@ Last updated: 2014-02-23
      are replayed. Their internal state will thus not change in the
      replay and will differ.
 
-  To compare savegame more semantically, easiest is to first export them
-  to a JSON format with for example:
+  To compare savegame more semantically, there exist some ugly hackish
+  tools at:
+     http://devs.openttd.org/~frosch/texts/zpipe.c
+     http://devs.openttd.org/~frosch/texts/printhunk.c
 
-  https://github.com/TrueBrain/OpenTTD-savegame-reader
+  The first one decompresses OpenTTD savegames. The second one creates
+  a textual representation of an uncompressed savegame, by parsing hunks
+  and arrays and such. With both tools you need to be a bit careful
+  since they work on stdin and stdout, which may not deal well with
+  binary data.
 
-  By running:
-
-  python -m savegame_reader --export-json dmp_cmds_NNN.sav | jq . > NNN.json
-
-  Now you can use any (JSON) diff tool to compare the two savegames in a
-  somewhat human readable way.
+  If you have the textual representation of the savegames, you can
+  compare them with regular diff tools.

docs/directory_structure.md

@@ -19,14 +19,14 @@ your operating system:
     - Windows:
         - `C:\My Documents\OpenTTD` (95, 98, ME)
         - `C:\Documents and Settings\<username>\My Documents\OpenTTD` (2000, XP)
-        - `C:\Users\<username>\Documents\OpenTTD` (7, 8.1, 10, 11)
+        - `C:\Users\<username>\Documents\OpenTTD` (Vista, 7, 8.1, 10)
     - macOS: `~/Documents/OpenTTD`
     - Linux: `$XDG_DATA_HOME/openttd` which is usually `~/.local/share/openttd`
        when built with XDG base directory support, otherwise `~/.openttd`
 3. The shared directory
     - Windows:
         - `C:\Documents and Settings\All Users\Shared Documents\OpenTTD` (2000, XP)
-        - `C:\Users\Public\Documents\OpenTTD` (7, 8.1, 10, 11)
+        - `C:\Users\Public\Documents\OpenTTD` (Vista, 7, 8.1, 10)
     - macOS: `/Library/Application Support/OpenTTD`
     - Linux: not available
 4. The binary directory (where the OpenTTD executable is)

docs/eints.md

@@ -25,10 +25,6 @@ The translators will decide whether, where and how to apply your suggestion.
 
 Sorry, we don't offer this option.
 
-Only when there is a consistency problem that needs addressing, this can be done via a PR.
-We are very strict about this, and in general all PRs making translation changes will be closed.
-But if it is really needed, and the change is not a revert of any older change, a PR can be created to do mass changes to a translation.
-
 ### I want to change the language definition (plural form, genders, cases) of a translation.
 
 Please [create an issue](https://github.com/OpenTTD/OpenTTD/issues/new/choose) for this.

docs/importing_town_data.md

@@ -1,97 +0,0 @@
-# Importing Town Data into OpenTTD
-
-To aid players in scenario creation, OpenTTD's Scenario Editor can import town data from external JSON files. This enables players to use an image editing program to align town coordinates with a real-world heightmap using a map underlay, instead of guessing at the correct locations in Scenario Editor itself.
-
-This town data consists of a JSON file storing an array of town data objects, each containing a name, location, target OpenTTD population, and whether it is marked as a city in the game.
-
-This document describes the standard format for this JSON file and outlines a workflow for creating this data effectively.
-
-## Table of contents
-
-- Why load external data?
-- How to use this feature
-  - Creating geodata
-    - Town data format standards
-    - Town data values
-  - Loading geodata into OpenTTD
-- Tutorial: Creating town data
-
-## Why load external data?
-
-There are three benefits to using an image editing program to create towns instead of the OpenTTD Scenario Editor.
-
-1. Placing towns accurately is much easier using a map underlay such as OpenStreetMap to match town locations with the corresponding heightmap.
-2. Storing town data in a JSON file instead of as an OpenTTD Scenario (.scn) doesn't require choosing your NewGRF house set before placing towns.
-3. Town coordinates are scaled by the map size, so you can load the data onto whatever size map you like.
-
-## How to use this feature
-
-### Creating geodata
-
-Town data is a text file in the JSON format, with a list of towns, each containing a coordinate location and properties: name, population, and whether or not it should be a city in OpenTTD.
-
-The format of this file is standardized for importing into OpenTTD and must be followed for OpenTTD to properly parse the data.
-
-For use in OpenTTD, you will also need a matching heightmap of the terrain features, as a PNG.
-
-#### Town data format standards
-
-The following code sample is complete and can be used in OpenTTD.
-- The list of towns is enclosed in an array marked with square brackets `[]`
-- Each town is enclosed in curly braces `{}`, with a comma after each town except for the last in the list.
-- The properties separated by commas except for the last.
-- Property names are enclosed in double quotes `""` with a colon `:` separating it from the property value.
-- The name property value is enclosed in double quotes `"London"`, while all other property values `44910`, `true`, etc., are not.
-
-```
-[
-    {
-        "name": "London",
-        "population": 44910,
-        "city": true,
-        "x": 0.7998046875,
-        "y": 0.708984375
-    },
-    {
-        "name": "Canterbury",
-        "population": 217.16,
-        "city": false,
-        "x": 0.83251953125,
-        "y": 0.828125
-    }
-]
-```
-
-#### Town data values
-
-- Population is scaled down for use in OpenTTD. It is possible to generate huge cities by using a large number, but there is a practical limit to town size. The larger the town, the longer it will take to import town data, since towns are placed at a relatively small size and then expanded until the population is greater than the player-defined target.
-- X and Y coordinates are a proportion of the total map dimension, between 0 and 1. Just take the pixel coordinates of the town's location in the corresponding heightmap (more detail in the tutorial below) and divide each by the maximum value.
-  - For example, London is at `726, 1638` in a 1024 px by 2048 px heightmap, so `726 / 1024 = 0.7998046875` and `1638 / 2048 = 0.708984375` gives the correct coordinates for OpenTTD.
-  - The reason for these proportional coordinates is so the data can be used for any map size.
-- 0,0 is (approximately) the very top tile in OpenTTD. You can see tile coordinates in-game with the Land Info Tool.
-- In most image editing programs, 0,0 is the top-left corner of the image. You can rotate the image however you want relative to compass north to orient the map to your liking. Make sure you crop and resize the image before recording town locations.
-- In OpenTTD, X and Y axis are swapped compared to most image editing programs and the standard Cartesian coordinate system. From the 0,0 origin at top left, X is the axis along the left side and Y is the axis along the right side. You can still measure X and Y coordinates in your image editing program, just swap them before importing into OpenTTD or towns won't line up with your heightmap.
-
-### Loading geodata into OpenTTD
-Using geodata to create a real-world location in OpenTTD is done in the Scenario Editor.
-
-1. Choose the NewGRFs you want to use in the game.
-2. Load the heightmap which you created in the geodata workflow. Either rotation will work, but the clockwise rotation is considered "correct" and the coordinates in the Land Info Tool will match your data; counter clockwise maps will align properly but the coordinates won't match your data.
-3. In the Town Generation window, click `Load from file` and choose the .json file containing town data. The default directory to search for town data is `OpenTTD\scenario\heightmap`.
-4. (Optional) Manually add industries, rivers, trees, and objects.
-5. Save the game as a Scenario and exit to the main menu.
-6. Load the game with Play Scenario and enjoy.
-
-Sometimes it's not possible to place a town, such as when the heightmap is very rough and a flat tile can't be found with a 16-tile radius of the target tile. In such cases, a sign will be placed on the target tile with the name of the town. The player can then place the town manually or change the heightmap settings and try again. This fallback also helps debug errors with data creation, such as if towns end up in the ocean.
-
-## Tutorial: Creating town data
-
-1. Load both your heightmap and a labeled map like OpenStreetMap as layers in an image editing program. You can use a free/open-source program like QGIS to acquire, align, and export these map images, if you like.
-2. Crop the image to your desired bounds, ensuring the aspect ratio is supported in OpenTTD (1:1, 1:2, 1:4, etc.).
-3. Resize the image to one of OpenTTD's supported map sizes, such as 512 px by 1024 px. Some image editors let you do this part of step 2. You can always load heightmaps and town data at a reduced size, so you may want to make this larger than your intended use in case you want it later.
-4. Use the labeled map layer to find the pixel coordinates of each town you'd like to include in your map. In GIMP this is displayed in the bottom left corner of the image window, and in Photoshop you need to enable the Info panel (F8) and switch to pixel units of measurement if not already.
-5. Some spreadsheets including Google Sheets can export data as JSON, so you may want to record it there, to export after step 8. Or you can build the JSON file manually.
-6. Adjust population numbers for OpenTTD.
-7. Change coordinates from pixels to proportion (0-1) of the total dimension: `x / maximum_x` and `y / maximum_y`, as described in "Town data values" above.
-8. Swap X and Y coordinates before importing to OpenTTD, since OpenTTD uses a reverse X and Y system than most image editors.
-9. Save the heightmap and town data files in your `OpenTTD\scenario\heightmap` folder.

docs/landscape.html

@@ -721,9 +721,10 @@
         </ul>
        </li>
       </ul>
-     <li>m3 bits 6..5 : free</li>
+     <li>m3 bit 6 : bit 8 of house type (m4), allowing 512 different types.</li>
+     <li>m3 bit 5 : free</li>
      <li>m3 bits 4..0 : triggers activated <a href="#newhouses">(newhouses)</a></li>
-     <li>m4 : free</li>
+     <li>m4 : <a href="landscape_externals.html">town building type</a> (with m3[6] bit)</li>
      <li>m5 : see m3 bit 7</li>
      <li>m6 :
       <ul>
@@ -739,7 +740,6 @@
        </li>
       </ul>
      </li>
-     <li>m6: bits 1..0: animated tile state</li>
      <li>m7 :
       <ul>
        <li>If <a href="#newhouses">newhouses</a> is activated
@@ -759,12 +759,10 @@
        </li>
       </ul>
      </li>
-     <li>m8 bits 15..12 : free</li>
-     <li>m8 bits 11..0 : <a href="landscape_externals.html">town building type</a></li>
     </ul>
     <small><a name="newhouses"></a>Newhouses is the name englobing a newGRF feature developed by TTDPatch devs (mainly Csaboka).<br>
     It allows the replacement of the properties as well as the graphics of houses in the game.<br>
-    To distinguish between the standard behaviour and the newGRF one, HouseID is tested for anything above 110.<br>
+    To distinguish between the standard behaviour and the newGRF one, HouseID (m4 + m3[6]) is tested for anything above 110.<br>
     110 is the count of standard houses. So above 110 means there is a new definition of at least one house</small>
    </td>
   </tr>
@@ -809,6 +807,8 @@
       </table>
      </li>
      <li>m2 bits 5..4: ground density</li>
+     <li>m2 bits 3..0: update counter, incremented on every periodic processing.<br>
+          on wraparound the growth status is updated (or, if it's <tt>3</tt>, a random action is taken)</li>
      <li>m3 bits 7..0: type of trees:
       <table>
        <tr>
@@ -878,25 +878,6 @@
      <li>m2: index into the array of stations</li>
      <li>m3 bits 7..4: persistent random data for railway stations/waypoints and airports)</li>
      <li>m3 bits 7..4: <a href="#OwnershipInfo">owner</a> of tram tracks (road stop)</li>
-     <li>m3 bits 3..2: ground type (road waypoints)
-      <table>
-       <tr>
-        <td><tt>0</tt>&nbsp; </td>
-        <td>on bare land</td>
-       </tr>
-       <tr>
-        <td><tt>1</tt>&nbsp; </td>
-        <td>on grass</td>
-       </tr>
-       <tr>
-        <td><tt>2</tt>&nbsp; </td>
-        <td>paved</td>
-       </tr>
-      </table>
-     </li>
-     <li>m3 bit 2: rail station / waypoint may have catenary pylons</li>
-     <li>m3 bit 1: rail station / waypoint may have catenary wires</li>
-     <li>m3 bit 0: rail station / waypoint is blocked</li>
      <li>m4: custom station id; 0 means standard graphics</li>
      <li>m4: <a href="#RoadType">Roadtype</a> for road stops</li>
      <li>m5: graphics index (range from 0..255 for each station type):
@@ -977,22 +958,6 @@
         </td>
        </tr>
 
-       <tr>
-        <td nowrap valign=top><tt>04</tt>..<tt>05</tt>&nbsp; </td>
-        <td align=left>road waypoints
-         <table>
-          <tr>
-           <td><tt>04</tt>&nbsp; </td>
-           <td align=left>drive through X</td>
-          </tr>
-          <tr>
-           <td><tt>05</tt>&nbsp; </td>
-           <td align=left>drive through Y</td>
-          </tr>
-         </table>
-        </td>
-       </tr>
-
        <tr>
         <td nowrap valign=top><tt>00</tt>..<tt>05</tt>&nbsp; </td>
         <td align=left>ship dock
@@ -1026,16 +991,13 @@
        </tr>
       </table>
      </li>
-     <li>m6 bits 6..3: the station type (rail, airport, truck, bus, oilrig, dock, buoy, waypoint, road waypoint)</li>
+     <li>m6 bits 5..3: the station type (rail, airport, truck, bus, oilrig, dock, buoy, waypoint)</li>
      <li>m6 bit 2: pbs reservation state for railway stations/waypoints</li>
-     <li>m6 bits 1..0: animated tile state</li>
 
      <li>m7 bits 4..0: <a href="#OwnershipInfo">owner</a> of road (road stops)</li>
      <li>m7: animation frame (railway stations/waypoints, airports)</li>
-     <li>m8 bit 15: Snow or desert present (road waypoints)</li>
      <li>m8 bits 11..6: <a href="#TramType">Tramtype</a></li>
      <li>m8 bits 5..0: <a href="#TrackType">track type</a> for railway stations/waypoints</li>
-     <li>m8 bits 5..0: custom road stop/waypoint id; 0 means standard graphics</li>
     </ul>
    </td>
   </tr>
@@ -1052,94 +1014,99 @@
      <li>m1 bits 6..5 : Water class (sea, canal or river)
      <li>m1 bits 4..0: <a href="#OwnershipInfo">owner</a> (for sea, rivers, and coasts normally <tt>11</tt>)</li>
      <li>m2: Depot index (for depots only)</li>
-     <li>m3 bit 0: Non-flooding state</li>
      <li>m4: Random data for canal or river tiles</li>
-     <li>m5 bits 7..4: Water tile type:
+     <li>m5: tile type:
       <table>
-        <tr>
-         <td><tt>0</tt>&nbsp; </td>
-         <td>water, canal or river</td>
-        </tr>
-        <tr>
-         <td><tt>1</tt>&nbsp; </td>
-         <td>coast or riverbank</td>
-        </tr>
-        <tr>
-         <td nowrap valign=top><tt>2</tt>&nbsp; </td>
-         <td>canal lock<br>
-          <ul>
-           <li>m5 bits 3..2: Lock part
-            <table>
-             <tr>
-              <td><tt>0</tt>&nbsp; </td>
-              <td>Middle part</td>
-             </tr>
-             <tr>
-              <td><tt>1</tt>&nbsp; </td>
-              <td>Lower part</td>
-             </tr>
-             <tr>
-              <td><tt>2</tt>&nbsp; </td>
-              <td>Upper part</td>
-             </tr>
-            </table>
-           </li>
-           <li>m5 bits 1..0: Lock direction
-            <table>
-             <tr>
-              <td><tt>0</tt>&nbsp; </td>
-              <td>NE raised</td>
-             </tr>
-             <tr>
-              <td><tt>1</tt>&nbsp; </td>
-              <td>SE raised</td>
-             </tr>
-             <tr>
-              <td><tt>2</tt>&nbsp; </td>
-              <td>SW raised</td>
-             </tr>
-             <tr>
-              <td><tt>3</tt>&nbsp; </td>
-              <td>NW raised</td>
-             </tr>
-            </table>
-           </li>
-          </ul>
-         </td>
-        </tr>
-        <tr>
-         <td nowrap valign=top><tt>3</tt>&nbsp; </td>
-         <td>depot<br>
-          <ul>
-           <li>m5 bit 1: Depot axis
-            <table>
-             <tr>
-              <td><tt>0</tt>&nbsp; </td>
-              <td>X direction (NE-SW)</td>
-             </tr>
-             <tr>
-              <td><tt>1</tt>&nbsp; </td>
-              <td>Y direction (NW-SE)</td>
-             </tr>
-            </table>
-           </li>
-           <li>m5 bit 0: Depot part
-            <table>
-             <tr>
-              <td><tt>0</tt>&nbsp; </td>
-              <td>North part</td>
-             </tr>
-             <tr>
-              <td><tt>1</tt>&nbsp; </td>
-              <td>South part</td>
-             </tr>
-            </table>
-           </li>
-          </ul>
-         </td>
-        </tr>
-       </table>
-      </li>
+       <tr>
+        <td nowrap valign=top><tt>00</tt>&nbsp; </td>
+        <td align=left>water, canal or river</td>
+       </tr>
+
+       <tr>
+        <td nowrap valign=top><tt>01</tt>&nbsp; </td>
+        <td align=left>coast or riverbank</td>
+       </tr>
+
+       <tr>
+        <td nowrap valign=top><tt>10</tt>..<tt>1B</tt>&nbsp; </td>
+        <td align=left>canal locks
+         <table>
+          <tr>
+           <td nowrap valign=top><tt>10</tt>&nbsp; </td>
+           <td align=left>middle part, (SW-NE direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>11</tt>&nbsp; </td>
+           <td align=left>middle part, (NW-SE direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>12</tt>&nbsp; </td>
+           <td align=left>middle part, (NE-SW direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>13</tt>&nbsp; </td>
+           <td align=left>middle part, (SE-NW direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>14</tt>&nbsp; </td>
+           <td align=left>lower part, (SW-NE direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>15</tt>&nbsp; </td>
+           <td align=left>lower part, (NW-SE direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>16</tt>&nbsp; </td>
+           <td align=left>lower part, (NE-SW direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>17</tt>&nbsp; </td>
+           <td align=left>lower part, (SE-NW direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>18</tt>&nbsp; </td>
+           <td align=left>upper part, (SW-NE direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>19</tt>&nbsp; </td>
+           <td align=left>upper part, (NW-SE direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>1A</tt>&nbsp; </td>
+           <td align=left>upper part, (NE-SW direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>1B</tt>&nbsp; </td>
+           <td align=left>upper part, (SE-NW direction)</td>
+          </tr>
+         </table>
+        </td>
+       </tr>
+
+       <tr>
+        <td nowrap valign=top><tt>80</tt>..<tt>83</tt>&nbsp; </td>
+        <td align=left>ship depots
+         <table>
+          <tr>
+           <td nowrap valign=top><tt>80</tt>&nbsp; </td>
+           <td align=left>ship depot, NE part (X direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>81</tt>&nbsp; </td>
+           <td align=left>ship depot, SW part (X direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>82</tt>&nbsp; </td>
+           <td align=left>ship depot, NW part (Y direction)</td>
+          </tr>
+          <tr>
+           <td nowrap valign=top><tt>83</tt>&nbsp; </td>
+           <td align=left>ship depot, SE part (Y direction)</td>
+          </tr>
+         </table>
+        </td>
+       </tr>
+      </table>
      </li>
     </ul>
    </td>
@@ -1482,7 +1449,6 @@
      </li>
      <li>m6 bits 5..3: random triggers (NewGRF)</li>
      <li>m6 bit 2: bit 8 of type (see m5)</li>
-     <li>m6 bits 1..0: animated tile state</li>
      <li>m7: animation frame</li>
     </ul>
    </td>
@@ -1655,7 +1621,6 @@
      <li>m2: index into the array of objects, bits 0 to 15 (upper bits in m5)</li>
      <li>m3: random bits</li>
      <li>m5: index into the array of objects, bits 16 to 23 (lower bits in m2)</li>
-     <li>m6 bits 1..0: animated tile state</li>
      <li>m7: animation counter</li>
     </ul>
    </td>

docs/landscape_grid.html

@@ -79,8 +79,8 @@ the array so you can quickly see what is used and what is not.
     <tr>
       <td rowspan="2">0</td>
       <td class="caption">ground</td>
-      <td class="bits" rowspan=29><span class="used" title="Tile type">XXXX</span> <span class="used" title="Presence and direction of bridge above">XX</span> <span class="used" title="Tropic Zone: only meaningful in tropic climate. It contains the definition of the available zones">XX</span></td>
-      <td class="bits" rowspan=29><span class="used" title="Tile height">XXXX XXXX</span></td>
+      <td class="bits" rowspan=27><span class="used" title="Tile type">XXXX</span> <span class="used" title="Presence and direction of bridge above">XX</span> <span class="used" title="Tropic Zone: only meaningful in tropic climate. It contains the definition of the available zones">XX</span></td>
+      <td class="bits" rowspan=27><span class="used" title="Tile height">XXXX XXXX</span></td>
       <td class="bits" rowspan=2><span class="free">OOO</span><span class="usable" title="Owner (always OWNER_NONE)">1 OOOO</span></td>
       <td class="bits"><span class="free">OOOO OOOO OOOO OOOO</span></td>
       <td class="bits"><span class="used" title="Type of hedge on NE border">XXX</span> <span class="used" title="Snow presence">X</span><span class="free">OOOO</span></td>
@@ -130,7 +130,7 @@ the array so you can quickly see what is used and what is not.
       <td class="bits"><span class="used" title="Tile type: simple road (00), level crossing (01), road depot (10)">OO</span> <span class="used" title="Disallow vehicles to go a specific direction">XX</span> <span class="used" title="Road pieces">XXXX</span></td>
       <td class="bits"><span class="free">OO</span> <span class="used" title="Pavement type">XXX</span><span class="free">OOO</span></td>
       <td class="bits"><span class="free">OO</span><span class="used" title="Snow/desert present">X</span> <span class="free">O</span><span class="used" title="Roadworks counter">XXXX</span></td>
-      <td class="bits" rowspan=1><span class="free">OOOO</span> <span class="used" title="Tram type">XXXX XX</span><span class="free">OO OOOO</span></td>
+      <td class="bits" rowspan=1><span class="free">OOOO</span> <span class="used" title="Tram type">XXXX XX<span class="free">OO OOOO</span></td>
     </tr>
     <tr>
       <td class="caption">level crossing</td>
@@ -156,17 +156,17 @@ the array so you can quickly see what is used and what is not.
       <td class="caption">finished house</td>
       <td class="bits" rowspan=2><span class="used" title="House random bits">XXXX XXXX</span></td>
       <td class="bits" rowspan=2><span class="pool" title="Town index on pool">XXXX XXXX XXXX XXXX</span></td>
-      <td class="bits"><span class="used" title="House is complete/in construction (see m5)">1</span><span class="free">OO</span><span class="usable" title="Activated triggers (bits 2..4 don't have a meaning)">X XX</span><span class="used" title="Activated triggers (bits 2..4 don't have a meaning)">XX</span></td>
-      <td class="bits" rowspan=2><span class="free">OOOO OOOO</span></td>
+      <td class="bits"><span class="used" title="House is complete/in construction (see m5)">1</span> <span class="used" title="House type (m4 + m3[6])">X</span><span class="free">O</span><span class="usable" title="Activated triggers (bits 2..4 don't have a meaning)">XXX</span><span class="used" title="Activated triggers (bits 2..4 don't have a meaning)">XX</span></td>
+      <td class="bits" rowspan=2><span class="used" title="House type (m4 + m3[6])">XXXX XXXX</span></td>
       <td class="bits"><span class="used" title="Age in years, clamped at 255">XXXX XXXX</span></td>
-      <td class="bits" rowspan=2><span class="abuse" title="Newhouses activated: periodic processing time remaining; if not, lift position for houses 04 and 05">XXXX XX</span><span class="used" title="Animated tile state">XX</span></td>
+      <td class="bits" rowspan=2><span class="abuse" title="Newhouses activated: periodic processing time remaining; if not, lift position for houses 04 and 05">XXXX XX</span><span class="free">OO</span></td>
       <td class="bits" rowspan=2><span class="abuse" title="If newhouses active, m7 is the current animation frame">XXXX</span> <span class="abuse" title="If newhouses active, m7 is the current animantion frame; if not, lift behaviour for houses 04 and 05">XXXX</span></td>
-      <td class="bits" rowspan=2><span class="free">OOOO</span> <span class="used" title="House type">XXXX XXXX XXXX</span></td>
+      <td class="bits" rowspan=2><span class="free">OOOO OOOO OOOO OOOO</span></td>
     </tr>
     <tr>
       <td class="caption">house under construction</td>
-      <td class="bits"><span class="used" title="House is complete/in construction (see m5)">O</span><span class="used" title="House type (m4 + m3[6])">X</span><span class="free">O</span><span class="usable" title="Activated triggers (bits 2..4 don't have a meaning)">X XX</span><span class="used" title="Activated triggers (bits 2..4 don't have a meaning)">XX</span></td>
-      <td class="bits"><span class="free">OOO</span><span class="used" title="Construction stage">X X</span><span class="used" title="Construction counter">XXX</span></td>
+      <td class="bits"><span class="used" title="House is complete/in construction (see m5)">O</span> <span class="used" title="House type (m4 + m3[6])">X</span><span class="free">O</span><span class="usable" title="Activated triggers (bits 2..4 don't have a meaning)">XXX</span><span class="used" title="Activated triggers (bits 2..4 don't have a meaning)">XX</span></td>
+      <td class="bits"><span class="free">OOO</span><span class="used" title="Construction stage">XX</span> <span class="used" title="Construction counter">XXX</span></td>
     </tr>
     <tr>
       <td>4</td>
@@ -181,14 +181,14 @@ the array so you can quickly see what is used and what is not.
       <td class="bits"><span class="free">OOOO OOOO OOOO OOOO</span></td>
     </tr>
     <tr>
-      <td rowspan=8>5</td>
+      <td rowspan=7>5</td>
       <td class="caption">rail station</td>
-      <td class="bits" rowspan=8><span class="free">O</span><span class="used" title="Water class">XX</span> <span class="used" title="Owner">XXXXX</span></td>
-      <td class="bits" rowspan=8><span class="pool" title="Station index on pool">XXXX XXXX XXXX XXXX</span></td>
-      <td class="bits" rowspan=2><span class="used" title="Random bits">XXXX</span> <span class="free">O</span><span class="used" title="May have pylons">X</span><span class="used" title="May have wires">X</span><span class="used" title="Tile is blocked">X</span></td>
+      <td class="bits" rowspan=7><span class="free">O</span><span class="used" title="Water class">XX</span> <span class="used" title="Owner">XXXXX</span></td>
+      <td class="bits" rowspan=7><span class="pool" title="Station index on pool">XXXX XXXX XXXX XXXX</span></td>
+      <td class="bits" rowspan=2><span class="used" title="Random bits">XXXX</span> <span class="free">OOOO</span></td>
       <td class="bits" rowspan=2><span class="used" title="Custom station specifications ID">XXXX XXXX</span></td>
       <td class="bits"><span class="used" title="Graphics index">XXXX XXXX</span></td>
-      <td class="bits" rowspan=2><span class="free">O</span><span class="used" title="Station type">XXX X</span><span class="used" title="Reserved track">X</span><span class="used" title="Animated tile state">XX</span></td>
+      <td class="bits" rowspan=2><span class="free">OO</span><span class="used" title="Station type">XXX</span> <span class="used" title="Reserved track">X</span><span class="free">OO</span></td>
       <td class="bits" rowspan=2><span class="used" title="Animation frame">XXXX XXXX</span></td>
       <td class="bits" rowspan=2><span class="free">OOOO OOOO OO</span><span class="used" title="Railway type">XX XXXX</span></td>
     </tr>
@@ -199,16 +199,11 @@ the array so you can quickly see what is used and what is not.
     <tr>
       <td class="caption">road stop</td>
       <td class="bits"><span class="used" title="Owner of tram">XXXX</span> <span class="free">OOOO</span></td>
-      <td class="bits" rowspan=2><span class="free">OO</span><span class="used" title="Roadtype for road stop">XX XXXX</span></td>
-      <td class="bits" rowspan=2><span class="usable" title="Graphics index">OOOO O</span><span class="used" title="Graphics index: 00 (exit towards NE), 01 (exit towards SE), 02 (exit towards SW), 03 (exit towards NW), 04 (drive through X), 05 (drive through Y)">XXX</span></td>
-      <td class="bits" rowspan=6><span class="free">O</span><span class="used" title="Station type">XXX X</span><span class="free">O</span><span class="used" title="Animated tile state">XX</span></td>
-      <td class="bits" rowspan=2><span class="free">OOO</span><span class="used" title="Owner of road">X XXXX</span></td>
-      <td class="bits"><span class="free">OOOO</span> <span class="used" title="Tram type">XXXX XX</span> <span class="used" title="Custom road stops specifications ID">XXXXXX</span></td>
-    </tr>
-    <tr>
-      <td class="caption">road waypoint</td>
-      <td class="bits"><span class="used" title="Owner of tram">XXXX</span> <span class="used" title="Pavement type">XX</span><span class="free">OO</span></td>
-      <td class="bits"><span class="used" title="Snow/desert present">X</span><span class="free">OOO</span> <span class="used" title="Tram type">XXXX XX</span> <span class="used" title="Custom road stops specifications ID">XXXXXX</span></td>
+      <td class="bits"><span class="free">OO</span><span class="used" title="Roadtype for road stop">XX XXXX</span></td>
+      <td class="bits"><span class="usable" title="Graphics index">OOOO O</span><span class="used" title="Graphics index: 00 (exit towards NE), 01 (exit towards SE), 02 (exit towards SW), 03 (exit towards NW), 04 (drive through X), 05 (drive through Y)">XXX</span></td>
+      <td class="bits" rowspan=5><span class="free">OO</span><span class="used" title="Station type">XX X</span><span class="free">OOO</span></td>
+      <td class="bits"><span class="free">OOO</span><span class="used" title="Owner of road">X XXXX</span></td>
+      <td class="bits"><span class="free">OOOO</span> <span class="used" title="Tram type">XXXX XX<span class="free">OO OOOO</span></td>
     </tr>
     <tr>
       <td class="caption">airport</td>
@@ -240,37 +235,32 @@ the array so you can quickly see what is used and what is not.
       <td class="bits"><span class="free">OOOO OOOO</span></td>
     </tr>
     <tr>
-      <td rowspan=5>6</td>
-      <td class="caption">sea</td>
-      <td class="bits" rowspan=5><span class="used" title="Ship docking tile status">X</span> <span class="used" title="Water class">XX</span> <span class="used" title="Owner">XXXXX</span></td>
-      <td class="bits" rowspan=4><span class="free">OOOO OOOO OOOO OOOO</span></td>
-      <td class="bits" rowspan=5><span class="free">OOOO OOO</span><span class="used" title="Non-flooding state">X</span></td>
+      <td rowspan=4>6</td>
+      <td class="caption">sea, shore</td>
+      <td class="bits" rowspan=4><span class="used" title="Ship docking tile status">X</span> <span class="used" title="Water class">XX</span> <span class="used" title="Owner">XXXXX</span></td>
+      <td class="bits" rowspan=3><span class="free">OOOO OOOO OOOO OOOO</span></td>
+      <td class="bits" rowspan=4><span class="free">OOOO OOOO</span></td>
       <td class="bits"><span class="free">OOOO OOOO</span></td>
-      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">0000</span> <span class="free">OOO0</span></td>
-      <td class="bits" rowspan=5><span class="free">OOOO OOOO</span></td>
-      <td class="bits" rowspan=5><span class="free">OOOO OOOO</span></td>
-      <td class="bits" rowspan=5><span class="free">OOOO OOOO OOOO OOOO</span></td>
+      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">O<span class="usable">OO</span>O</span> <span class="free">OOO</span><span class="used" title="Sea shore flag">X</span></td>
+      <td class="bits" rowspan=4><span class="free">OOOO OOOO</span></td>
+      <td class="bits" rowspan=4><span class="free">OOOO OOOO</td>
+      <td class="bits" rowspan=4><span class="free">OOOO OOOO OOOO OOOO</span></td>
     </tr>
     <tr>
       <td class="caption">canal, river</td>
       <td class="bits"><span class="used" title="Canal/river random bits">XXXX XXXX</span></td>
-      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">0000</span> <span class="free">OOOO</span></td>
-    </tr>
-    <tr>
-      <td class="caption">shore</td>
-      <td class="bits"><span class="free">OOOO OOOO</span></td>
-      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">0001</span> <span class="free">OOOO</span></td>
+      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">O<span class="usable">OO</span>O</span> <span class="free">OOOO</span></td>
     </tr>
     <tr>
       <td class="caption">lock</td>
       <td class="bits"><span class="free">OOOO OOOO</span></td>
-      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">0010</span> <span class="used" title="Lock part">XX</span><span class="used" title="Lock orientation m5[1..0]">XX</span></td>
+      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">O<span class="usable">OO</span>1</span> <span class="used" title="Lock part">XX</span> <span class="used" title="Lock orientation m5[1..0]">XX</span></td>
     </tr>
     <tr>
       <td class="caption">shipdepot</td>
       <td class="bits"><span class="pool" title="Depot index on pool">XXXX XXXX XXXX XXXX</span></td>
       <td class="bits"><span class="free">OOOO OOOO</span></td>
-      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">0011</span> <span class="free">OO</span><span class="used" title="Depot axis">X</span><span class="used" title="Depot part">X</span></td>
+      <td class="bits"><span class="used" title="Water tile type: coast, clear, lock, depot">1<span class="usable">OOO</span></span> <span class="free">OO</span><span class="used" title="Depot axis">X</span> <span class="used" title="Depot part">X</span></td>
     </tr>
     <tr>
       <td rowspan=2>8</td>
@@ -280,7 +270,7 @@ the array so you can quickly see what is used and what is not.
       <td class="bits" rowspan=2><span class="used" title="Random bits">XXXX XXXX</span></td>
       <td class="bits" rowspan=2><span class="used" title="Animation loop">XXXX XXXX</span></td>
       <td class="bits" rowspan=2><span class="used" title="Industry graphics ID (m5 + m6[2])">XXXX XXXX</span></td>
-      <td class="bits" rowspan=2><span class="free">OO</span><span class="used" title="Random triggers (NewGRF)">XXX</span> <span class="used" title="Industry graphics ID (m5 + m6[2])">X</span><span class="used" title="Animated tile state">XX</span></td>
+      <td class="bits" rowspan=2><span class="free">OO</span><span class="used" title="Random triggers (NewGRF)">XXX</span> <span class="used" title="Industry graphics ID (m5 + m6[2])">X</span><span class="free">OO</span></td>
       <td class="bits" rowspan=2><span class="used" title="Animation frame">XXXX XXXX</span></td>
       <td class="bits" rowspan=2><span class="free">OOOO OOOO OOOO OOOO</span></td>
     </tr>
@@ -313,7 +303,7 @@ the array so you can quickly see what is used and what is not.
       <td class="bits"><span class="used" title="Random bits">XXXX XXXX</span></td>
       <td class="bits"><span class="free">OOOO OOOO</span></td>
       <td class="bits"><span class="pool" title="Object index on pool (m2 + m5)">XXXX XXXX</span></td>
-      <td class="bits"><span class="free">OOOO OO</span><span class="used" title="Animated tile state">XX</span></td>
+      <td class="bits"><span class="free">OOOO OOOO</span></td>
       <td class="bits"><span class="used" title="Animation counter">XXXX XXXX</span></td>
       <td class="bits" rowspan=1><span class="free">OOOO OOOO OOOO OOOO</span></td>
     </tr>

docs/multiplayer.md

@@ -193,9 +193,6 @@ If it is, and your server still isn't showing up, start OpenTTD with
 `-d net=4` as extra argument. This will show debug message related to the
 network, including communication to/from the Game Coordinator.
 
-See the [Game Coordinator documentation](./game_coordinator.md) for more
-technical information about the Game Coordinator service.
-
 ### My server warns a lot about getaddrinfo taking N seconds
 
 This could be a transient issue with your (local) DNS server, but if the

docs/openttd.6

@@ -1,6 +1,6 @@
 .\"                                      Hey, EMACS: -*- nroff -*-
 .\" Please adjust this date whenever revising the manpage.
-.Dd August 12, 2023
+.Dd October 13, 2014
 .Dt OPENTTD 6
 .Os
 .Sh NAME
@@ -8,18 +8,20 @@
 .Nd open source clone of the Microprose game \(lqTransport Tycoon Deluxe\(rq
 .Sh SYNOPSIS
 .Nm
-.Op Fl efhQxX
+.Op Fl efhx
 .Op Fl b Ar blitter
 .Op Fl c Ar config_file
 .Op Fl d Op Ar level | Ar cat Ns = Ns Ar lvl Ns Op , Ns Ar ...
 .Op Fl D Oo Ar host Oc Ns Op : Ns Ar port
-.Op Fl g Op Ar file
+.Op Fl g Op Ar savegame
 .Op Fl G Ar seed
 .Op Fl I Ar graphicsset
+.Op Fl l Ar host Ns Op : Ns Ar port
 .Op Fl m Ar driver
 .Op Fl M Ar musicset
-.Op Fl n Ar host Ns Oo : Ns Ar port Oc Ns Op # Ns Ar company
+.Op Fl n Ar host Ns Oo : Ns Ar port Oc Ns Op # Ns Ar player
 .Op Fl p Ar password
+.Op Fl P Ar password
 .Op Fl q Ar savegame
 .Op Fl r Ar width Ns x Ns Ar height
 .Op Fl s Ar driver
@@ -27,7 +29,7 @@
 .Op Fl t Ar year
 .Op Fl v Ar driver
 .Sh OPTIONS
-.Bl -tag -width "-n host[:port][#company]"
+.Bl -tag -width "-n host[:port][#player]"
 .It Fl b Ar blitter
 Select the blitter
 .Ar blitter ;
@@ -61,11 +63,11 @@ Start in world editor mode.
 .It Fl f
 Fork into background (dedicated server only, see
 .Fl D ) .
-.It Fl g Op Ar file
+.It Fl g Op Ar savegame
 Load
-.Ar file
-(can be either a savegame, scenario, or heightmap) at start or start a new game if omitted.
-.Ar file
+.Ar savegame
+at start or start a new game if omitted.
+.Ar savegame
 must be either an absolute path or one relative to the current path or one of
 the search paths.
 .It Fl G Ar seed
@@ -80,6 +82,11 @@ Select the graphics set
 see
 .Fl h
 for a full list.
+.It Fl l Ar host Ns Op : Ns Ar port
+Redirect
+.Fn DEBUG
+output; see
+.Fl D .
 .It Fl m Ar driver
 Select the music driver
 .Ar driver ;
@@ -92,23 +99,19 @@ Select the music set
 see
 .Fl h
 for a full list.
-.It Fl n Ar host Ns Oo : Ns Ar port Oc Ns Op # Ns Ar company
-Join a network game, optionally specifying a port to connect to and company to
+.It Fl n Ar host Ns Oo : Ns Ar port Oc Ns Op # Ns Ar player
+Join a network game, optionally specifying a port to connect to and player to
 play as.
 .It Fl p Ar password
 Password used to join server.
 Only useful with
 .Fl n .
+.It Fl P Ar password
+Password used to join company.
+Only useful with
+.Fl n .
 .It Fl q Ar savegame
 Write some information about the specified savegame and exit.
-.It Fl Q
-Don't scan for/load NewGRF files on startup.
-.Pp
-Passing
-.Fl Q
-twice (so,
-.Fl QQ
-) will disable NewGRF scanning/loading entirely.
 .It Fl r Ar width Ns x Ns Ar height
 Set the resolution to
 .Ar width
@@ -138,8 +141,6 @@ see
 for a full list.
 .It Fl x
 Do not automatically save to config file on exit.
-.It Fl X
-Do not use global folders to search for files.
 .El
 .Sh SEE ALSO
 .Lk https://wiki.openttd.org "Wiki"

docs/releasing_openttd.md

@@ -1,56 +0,0 @@
-# Releasing OpenTTD
-
-This guide is for OpenTTD developers/maintainers, to release a new version of OpenTTD.
-
-## Step 0: Branch or Backport
-
-* If this is a beta version release, skip this step.
-
-* If this is an RC1 (first Release Candidate) build, create a new branch `release/nn` where `nn` is the major version number, then apply changes similar to [PR#9573](https://github.com/OpenTTD/OpenTTD/pull/9573). You also need to forwardport the changelog, as in [PR#10113](https://github.com/OpenTTD/OpenTTD/pull/10113).
-  * Update the version in `CMakeLists.txt` in the master branch, heading for the next major release, e.g. from 14.0 to 15.0.
-  * Add a new (empty) AI compatibility script in `bin/ai/`
-  * Add the new version to CheckAPIVersion in `src/ai/ai_info.cpp` and `src/game/game_info.cpp`
-  * Add the new version to `src/script/api/ai_changelog.hpp` and `src/script/api/game_changelog.hpp`
-  * Update the version of regression in `bin/ai/regression/regression_info.nut`
-  * Add a note to `src/saveload/saveload.h` about which savegame version is used in the branch.
-
-* If this is a later RC or release build and the release branch already exists, you'll need to backport fixes and language from master to this branch, which were merged after the branch diverged from master. You can use these two helper scripts: https://github.com/OpenTTD/scripts/tree/main/backport
-
-* If this is a maintenance release, update the version in `CMakeLists.txt` in the release branch, e.g. from 14.0 to 14.1.
-
-## Step 1: Prepare changelog documentation
-
-1. Update the [changelog](../changelog.md) with new changes since the last release.
-   * Changelog entries are typically PR titles, but can be edited to be more helpful without context.
-   * Don't include fixes to things which haven't previously been released (like fixes to features which are in the same changelog).
-   * Order the entries by importance: `Feature > Add > Change > Fix`, then numerically by PR number.
-2. Create a changelog PR, get approval, and merge.
-   * For beta releases, target master, otherwise target the release branch.
-
-## Step 2: Prepare website release announcement
-
-1. Go to https://github.com/OpenTTD/website/new/main/_posts and write a new announcement post. See a [previous example](https://github.com/OpenTTD/website/pull/238) for a template.
-2. Create a new branch for this post and open a PR for it.
-3. Write announcement text for the store pages and socials like TT-Forums / Discord / Twitter / Reddit / Fosstodon / etc., and include it in the PR.
-4. Create a Steam news image for that post and include it in the PR.
-5. Check the website post ("View Deployment" link) and make corrections. We usually just use the GitHub web interface for this and squash the result later.
-6. Get this PR approved, but do not merge yet.
-
-## Step 3: Make the actual OpenTTD release
-
-1. Confirm that the version in `CMakeLists.txt` matches the intended release version.
-2. Go to https://github.com/OpenTTD/OpenTTD/releases/new and create a new tag matching the release number. For the body of the release, copy in the changelog. "Set as a pre-release" for a beta or RC.
-3. Wait for the OpenTTD release workflow to be complete.
-4. If this is a full release:
-   * for `Steam`: under Steamworks -> SteamPipe -> Builds, set the "testing" branch live on the "default" branch. This will request 2FA validation.
-   * for `GOG`: under Builds, "Publish" the freshly uploaded builds to `Master`, `GOG-use only` and `Testing`.
-   * for `Microsoft Store`: ask orudge to publish the new release.
-
-Access to `Steam`, `GOG` and/or `Microsoft Store` requires a developer account on that platform.
-You will need access to the shared keystore in order to create such an account.
-For help and/or access to either or both, please contact TrueBrain.
-
-## Step 4: Tell the world
-
-1. Merge the website PR. This will publish the release post.
-2. Make announcements on social media and store pages. You may need to coordinate with other developers who can make posts on TT-Forums, Twitter, Reddit, Fosstodon, Discord, Steam, GOG, Microsoft Store, etc.

docs/symbol_server.md

@@ -1,34 +0,0 @@
-# OpenTTD's Symbol Server
-
-For all official releases, OpenTTD collects the Breakpad Symbols (SYM-files) and Microsoft's Symbols (PDB-files), and publishes them on our own Symbol Server (https://symbols.openttd.org).
-
-These symbol files are needed to analyze `crash.dmp` files as attached to issues by users.
-A `crash.dmp` is created on Windows, Linux, and MacOS when a crash happens.
-This combined with the `crash.log` should give a pretty good indication what was going on at the moment the game crashed.
-
-## Analyzing a crash.dmp
-
-### MSVC
-
-In MSVC you can add the above URL as Symbol Server (and please enable MSVC's for all other libraries), allowing you to analyze `crash.dmp`.
-
-Now simply open up the `crash.dmp`, and start debugging.
-
-### All other platforms
-
-The best tool to use is `minidump-stackwalk` as published in the Rust's cargo index:
-
-```bash
-cargo install --locked minidump-stackwalk
-```
-
-For how to install Rust, please see [here](https://doc.rust-lang.org/cargo/getting-started/installation.html).
-
-Now run the tool like:
-
-```bash
-minidump-stackwalk <crash.dmp> --symbols-url https://symbols.openttd.org
-```
-
-For convenience, the above Symbol Server also check with Mozilla's Symbol Server in case any other library but OpenTTD is requested.
-This means files like `libc`, `kernel32.dll`, etc are all available on the above mentioned Symbol Server.

known-bugs.md

@@ -1,426 +0,0 @@
-# OpenTTD's known bugs
-
-## Table of contents
-
-- 1.0) About
-- 2.0) Known bugs
-
-## 1.0) About
-
-All bugs listed below are marked as known. Please do not submit any bugs
-that are the same as these. If you do, do not act surprised, because
-we WILL flame you!
-
-The current list of known bugs that we intend to fix can be found in our
-bug tracking system at https://github.com/OpenTTD/OpenTTD/issues
-Also check the closed bugs when searching for your bug in this system as we
-might have fixed the bug in the mean time.
-
-## 2.0) Known bugs
-
-This section lists all known bugs that we do not intend to fix and the
-reasons why we think that fixing them is infeasible. We might make some
-minor improvements that reduce the scope of these bugs, but we will not
-be able to completely fix them.
-
-### No suitable AI can be found:
-
-If you have no AIs and an AI is started the so-called 'dummy' AI will
-be loaded. This AI does nothing but writing a message on the AI debug
-window and showing a red warning. There are basically two solutions
-for this problem: Either you set the number of AI players to 0 so that
-no AI is started. You find that setting at the top of the window in the
-"AI / Game Scripts Settings" window.
-
-The other solution is acquiring (downloading) some AI. The easiest way
-to do this is via the "Check Online Content" button in the main (intro)
-menu or directly in the "AI / Game Scripts Settings" dialogue via the
-"Check Online Content" button.
-
-### After a while of playing, colours get corrupted:
-
-In Windows 7 the background slideshow corrupts the colour mapping
-of OpenTTD's 8bpp screen modes. Workarounds for this are:
-
-* Switching to windowed mode, instead of fullscreen
-* Switching off background slideshow
-* Setting up the `32bpp-anim` or `32bpp-optimized` blitter
-
-### Custom vehicle type name is incorrectly aligned:
-
-Some NewGRFs use sprites that are bigger than normal in the "buy
-vehicle" window. Due to this they have to encode an offset for
-the vehicle type name. Upon renaming the vehicle type this encoded
-offset is stripped from the name because the "edit box" cannot show
-this encoding. As a result the custom vehicle type names will get
-the default alignment. The only way to (partially) fix this is by
-adding spaces to the custom name.
-
-### Clipping problems [#119]:
-
-In some cases sprites are not drawn as one would expect. Examples of
-this are aircraft that might be hidden below the runway or trees that
-in some cases are rendered over vehicles.
-
-The primary cause of this problem is that OpenTTD does not have enough
-data (like a 3D model) to properly determine what needs to be drawn in
-front of what. OpenTTD has bounding boxes but in lots of cases they
-are either too big or too small and then cause problems with what
-needs to be drawn in front of what. Also some visual tricks are used.
-
-For example trains at 8 pixels high, the catenary needs to be drawn
-above that. When you want to draw bridges on top of that, which are
-only one height level (= 8 pixels) higher, you are getting into some
-big problems.
-
-We can not change the height levels; it would require us to either
-redraw all vehicle or all landscape graphics. Doing so would mean we
-leave the Transport Tycoon graphics, which in effect means OpenTTD
-will not be a Transport Tycoon clone anymore.
-
-### Mouse scrolling not possible at the edges of the screen [#383] [#3966]:
-
-Scrolling the viewport with the mouse cursor at the edges of the screen
-in the same direction of the edge will fail. If the cursor is near the
-edge the scrolling will be very slow.
-
-OpenTTD only receives cursor position updates when the cursor is inside
-OpenTTD's window. It is not told how far you have moved the cursor
-outside of OpenTTD's window.
-
-### Lost trains ignore (block) exit signals [#1473]:
-
-If trains are lost they ignore block exit signals, blocking junctions
-with presignals. This is caused because the path finders cannot tell
-where the train needs to go. As such a random direction is chosen at
-each junction. This causes the trains to occasionally to make choices
-that are unwanted from a player's point of view.
-
-This will not be fixed because lost trains are in almost all cases a
-network problem, e.g. a train can never reach a specific place. This
-makes the impact of fixing the bug enormously small against the amount
-of work needed to write a system that prevents the lost trains from
-taking the wrong direction.
-
-### Vehicle owner of last transfer leg gets paid for all [#2427]:
-
-When you make a transfer system that switches vehicle owners. This
-is only possible with 'industry stations', e.g. the oil rig station
-the owner of the vehicle that does the final delivery gets paid for
-the whole trip. It is not shared amongst the different vehicle
-owners that have participated in transporting the cargo.
-
-This sharing is not done because it would enormously increase the
-memory and CPU usage in big games for something that is happening
-in only one corner case. We think it is not worth the effort until
-sharing of stations is an official feature.
-
-### Forbid 90 degree turns does not work for crossing PBS paths [#2737]:
-
-When you run a train through itself on a X junction with PBS turned on
-the train will not obey the 'forbid 90 degree turns' setting. This is
-due to the fact that we can not be sure that the setting was turned
-off when the track was reserved, which means that we assume it was
-turned on and that the setting does not hold at the time. We made it
-this way to allow one to change the setting in-game, but it breaks
-slightly when you are running your train through itself. Running a
-train through means that your network is broken and is thus a user
-error which OpenTTD tries to graciously handle.
-
-Fixing this bug means that we need to record whether this particular
-setting was turned on or off at the time the reservation was made. This
-means adding quite a bit of data to the savegame for solving an issue
-that is basically an user error. We think it is not worth the effort.
-
-### Duplicate (station) names after renaming [#3204]:
-
-After renaming stations one can create duplicate station names. This
-is done giving a station the same custom name as another station with
-an automatically generated name.
-
-The major part of this problem is that station names are translatable.
-Meaning that a station is called e.g. '<TOWN> Central' in English and
-'<TOWN> Centraal' in Dutch. This means that in network games the
-renaming of a town could cause the rename to succeed on some clients
-and fail at others. This creates an inconsistent game state that will
-be seen as a 'desync'. Secondly the custom names are intended to fall
-completely outside of the '<TOWN> <name>' naming of stations, so when
-you rename a town all station names are updated accordingly.
-
-As a result the decision has been made that all custom names are only
-compared to the other custom names in the same class and not compared
-to the automatically generated names.
-
-### Extreme CPU usage/hangs when using SDL and PulseAudio [#3294], OpenTTD hangs/freezes when closing, OpenTTD is slow, OpenTTD uses a lot of CPU:
-
-OpenTTD can be extremely slow/use a lot of CPU when the sound is
-played via SDL and then through PulseAudio's ALSA wrapper. Under the
-same configuration OpenTTD, or rather SDL, might hang when exiting
-the game. This problem is seen most in Ubuntu 9.04 and higher.
-
-This is because recent versions of the PulseAudio sound server
-are configured to use timer-based audio scheduling rather than
-interrupt-based audio scheduling. Configuring PulseAudio to force
-use of interrupt-based scheduling may resolve sound problems for
-some users. Under recent versions of Ubuntu Linux (9.04 and higher)
-this can be accomplished by changing the following line in the
-`/etc/pulse/default.pa` file:
-        `load-module module-udev-detect`
-to
-        `load-module module-udev-detect tsched=0`
-
-Note that PulseAudio must be restarted for changes to take effect. Older
-versions of PulseAudio may use the module-hal-detect module instead.
-Adding tsched=0 to the end of that line will have a similar effect.
-
-Another possible solution is selecting the "pulse" backend of SDL
-by either using `SDL_AUDIODRIVER=pulse openttd` at the command
-prompt or installing the `libsdl1.2debian-pulseaudio` package from
-Ubuntu's Universe repository. For other distributions a similar
-package needs to be installed.
-
-### OpenTTD not properly resizing with SDL on X [#3305]:
-
-Under some X window managers OpenTTD's window does not properly
-resize. You will either end up with a black bar at the right/bottom
-side of the window or you cannot see the right/bottom of the window,
-e.g. you cannot see the status bar. The problem is that OpenTTD does
-not always receive a resize event from SDL making it impossible for
-OpenTTD to know that the window was resized; sometimes moving the
-window will solve the problem.
-
-Window managers that are known to exhibit this behaviour are GNOME's
-and KDE's. With the XFCE's and LXDE's window managers the resize
-event is sent when the user releases the mouse.
-
-### Incorrect colours, crashes upon exit, debug warnings and smears upon window resizing with SDL on macOS [#3447]:
-
-Video handling with (lib)SDL under macOS is known to fail on some
-versions of macOS with some hardware configurations. Some of
-the problems happen only under some circumstances whereas others
-are always present.
-
-We suggest that the SDL video/sound backend is not used for OpenTTD
-in combinations with macOS.
-
-### Train crashes entering same junction from block and path signals [#3928]:
-
-When a train has reserved a path from a path signal to a two way
-block signal and the reservation passes a path signal through the
-back another train can enter the reserved path (only) via that
-same two way block signal.
-
-The reason for this has to do with optimisation; to fix this issue
-the signal update has to pass all path signals until it finds either
-a train or a backwards facing signal. This is a very expensive task.
-
-The (signal) setups that allow these crashes can furthermore be
-considered incorrectly signalled; one extra safe waiting point for
-the train entering from path signal just after the backwards facing
-signal (from the path signal train) resolves the issue.
-
-### Crashes when run in a VM using Parallels Desktop [#4003]:
-
-When the Windows version of OpenTTD is executed in a VM under
-Parallels Desktop a privileged instruction exception may be thrown.
-
-As OpenTTD works natively on macOS as well as natively on Windows and
-these native builds both don't exhibit this behaviour this crash is
-most likely due to a bug in the virtual machine, something out of
-the scope of OpenTTD. Most likely this is due to Parallels Desktop
-lacking support for RDTSC calls. The problem can be avoided by using
-other VM-software, Wine, or running natively on macOS.
-
-### Entry- and exit signals are not dragged [#4378]:
-
-Unlike all other signal types, the entry- and exit signals are not
-dragged but instead normal signals are placed on subsequent track
-sections. This is done on purpose as this is the usually more
-convenient solution. There are little to no occasions where more
-than one entry or exit signal in a row are useful. This is different
-for all other signal types where several in a row can serve one
-purpose or another.
-
-### (Temporary) wrong colours when switching to full screen [#4511]:
-
-On Windows it can happen that you temporarily see wrong colours
-when switching to full screen OpenTTD, either by starting
-OpenTTD in full screen mode, changing to full screen mode or by
-ALT-TAB-ing into a full screen OpenTTD. This is caused by the
-fact that OpenTTD, by default, uses 8bpp paletted output. The
-wrong colours you are seeing is a temporary effect of the video
-driver switching to 8bpp palette mode.
-
-This issue can be worked around in two ways:
-* Setting fullscreen_bpp to 32
-* Setting up the 32bpp-anim or 32bpp-optimized blitter
-
-### Can't run OpenTTD with the -d option from a MSYS console [#4587]:
-
-The MSYS console does not allow OpenTTD to open an extra console for
-debugging output. Compiling OpenTTD with the --enable-console
-configure option prevents this issue and allows the -d option to use
-the MSYS console for its output.
-
-### Unreadable characters for non-latin locales [#4607]:
-
-OpenTTD does not ship a non-latin font in its graphics files. As a
-result OpenTTD needs to acquire the font from somewhere else. What
-OpenTTD does is ask the operating system, or a system library, for
-the best font for a given language if the currently loaded font
-does not provide all characters of the chosen translation. This
-means that OpenTTD has no influence over the quality of the chosen
-font; it just does the best it can do.
-
-If the text is unreadable there are several steps that you can take
-to improve this. The first step is finding a good font and configure
-this in the configuration file. See section 9.0 of README.md for
-more information. You can also increase the font size to make the
-characters bigger and possible better readable.
-
-If the problem is with the clarity of the font you might want to
-enable anti-aliasing by setting the small_aa/medium_aa/large_aa
-settings to "true". However, anti-aliasing only works when a 32-bit
-blitter has been selected, e.g. `blitter = "32bpp-anim"`, as with the
-8 bits blitter there are not enough colours to properly perform the
-anti-aliasing.
-
-### Train does not crash with itself [#4635]:
-
-When a train drives in a circle the front engine passes through
-wagons of the same train without crashing. This is intentional.
-Signals are only aware of tracks, they do not consider the train
-length and whether there would be enough room for a train in some
-circle it might drive on. Also the path a train might take is not
-necessarily known when passing a signal.
-
-Checking all circumstances would take a lot of additional
-computational power for signals, which is not considered worth
-the effort, as it does not add anything to gameplay.
-
-Nevertheless trains shall not crash in normal operation, so making
-a train not crash with itself is the best solution for everyone.
-
-### Aircraft coming through wall in rotated airports [#4705]:
-
-With rotated airports, specifically hangars, you will see that the
-aircraft will show a part through the back wall of the hangar.
-
-This can be solved by only drawing a part of the plane when being
-at the back of the hangar, however then with transparency turned on
-the aircraft would be shown partially which would be even weirder.
-
-As such the current behaviour is deemed the least bad.
-The same applies to overly long ships and their depots.
-
-### Vehicles not keeping their "maximum" speed [#4815]:
-
-Vehicles that have not enough power to reach and maintain their
-advertised maximum speed might be constantly jumping between two
-speeds. This is due to the fact that speed and its calculations
-are done with integral numbers instead of floating point numbers.
-
-As a result of this a vehicle will never reach its equilibrium
-between the drag/friction and propulsion. So in effect it will be
-in a vicious circle of speeding up and slowing down due to being
-just at the other side of the equilibrium.
-
-Not speeding up when near the equilibrium will cause the vehicle to
-never come in the neighbourhood of the equilibrium and not slowing
-down when near the equilibrium will cause the vehicle to never slow
-down towards the equilibrium once it has come down a hill.
-
-It is possible to calculate whether the equilibrium will be passed,
-but then all acceleration calculations need to be done twice.
-
-### Settings not saved when OpenTTD crashes [#4846]:
-
-The settings are not saved when OpenTTD crashes for several reasons.
-The most important is that the game state is broken and as such the
-settings might contain invalid values, or the settings have not even
-been loaded yet. This would cause invalid or totally wrong settings
-to be written to the configuration file.
-
-A solution to that would be saving the settings whenever one changes,
-however due to the way the configuration file is saved this requires
-a flush of the file to the disk and OpenTTD needs to wait till that
-is finished. On some file system implementations this causes the
-flush of all 'write-dirty' caches, which can be a significant amount
-of data to be written. This can further be aggravated by spinning
-down disks to conserve power, in which case this disk needs to be
-spun up first. This means that many seconds may pass before the
-configuration file is actually written, and all that time OpenTTD
-will not be able to show any progress. Changing the way the
-configuration file is saved is not an option as that leaves us more
-vulnerable to corrupt configuration files.
-
-Finally, crashes should not be happening. If they happen they should
-be reported and fixed, so essentially fixing this is fixing the wrong
-thing. If you really need the configuration changes to be saved,
-and you need to run a version that crashes regularly, then you can
-use the `saveconfig` command in the console to save the settings.
-
-### Not all NewGRFs, AIs, game scripts are found [#4887]:
-
-Under certain situations, where the path for the content within a
-tar file is the same as other content on the file system or in another
-tar file, it is possible that content is not found. A more thorough
-explanation and solutions are described in section 4.4 of README.md.
-
-### Mouse cursor going missing with SDL [#4997]:
-
-Under certain circumstances SDL does not notify OpenTTD of changes with
-respect to the mouse pointer, specifically whether the mouse pointer
-is within the bounds of OpenTTD or not. For example, if you "Alt-Tab"
-to another application the mouse cursor will still be shown in OpenTTD,
-and when you move the mouse outside of the OpenTTD window so the cursor
-gets hidden, open/move another application on top of the OpenTTD window
-and then Alt-tab back into OpenTTD the cursor will not be shown.
-
-We cannot fix this problem as SDL simply does not provide the required
-information in these corner cases. This is a bug in SDL and as such
-there is little that we can do about it.
-
-### Trains might not stop at platforms that are currently being changed [#5553]:
-
-If you add tiles to or remove tiles from a platform while a train is
-approaching to stop at the same platform, that train can miss the place
-where it's supposed to stop and pass the station without stopping.
-
-This is caused by the fact that the train is considered to already
-have stopped if it's beyond its assigned stopping location. We can't
-let the train stop just anywhere in the station because then it would
-never leave the station if you have the same station in the order
-list multiple times in a row or if there is only one station
-in theorder list (see #5684).
-
-### Some houses and industries are not affected by transparency [#5817]:
-
-Some of the default houses and industries (f.e. the iron ore mine) are
-not affected by the transparency options. This is because the graphics
-do not (completely) separate the ground from the building.
-
-This is a bug of the original graphics, and unfortunately cannot be
-fixed with OpenGFX for the sake of maintaining compatibility with
-the original graphics.
-
-### Involuntary cargo exchange with cargodist via neutral station [#6114]:
-
-When two players serve a neutral station at an industry, a cross-company
-chain for cargo flow can and will be established which can only be
-interrupted if one of the players stops competing for the resources of
-that industry. There is an easy fix for this: If you are loading at the
-shared station make the order "no unload" and if you're unloading make
-it "no load". Cargodist will then figure out that it should not create
-such a route.
-
-### Incorrect ending year displayed in end of game newspaper [#8625]
-
-The ending year of the game is configurable, but the date displayed in
-the newspaper at the end of the game is part of the graphics, not text.
-
-So to fix this would involve fixing the graphics in every baseset,
-including the original. Additionally, basesets are free to put this
-text in different positions (which they do), making a proper solution
-to this infinitely more complex for a part of the game that fewer than
-1% of players ever see.

known-bugs.txt

@@ -0,0 +1,389 @@
+OpenTTD's known bugs
+------------------------------------------------------------------------
+
+
+Table of contents
+-----------------
+1.0) About
+2.0) Known bugs
+
+
+1.0) About
+---- -----
+All bugs listed below are marked as known. Please do not submit any bugs
+that are the same as these. If you do, do not act surprised, because
+we WILL flame you!
+
+The current list of known bugs that we intend to fix can be found in our
+bug tracking system at https://github.com/OpenTTD/OpenTTD/issues
+Also check the closed bugs when searching for your bug in this system as we
+might have fixed the bug in the mean time.
+
+
+2.0) Known bugs
+---- ----------------------------------
+This section lists all known bugs that we do not intend to fix and the
+reasons why we think that fixing them is infeasible. We might make some
+minor improvements that reduce the scope of these bugs, but we will not
+be able to completely fix them.
+
+No suitable AI can be found:
+        If you have no AIs and an AI is started the so-called 'dummy' AI will
+        be loaded. This AI does nothing but writing a message on the AI debug
+        window and showing a red warning. There are basically two solutions
+        for this problem: Either you set the number of AI players to 0 so that
+        no AI is started. You find that setting at the top of the window in the
+        "AI / Game Scripts Settings" window.
+        The other solution is acquiring (downloading) some AI. The easiest way
+        to do this is via the "Check Online Content" button in the main (intro)
+        menu or directly in the "AI / Game Scripts Settings" dialogue via the
+        "Check Online Content" button.
+
+After a while of playing, colours get corrupted:
+        In Windows 7 the background slideshow corrupts the colour mapping
+        of OpenTTD's 8bpp screen modes. Workarounds for this are:
+                a) Switching to windowed mode, instead of fullscreen
+                b) Switching off background slideshow
+                c) Setting up the 32bpp-anim or 32bpp-optimized blitter
+
+Custom vehicle type name is incorrectly aligned:
+        Some NewGRFs use sprites that are bigger than normal in the "buy
+        vehicle" window. Due to this they have to encode an offset for
+        the vehicle type name. Upon renaming the vehicle type this encoded
+        offset is stripped from the name because the "edit box" cannot show
+        this encoding. As a result the custom vehicle type names will get
+        the default alignment. The only way to (partially) fix this is by
+        adding spaces to the custom name.
+
+Clipping problems [#119]:
+        In some cases sprites are not drawn as one would expect. Examples of
+        this are aircraft that might be hidden below the runway or trees that
+        in some cases are rendered over vehicles.
+        The primary cause of this problem is that OpenTTD does not have enough
+        data (like a 3D model) to properly determine what needs to be drawn in
+        front of what. OpenTTD has bounding boxes but in lots of cases they
+        are either too big or too small and then cause problems with what
+        needs to be drawn in front of what. Also some visual tricks are used.
+        For example trains at 8 pixels high, the catenary needs to be drawn
+        above that. When you want to draw bridges on top of that, which are
+        only one height level (= 8 pixels) higher, you are getting into some
+        big problems.
+        We can not change the height levels; it would require us to either
+        redraw all vehicle or all landscape graphics. Doing so would mean we
+        leave the Transport Tycoon graphics, which in effect means OpenTTD
+        will not be a Transport Tycoon clone anymore.
+
+Mouse scrolling not possible at the edges of the screen [#383] [#3966]:
+        Scrolling the viewport with the mouse cursor at the edges of the screen
+        in the same direction of the edge will fail. If the cursor is near the
+        edge the scrolling will be very slow.
+        OpenTTD only receives cursor position updates when the cursor is inside
+        OpenTTD's window. It is not told how far you have moved the cursor
+        outside of OpenTTD's window.
+
+Lost trains ignore (block) exit signals [#1473]:
+        If trains are lost they ignore block exit signals, blocking junctions
+        with presignals. This is caused because the path finders cannot tell
+        where the train needs to go. As such a random direction is chosen at
+        each junction. This causes the trains to occasionally to make choices
+        that are unwanted from a player's point of view.
+        This will not be fixed because lost trains are in almost all cases a
+        network problem, e.g. a train can never reach a specific place. This
+        makes the impact of fixing the bug enormously small against the amount
+        of work needed to write a system that prevents the lost trains from
+        taking the wrong direction.
+
+Vehicle owner of last transfer leg gets paid for all [#2427]:
+        When you make a transfer system that switches vehicle owners. This
+        is only possible with 'industry stations', e.g. the oil rig station
+        the owner of the vehicle that does the final delivery gets paid for
+        the whole trip. It is not shared amongst the different vehicle
+        owners that have participated in transporting the cargo.
+        This sharing is not done because it would enormously increase the
+        memory and CPU usage in big games for something that is happening
+        in only one corner case. We think it is not worth the effort until
+        sharing of stations is an official feature.
+
+Forbid 90 degree turns does not work for crossing PBS paths [#2737]:
+        When you run a train through itself on a X junction with PBS turned on
+        the train will not obey the 'forbid 90 degree turns' setting. This is
+        due to the fact that we can not be sure that the setting was turned
+        off when the track was reserved, which means that we assume it was
+        turned on and that the setting does not hold at the time. We made it
+        this way to allow one to change the setting in-game, but it breaks
+        slightly when you are running your train through itself. Running a
+        train through means that your network is broken and is thus a user
+        error which OpenTTD tries to graciously handle.
+        Fixing this bug means that we need to record whether this particular
+        setting was turned on or off at the time the reservation was made. This
+        means adding quite a bit of data to the savegame for solving an issue
+        that is basically an user error. We think it is not worth the effort.
+
+Duplicate (station) names after renaming [#3204]:
+        After renaming stations one can create duplicate station names. This
+        is done giving a station the same custom name as another station with
+        an automatically generated name.
+        The major part of this problem is that station names are translatable.
+        Meaning that a station is called e.g. '<TOWN> Central' in English and
+        '<TOWN> Centraal' in Dutch. This means that in network games the
+        renaming of a town could cause the rename to succeed on some clients
+        and fail at others. This creates an inconsistent game state that will
+        be seen as a 'desync'. Secondly the custom names are intended to fall
+        completely outside of the '<TOWN> <name>' naming of stations, so when
+        you rename a town all station names are updated accordingly.
+        As a result the decision has been made that all custom names are only
+        compared to the other custom names in the same class and not compared
+        to the automatically generated names.
+
+Extreme CPU usage/hangs when using SDL and PulseAudio [#3294],
+OpenTTD hangs/freezes when closing, OpenTTD is slow, OpenTTD uses a lot of CPU:
+        OpenTTD can be extremely slow/use a lot of CPU when the sound is
+        played via SDL and then through PulseAudio's ALSA wrapper. Under the
+        same configuration OpenTTD, or rather SDL, might hang when exiting
+        the game. This problem is seen most in Ubuntu 9.04 and higher.
+
+        This is because recent versions of the PulseAudio sound server
+        are configured to use timer-based audio scheduling rather than
+        interrupt-based audio scheduling. Configuring PulseAudio to force
+        use of interrupt-based scheduling may resolve sound problems for
+        some users. Under recent versions of Ubuntu Linux (9.04 and higher)
+        this can be accomplished by changing the following line in the
+        /etc/pulse/default.pa file:
+                load-module module-udev-detect
+        to
+                load-module module-udev-detect tsched=0
+        Note that PulseAudio must be restarted for changes to take effect. Older
+        versions of PulseAudio may use the module-hal-detect module instead.
+        Adding tsched=0 to the end of that line will have a similar effect.
+
+        Another possible solution is selecting the "pulse" backend of SDL
+        by either using "SDL_AUDIODRIVER=pulse openttd" at the command
+        prompt or installing the 'libsdl1.2debian-pulseaudio' package from
+        Ubuntu's Universe repository. For other distributions a similar
+        package needs to be installed.
+
+OpenTTD not properly resizing with SDL on X [#3305]:
+        Under some X window managers OpenTTD's window does not properly
+        resize. You will either end up with a black bar at the right/bottom
+        side of the window or you cannot see the right/bottom of the window,
+        e.g. you cannot see the status bar. The problem is that OpenTTD does
+        not always receive a resize event from SDL making it impossible for
+        OpenTTD to know that the window was resized; sometimes moving the
+        window will solve the problem.
+        Window managers that are known to exhibit this behaviour are GNOME's
+        and KDE's. With the XFCE's and LXDE's window managers the resize
+        event is sent when the user releases the mouse.
+
+Incorrect colours, crashes upon exit, debug warnings and smears upon
+window resizing with SDL on macOS [#3447]:
+        Video handling with (lib)SDL under macOS is known to fail on some
+        versions of macOS with some hardware configurations. Some of
+        the problems happen only under some circumstances whereas others
+        are always present.
+        We suggest that the SDL video/sound backend is not used for OpenTTD
+        in combinations with macOS.
+
+Train crashes entering same junction from block and path signals [#3928]:
+        When a train has reserved a path from a path signal to a two way
+        block signal and the reservation passes a path signal through the
+        back another train can enter the reserved path (only) via that
+        same two way block signal.
+        The reason for this has to do with optimisation; to fix this issue
+        the signal update has to pass all path signals until it finds either
+        a train or a backwards facing signal. This is a very expensive task.
+        The (signal) setups that allow these crashes can furthermore be
+        considered incorrectly signalled; one extra safe waiting point for
+        the train entering from path signal just after the backwards facing
+        signal (from the path signal train) resolves the issue.
+
+Crashes when run in a VM using Parallels Desktop [#4003]:
+        When the Windows version of OpenTTD is executed in a VM under
+        Parallels Desktop a privileged instruction exception may be thrown.
+        As OpenTTD works natively on macOS as well as natively on Windows and
+        these native builds both don't exhibit this behaviour this crash is
+        most likely due to a bug in the virtual machine, something out of
+        the scope of OpenTTD. Most likely this is due to Parallels Desktop
+        lacking support for RDTSC calls. The problem can be avoided by using
+        other VM-software, Wine, or running natively on macOS.
+
+Entry- and exit signals are not dragged [#4378]:
+        Unlike all other signal types, the entry- and exit signals are not
+        dragged but instead normal signals are placed on subsequent track
+        sections. This is done on purpose as this is the usually more
+        convenient solution. There are little to no occasions where more
+        than one entry or exit signal in a row are useful. This is different
+        for all other signal types where several in a row can serve one
+        purpose or another.
+
+Station build date is incorrect [#4415]:
+        The tile query tool will show the date of the last (re)construction
+        at the station and not the date of the first construction. This is
+        due to compatibility reasons with NewGRFs and the fact that it is
+        wrong to say that the station is built in a particular year when it
+        was completely destroyed/rebuilt later on.
+        The tile query tool can be fixed by changing the "Build date" text
+        to "Date at which the last (re)construction took place" but this is
+        deemed too specific and long for that window.
+
+(Temporary) wrong colours when switching to full screen [#4511]:
+        On Windows it can happen that you temporarily see wrong colours
+        when switching to full screen OpenTTD, either by starting
+        OpenTTD in full screen mode, changing to full screen mode or by
+        ALT-TAB-ing into a full screen OpenTTD. This is caused by the
+        fact that OpenTTD, by default, uses 8bpp paletted output. The
+        wrong colours you are seeing is a temporary effect of the video
+        driver switching to 8bpp palette mode.
+
+        This issue can be worked around in two ways:
+                a) Setting fullscreen_bpp to 32
+                b) Setting up the 32bpp-anim or 32bpp-optimized blitter
+
+Can't run OpenTTD with the -d option from a MSYS console [#4587]:
+        The MSYS console does not allow OpenTTD to open an extra console for
+        debugging output. Compiling OpenTTD with the --enable-console
+        configure option prevents this issue and allows the -d option to use
+        the MSYS console for its output.
+
+Unreadable characters for non-latin locales [#4607]:
+        OpenTTD does not ship a non-latin font in its graphics files. As a
+        result OpenTTD needs to acquire the font from somewhere else. What
+        OpenTTD does is ask the operating system, or a system library, for
+        the best font for a given language if the currently loaded font
+        does not provide all characters of the chosen translation. This
+        means that OpenTTD has no influence over the quality of the chosen
+        font; it just does the best it can do.
+
+        If the text is unreadable there are several steps that you can take
+        to improve this. The first step is finding a good font and configure
+        this in the configuration file. See section 9.0 of README.md for
+        more information. You can also increase the font size to make the
+        characters bigger and possible better readable.
+
+        If the problem is with the clarity of the font you might want to
+        enable anti-aliasing by setting the small_aa/medium_aa/large_aa
+        settings to "true". However, anti-aliasing only works when a 32-bit
+        blitter has been selected, e.g. blitter = "32bpp-anim", as with the
+        8 bits blitter there are not enough colours to properly perform the
+        anti-aliasing.
+
+Train does not crash with itself [#4635]:
+        When a train drives in a circle the front engine passes through
+        wagons of the same train without crashing. This is intentional.
+        Signals are only aware of tracks, they do not consider the train
+        length and whether there would be enough room for a train in some
+        circle it might drive on. Also the path a train might take is not
+        necessarily known when passing a signal.
+        Checking all circumstances would take a lot of additional
+        computational power for signals, which is not considered worth
+        the effort, as it does not add anything to gameplay.
+        Nevertheless trains shall not crash in normal operation, so making
+        a train not crash with itself is the best solution for everyone.
+
+Aircraft coming through wall in rotated airports [#4705]:
+        With rotated airports, specifically hangars, you will see that the
+        aircraft will show a part through the back wall of the hangar.
+        This can be solved by only drawing a part of the plane when being
+        at the back of the hangar, however then with transparency turned on
+        the aircraft would be shown partially which would be even weirder.
+        As such the current behaviour is deemed the least bad.
+        The same applies to overly long ships and their depots.
+
+Vehicles not keeping their "maximum" speed [#4815]:
+        Vehicles that have not enough power to reach and maintain their
+        advertised maximum speed might be constantly jumping between two
+        speeds. This is due to the fact that speed and its calculations
+        are done with integral numbers instead of floating point numbers.
+        As a result of this a vehicle will never reach its equilibrium
+        between the drag/friction and propulsion. So in effect it will be
+        in a vicious circle of speeding up and slowing down due to being
+        just at the other side of the equilibrium.
+
+        Not speeding up when near the equilibrium will cause the vehicle to
+        never come in the neighbourhood of the equilibrium and not slowing
+        down when near the equilibrium will cause the vehicle to never slow
+        down towards the equilibrium once it has come down a hill.
+
+        It is possible to calculate whether the equilibrium will be passed,
+        but then all acceleration calculations need to be done twice.
+
+Settings not saved when OpenTTD crashes [#4846]:
+        The settings are not saved when OpenTTD crashes for several reasons.
+        The most important is that the game state is broken and as such the
+        settings might contain invalid values, or the settings have not even
+        been loaded yet. This would cause invalid or totally wrong settings
+        to be written to the configuration file.
+
+        A solution to that would be saving the settings whenever one changes,
+        however due to the way the configuration file is saved this requires
+        a flush of the file to the disk and OpenTTD needs to wait till that
+        is finished. On some file system implementations this causes the
+        flush of all 'write-dirty' caches, which can be a significant amount
+        of data to be written. This can further be aggravated by spinning
+        down disks to conserve power, in which case this disk needs to be
+        spun up first. This means that many seconds may pass before the
+        configuration file is actually written, and all that time OpenTTD
+        will not be able to show any progress. Changing the way the
+        configuration file is saved is not an option as that leaves us more
+        vulnerable to corrupt configuration files.
+
+        Finally, crashes should not be happening. If they happen they should
+        be reported and fixed, so essentially fixing this is fixing the wrong
+        thing. If you really need the configuration changes to be saved,
+        and you need to run a version that crashes regularly, then you can
+        use the 'saveconfig' command in the console to save the settings.
+
+Not all NewGRFs, AIs, game scripts are found [#4887]:
+        Under certain situations, where the path for the content within a
+        tar file is the same as other content on the file system or in another
+        tar file, it is possible that content is not found. A more thorough
+        explanation and solutions are described in section 4.4 of README.md.
+
+Mouse cursor going missing with SDL [#4997]:
+        Under certain circumstances SDL does not notify OpenTTD of changes with
+        respect to the mouse pointer, specifically whether the mouse pointer
+        is within the bounds of OpenTTD or not. For example, if you "Alt-Tab"
+        to another application the mouse cursor will still be shown in OpenTTD,
+        and when you move the mouse outside of the OpenTTD window so the cursor
+        gets hidden, open/move another application on top of the OpenTTD window
+        and then Alt-tab back into OpenTTD the cursor will not be shown.
+
+        We cannot fix this problem as SDL simply does not provide the required
+        information in these corner cases. This is a bug in SDL and as such
+        there is little that we can do about it.
+
+Trains might not stop at platforms that are currently being changed [#5553]:
+        If you add tiles to or remove tiles from a platform while a train is
+        approaching to stop at the same platform, that train can miss the place
+        where it's supposed to stop and pass the station without stopping.
+        This is caused by the fact that the train is considered to already
+        have stopped if it's beyond its assigned stopping location. We can't
+        let the train stop just anywhere in the station because then it would
+        never leave the station if you have the same station in the order
+        list multiple times in a row or if there is only one station
+        in theorder list (see #5684).
+
+Some houses and industries are not affected by transparency [#5817]:
+        Some of the default houses and industries (f.e. the iron ore mine) are
+        not affected by the transparency options. This is because the graphics
+        do not (completely) separate the ground from the building.
+        This is a bug of the original graphics, and unfortunately cannot be
+        fixed with OpenGFX for the sake of maintaining compatibility with
+        the original graphics.
+
+Involuntary cargo exchange with cargodist via neutral station [#6114]:
+        When two players serve a neutral station at an industry, a cross-company
+        chain for cargo flow can and will be established which can only be
+        interrupted if one of the players stops competing for the resources of
+        that industry. There is an easy fix for this: If you are loading at the
+        shared station make the order "no unload" and if you're unloading make
+        it "no load". Cargodist will then figure out that it should not create
+        such a route.
+
+Incorrect ending year displayed in end of game newspaper [#8625]
+        The ending year of the game is configurable, but the date displayed in
+        the newspaper at the end of the game is part of the graphics, not text.
+        So to fix this would involve fixing the graphics in every baseset,
+        including the original. Additionally, basesets are free to put this
+        text in different positions (which they do), making a proper solution
+        to this infinitely more complex for a part of the game that fewer than
+        1% of players ever see.

media/baseset/CMakeLists.txt

@@ -18,10 +18,6 @@ set(BASESET_OTHER_SOURCE_FILES
         ${CMAKE_CURRENT_SOURCE_DIR}/opntitle.dat
         ${CMAKE_CURRENT_SOURCE_DIR}/orig_extra.grf
         ${CMAKE_CURRENT_SOURCE_DIR}/../openttd.32.bmp
-        ${CMAKE_CURRENT_SOURCE_DIR}/OpenTTD-Sans.ttf
-        ${CMAKE_CURRENT_SOURCE_DIR}/OpenTTD-Serif.ttf
-        ${CMAKE_CURRENT_SOURCE_DIR}/OpenTTD-Small.ttf
-        ${CMAKE_CURRENT_SOURCE_DIR}/OpenTTD-Mono.ttf
 )
 
 # Done by the subdirectories, if nforenum / grfcodec is installed
@@ -53,7 +49,6 @@ foreach(BASESET_SOURCE_FILE IN LISTS BASESET_SOURCE_FILES)
             MAIN_DEPENDENCY ${BASESET_SOURCE_FILE}
             DEPENDS ${LANG_SOURCE_FILES}
                     ${BASESET_EXTRAGRF_FILE}
-                    ${BASESET_EXTRAGRF_FILE}.hash
                     ${CMAKE_SOURCE_DIR}/cmake/scripts/Baseset.cmake
             WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
             COMMENT "Generating ${BASESET_SOURCE_FILE_NAME} baseset metadata file"
@@ -67,7 +62,7 @@ foreach(BASESET_OTHER_SOURCE_FILE IN LISTS BASESET_OTHER_SOURCE_FILES)
     get_filename_component(BASESET_OTHER_SOURCE_FILE_NAME "${BASESET_OTHER_SOURCE_FILE}" NAME)
     set(BASESET_OTHER_BINARY_FILE "${CMAKE_BINARY_DIR}/baseset/${BASESET_OTHER_SOURCE_FILE_NAME}")
 
-    add_custom_command_timestamp(OUTPUT ${BASESET_OTHER_BINARY_FILE}
+    add_custom_command(OUTPUT ${BASESET_OTHER_BINARY_FILE}
             COMMAND ${CMAKE_COMMAND} -E copy
                     ${BASESET_OTHER_SOURCE_FILE}
                     ${BASESET_OTHER_BINARY_FILE}

media/baseset/OpenTTD-font.md

@@ -1,6 +0,0 @@
-# OpenTTD TrueType font
-
-The OpenTTD TrueType font was created by Zephyris and is maintained on [Github](https://github.com/zephyris/openttd-ttf).
-It is licensed under GPL-2.0.
-
-The currently included files correspond to release v0.6.