63d9bb93b8
Codechange: migrate from C-style GetString to C++-style GetString
2023-05-21 21:17:12 +02:00
Peter Nelson
56085be9bd
Codechange: Move includes for common STL headers to stdafx.
2023-05-17 10:14:41 +01:00
PeterN
e97bf271dc
Codechange: Make SpriteType, CargoSortType, SourceType and ScriptType enum classes. ( #10663 )
...
This avoids a (soft) namespace conflict between the four ST_* enums.
2023-04-16 20:00:55 +01:00
PeterN
c1077212d7
Codechange: Use a shared_ptr for viewport overlay. ( #10586 )
2023-03-31 16:06:36 +01:00
6ba55e663e
Codechange: do not hide variables with other variables
2023-01-29 07:21:34 +01:00
f001e84e5e
Codechange: use RAII to automatically restore _cur_dpi after use
2023-01-28 20:33:02 +01:00
04d10b3d2d
Codechange: instead of global pointer to stack variable, just put variable in that global
...
Removes one indirection and a dangling pointer to a stack location
2023-01-28 17:23:30 +01:00
71b46db8d0
Cleanup: remove commented out code
2023-01-26 23:47:55 +01:00
fe2bcd2a58
Codechange: migrate size related functions to Map structure
2023-01-21 17:11:40 +01:00
PeterN
c8cc61d889
Fix #10150 : Force FS_SMALL for small viewport signs. ( #10283 )
...
* Fix #10150 : Force FS_SMALL for small viewport signs.
This is a workaround for string widths being different with mixed
font-sizes.
* Fix: Flag small sign shadow as small text.
(This method of drawing shadows is hilarious and needs replacing, but
this is a quick fix.)
2022-12-25 13:29:38 +00:00
Peter Nelson
138198e971
Change: Separate ground sprite from foundation sprite offsets.
2022-12-23 15:43:11 +00:00
Peter Nelson
002fe67bef
Add: Optionally disable child sprites drawing relative to parent sprites offsets.
2022-12-23 15:43:11 +00:00
PeterN
f6e7e44169
Fix #10151 : Use smaller padding for viewport signs. ( #10272 )
...
Before variable-scaling, the padding was always 1x1 pixel. This was
changed to be scaled, except using the wrong dimension of 2x1 pixels
instead of 1x1 pixel.
2022-12-21 22:21:50 +00:00
Peter Nelson
890b2666d3
Change: Use scaled WidgetDimensions.
2022-11-12 18:28:39 +00:00
fbbc80f79e
Fix #9020 : Update station coverage highlight when adding/removing tiles
2022-03-10 20:54:45 +01:00
58cff7b081
Codechange: Un-bitstuff the remaining on-map commands.
2021-12-16 22:28:32 +01:00
7048e1522f
Codechange: Move flags in CommandProc in front of the command arguments.
2021-12-16 22:28:32 +01:00
33ca4f2b99
Codechange: Let the compile generate the master command table out of templated command traits.
...
This is using a non-intrusive type-traits like templated system, which
allows compile-time validation that the command table and the command
enum match up.
2021-12-16 22:28:32 +01:00
8ab267496b
Codechange: reference a string by its name, not with "another + 1" ( #9517 )
...
It is wrong anyway, as "TINY" normally is at -1. Just weird code.
2021-08-28 17:08:01 +02:00
55a11710a6
Codechange: convert printf DEBUG statements to fmt Debug statements
2021-06-13 12:45:45 +02:00
5799402f7a
Codechange: Rename window related DeleteXXX to match new behaviour
2021-05-29 21:08:25 +02:00
2e136285e1
Codechange: move from C-string to std::string for DoCommand
2021-05-29 19:02:18 +02:00
b791ffc6de
Fix: do not hide parameter by local variable with the same name
2021-05-27 18:30:56 +02:00
f96f113951
Codechange: use IterateFromBack/Front only if the order is important.
...
Use Iterate if the order does not matter.
2021-05-12 23:22:41 +02:00
22567a1f43
Codechange: use iterators instead of 'subranges' when iterating from a specific window.
...
Using iterators makes it easier to include or exclude the start window in the iteration.
2021-05-12 23:22:41 +02:00
14e92bd8e2
Codechange: Replace window related FOR_ALL with range-based for loops
2021-04-29 21:08:24 +02:00
3ede756d23
Fix: Viewport drag tooltips not being removed when dragging over other windows
2021-04-08 19:34:45 +02:00
b927da73c1
Fix 81d335b081: Use non-pulsating red highlight for coverage ( #8622 )
2021-02-07 16:20:26 +01:00
a4035af337
Codechange: Apply coding style ( #8640 )
...
* Fix: Missing or needed spaces
* Codechange: Remove space
* Codechange: Remove space
* Codechange: More missing spaces
* Codechange: Missing spaces
* Codechange: Remove space
* Codechange: Remove space
2021-02-05 11:00:36 +01:00
40d5fe1631
Fix eeb88e8: Trains reversed while paused do not correctly update sprite bounds ( #8540 )
2021-01-17 19:57:16 +01:00
9b800a96ed
Codechange: Remove min/max functions in favour of STL variants ( #8502 )
2021-01-08 11:16:18 +01:00
2d9fa81bd0
Feature: Plant clumps of trees in editor by dragging on the landscape
2020-12-27 01:03:27 +01:00
e82333cf77
Feature #7962 : Improve rendering of large viewports
2020-12-20 10:13:35 +01:00
5ca8a0bda9
Feature #7962 : Significantly improve sprite sorter performance
2020-12-20 10:13:35 +01:00
79240eab1e
Codechange: Make use of the improved C++17 emplace_back function.
2020-12-15 00:29:30 +01:00
a10013dd00
Codechange: Spell 'Viewport' consistently
...
Some places in the codebase misspell 'Viewport' as 'ViewPort' or 'view_port'.
This patch makes everything consistent.
2020-07-27 17:31:29 +01:00
8652a4db76
Cleanup: Give `SetDirtyBlocks` a more descriptive name.
2020-06-09 13:15:47 +01:00
14af8701df
Fix #6566 : Fix signed integer overflow in viewport draw area chunking
...
This caused drawing areas larger than 2097151 pixels at 8x zoom to
not be subdivided into smaller chunks as required.
This resulted in pathological performance issues in the sprite sorter.
2020-02-02 15:37:14 +01:00
ee7a8eebca
Codechange: Replace FOR_ALL_TOWNS with range-based for loops
2019-12-21 20:13:03 +01:00
869581eb23
Codechange: Replace FOR_ALL_SIGNS with range-based for loops
2019-12-21 20:13:03 +01:00
ddabfed1cd
Codechange: Replace station related FOR_ALL with range-based for loops
2019-12-21 20:13:03 +01:00
9900af38f5
Fix #7847 : Use ViewportSign coordinates for sign Kdtree coordinates ( #7849 )
...
Ensure the same coordinates are used for station/town/player signs regardless of how the landscape changes below it after the coordinates were first determined.
By keeping track of whether each ViewportSign is valid for Kdtree use (and only ever registering the viewport sign when the object is valid) a lot of code can be simplified and become more robust at the same time.
2019-12-01 23:17:33 +01:00
13cc8a0cee
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
b870596f15
Add #6887 : Option to show zone inside local authority boundary of towns
...
Can be found at town information > local authority window
Layout for button is same as Graph Keys
Turn on/off for every town individually
2019-08-17 21:45:20 +01:00
PeterN
2d0352d67f
Fix e8d397e4ee: Avoid using RemapCoords2 during savegame conversion. ( #7588 )
2019-05-13 12:27:35 +01:00
c9fe6e7b8f
Fix #7371 : Avoid dependency on foundations of town tile during saveload
2019-05-11 14:58:00 +02:00
96a4787710
Codechange: Set ZoomLevel's base type to byte instead of using ZoomLevelByte
2019-04-29 17:40:22 +01:00
peter1138
81d335b081
Feature: Add station coverage area display for towns.
2019-04-25 09:14:01 +02:00
peter1138
81f0f97406
Feature: Add existing station coverage area display when placing new station parts.
2019-04-25 09:14:01 +02:00
peter1138
b6733edd17
Feature: Add coverage area display for existing stations.
2019-04-25 09:14:01 +02:00
PeterN
c17736b493
Fix e8d397e: Invisible station/waypoint signs could still be clicked on. ( #7531 )
2019-04-20 17:49:54 +01:00
7c8e7c6b6e
Codechange: Use null pointer literal instead of the NULL macro
2019-04-10 23:22:20 +02:00
66dd7c3879
Fix: MSVC warnings ( #7423 )
2019-03-28 00:09:33 +01:00
c01a2e2a81
Codechange: Removed SmallVector completely
2019-03-26 20:15:57 +00:00
ab711e6942
Codechange: Replaced SmallVector::[Begin|End]() with std alternatives
2019-03-26 20:15:57 +00:00
a0f36a50e6
Codechange: Replaced SmallVector::Append() with std::vector::[push|emplace]_back()
2019-03-26 20:15:57 +00:00
097328c3d7
Codechange: Replaced SmallVector::Get() const with std alternatives
2019-03-26 20:15:57 +00:00
a690936ed7
Codechange: Replace SmallVector::Length() with std::vector::size()
2019-03-26 20:15:57 +00:00
bfd79e59dc
Codechange: Replace SmallVector::Clear() with std::vector::clear()
2019-03-26 20:15:57 +00:00
peter1138
1585c12bb9
Fix 4da83d2f66: Remove measurement tooltips when completed.
2019-03-21 19:14:41 +00:00
peter1138
4da83d2f66
Fix #7386 : Measurement tooltip for tunnels, aqueducts & docks did not display or flickered.
...
Measurement tooltip was auto-closed as the hover/right-click test for tooltips was not
satisfied in this case. This is fixed by keeping the tooltip visible and instead explicitly
closing the tooltip when the PlaceObject is cancelled/completed.
2019-03-20 23:00:32 +00:00
e3c639a09f
Remove: ENABLE_NETWORK switch
...
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
2019-03-20 19:24:55 +01:00
e8d397e4ee
Codechange: Make a merged k-d tree index of all viewport signs
2019-03-09 20:27:11 +01:00
PeterN
87ebfe1227
Fix #7004 : Mark linkgraph dirty to be rebuilt on next draw call. ( #7265 )
...
Previously the linkgraph was rebuilt before the viewport extents were finalized.
2019-02-23 19:19:41 +00:00
Peter Nelson
0749a291c4
Revert 479f13fc41, Fix #7133 , Fix #7136 : "Codechange: Tweak ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, #6583 )"
...
This reverts commit 479f13fc41
2019-02-03 19:39:20 +00:00
479f13fc41
Codechange: Tweak ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, #6583 )
2019-01-24 21:17:17 +01:00
05da5a177c
Codechange: Simplify marking tiles dirty when terraforming (Patch by adf88, #6583 )
2019-01-24 21:17:17 +01:00
f744dea0ff
Fix: jumping effect when scrolling viewport over bottom edge of the map (Patch by adf88, #6583 )
2019-01-24 21:17:17 +01:00
f0290d5de7
Codechange: Add InverseRemapCoords2 function for remapping viewport coordinates to underlying tile coordinates (Patch by adf88, #6583 )
2019-01-24 21:17:17 +01:00
9d75600ac0
Fix: Round up deltas for smooth scrolling, so target will be reached
2019-01-20 19:43:56 +00:00
d8ccad91f9
Fix: Some code and comment typos
...
Found with codespell
2019-01-17 22:01:07 +00:00
1a1204472e
Revert: Sprite sorting optimisation sorted incorrectly.
...
This reverts commit 25ab9c1997
2018-11-18 17:30:28 +01:00
52ed3bcbaa
Remove: A few bits of dead code
2018-10-31 12:41:49 +01:00
25ab9c1997
Codechange: Improve (un)zoom performance
...
When zooming out with a high res display, there can be about 150k sprites
to be sorted before displaying. With the O(n^2) complexity of the sprite
sorter, this can take several seconds.
This patch works around this by sorting the sprites by the xmin coordinate
first using QSort, which later allows an early bailout out of the inner
loop. This is enough to cut down the full unzoom time on a 4k display to a
fraction of second.
2018-10-26 20:22:38 +02:00
2a868b9f3b
Feature: Framerate display window ( #6822 )
...
Frame rate and various game loop/graphics timing measurements and graphs. Accessible via the Help menu, and can print some stats in the console via the fps command.
2018-07-19 21:17:07 +02:00
cfb8092397
Fix b4b98e5165: Use FALLTHROUGH attribute with correct indentation.
2018-04-30 21:52:40 +02:00
8e4bce58ea
Feature: GS methods to scroll viewport for players ( #6745 )
2018-04-24 19:19:00 +02:00
b4b98e5165
(svn r27893) -Codechange: Use fallthrough attribute. (LordAro)
2017-08-13 18:38:42 +00:00
3cd390b2ce
(svn r27344) -Doc: Documenting the (Re)setObjectToPlace functions.
2015-07-28 08:16:52 +00:00
4830497f0b
(svn r27340) -Fix [FS#6338]: Silence warning by moving _string_colourmap to a file no its own. (Cif)
2015-07-26 09:47:17 +00:00
9fb56ca02e
(svn r27248) -Fix [FS#6257]: Town labels on smallmap and zoomed-out viewports were not centered. (_dp_)
2015-04-25 11:58:19 +00:00
f26e9bf59d
(svn r27162) -Fix [FS#6208]: Tile selection was drawn outside of map in some cases. (adf88)
2015-02-22 15:05:48 +00:00
3adf082db2
(svn r27161) -Fix [FS#6156] [FS#6206]: Reimplement the viewport drawing algorithm.
2015-02-22 14:42:34 +00:00
cfac8dbbc6
(svn r27160) -Fix: Division of signed values by TILE_SIZE requires cast to stay signed.
2015-02-22 14:14:30 +00:00
06d1d50884
(svn r27158) -Codechange: Simplify mapping from viewport to smallmap coordinates by duplicating less code.
2015-02-22 14:10:44 +00:00
e8e49e5dda
(svn r27157) -Fix: Mark bridge middle tiles dirty when building/removing/changing bridges.
2015-02-22 14:01:24 +00:00
2e1be6081d
(svn r27148) -Fix: Rounding and unit-conversion inconsistencies in calls to MarkAllViewportsDirty.
2015-02-14 12:53:07 +00:00
d534c80e94
(svn r27020) -Cleanup: some coding style consistency improvements (mostly spaces)
2014-10-15 18:31:37 +00:00
fddeeb5e49
(svn r27002) -Fix-ish: replace some non-ASCII characters with ASCII characters, e.g. @þaram to @param
2014-10-12 18:26:54 +00:00
a229fb79b5
(svn r26910) -Fix: account for the height of the landscape at the edge of the map to determine the scroll boundaries (based on patch by ic111)
2014-09-22 18:14:44 +00:00
adf237d550
(svn r26908) -Codechange: replace a magic number by a more logical calculation
2014-09-22 15:04:18 +00:00
073aa05da5
(svn r26900) -Fix-ish: dirty the appropriate area around map edges when terraforming there to prevent any artefacts from occuring (ic111)
2014-09-21 17:29:48 +00:00
4d619ad10e
(svn r26899) -Codechange: reduce the amount of tiles that needs to be drawn by taking the height of tiles into account instead of drawing way too many (ic111)
2014-09-21 17:27:37 +00:00
c9d7e89138
(svn r26870) -Fix (r15190): since freeform edges the 'tile height' at southern edge * 8 pixels just 'south' of the edge tile would not be drawn and would as a result not be refreshed causing artefacts to remain there. This adds a virtual slope to level 0 so it can be redrawn appropriately. Loosely based on patch by ic111
2014-09-21 08:19:32 +00:00
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
4055397915
(svn r26338) -Fix [FS#5908]: Don't redraw the link graph overlay if it's empty (MJP)
2014-02-15 12:19:46 +00:00
2618d960e3
(svn r26209) -Codechange: remove some template magic and simplify some code
2014-01-02 22:41:58 +00:00
3c94485ba0
(svn r26205) -Feature: SSE 4.1 sprite sorter, improving the sorting performance significantly (MJP)
...
For example with GCC 4.8, x86_64 Linux, Intel i5-3337U this patch improves the performance of Pile, Treham and Hamac test save games by about 10% in over-all run time at fast forward at 1920x1080 when zoomed out and when trees are not disabled.
2014-01-02 16:48:16 +00:00
3d99546107
(svn r25823) -Codechange [FS#5780]: Simplify if-cases in ViewportDrawStrings. (Juanjo)
2013-10-06 20:18:53 +00:00
f4c9ba4981
(svn r25546) -Fix: two small memory leaks
2013-06-30 20:40:49 +00:00
Rubidium
Peter Nelson
Tyler Trahan
Michael Lutz
Patric Stout
glx22
frosch
Jonathan G Rennison
Loïc Guilloux
SamuXarick
Matt Kimber
Charles Pigott
Niels Martin Hansen
dP
TechGeekNZ
S. D. Cloudt
Gabda
Henry Wilson
Johannes E. Krause
btzy
nikolas
Jindrich Makovicka
J0an Josep
alberth
fonsinchen