frosch
8027e31f47
Codechange: Remove virtual functions SpriteGroup::GetResult and GetNumResults. They are only implemented in and called via ResultSpriteGroup.
2025-04-29 10:35:10 +02:00
frosch
010b944173
Codechange: Move SpriteGroup cast from callers into Resolve.
2025-04-29 10:35:10 +02:00
Rubidium
af25eecc15
Codechange: use const for std::string_view where appropriate
2025-04-29 10:15:18 +02:00
Rubidium
78250c3bba
Codechange: remove const char* overloads when there are std::string_view and std::string& overloads
2025-04-29 10:14:53 +02:00
Peter Nelson
a5578166bb
Codechange: Pass Script Info by reference.
2025-04-28 23:08:20 +01:00
Peter Nelson
341cdbc16b
Codechange: Pass Script engine by reference.
2025-04-28 23:08:20 +01:00
Peter Nelson
72ca962b84
Codechange: Pass ScriptInstance by reference.
2025-04-28 23:08:20 +01:00
Peter Nelson
13fcc0900e
Change: Use enum/bitset to track which script configuration items are defined. ( #14150 )
...
Removes magic numbers, and simplifies compatibility. It is no longer necessary to provide values which won't be used.
2025-04-28 23:07:57 +01:00
Rubidium
b20b56d5fc
Codechange: store revision information in C++ style strings
2025-04-28 23:48:32 +02:00
Rubidium
8b1c1cc33d
Codechange: provide 'sv' (string_view) literals globally
2025-04-28 23:39:33 +02:00
Rubidium
be53bd320d
Codechange: replace char* from settingsgen
2025-04-28 23:27:46 +02:00
frosch
47b5ca6115
Fix: [NewGRF] Computed VarAction2 callback results were not always properly masked to 15 bit results.
2025-04-28 23:25:31 +02:00
frosch
d90f6f01cc
Codechange: CALLBACK_FAILED is an internal constant, do not use it as numeric value in VA2 computations.
2025-04-28 23:25:31 +02:00
frosch
30b1eb6e5f
Fix: [NewGRF] The result of Action123 evaluation affected rerandomisation in a weird corner case. ( #14139 )
...
Rerandomisation does not care about the Resolve result.
But we skipped it, in case of 'invalid SpriteGroup reference'.
2025-04-28 23:24:42 +02:00
frosch
b281c5616e
Change: [NewGRF] If Action123 does not resolve in a valid SpriteSet, prefer drawing the default sprite instead of an invalid sprite.
2025-04-28 22:20:54 +02:00
frosch
7b08170ac8
Codechange: Replace a magic value with a maybe less magical constant.
2025-04-28 22:20:54 +02:00
Rubidium
360670626b
Codechange: replace char* with std::string_view
2025-04-28 21:31:12 +02:00
Rubidium
9107c3f6c6
Codechange: add std::string_view variant of FileHandle::Open
2025-04-28 21:31:12 +02:00
Peter Nelson
2c4897c2cd
Codechange: Use EnumBitSet for HouseZones. ( #14137 )
2025-04-28 20:27:43 +01:00
frosch
f5a9eae8b1
Fix: [NewGRF] AI station construction callback did not work for stations with ID >= 0x100.
2025-04-28 20:50:13 +02:00
frosch
e2084bbdcd
Codechange: Replace out parameters with result tuples.
2025-04-28 20:50:13 +02:00
frosch
0c6426cb2d
Fix: Out-of-bounds read, if NewGRF stations provided no spritesets.
2025-04-28 20:49:20 +02:00
frosch
0f1ef96ca1
Codechange: Road stops do not use RealSpriteGroup, ResolveReal is never called.
2025-04-28 20:49:20 +02:00
Rubidium
9116f96e2e
Codechange: replace char * with std::string_view
2025-04-28 17:53:18 +02:00
Rubidium
c6ea0ce961
Codechange: use std::span for transferring data in network code
2025-04-28 17:53:18 +02:00
frosch
b7e7f08f78
Codechange: Simplify usage of GRFFileProps by adding some common helper methods.
2025-04-28 13:44:46 +02:00
frosch
46494c6d44
Codechange: Rename GRFFileProps to SubstituteGRFFileProps.
2025-04-28 13:44:46 +02:00
Richard Wheeler
298e02d593
Fix: List Ctrl+Click behaviour for vehicle details tooltip ( #14127 )
...
Also change mention of "road vehicle" to "vehicle", in line with vehicle order, refit, reverse, etc. tooltips. Fixes #14128
2025-04-28 07:00:18 +01:00
translators
68ba2735ea
Update: Translations from eints
...
swedish: 109 changes by Brickblock1
spanish (mexican): 1 change by absay
english (us): 1 change by 2TallTyler
2025-04-28 04:46:30 +00:00
Rubidium
794ba1f5da
Fix 29ceaf0a8: checking std::optional against nullptr caused crash
2025-04-27 21:10:12 +02:00
Rubidium
49ef3eee13
Codechange: replace char* with std::string_view
2025-04-27 20:08:02 +02:00
frosch
e1859df1c0
Codechange: Use enums as keys for the spritegroups in FixedGRFFileProps.
2025-04-27 19:50:51 +02:00
frosch
05504ec463
Codechange: Use SingleGRFFileProps, if the feature has no spritegroup keys.
2025-04-27 19:50:51 +02:00
frosch
41a20e512d
Codechange: Use proper enum type to index sprite groups in VariableGRFFileProps.
2025-04-27 19:50:51 +02:00
frosch
893aa0fb91
Codechange: Add an explicit enum member for the default spritegroup of badges.
2025-04-27 19:50:51 +02:00
Rubidium
29ceaf0a84
Codechange: use std::string_view over const char *
2025-04-27 18:04:04 +02:00
Rubidium
c7056866a3
Codechange: remove manual param count; in all cases strlen(params) == nparams
2025-04-27 17:57:53 +02:00
Rubidium
781187b8a6
Codechange: replace C-style strings with std::string_view related to strings functions
2025-04-27 17:57:42 +02:00
Rubidium
4e3e3d5be6
Codechange: introduce transparent hash lookup for strings
2025-04-27 17:57:42 +02:00
Peter Nelson
7bbf380931
Fix #14125 , 828e808444: NewGRF sounds were not loaded. ( #14130 )
...
NewGRF Action 11 should be handled in both INIT and ACTIVATION stages for sounds to be loaded.
Additionally the Action 0 feature test failed due to offsets involved.
2025-04-27 15:20:38 +00:00
Rubidium
b9667ec3d1
Codechange: use std::string_view for scripts
2025-04-27 17:00:25 +02:00
translators
864fe29028
Update: Translations from eints
...
english (au): 1 change by krysclarke
chinese (traditional): 1 change by KogentaSan
galician: 66 changes by pvillaverde
chinese (simplified): 1 change by WenSimEHRP
korean: 72 changes by telk5093
greek: 1 change by gh658804
russian: 1 change by Ln-Wolf
finnish: 1 change by hpiirai
portuguese: 1 change by jcteotonio
portuguese (brazilian): 1 change by pasantoro
polish: 1 change by pAter-exe
2025-04-27 04:44:13 +00:00
Peter Nelson
5a7893b730
Fix #14104 , 67a0fcc: Don't base timetable timing decisions on client settings. ( #14105 )
...
Client settings different between clients so the resultant timings may be different.
Partially reverts 67a0fcc
.
2025-04-26 22:39:01 +01:00
Peter Nelson
b87ce9c845
Change: Draw info headers as shade of window colour instead of pixel colour. ( #14123 )
...
Use the normal or lightest colour gradient to pick a suitable colour, instead of an arbitrary pixel colour.
(Except for the NewGRF window's info panel, this happens to be the same colour.)
2025-04-26 22:38:24 +01:00
frosch
55fad9c78a
Add: Limit height of settings description, and add scrollbar. ( #14102 )
2025-04-26 22:34:18 +02:00
frosch
d85f6dccc5
Fix 5575379: Crash with default airports. ( #14120 )
2025-04-26 22:29:01 +02:00
frosch
f62f728187
Codechange: Move usage of ResolverObjects to newgrf_xxx.cpp ( #14116 )
2025-04-26 20:53:50 +02:00
frosch
be39a05327
Fix: Road vehicle blocking and train collissions used slightly inconsistent distance thresholds.
2025-04-26 19:32:59 +02:00
frosch
3a70d1e2f7
Codechange: Pass the max-distance as parameter to VehiclesNearTileXY.
2025-04-26 19:32:59 +02:00
frosch
2df1233f1f
Codechange: Clamp the search area to valid values for the hash bucket selection.
...
The bucket selection uses a truncating division instead of a flooring division, so it does not work for negative positions.
Anyhow, there are no negative tile coordinates, so just clamp the search area.
2025-04-26 19:32:59 +02:00