mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

(svn r11290) -Fix: obiwan in the assertion that checked for overflows when writing a packet, causing still correctly sized packets to cause assertions.

release/0.6
rubidium 2007-10-18 17:44:59 +00:00
parent 405489d06f
commit 8795050ff7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/network/core/packet.cpp
View File

@ -133,7 +133,8 @@ void Packet::Send_uint64(uint64 data)
void Packet::Send_string(const char* data) void Packet::Send_string(const char* data)
{ {
assert(data != NULL); assert(data != NULL);
assert(this->size < sizeof(this->buffer) - strlen(data) - 1); /* The <= *is* valid due to the fact that we are comparing sizes and not the index. */
assert(this->size + strlen(data) + 1 <= sizeof(this->buffer));
while ((this->buffer[this->size++] = *data++) != '\0') {} while ((this->buffer[this->size++] = *data++) != '\0') {}
} }