1
0
Fork 0

Fix #14480: Music player playlist buttons are clickable but non-operational in intro menu. (#14482)

In the intro menu the music is hardcoded to be the introduction track. Therefore, prevent these buttons being clickable.
pull/14484/head
Peter Nelson 2025-07-27 16:03:47 +01:00 committed by GitHub
parent 79524af5fc
commit 009b7cbc57
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 4 deletions

View File

@ -683,13 +683,16 @@ struct MusicWindow : public Window {
void UpdateDisabledButtons()
{
/* Disable music control widgets if there is no music
* -- except Programme button! So you can still select a music set. */
/* Disable stop and play if there is no music. */
this->SetWidgetsDisabledState(BaseMusic::GetUsedSet()->num_available == 0, WID_M_STOP, WID_M_PLAY);
/* Disable most music control widgets if there is no music, or we are in the intro menu. */
this->SetWidgetsDisabledState(
BaseMusic::GetUsedSet()->num_available == 0,
WID_M_PREV, WID_M_NEXT, WID_M_STOP, WID_M_PLAY, WID_M_SHUFFLE,
BaseMusic::GetUsedSet()->num_available == 0 || _game_mode == GM_MENU,
WID_M_PREV, WID_M_NEXT, WID_M_SHUFFLE,
WID_M_ALL, WID_M_OLD, WID_M_NEW, WID_M_EZY, WID_M_CUSTOM1, WID_M_CUSTOM2
);
/* Also disable programme button in the intro menu (not in game; it is desirable to allow change of music set.) */
this->SetWidgetsDisabledState(_game_mode == GM_MENU, WID_M_PROGRAMME);
}
void UpdateWidgetSize(WidgetID widget, Dimension &size, [[maybe_unused]] const Dimension &padding, [[maybe_unused]] Dimension &fill, [[maybe_unused]] Dimension &resize) override