Peter Nelson
88d2850afd
Codechange: Use std::list instead of C-linked list for ini files.
...
This removes self-management of memory with new/delete and allows simpler iteration.
2023-10-11 12:31:21 +01:00
Peter Nelson
2f714f32f5
Codechange: Move initialization of group-type to CreateGroup function.
2023-10-11 12:31:20 +01:00
Peter Nelson
4fad6c4ad2
Codechange: Pass initializer list instead of null-terminated list of group types.
2023-10-11 12:31:20 +01:00
Peter Nelson
59ac96d16c
Codechange: Remove create parameter from IniLoadFile::GetGroup.
...
GetGroup now only returns nullptr if the group does not exist.
Use GetOrCreateGroup to create a group.
This avoids creating groups while reading ini files.
2023-10-11 12:31:19 +01:00
Peter Nelson
c28273cb39
Codechange: Correct scope of IniItem for for-loop.
2023-10-11 12:31:19 +01:00
Peter Nelson
00bcb4f3e1
Codechange: Split GetGroup into GetGroup/GetOrCreateGroup.
...
This follows the pattern used for GetItem/GetOrCreateItem, and allows use
of references where we know the group must exist.
2023-10-11 12:31:18 +01:00
Peter Nelson
5c3ff62b2f
Codechange: Test for nullptr instead of treating pointer as boolean.
2023-10-11 12:31:18 +01:00
Peter Nelson
abcbb620df
Codechange: Add CreateGroup/CreateItem methods for ini files.
...
This abstracts the internals a bit.
2023-10-11 12:31:17 +01:00
Peter Nelson
714364c84d
Codechange: Pass ini file by reference and prefer automatic storage.
...
This avoids new/delete operations, and (not) checking for nullptr.
2023-10-11 12:31:17 +01:00
Peter Nelson
b7d3cf3b64
Codechange: Accept std::string in RemoveGroup().
2023-10-11 12:31:12 +01:00
Peter Nelson
cda6f24fe8
Change: Filter duplicate paths from valid search path list. ( #11363 )
2023-10-09 21:38:13 +00:00
0458c15060
Cleanup: [MacOS] Remove unneeded WITH_SDL checks ( #11360 )
2023-10-09 19:35:15 +02:00
Peter Nelson
ac9db3f5aa
Codechange: Don't use bit-field in Yapf rail node. ( #11362 )
...
Compacting 3 booleans into 3 bits could save memory allocation, however this data is inside a union which also contains a 4-byte integer. As such this gives the cost penalty of a bit-field without any benefit.
2023-10-09 12:11:55 +00:00
84201a8520
Update: Translations from eints
...
chinese (traditional): 80 changes by wpi3
chinese (simplified): 1 change by WenSimEHRP
2023-10-07 18:37:44 +00:00
Peter Nelson
2fd3d943aa
Fix 94167dfd: Don't shade the currently selected engine in autoreplace window. ( #11354 )
...
This breaks #7729 which specifically allows autoreplace of same engine types, and also did not work properly if the engine had been built during the current game session.
2023-10-06 21:09:24 +01:00
89acfc7ff9
Update: Translations from eints
...
chinese (simplified): 1 change by WenSimEHRP
indonesian: 12 changes by liimee
2023-10-04 18:39:06 +00:00
Peter Nelson
d1a94d75e1
Fix: Incorrect include path for timers. ( #11351 )
2023-10-04 17:02:16 +01:00
7145b7060a
Update: Translations from eints
...
romanian: 3 changes by bnegrut
2023-10-03 18:39:41 +00:00
c794676928
Fix #10763 , Fix #11168 : Display variant groups that consist only of unavailable sub-groups ( #11342 )
2023-10-03 12:43:15 +00:00
Peter Nelson
5869f790d8
Fix: Check for engine variant loops during NewGRF initialization. ( #11343 )
...
Invalid NewGRFs could set up an engine variant loop that never ends. This
was checked for in some places that evaluated variants, but not all. In
most cases this would result in the engines not appearing, but could
potentially cause an infinite loop and crash.
Instead, during NewGRF initialization detect loops and remove invalid
variants before setting display flags.
2023-10-03 12:14:32 +01:00
077b08bbfa
Fix #11261 : Set number of items correctly when choosing available airport set ( #11344 )
2023-10-03 12:58:44 +02:00
82c8720814
Fix #8846 : When upgrading NewGRF presets, copy NewGRF parameters only if the NewGRF are compatible. Otherwise reset to defaults.
2023-10-02 22:32:30 +02:00
d75a5e1a9a
Fix: Upgrading NewGRF presets could result in incomplete display of NewGRF parameters until restart.
2023-10-02 22:32:30 +02:00
c84219a42e
Update: Translations from eints
...
english (us): 1 change by 2TallTyler
vietnamese: 21 changes by KhoiCanDev
2023-09-30 18:37:10 +00:00
Peter Nelson
b5dc9328f2
Change: Store station blocked/wires/pylons flags in map. ( #11337 )
...
This stores three flags in unused map bits, and avoids having to look up
station graphics and custom station specs to determine blocked/wires/pylons
status.
This potentially affects rail pathfinding performance.
Savegame version is not bumped, as the flags can just be updated every
time.
2023-09-30 12:30:25 +01:00
fd79d34ba9
Update: Translations from eints
...
korean: 1 change by telk5093
2023-09-27 18:39:05 +00:00
beafdadde4
Update: Translations from eints
...
italian: 25 changes by Rivarossi
2023-09-26 18:39:04 +00:00
Peter Nelson
890146fecb
Codechange: Add -Wsuggest-override compilation flag.
2023-09-25 21:27:45 +01:00
Peter Nelson
015fbafe34
Codechange: Add missing override specifiers to squirrel.
2023-09-25 21:27:45 +01:00
Peter Nelson
49dae08a3b
Codechange: Add missing override specifiers.
2023-09-25 21:27:45 +01:00
a454773a73
Doc: Link 3rdparty licenses from README. ( #11333 )
2023-09-25 22:11:20 +02:00
a650194227
Update: Translations from eints
...
finnish: 1 change by hpiirai
2023-09-25 18:38:49 +00:00
976f8c474f
Update: Translations from eints
...
chinese (simplified): 139 changes by BYXxiaonanhui
catalan: 23 changes by J0anJosep
portuguese (brazilian): 1 change by pasantoro
2023-09-24 18:36:59 +00:00
f8303b0397
Update: Translations from eints
...
english (au): 1 change by krysclarke
russian: 1 change by Ln-Wolf
danish: 1 change by bscargo
dutch: 1 change by Afoklala
french: 1 change by ottdfevr
portuguese: 1 change by azulcosta
polish: 68 changes by pAter-exe
2023-09-22 18:37:34 +00:00
bec36c1f98
Cleanup ba67f39: CodeQL's dependency was forgotten to be removed
2023-09-21 21:48:35 +02:00
Peter Nelson
398c7e5f9d
Codechange: Use new function to get a bitmask of empty cargo types.
2023-09-21 18:29:02 +01:00
Peter Nelson
69ee38bd43
Codechange: Use GetAcceptanceMask() instead of duplicating it.
2023-09-21 18:29:02 +01:00
PeterN
6d675c8acf
Fix : #11329 : Don't assert vehicle list length is non-zero when only asked to set string parameter. ( #11330 )
...
Since #11321 , the vehicle list is not yet initialized when SetStringParameters is called, so a test that the vehicle list size is zero is triggered. However, doing this check in the SetStringParameters function is a bit out of its remit, so just remove it.
2023-09-21 13:24:53 +01:00
PeterN
cef6a5f79c
Fix #11326 : Update autoreplace scrollbar count after clearing engine list. ( #11327 )
2023-09-21 07:42:49 +01:00
6b7537646d
Fix: Allow NewGRF inspection of road tiles. ( #11323 )
2023-09-20 22:54:34 +01:00
Peter Nelson
122bfa2afd
Codechange: Use less locals for station free names bitmask.
2023-09-20 21:57:51 +01:00
Peter Nelson
aeaa552385
Codechange: Use std::bitset instead of bool array.
...
This avoids use of C-style pointers and memset.
2023-09-20 21:57:51 +01:00
Peter Nelson
2eacf36d0a
Codechange: List fallback station names by ID instead of magic number.
...
This improves readability and intention of the station name generator.
2023-09-20 21:57:51 +01:00
f40816503f
Codechange: Add enum items for dynmically created setting dropdowns.
2023-09-20 22:35:32 +02:00
39e67b6f4c
Codechange: Use existing widget ids instead of raw numbers.
2023-09-20 22:35:32 +02:00
e0df937247
Fix b5885295: NewGRF preset dropdown was broken.
2023-09-20 22:35:32 +02:00
72323ae9e6
Update: Translations from eints
...
danish: 20 changes by bscargo
2023-09-20 18:38:51 +00:00
b9a1cb5d7c
Fix: Spelling of NIHAirport. ( #11322 )
2023-09-20 20:22:37 +02:00
PeterN
a0c6259e33
Codechange: Don't access cargo filter before it is initialized. ( #11321 )
...
The cargo filter list is initialized during window OnInit, but the first
build of the filtered list occurred before this.
2023-09-20 08:58:08 +01:00
PeterN
48dc4219ea
Codechange: Don't pass GUI cargo filter constants to command system. ( #11320 )
...
CMD_BUILD_VEHICLE expects CT_INVALID to indicate a new vehicle should not
be refitted on build, but the code passed CF_NONE instead. CF_NONE has the
same numeric value at CT_INVALID, so the test passed, but...
2023-09-20 08:56:53 +01:00
Peter Nelson
Loïc Guilloux
translators
merni-ns
frosch
Rubidium
Joan Josep