Codechange: use default virtual destructors over empty destructors

src/gamelog_internal.h

@@ -30,7 +30,7 @@ using GrfIDMapping = std::map<uint32_t, GRFPresence>;
 
 struct LoggedChange {
 	LoggedChange(GamelogChangeType type = GLCT_NONE) : ct(type) {}
-	virtual ~LoggedChange() {}
+	virtual ~LoggedChange() = default;
 	virtual void FormatTo(std::back_insert_iterator<std::string> &output_iterator, GrfIDMapping &grf_names, GamelogActionType action_type) = 0;
 
 	GamelogChangeType ct;

src/ini_type.h

@@ -56,7 +56,7 @@ struct IniLoadFile {
 	const IniGroupNameList seq_group_names;  ///< list of group names that are sequences.
 
 	IniLoadFile(const IniGroupNameList &list_group_names = {}, const IniGroupNameList &seq_group_names = {});
-	virtual ~IniLoadFile() { }
+	virtual ~IniLoadFile() = default;
 
 	const IniGroup *GetGroup(std::string_view name) const;
 	IniGroup *GetGroup(std::string_view name);

src/network/network_crypto.h

@@ -40,7 +40,7 @@
  */
 class NetworkEncryptionHandler {
 public:
-	virtual ~NetworkEncryptionHandler() {}
+	virtual ~NetworkEncryptionHandler() = default;
 
 	/**
 	 * Get the size of the MAC (Message Authentication Code) used by the underlying encryption protocol.
@@ -70,7 +70,7 @@ public:
  */
 class NetworkAuthenticationPasswordRequest {
 public:
-	virtual ~NetworkAuthenticationPasswordRequest() {}
+	virtual ~NetworkAuthenticationPasswordRequest() = default;
 
 	/**
 	 * Reply to the request with the given password.
@@ -108,7 +108,7 @@ public:
  */
 class NetworkAuthenticationPasswordProvider {
 public:
-	virtual ~NetworkAuthenticationPasswordProvider() {}
+	virtual ~NetworkAuthenticationPasswordProvider() = default;
 
 	/**
 	 * Callback to return the password where to validate against.
@@ -139,7 +139,7 @@ public:
  */
 class NetworkAuthenticationAuthorizedKeyHandler {
 public:
-	virtual ~NetworkAuthenticationAuthorizedKeyHandler() {}
+	virtual ~NetworkAuthenticationAuthorizedKeyHandler() = default;
 
 	/**
 	 * Check whether the key handler can be used, i.e. whether there are authorized keys to check against.
@@ -189,7 +189,7 @@ using NetworkAuthenticationMethodMask = uint16_t;
  */
 class NetworkAuthenticationHandler {
 public:
-	virtual ~NetworkAuthenticationHandler() {}
+	virtual ~NetworkAuthenticationHandler() = default;
 
 	/**
 	 * Get the name of the handler for debug messages.

src/random_access_file_type.h

@@ -40,7 +40,7 @@ public:
 	RandomAccessFile(const RandomAccessFile&) = delete;
 	void operator=(const RandomAccessFile&) = delete;
 
-	virtual ~RandomAccessFile() {}
+	virtual ~RandomAccessFile() = default;
 
 	const std::string &GetFilename() const;
 	const std::string &GetSimplifiedFilename() const;

src/saveload/saveload_filter.h

@@ -24,9 +24,7 @@ struct LoadFilter {
 	}
 
 	/** Make sure the writers are properly closed. */
-	virtual ~LoadFilter()
+	virtual ~LoadFilter() = default;
-	{
-	}
 
 	/**
 	 * Read a given number of bytes from the savegame.
@@ -69,9 +67,7 @@ struct SaveFilter {
 	}
 
 	/** Make sure the writers are properly closed. */
-	virtual ~SaveFilter()
+	virtual ~SaveFilter() = default;
-	{
-	}
 
 	/**
 	 * Write a given number of bytes into the savegame.

src/script/api/script_object.hpp

@@ -44,7 +44,7 @@ typedef bool (ScriptAsyncModeProc)();
 class SimpleCountedObject {
 public:
 	SimpleCountedObject() : ref_count(0) {}
-	virtual ~SimpleCountedObject() {}
+	virtual ~SimpleCountedObject() = default;
 
 	inline void AddRef() { ++this->ref_count; }
 	void Release();

src/strgen/strgen.h

@@ -62,7 +62,7 @@ struct StringReader {
 	bool translation; ///< Are we reading a translation, implies !master. However, the base translation will have this false.
 
 	StringReader(StringData &data, const std::string &file, bool master, bool translation);
-	virtual ~StringReader() {}
+	virtual ~StringReader() = default;
 	void HandleString(char *str);
 
 	/**

src/tilearea_type.h

@@ -115,10 +115,7 @@ protected:
 	}
 
 public:
-	/** Some compilers really like this. */
+	virtual ~TileIterator() = default;
-	virtual ~TileIterator()
-	{
-	}
 
 	/**
 	 * Get the tile we are currently at.