mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Change: [strgen] Change warnings for translations into infos (#9406) 

Unless invoked with -w, --warning ("print a warning for any untranslated strings") or -t, --todo ("replace any untranslated strings with '<TODO>'").

Eints normally fixes the warnings after a Pull Request, so it is not really useful information for the developer to see as a warning.
pull/9298/head
Loïc Guilloux 2021-06-29 22:19:24 +02:00 committed by GitHub
parent 8336d21b25
commit b6fb020388
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/strgen/strgen.cpp
View File

@ -46,7 +46,11 @@ void CDECL strgen_warning(const char *s, ...)
va_start(va, s); va_start(va, s);
vseprintf(buf, lastof(buf), s, va); vseprintf(buf, lastof(buf), s, va);
va_end(va); va_end(va);
fprintf(stderr, LINE_NUM_FMT("warning"), _file, _cur_line, buf); if (_show_todo > 0) {
fprintf(stderr, LINE_NUM_FMT("warning"), _file, _cur_line, buf);
} else {
fprintf(stderr, LINE_NUM_FMT("info"), _file, _cur_line, buf);
}
_warnings++; _warnings++;
} }

6
src/strgen/strgen_base.cpp
View File

@ -818,9 +818,13 @@ void StringReader::ParseFile()
char buf[2048]; char buf[2048];
_warnings = _errors = 0; _warnings = _errors = 0;
_translation = this->master || this->translation; _translation = this->translation;
_file = this->file; _file = this->file;
/* Abusing _show_todo to replace "warning" with "info" for translations. */
_show_todo &= 3;
if (!this->translation) _show_todo |= 4;
/* For each new file we parse, reset the genders, and language codes. */ /* For each new file we parse, reset the genders, and language codes. */
MemSetT(&_lang, 0); MemSetT(&_lang, 0);
strecpy(_lang.digit_group_separator, ",", lastof(_lang.digit_group_separator)); strecpy(_lang.digit_group_separator, ",", lastof(_lang.digit_group_separator));