mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

(svn r13072) -Fix (r12995): possible out-of-bounds access

release/0.7
smatz 2008-05-13 18:39:15 +00:00
parent ab7a5568d7
commit ad8057ab76
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/engine.cpp
View File

@ -120,7 +120,11 @@ Engine::~Engine()
*/ */
void EngList_Sort(EngineList *el, EngList_SortTypeFunction compare) void EngList_Sort(EngineList *el, EngList_SortTypeFunction compare)
{ {
qsort(&((*el)[0]), el->size(), sizeof(EngineID), compare); size_t size = el->size();
/* out-of-bounds access at the next line for size == 0 (even with operator[] at some systems)
* generally, do not sort if there are less than 2 items */
if (size < 2) return;
qsort(&(el->at(0)), size, sizeof(EngineID), compare);
} }
/** Sort selected range of items (on indices @ <begin, begin+num_items-1>) /** Sort selected range of items (on indices @ <begin, begin+num_items-1>)