mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Fix: Violation of strict weak ordering in engine value/running cost sorter

pull/10697/head
Jonathan G Rennison 2023-04-23 11:59:58 +01:00 committed by PeterN
parent 684c7bbc93
commit a967cc4de2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/build_vehicle_gui.cpp
View File

@ -300,7 +300,7 @@ static bool EnginePowerVsRunningCostSorter(const GUIEngineListItem &a, const GUI
* since we want consistent sorting. * since we want consistent sorting.
* Also if both have no power then sort with reverse of running cost to simulate * Also if both have no power then sort with reverse of running cost to simulate
* previous sorting behaviour for wagons. */ * previous sorting behaviour for wagons. */
if (v_a == 0 && v_b == 0) return !EngineRunningCostSorter(a, b); if (v_a == 0 && v_b == 0) return EngineRunningCostSorter(b, a);
if (v_a == v_b) return EngineNumberSorter(a, b); if (v_a == v_b) return EngineNumberSorter(a, b);
return _engine_sort_direction != (v_a < v_b); return _engine_sort_direction != (v_a < v_b);
} }