mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Codechange: Ensure SDLK mappings stay in the expected order. (#12608) 

Add a constexpr constructor that ensures at compile-time that the source SDLK range matches the target range.
pull/12614/head
Peter Nelson 2024-05-02 23:19:08 +01:00 committed by GitHub
parent c17fa6032b
commit 90029beb49
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/video/sdl2_v.cpp
View File

@ -240,18 +240,24 @@ std::vector<int> VideoDriver_SDL_Base::GetListOfMonitorRefreshRates()
struct SDLVkMapping { struct SDLVkMapping {
SDL_Keycode vk_from; const SDL_Keycode vk_from;
uint8_t vk_count; const uint8_t vk_count;
uint8_t map_to; const uint8_t map_to;
bool unprintable; const bool unprintable;
constexpr SDLVkMapping(SDL_Keycode vk_first, SDL_Keycode vk_last, uint8_t map_first, [[maybe_unused]] uint8_t map_last, bool unprintable)
: vk_from(vk_first), vk_count(vk_first - vk_last + 1), map_to(map_first), unprintable(unprintable)
{
assert((vk_last - vk_first) == (map_last - map_first));
}
}; };
#define AS(x, z) {x, 1, z, false} #define AS(x, z) {x, x, z, z, false}
#define AM(x, y, z, w) {x, (uint8_t)(y - x + 1), z, false} #define AM(x, y, z, w) {x, y, z, w, false}
#define AS_UP(x, z) {x, 1, z, true} #define AS_UP(x, z) {x, x, z, z, true}
#define AM_UP(x, y, z, w) {x, (uint8_t)(y - x + 1), z, true} #define AM_UP(x, y, z, w) {x, y, z, w, true}
static const SDLVkMapping _vk_mapping[] = { static constexpr SDLVkMapping _vk_mapping[] = {
/* Pageup stuff + up/down */ /* Pageup stuff + up/down */
AS_UP(SDLK_PAGEUP, WKC_PAGEUP), AS_UP(SDLK_PAGEUP, WKC_PAGEUP),
AS_UP(SDLK_PAGEDOWN, WKC_PAGEDOWN), AS_UP(SDLK_PAGEDOWN, WKC_PAGEDOWN),

18
src/video/sdl_v.cpp
View File

@ -373,15 +373,21 @@ bool VideoDriver_SDL::ClaimMousePointer()
} }
struct SDLVkMapping { struct SDLVkMapping {
uint16_t vk_from; const uint16_t vk_from;
uint8_t vk_count; const uint8_t vk_count;
uint8_t map_to; const uint8_t map_to;
constexpr SDLVkMapping(SDL_Keycode vk_first, SDL_Keycode vk_last, uint8_t map_first, [[maybe_unused]] uint8_t map_last)
: vk_from(vk_first), vk_count(vk_first - vk_last + 1), map_to(map_first)
{
assert((vk_last - vk_first) == (map_last - map_first));
}
}; };
#define AS(x, z) {x, 1, z} #define AS(x, z) {x, x, z, z, false}
#define AM(x, y, z, w) {x, (uint8_t)(y - x + 1), z} #define AM(x, y, z, w) {x, y, z, w, false}
static const SDLVkMapping _vk_mapping[] = { static constexpr SDLVkMapping _vk_mapping[] = {
/* Pageup stuff + up/down */ /* Pageup stuff + up/down */
AM(SDLK_PAGEUP, SDLK_PAGEDOWN, WKC_PAGEUP, WKC_PAGEDOWN), AM(SDLK_PAGEUP, SDLK_PAGEDOWN, WKC_PAGEUP, WKC_PAGEDOWN),
AS(SDLK_UP, WKC_UP), AS(SDLK_UP, WKC_UP),