mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Codechange: Avoid call to memcpy using null pointer in TooltipsWindow constructor 

Strictly speaking, calling memcpy with src as a nullptr is undefined behaviour
and the optimiser is entitled to delete any null ptr checks which occur afterwards.
This removes the warning emitted by UndefinedBehaviorSantizer.
pull/6821/head
Jonathan G Rennison 2018-06-06 08:22:58 +01:00 committed by PeterN
parent cd966f3810
commit 71450881fc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/misc_gui.cpp
View File

@ -656,7 +656,7 @@ struct TooltipsWindow : public Window
this->string_id = str; this->string_id = str;
assert_compile(sizeof(this->params[0]) == sizeof(params[0])); assert_compile(sizeof(this->params[0]) == sizeof(params[0]));
assert(paramcount <= lengthof(this->params)); assert(paramcount <= lengthof(this->params));
memcpy(this->params, params, sizeof(this->params[0]) * paramcount); if (paramcount > 0) memcpy(this->params, params, sizeof(this->params[0]) * paramcount);
this->paramcount = paramcount; this->paramcount = paramcount;
this->close_cond = close_tooltip; this->close_cond = close_tooltip;