mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Cleanup: Use range iterator to evaluate DeterministicSpriteGroup.

pull/9175/head
Peter Nelson 2021-05-02 00:04:34 +01:00 committed by PeterN
parent 913d8a7f28
commit 6b0b1bb3de
1 changed files with 13 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/newgrf_spritegroup.cpp
View File

@ -141,18 +141,18 @@ static inline uint32 GetVariable(const ResolverObject &object, ScopeResolver *sc
/* Evaluate an adjustment for a variable of the given size. /* Evaluate an adjustment for a variable of the given size.
* U is the unsigned type and S is the signed type to use. */ * U is the unsigned type and S is the signed type to use. */
template <typename U, typename S> template <typename U, typename S>
static U EvalAdjustT(const DeterministicSpriteGroupAdjust *adjust, ScopeResolver *scope, U last_value, uint32 value) static U EvalAdjustT(const DeterministicSpriteGroupAdjust &adjust, ScopeResolver *scope, U last_value, uint32 value)
{ {
value >>= adjust->shift_num; value >>= adjust.shift_num;
value &= adjust->and_mask; value &= adjust.and_mask;
switch (adjust->type) { switch (adjust.type) {
case DSGA_TYPE_DIV: value = ((S)value + (S)adjust->add_val) / (S)adjust->divmod_val; break; case DSGA_TYPE_DIV: value = ((S)value + (S)adjust.add_val) / (S)adjust.divmod_val; break;
case DSGA_TYPE_MOD: value = ((S)value + (S)adjust->add_val) % (S)adjust->divmod_val; break; case DSGA_TYPE_MOD: value = ((S)value + (S)adjust.add_val) % (S)adjust.divmod_val; break;
case DSGA_TYPE_NONE: break; case DSGA_TYPE_NONE: break;
} }
switch (adjust->operation) { switch (adjust.operation) {
case DSGA_OP_ADD: return last_value + value; case DSGA_OP_ADD: return last_value + value;
case DSGA_OP_SUB: return last_value - value; case DSGA_OP_SUB: return last_value - value;
case DSGA_OP_SMIN: return std::min<S>(last_value, value); case DSGA_OP_SMIN: return std::min<S>(last_value, value);
@ -190,17 +190,14 @@ const SpriteGroup *DeterministicSpriteGroup::Resolve(ResolverObject &object) con
{ {
uint32 last_value = 0; uint32 last_value = 0;
uint32 value = 0; uint32 value = 0;
uint i;
ScopeResolver *scope = object.GetScope(this->var_scope); ScopeResolver *scope = object.GetScope(this->var_scope);
for (i = 0; i < this->adjusts.size(); i++) { for (const auto &adjust : this->adjusts) {
const DeterministicSpriteGroupAdjust *adjust = &this->adjusts[i];
/* Try to get the variable. We shall assume it is available, unless told otherwise. */ /* Try to get the variable. We shall assume it is available, unless told otherwise. */
bool available = true; bool available = true;
if (adjust->variable == 0x7E) { if (adjust.variable == 0x7E) {
const SpriteGroup *subgroup = SpriteGroup::Resolve(adjust->subroutine, object, false); const SpriteGroup *subgroup = SpriteGroup::Resolve(adjust.subroutine, object, false);
if (subgroup == nullptr) { if (subgroup == nullptr) {
value = CALLBACK_FAILED; value = CALLBACK_FAILED;
} else { } else {
@ -208,10 +205,10 @@ const SpriteGroup *DeterministicSpriteGroup::Resolve(ResolverObject &object) con
} }
/* Note: 'last_value' and 'reseed' are shared between the main chain and the procedure */ /* Note: 'last_value' and 'reseed' are shared between the main chain and the procedure */
} else if (adjust->variable == 0x7B) { } else if (adjust.variable == 0x7B) {
value = GetVariable(object, scope, adjust->parameter, last_value, &available); value = GetVariable(object, scope, adjust.parameter, last_value, &available);
} else { } else {
value = GetVariable(object, scope, adjust->variable, adjust->parameter, &available); value = GetVariable(object, scope, adjust.variable, adjust.parameter, &available);
} }
if (!available) { if (!available) {