mirror/OpenTTD
1
0
Fork 1
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-08-29 09:29:10 +00:00
Code Issues Activity

Fix: Narrowing cast in one storybook command

Browse Source 
CompanyID is 8 bit wide, so this incorrect cast would make it impossible to create story page elements for pages past 255.
This commit is contained in:
Niels Martin Hansen
2019-07-17 22:08:41 +02:00
committed by Charles Pigott
parent a82f21f24d
commit 59e4ccd7dc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/story.cpp
View File

@@ -154,7 +154,7 @@ CommandCost CmdCreateStoryPageElement(TileIndex tile, DoCommandFlag flags, uint3
{
if (!StoryPageElement::CanAllocateItem()) return CMD_ERROR;
StoryPageID page_id = (CompanyID)GB(p1, 0, 16);
StoryPageID page_id = (StoryPageID)GB(p1, 0, 16);
StoryPageElementType type = Extract<StoryPageElementType, 16, 8>(p1);
/* Allow at most 128 elements per page. */