mirror/OpenTTD
1
0
Fork 1
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-08-22 14:09:10 +00:00
Code Issues Activity

Fix c2d4098afa: Crash when accessing unconfigurable badge feature. (#14403)

Browse Source 
Some features support badges but do not have a way to configure them. Accessing these features could crash the game.
This commit is contained in:
Peter Nelson
2025-06-30 21:45:08 +01:00
committed by GitHub
parent 36d7e09369
commit 4fe6adb2dd
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/newgrf_badge_config.cpp
View File

@@ -118,14 +118,16 @@ void ResetBadgeClassConfiguration(GrfSpecFeature feature)
*/
std::pair<const BadgeClassConfigItem &, int> GetBadgeClassConfigItem(GrfSpecFeature feature, std::string_view label)
{
auto config = GetBadgeClassConfiguration(feature);
auto found = std::ranges::find(config, label, &BadgeClassConfigItem::label);
if (found == std::end(config)) {
return {BadgeClassConfig::EMPTY_CONFIG_ITEM, 0};
if (BadgeClassConfig::CONFIGURABLE_FEATURES.Test(feature)) {
auto config = GetBadgeClassConfiguration(feature);
auto found = std::ranges::find(config, label, &BadgeClassConfigItem::label);
if (found != std::end(config)) {
/* Sort order is simply the position in the configuration list. */
return {*found, static_cast<int>(std::distance(std::begin(config), found))};
}
}
/* Sort order is simply the position in the configuration list. */
return {*found, static_cast<int>(std::distance(std::begin(config), found))};
return {BadgeClassConfig::EMPTY_CONFIG_ITEM, 0};
}
/**