mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Fix: [Script] Ensure the saved script strings are properly validated and terminated when being read from the savegame

pull/9341/head
rubidium42 2021-06-04 18:59:13 +02:00 committed by rubidium42
parent bb8fd00760
commit 2924ac48c5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/script/script_instance.cpp
View File

@ -569,8 +569,9 @@ bool ScriptInstance::IsPaused()
case SQSL_STRING: { case SQSL_STRING: {
SlObject(nullptr, _script_byte); SlObject(nullptr, _script_byte);
static char buf[256]; static char buf[std::numeric_limits<decltype(_script_sl_byte)>::max()];
SlArray(buf, _script_sl_byte, SLE_CHAR); SlArray(buf, _script_sl_byte, SLE_CHAR);
StrMakeValidInPlace(buf, buf + _script_sl_byte);
if (vm != nullptr) sq_pushstring(vm, buf, -1); if (vm != nullptr) sq_pushstring(vm, buf, -1);
return true; return true;
} }