mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

(svn r26742) -Doc: Why reverse_iterator is unsuitable for ScriptList iterators

release/1.5
frosch 2014-08-16 20:40:26 +00:00
parent c775ffe530
commit 0d561bcf57
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/script/api/script_list.cpp
View File

@ -151,6 +151,9 @@ public:
*/ */
class ScriptListSorterValueDescending : public ScriptListSorter { class ScriptListSorterValueDescending : public ScriptListSorter {
private: private:
/* Note: We cannot use reverse_iterator.
* The iterators must only be invalidated when the element they are pointing to is removed.
* This only holds for forward iterators. */
ScriptList::ScriptListBucket::iterator bucket_iter; ///< The iterator over the list to find the buckets. ScriptList::ScriptListBucket::iterator bucket_iter; ///< The iterator over the list to find the buckets.
ScriptList::ScriptItemList *bucket_list; ///< The current bucket list we're iterator over. ScriptList::ScriptItemList *bucket_list; ///< The current bucket list we're iterator over.
ScriptList::ScriptItemList::iterator bucket_list_iter; ///< The iterator over the bucket list. ScriptList::ScriptItemList::iterator bucket_list_iter; ///< The iterator over the bucket list.
@ -315,6 +318,9 @@ public:
*/ */
class ScriptListSorterItemDescending : public ScriptListSorter { class ScriptListSorterItemDescending : public ScriptListSorter {
private: private:
/* Note: We cannot use reverse_iterator.
* The iterators must only be invalidated when the element they are pointing to is removed.
* This only holds for forward iterators. */
ScriptList::ScriptListMap::iterator item_iter; ///< The iterator over the items in the map. ScriptList::ScriptListMap::iterator item_iter; ///< The iterator over the items in the map.
public: public: