(svn r2669) Shuffle some more stuff around to reduce dependencies

ai_build.c

@@ -7,6 +7,7 @@
 #include "ai_new.h"
 #include "engine.h"
 #include "station.h"
+#include "variables.h"
 
 // Build HQ
 //  Params:

aircraft_gui.c

@@ -15,6 +15,7 @@
 #include "viewport.h"
 #include "player.h"
 #include "depot.h"
+#include "vehicle_gui.h"
 
 /**
  * Draw the purchase info details of an aircraft at a given location.

airport.c

@@ -3,6 +3,8 @@
 #include "debug.h"
 #include "map.h"
 #include "airport.h"
+#include "macros.h"
+#include "variables.h"
 
 AirportFTAClass *CountryAirport;
 AirportFTAClass *CityAirport;
@@ -359,3 +361,14 @@ const AirportFTAClass* GetAirport(const byte airport_type)
 	}
 	return Airport;
 }
+
+uint32 GetValidAirports(void)
+{
+	uint32 bytemask = _avail_aircraft; /// sets the first 3 bytes, 0 - 2, @see AdjustAvailAircraft()
+
+	// 1980-1-1 is --> 21915
+	// 1990-1-1 is --> 25568
+	if (_date >= 21915) {SETBIT(bytemask, 3);}	// metropilitan airport 1980
+	if (_date >= 25568) {SETBIT(bytemask, 4);}	// international airport 1990
+	return bytemask;
+}

airport.h

@@ -2,7 +2,6 @@
 #define AIRPORT_H
 
 #include "airport_movement.h"
-#include "variables.h"
 
 enum {MAX_TERMINALS = 6};
 enum {MAX_HELIPADS  = 2};
@@ -54,15 +53,6 @@ const AirportFTAClass* GetAirport(const byte airport_type);
  * Bit 0 means the small airport is buildable, etc.
  * @todo set availability of airports by year, instead of airplane
  */
-static inline uint32 GetValidAirports(void)
+uint32 GetValidAirports(void);
-{
-	uint32 bytemask = _avail_aircraft; /// sets the first 3 bytes, 0 - 2, @see AdjustAvailAircraft()
-
-	// 1980-1-1 is --> 21915
-	// 1990-1-1 is --> 25568
-	if (_date >= 21915) {SETBIT(bytemask, 3);}	// metropilitan airport 1980
-	if (_date >= 25568) {SETBIT(bytemask, 4);}	// international airport 1990
-	return bytemask;
-}
 
 #endif /* AIRPORT_H */

airport_movement.h

@@ -2,7 +2,6 @@
 #define AIRPORT_MOVEMENT_H
 
 #include "stdafx.h"
-#include "macros.h"
 
 typedef struct AirportMovingData {
 	int x,y;

bridge_gui.c

@@ -8,6 +8,7 @@
 #include "gfx.h"
 #include "command.h"
 #include "sound.h"
+#include "variables.h"
 
 static struct BridgeData {
 	uint count;

command.c

@@ -6,6 +6,7 @@
 #include "command.h"
 #include "player.h"
 #include "network.h"
+#include "variables.h"
 
 const char* _cmd_text = NULL;
 

dedicated.c

@@ -10,6 +10,7 @@
 #include "window.h"
 #include "command.h"
 #include "console.h"
+#include "variables.h"
 #ifdef WIN32
 #	include <windows.h> /* GetTickCount */
 #	include <conio.h>

disaster_cmd.c

@@ -12,6 +12,7 @@
 #include "player.h"
 #include "airport_movement.h"
 #include "sound.h"
+#include "variables.h"
 
 static void DisasterClearSquare(TileIndex tile)
 {

dock_gui.c

@@ -10,6 +10,7 @@
 #include "gfx.h"
 #include "sound.h"
 #include "command.h"
+#include "variables.h"
 
 static void ShowBuildDockStationPicker(void);
 static void ShowBuildDocksDepotPicker(void);

economy.c

@@ -18,6 +18,8 @@
 #include "sound.h"
 #include "engine.h"
 #include "network_data.h"
+#include "variables.h"
+#include "vehicle_gui.h"
 
 // get a mask of the allowed currencies depending on the year
 uint GetMaskOfAllowedCurrencies(void)

engine.c

@@ -11,6 +11,7 @@
 #include "news.h"
 #include "saveload.h"
 #include "sprite.h"
+#include "variables.h"
 
 enum {
 	ENGINE_AVAILABLE = 1,

engine_gui.c

@@ -8,6 +8,7 @@
 #include "engine.h"
 #include "command.h"
 #include "news.h"
+#include "variables.h"
 
 
 static StringID GetEngineCategoryName(byte engine)

fileio.c

@@ -1,6 +1,7 @@
 #include "stdafx.h"
 #include "openttd.h"
 #include "fileio.h"
+#include "macros.h"
 #include "variables.h"
 #if defined(UNIX) || defined(__OS2__)
 #include <ctype.h> // required for tolower()

graph_gui.c

@@ -9,6 +9,7 @@
 #include "signs.h"
 #include "strings.h"
 #include "debug.h"
+#include "variables.h"
 
 static uint _legend_excludebits;
 static uint _legend_cargobits;

gui.h

@@ -114,8 +114,6 @@ bool InsertTextBufferChar(Textbuf *tb, byte key);
 bool InsertTextBufferClipboard(Textbuf *tb);
 bool MoveTextBufferPos(Textbuf *tb, int navmode);
 void UpdateTextBufferSize(Textbuf *tb);
-/* IS_INT_INSIDE = filter for ascii-function codes like BELL and so on [we need an special filter here later] */
-static inline bool IsValidAsciiChar(byte key) {return IS_INT_INSIDE(key, ' ', 256);}
 
 void BuildFileList(void);
 void SetFiosType(const byte fiostype);

industry_cmd.c

@@ -13,6 +13,7 @@
 #include "saveload.h"
 #include "economy.h"
 #include "sound.h"
+#include "variables.h"
 
 enum {
 	/* Max industries: 64000 (8 * 8000) */

industry_gui.c

@@ -12,6 +12,7 @@
 #include "viewport.h"
 #include "industry.h"
 #include "town.h"
+#include "variables.h"
 
 /* Present in table/build_industry.h" */
 extern const byte _build_industry_types[4][12];

intro_gui.c

@@ -9,6 +9,7 @@
 #include "command.h"
 #include "console.h"
 #include "network.h"
+#include "variables.h"
 
 extern void SwitchMode(int new_mode);
 

landscape.c

@@ -9,6 +9,7 @@
 #include "viewport.h"
 #include "command.h"
 #include "vehicle.h"
+#include "variables.h"
 
 extern const TileTypeProcs
 	_tile_type_clear_procs,

macros.h

@@ -110,17 +110,6 @@ static inline int KillFirstBit2x64(int value)
 #define CHANCE16R(a,b,r) ((uint16)(r=Random()) <= (uint16)((65536 * a) / b))
 #define CHANCE16I(a,b,v) ((uint16)(v) <= (uint16)((65536 * a) / b))
 
-#define BEGIN_TILE_LOOP(var,w,h,tile)		\
-		{int h_cur = h;									\
-		uint var = tile;									\
-		do {														\
-			int w_cur = w;								\
-			do {
-
-#define END_TILE_LOOP(var,w,h,tile)			\
-			} while (++var, --w_cur != 0);						\
-		} while (var += TileDiffXY(0, 1) - (w), --h_cur != 0);}
-
 
 #define for_each_bit(_i,_b)										\
 	for(_i=0; _b!=0; _i++,_b>>=1)								\
@@ -165,4 +154,10 @@ static inline void swap_tile(TileIndex *a, TileIndex *b) { TileIndex t = *a; *a
 #define ROL(x, n) ((x) << (n) | (x) >> (sizeof(x) * 8 - (n)))
 #define ROR(x, n) ((x) >> (n) | (x) << (sizeof(x) * 8 - (n)))
 
+/* IS_INT_INSIDE = filter for ascii-function codes like BELL and so on [we need an special filter here later] */
+static inline bool IsValidAsciiChar(byte key)
+{
+	return IS_INT_INSIDE(key, ' ', 256);
+}
+
 #endif /* MACROS_H */

main_gui.c

@@ -20,6 +20,7 @@
 #include "network.h"
 #include "signs.h"
 #include "waypoint.h"
+#include "variables.h"
 
 #include "network_data.h"
 #include "network_client.h"

map.c

@@ -2,6 +2,7 @@
 #include "openttd.h"
 #include "debug.h"
 #include "functions.h"
+#include "macros.h"
 #include "map.h"
 
 uint _map_log_x;

map.h

@@ -146,6 +146,20 @@ uint DistanceTrack(TileIndex, TileIndex); // Returns the shortest distance one c
 uint DistanceFromEdge(TileIndex); // shortest distance from any edge of the map
 
 
+#define BEGIN_TILE_LOOP(var,w,h,tile)                      \
+	{                                                        \
+		int h_cur = h;                                         \
+		uint var = tile;                                       \
+		do {                                                   \
+			int w_cur = w;                                       \
+			do {
+
+#define END_TILE_LOOP(var,w,h,tile)                        \
+			} while (++var, --w_cur != 0);                       \
+		} while (var += TileDiffXY(0, 1) - (w), --h_cur != 0); \
+	}
+
+
 static inline TileIndexDiff TileOffsByDir(uint dir)
 {
 	extern const TileIndexDiffC _tileoffs_by_dir[4];

misc.c

@@ -13,6 +13,7 @@
 #include "network_server.h"
 #include "engine.h"
 #include "vehicle_gui.h"
+#include "variables.h"
 
 extern void StartupEconomy(void);
 extern void InitNewsItemStructs(void);

misc_cmd.c

@@ -9,6 +9,7 @@
 #include "gui.h"
 #include "economy.h"
 #include "network.h"
+#include "variables.h"
 
 /** Change the player's face.
  * @param x,y unused

misc_gui.c

@@ -18,6 +18,7 @@
 #include "sound.h"
 #include "network.h"
 #include "string.h"
+#include "variables.h"
 
 #include "hal.h" // for file list
 

music_gui.c

@@ -6,6 +6,8 @@
 #include "gfx.h"
 #include "sound.h"
 #include "hal.h"
+#include "macros.h"
+#include "variables.h"
 
 static byte _music_wnd_cursong;
 static bool _song_is_active;

network_client.c

@@ -14,6 +14,7 @@
 #include "window.h"
 #include "settings.h"
 #include "console.h"
+#include "variables.h"
 
 
 // This file handles all the client-commands

network_server.c

@@ -15,6 +15,7 @@
 #include "vehicle.h"
 #include "station.h"
 #include "settings.h"
+#include "variables.h"
 
 // This file handles all the server-commands
 

newgrf.c

@@ -10,6 +10,7 @@
 #include "station.h"
 #include "sprite.h"
 #include "newgrf.h"
+#include "variables.h"
 
 /* TTDPatch extended GRF format codec
  * (c) Petr Baudis 2004 (GPL'd)

news_gui.c

@@ -10,6 +10,7 @@
 #include "news.h"
 #include "vehicle.h"
 #include "sound.h"
+#include "variables.h"
 
 /* News system
 News system is realized as a FIFO queue (in an array)

npf.h

@@ -7,6 +7,7 @@
 #include "pbs.h"
 #include "tile.h"
 #include "rail.h"
+#include "variables.h"
 
 //mowing grass
 enum {

openttd.h

@@ -51,7 +51,7 @@ typedef struct YearMonthDay {
 #define MAX_YEAR_END_REAL 2090
 #define MAX_YEAR_END 170
 
-#include "macros.h"
+#include "map.h"
 
 // Forward declarations of structs.
 typedef struct Vehicle Vehicle;

order.h

@@ -1,6 +1,7 @@
 #ifndef ORDER_H
 #define ORDER_H
 
+#include "macros.h"
 #include "pool.h"
 
 /* Order types */

pbs.h

@@ -5,7 +5,6 @@
  *  @see pbs.c */
 
 #include "vehicle.h"
-#include "tile.h"
 #include "map.h"
 #include "rail.h"
 

player.h

@@ -2,7 +2,6 @@
 #define PLAYER_H
 
 #include "aystar.h"
-#include "engine.h"
 #include "rail.h"
 
 typedef struct PlayerEconomyEntry {

player_gui.c

@@ -11,6 +11,7 @@
 #include "vehicle.h"
 #include "economy.h"
 #include "network.h"
+#include "variables.h"
 
 #ifdef ENABLE_NETWORK
 #include "network_data.h"

players.c

@@ -1,5 +1,6 @@
 #include "stdafx.h"
 #include "openttd.h"
+#include "engine.h"
 #include "string.h"
 #include "strings.h"
 #include "table/strings.h"
@@ -15,6 +16,7 @@
 #include "ai_new.h"
 #include "sound.h"
 #include "network.h"
+#include "variables.h"
 
 PlayerID _current_player;
 

rail_gui.c

@@ -14,6 +14,7 @@
 #include "station.h"
 #include "waypoint.h"
 #include "debug.h"
+#include "variables.h"
 
 static uint _cur_railtype;
 static bool _remove_button_clicked;

road_gui.c

@@ -10,6 +10,7 @@
 #include "gfx.h"
 #include "sound.h"
 #include "command.h"
+#include "variables.h"
 //needed for catchments
 #include "station.h"
 

roadveh_gui.c

@@ -14,6 +14,7 @@
 #include "player.h"
 #include "engine.h"
 #include "depot.h"
+#include "vehicle_gui.h"
 
 /**
  * Draw the purchase info details of road vehicle at a given location.

saveload.c

@@ -21,6 +21,7 @@
 #include "town.h"
 #include "player.h"
 #include "saveload.h"
+#include "variables.h"
 
 enum {
 	SAVEGAME_MAJOR_VERSION = 15,

screenshot.c

@@ -8,6 +8,7 @@
 #include "player.h"
 #include "gui.h"
 #include "screenshot.h"
+#include "variables.h"
 
 char _screenshot_format_name[8];
 uint _num_screenshot_formats;

sdl.c

@@ -10,6 +10,7 @@
 #include "player.h"
 #include "hal.h"
 #include "network.h"
+#include "variables.h"
 
 #ifdef UNIX
 #include <signal.h>

settings_gui.c

@@ -14,6 +14,7 @@
 #include "network.h"
 #include "console.h"
 #include "town.h"
+#include "variables.h"
 
 static uint32 _difficulty_click_a;
 static uint32 _difficulty_click_b;

ship_cmd.c

@@ -14,6 +14,7 @@
 #include "sound.h"
 #include "npf.h"
 #include "depot.h"
+#include "vehicle_gui.h"
 
 static const uint16 _ship_sprites[] = {0x0E5D, 0x0E55, 0x0E65, 0x0E6D};
 static const byte _ship_sometracks[4] = {0x19, 0x16, 0x25, 0x2A};

ship_gui.c

@@ -13,6 +13,7 @@
 #include "player.h"
 #include "engine.h"
 #include "depot.h"
+#include "vehicle_gui.h"
 
 /**
  * Draw the purchase info details of a ship at a given location.

smallmap_gui.c

@@ -13,6 +13,7 @@
 #include "vehicle.h"
 #include "town.h"
 #include "sound.h"
+#include "variables.h"
 
 static const Widget _smallmap_widgets[] = {
 {   WWT_TEXTBTN,   RESIZE_NONE,    13,     0,    10,     0,    13, STR_00C5,                STR_018B_CLOSE_WINDOW},

spritecache.c

@@ -7,6 +7,7 @@
 #include "fileio.h"
 #include "newgrf.h"
 #include "md5.h"
+#include "variables.h"
 #include <ctype.h>
 
 #define SPRITECACHE_ID 0xF00F0006

station_gui.c

@@ -10,6 +10,8 @@
 #include "player.h"
 #include "town.h"
 #include "command.h"
+#include "variables.h"
+#include "vehicle_gui.h"
 
 static void StationsWndShowStationRating(int x, int y, int type, uint acceptance, int rating)
 {

strings.c

@@ -11,6 +11,7 @@
 #include "screenshot.h"
 #include "waypoint.h"
 #include "industry.h"
+#include "variables.h"
 
 static char *StationGetSpecialString(char *buff, int x);
 static char *GetSpecialTownNameString(char *buff, int ind, uint32 seed);

subsidy_gui.c

@@ -9,6 +9,7 @@
 #include "player.h"
 #include "gfx.h"
 #include "economy.h"
+#include "variables.h"
 
 static void HandleSubsidyClick(int y)
 {

terraform_gui.c

@@ -12,6 +12,7 @@
 #include "command.h"
 #include "vehicle.h"
 #include "signs.h"
+#include "variables.h"
 
 void CcTerraform(bool success, TileIndex tile, uint32 p1, uint32 p2)
 {

town_cmd.c

@@ -18,6 +18,7 @@
 #include "economy.h"
 #include "gui.h"
 #include "network.h"
+#include "variables.h"
 
 enum {
 	/* Max towns: 64000 (8 * 8000) */

town_gui.c

@@ -12,6 +12,7 @@
 #include "command.h"
 #include "player.h"
 #include "network.h"
+#include "variables.h"
 
 static const Widget _town_authority_widgets[] = {
 {    WWT_TEXTBTN,   RESIZE_NONE,    13,     0,    10,     0,    13, STR_00C5,				STR_018B_CLOSE_WINDOW},

tunnelbridge_cmd.c

@@ -12,6 +12,7 @@
 #include "sound.h"
 #include "pbs.h"
 #include "debug.h"
+#include "variables.h"
 
 extern void DrawCanalWater(TileIndex tile);
 

unix.c

@@ -4,6 +4,7 @@
 #include "string.h"
 #include "table/strings.h"
 #include "hal.h"
+#include "variables.h"
 
 #include <dirent.h>
 #include <unistd.h>

unmovable_cmd.c

@@ -12,6 +12,7 @@
 #include "economy.h"
 #include "town.h"
 #include "sprite.h"
+#include "variables.h"
 
 /** Destroy a HQ.
  * During normal gameplay you can only implicitely destroy a HQ when you are

vehicle.h

@@ -4,7 +4,6 @@
 #include "pool.h"
 #include "order.h"
 #include "rail.h"
-#include "variables.h"
 
 enum {
 	VEH_Train = 0x10,

vehicle_gui.c

@@ -11,6 +11,14 @@
 #include "gui.h"
 #include "command.h"
 #include "gfx.h"
+#include "variables.h"
+#include "vehicle_gui.h"
+
+Sorting _sorting;
+
+static uint32 _internal_name_sorter_id; // internal StringID for default vehicle-names
+static uint32 _last_vehicle_idx;        // cached index to hopefully speed up name-sorting
+static bool   _internal_sort_order;     // descending/ascending
 
 VehicleSortListingTypeFunctions * const _vehicle_sorter[] = {
 	&VehicleUnsortedSorter,

vehicle_gui.h

@@ -17,9 +17,6 @@ void BuildVehicleList(struct vehiclelist_d *vl, int type, int owner, int station
 void SortVehicleList(struct vehiclelist_d *vl);
 
 int CDECL GeneralOwnerSorter(const void *a, const void *b);
-VARDEF uint32	_internal_name_sorter_id;	// internal StringID for default vehicle-names
-VARDEF uint32	_last_vehicle_idx;				// cached index to hopefully speed up name-sorting
-VARDEF bool		_internal_sort_order;			// descending/ascending
 
 #define PERIODIC_RESORT_DAYS 10
 #define DEF_SORTER(yyyy) int CDECL yyyy(const void *a, const void *b)
@@ -60,7 +57,7 @@ typedef struct Sorting {
 	Listing train;
 } Sorting;
 
-VARDEF Sorting _sorting;
+extern Sorting _sorting;
 
 enum {
   PLY_WND_PRC__OFFSET_TOP_WIDGET	= 26,

viewport.c

@@ -14,6 +14,7 @@
 #include "town.h"
 #include "signs.h"
 #include "waypoint.h"
+#include "variables.h"
 
 #define VIEWPORT_DRAW_MEM (65536 * 2)
 

waypoint.c

@@ -10,6 +10,7 @@
 #include "tile.h"
 #include "town.h"
 #include "waypoint.h"
+#include "variables.h"
 #include "table/sprites.h"
 #include "table/strings.h"
 #include "table/track_land.h"

window.c

@@ -7,6 +7,7 @@
 #include "gfx.h"
 #include "viewport.h"
 #include "console.h"
+#include "variables.h"
 
 // delta between mouse cursor and upper left corner of dragged window
 static Point _drag_delta;

window.h

@@ -1,8 +1,6 @@
 #ifndef WINDOW_H
 #define WINDOW_H
 
-#include "vehicle_gui.h"
-
 typedef union WindowEvent WindowEvent;
 
 //typedef void WindowProc(Window *w, int event, int wparam, long lparam);