mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Add: don't allow two plugins for the same social platform 

The second one will be unloaded as soon as it is detected it is
for the same platform.
pull/11628/head
Patric Stout 2024-01-21 10:55:31 +01:00
parent e354b747f9
commit 05965a1735
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/social_integration.cpp
View File

@ -38,6 +38,7 @@ public:
}; };
static std::vector<std::unique_ptr<InternalSocialIntegrationPlugin>> _plugins; ///< List of loaded plugins. static std::vector<std::unique_ptr<InternalSocialIntegrationPlugin>> _plugins; ///< List of loaded plugins.
static std::set<std::string> _loaded_social_platform; ///< List of Social Platform plugins already loaded. Used to prevent loading a plugin for the same Social Platform twice.
/** Helper for scanning for files with SocialIntegration as extension */ /** Helper for scanning for files with SocialIntegration as extension */
class SocialIntegrationFileScanner : FileScanner { class SocialIntegrationFileScanner : FileScanner {
@ -81,6 +82,17 @@ public:
getinfo_func(&plugin->plugin_info); getinfo_func(&plugin->plugin_info);
/* Lowercase the string for comparison. */
std::string lc_social_platform = plugin->plugin_info.social_platform;
strtolower(lc_social_platform);
/* Prevent more than one plugin for a certain Social Platform to be loaded, as that never ends well. */
if (_loaded_social_platform.find(lc_social_platform) != _loaded_social_platform.end()) {
Debug(misc, 0, "[Social Integration: {}] Another plugin for {} is already loaded", basepath, plugin->plugin_info.social_platform);
return false;
}
_loaded_social_platform.insert(lc_social_platform);
auto state = init_func(&plugin->plugin_api, &plugin->openttd_info); auto state = init_func(&plugin->plugin_api, &plugin->openttd_info);
switch (state) { switch (state) {
case OTTD_SOCIAL_INTEGRATION_V1_INIT_SUCCESS: case OTTD_SOCIAL_INTEGRATION_V1_INIT_SUCCESS:
@ -110,4 +122,5 @@ void SocialIntegration::Initialize()
void SocialIntegration::Shutdown() void SocialIntegration::Shutdown()
{ {
_plugins.clear(); _plugins.clear();
_loaded_social_platform.clear();
} }