petern/OpenTTD
1
0
Fork 0
forked from mirror/OpenTTD
Code Pull Requests Activity

Codefix: Avoiding passing new raw pointer into a smart pointer. (#13138)

Browse Source 
Use `std::make_shared` or `std::make_unique` instead of `reset(new ...)`.
This commit is contained in:
Peter Nelson
2024-12-01 14:22:41 +00:00
committed by GitHub
parent 46176a81e3
commit e28617fda6
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/newgrf_text.cpp
View File

@@ -521,7 +521,7 @@ void AddGRFTextToList(GRFTextList &list, uint8_t langid, uint32_t grfid, bool al
*/
void AddGRFTextToList(GRFTextWrapper &list, uint8_t langid, uint32_t grfid, bool allow_newlines, std::string_view text_to_add)
{
if (!list) list.reset(new GRFTextList());
if (list == nullptr) list = std::make_shared<GRFTextList>();
AddGRFTextToList(*list, langid, grfid, allow_newlines, text_to_add);
}
@@ -533,7 +533,7 @@ void AddGRFTextToList(GRFTextWrapper &list, uint8_t langid, uint32_t grfid, bool
*/
void AddGRFTextToList(GRFTextWrapper &list, std::string_view text_to_add)
{
if (!list) list.reset(new GRFTextList());
if (list == nullptr) list = std::make_shared<GRFTextList>();
AddGRFTextToList(*list, GRFLX_UNSPECIFIED, text_to_add);
}