1
0
Fork 0

Fix: [CI] force a CMake minimum version of 3.5 for all dependencies (#13936)

With CMake 4.0.0, any project < 3.5 is no longer supported. Yet,
some projects indicate 3.0 or 3.1 (while fully compatible with
3.5+). But CMake doesn't know, so it bails.
pull/13939/head
Patric Stout 2025-03-31 20:48:39 +02:00 committed by GitHub
parent dc956a758d
commit f719fa678f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 32 additions and 8 deletions

View File

@ -43,7 +43,10 @@ jobs:
cd ${GITHUB_WORKSPACE}/build
echo "::group::CMake"
cmake ${GITHUB_WORKSPACE} \
# CMake 4.0.0 deprecated < 3.5, but some vcpkg packages still use it.
# Yet, they are fully compatible with 3.5, and so there is no problem
# forcing them to upgrade.
CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake ${GITHUB_WORKSPACE} \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DOPTION_DOCS_ONLY=ON \
# EOF

View File

@ -136,7 +136,10 @@ jobs:
cd build
echo "::group::CMake"
cmake ${GITHUB_WORKSPACE} \
# CMake 4.0.0 deprecated < 3.5, but some vcpkg packages still use it.
# Yet, they are fully compatible with 3.5, and so there is no problem
# forcing them to upgrade.
CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake ${GITHUB_WORKSPACE} \
-DCMAKE_TOOLCHAIN_FILE=/vcpkg/scripts/buildsystems/vcpkg.cmake \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DOPTION_SURVEY_KEY=${{ inputs.survey_key }} \

View File

@ -74,7 +74,10 @@ jobs:
cd build-host
echo "::group::CMake"
cmake ${GITHUB_WORKSPACE} \
# CMake 4.0.0 deprecated < 3.5, but some vcpkg packages still use it.
# Yet, they are fully compatible with 3.5, and so there is no problem
# forcing them to upgrade.
CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake ${GITHUB_WORKSPACE} \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DOPTION_TOOLS_ONLY=ON \
# EOF
@ -101,7 +104,10 @@ jobs:
cd build-arm64
echo "::group::CMake"
cmake ${GITHUB_WORKSPACE} \
# CMake 4.0.0 deprecated < 3.5, but some vcpkg packages still use it.
# Yet, they are fully compatible with 3.5, and so there is no problem
# forcing them to upgrade.
CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake ${GITHUB_WORKSPACE} \
-DCMAKE_OSX_ARCHITECTURES=arm64 \
-DVCPKG_TARGET_TRIPLET=arm64-osx \
-DCMAKE_TOOLCHAIN_FILE=${{ runner.temp }}/vcpkg/scripts/buildsystems/vcpkg.cmake \
@ -122,7 +128,10 @@ jobs:
cd build-x64
echo "::group::CMake"
cmake ${GITHUB_WORKSPACE} \
# CMake 4.0.0 deprecated < 3.5, but some vcpkg packages still use it.
# Yet, they are fully compatible with 3.5, and so there is no problem
# forcing them to upgrade.
CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake ${GITHUB_WORKSPACE} \
-DCMAKE_OSX_ARCHITECTURES=x86_64 \
-DVCPKG_TARGET_TRIPLET=x64-osx \
-DCMAKE_TOOLCHAIN_FILE=${{ runner.temp }}/vcpkg/scripts/buildsystems/vcpkg.cmake \

View File

@ -84,7 +84,10 @@ jobs:
cd build-host
echo "::group::CMake"
cmake ${GITHUB_WORKSPACE} \
# CMake 4.0.0 deprecated < 3.5, but some vcpkg packages still use it.
# Yet, they are fully compatible with 3.5, and so there is no problem
# forcing them to upgrade.
CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake ${GITHUB_WORKSPACE} \
-GNinja \
-DOPTION_TOOLS_ONLY=ON \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
@ -108,7 +111,10 @@ jobs:
cd build
echo "::group::CMake"
cmake ${GITHUB_WORKSPACE} \
# CMake 4.0.0 deprecated < 3.5, but some vcpkg packages still use it.
# Yet, they are fully compatible with 3.5, and so there is no problem
# forcing them to upgrade.
CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake ${GITHUB_WORKSPACE} \
-GNinja \
-DVCPKG_TARGET_TRIPLET=${{ matrix.arch }}-windows-static \
-DCMAKE_TOOLCHAIN_FILE="${{ runner.temp }}\vcpkg\scripts\buildsystems\vcpkg.cmake" \
@ -138,7 +144,10 @@ jobs:
cd build
echo "::group::CMake"
cmake ${GITHUB_WORKSPACE} \
# CMake 4.0.0 deprecated < 3.5, but some vcpkg packages still use it.
# Yet, they are fully compatible with 3.5, and so there is no problem
# forcing them to upgrade.
CMAKE_POLICY_VERSION_MINIMUM=3.5 cmake ${GITHUB_WORKSPACE} \
-GNinja \
-DVCPKG_TARGET_TRIPLET=${{ matrix.arch }}-windows-static \
-DCMAKE_TOOLCHAIN_FILE="${{ runner.temp }}\vcpkg\scripts\buildsystems\vcpkg.cmake" \