mirror/OpenTTD
1
0
Fork 1
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-08-30 09:59:10 +00:00
Code Issues Activity

Codechange: Use std::any_of() (#10830)

Browse Source 
When the result of std::find_if is compared only with end()
then '!= end()' is replaced with any_of().

Just... there's only one.
This commit is contained in:
PeterN
2023-05-14 23:18:52 +01:00
committed by GitHub
parent 199e41c762
commit e4fd9d41d3
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/group_gui.cpp
View File

@@ -144,8 +144,7 @@ private:
this->indents.push_back(indent); this->indents.push_back(indent);
if (g->folded) { if (g->folded) {
/* Test if this group has children at all. If not, the folded flag should be cleared to avoid lingering unfold buttons in the list. */ /* Test if this group has children at all. If not, the folded flag should be cleared to avoid lingering unfold buttons in the list. */
auto child = std::find_if(source.begin(), source.end(), [g](const Group *child){ return child->parent == g->index; }); bool has_children = std::any_of(source.begin(), source.end(), [g](const Group *child){ return child->parent == g->index; });
bool has_children = child != source.end();
Group::Get(g->index)->folded = has_children; Group::Get(g->index)->folded = has_children;
} else { } else {
AddChildren(source, g->index, indent + 1); AddChildren(source, g->index, indent + 1);