mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Fix #13002: Crash due to use of dangling types in picker GUI used/saved lists

pull/13008/head
Jonathan G Rennison 2024-10-18 21:27:37 +01:00
parent b074a4d3ce
commit dd205f87ef
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/picker_gui.cpp
View File

@ -197,10 +197,14 @@ void PickerWindow::ConstructWindow()
this->classes.SetSortFuncs(_class_sorter_funcs);
this->classes.SetFilterFuncs(_class_filter_funcs);
/* Update saved type information. */
this->callbacks.saved = this->callbacks.UpdateSavedItems(this->callbacks.saved);
/* Clear used type information. */
this->callbacks.used.clear();
if (this->has_type_picker) {
/* Update used and saved type information. */
this->callbacks.saved = this->callbacks.UpdateSavedItems(this->callbacks.saved);
this->callbacks.used.clear();
/* Populate used type information. */
this->callbacks.FillUsedItems(this->callbacks.used);
SetWidgetDisabledState(WID_PW_MODE_ALL, !this->callbacks.HasClassChoice());