From d8e870c50c8c4bc57701a5a0bc2cb56e484a754e Mon Sep 17 00:00:00 2001 From: Patric Stout Date: Sat, 28 Aug 2021 21:19:53 +0200 Subject: [PATCH] Fix: when DNS didn't resolve any IPs, the debug message was misleading (#9519) --- src/network/core/tcp_connect.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/network/core/tcp_connect.cpp b/src/network/core/tcp_connect.cpp index 29e9048d93..73c6aa90d3 100644 --- a/src/network/core/tcp_connect.cpp +++ b/src/network/core/tcp_connect.cpp @@ -205,9 +205,13 @@ void TCPConnecter::OnResolved(addrinfo *ai) } if (_debug_net_level >= 6) { - Debug(net, 6, "{} resolved in:", this->connection_string); - for (const auto &address : this->addresses) { - Debug(net, 6, "- {}", NetworkAddress(address->ai_addr, (int)address->ai_addrlen).GetAddressAsString()); + if (this->addresses.size() == 0) { + Debug(net, 6, "{} did not resolve", this->connection_string); + } else { + Debug(net, 6, "{} resolved in:", this->connection_string); + for (const auto &address : this->addresses) { + Debug(net, 6, "- {}", NetworkAddress(address->ai_addr, (int)address->ai_addrlen).GetAddressAsString()); + } } }