(svn r1093) -Fix: Hopefully fixed windows revision issues once and for all. Removed globalness of _openttd_revision and put all such ifdefs into one place. If server has a revision only the same revisions can join; if the server has no revision everyone can join. I reckon this should be a server-side option to allow people to join or not to join.

strings.c

@@ -20,6 +20,14 @@ static byte *_langpack;
 static uint _langtab_num[32]; // Offset into langpack offs
 static uint _langtab_start[32]; // Offset into langpack offs
 
+#if defined(WITH_REV)
+	extern const char _openttd_revision[];
+#elif defined(WITH_REV_HACK)
+	const char _openttd_revision[] = WITH_REV_HACK;
+#else
+	const char _openttd_revision[] = NOREV_STRING;
+#endif
+
 typedef byte *PlayerNameGeneratorProc(byte *buffr);
 
 typedef struct {
@@ -433,9 +441,7 @@ static byte *DecodeString(byte *buff, const byte *str)
 				buff = FormatNoCommaNumber(buff, GetParamInt32());
 				break;
 			case 2: /* {REV} */
-#ifdef WITH_REV
 				buff = str_cat(buff, (const byte*)_openttd_revision);
-#endif
 				break;
 			case 3: { /* {SHORTCARGO} */
 				// Short description of cargotypes. Layout: