From b36ecb0e0afaee211bdb1025309d4ad0d04375bf Mon Sep 17 00:00:00 2001 From: SamuXarick <43006711+SamuXarick@users.noreply.github.com> Date: Fri, 3 Jan 2025 17:05:10 +0000 Subject: [PATCH] Codechange: Optimize MakeLake --- src/landscape.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/landscape.cpp b/src/landscape.cpp index 544a41876b..aa0e526b85 100644 --- a/src/landscape.cpp +++ b/src/landscape.cpp @@ -1028,9 +1028,10 @@ static bool FindSpring(TileIndex tile, void *) */ static bool MakeLake(TileIndex tile, void *user_data) { + if (_settings_game.game_creation.landscape == LT_TROPIC && GetTropicZone(tile) == TROPICZONE_DESERT) return false; + uint height_lake = *static_cast(user_data); if (!IsValidTile(tile) || TileHeight(tile) != height_lake || !IsTileFlat(tile)) return false; - if (_settings_game.game_creation.landscape == LT_TROPIC && GetTropicZone(tile) == TROPICZONE_DESERT) return false; for (DiagDirection d = DIAGDIR_BEGIN; d < DIAGDIR_END; d++) { TileIndex t = tile + TileOffsByDiagDir(d);