mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Cleanup: remove unneeded CopyOutDParam version with StringID

pull/11103/head
Rubidium 2023-06-22 18:49:32 +02:00 committed by rubidium42
parent 4654b2b0aa
commit b2edf82b69
3 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/error_gui.cpp
View File

@ -122,7 +122,7 @@ void ErrorMessageData::CopyOutDParams()
/* Get parameters using type information */
if (this->textref_stack_size > 0) StartTextRefStackUsage(this->textref_stack_grffile, this->textref_stack_size, this->textref_stack);
CopyOutDParam(this->params, 20, this->detailed_msg == INVALID_STRING_ID ? this->summary_msg : this->detailed_msg);
CopyOutDParam(this->params, 20);
if (this->textref_stack_size > 0) StopTextRefStackUsage();
}

11
src/strings.cpp
View File

@ -187,17 +187,6 @@ void CopyOutDParam(std::vector<StringParameterBackup> &backup, size_t num)
}
}
/**
* Copy \a num string parameters from the global string parameter array to the \a backup.
* @param backup The backup to write to.
* @param num Number of string parameters to copy.
* @param string The string used to determine where raw strings are and where there are no raw strings.
*/
void CopyOutDParam(std::vector<StringParameterBackup> &backup, size_t num, StringID string)
{
CopyOutDParam(backup, num);
}
/**
* Checks whether the global string parameters have changed compared to the given backup.
* @param backup The backup to check against.

1
src/strings_func.h
View File

@ -88,7 +88,6 @@ void SetDParamStr(size_t n, std::string &&str) = delete; // block passing tempor
void CopyInDParam(const span<const StringParameterBackup> backup);
void CopyOutDParam(std::vector<StringParameterBackup> &backup, size_t num);
void CopyOutDParam(std::vector<StringParameterBackup> &backup, size_t num, StringID string);
bool HaveDParamChanged(const std::vector<StringParameterBackup> &backup);
uint64_t GetDParam(size_t n);