mirror/OpenTTD
1
0
Fork 1
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-08-17 03:29:09 +00:00
Code Issues Activity

Fix b3003dd1: swap SERVER_GAME_INFO with CLIENT_GAME_INFO (#9129)

Browse Source 
The idea is that if you query an older server that does not support
this packet yet, the client receives an error. The assumption was
that on every "illegal packet" the connection would be closed. This
turns out to be false.

Now CLIENT_GAME_INFO aligns with the old PACKET_CLIENT_NEWGRFS_CHECKED,
which does a pre-check (which fails), and an error is sent back
and the connection is closed.

This is not a nice solution, but it is the best we got.
This commit is contained in:
Patric Stout
2021-04-28 23:09:03 +02:00
committed by GitHub
parent 8e9eca6ddd
commit 96dc0d04ec
1 changed files with 1 additions and 1 deletions

2
src/network/core/tcp_game.h

@@ -43,8 +43,8 @@ enum PacketGameType {
PACKET_SERVER_COMPANY_INFO, ///< Information about a single company. PACKET_SERVER_COMPANY_INFO, ///< Information about a single company.
/* Packets used to get the game info. */ /* Packets used to get the game info. */
PACKET_CLIENT_GAME_INFO, ///< Request information about the server.
PACKET_SERVER_GAME_INFO, ///< Information about the server. PACKET_SERVER_GAME_INFO, ///< Information about the server.
PACKET_CLIENT_GAME_INFO, ///< Request information about the server.
/* /*
* Packets after here assume that the client * Packets after here assume that the client