mirror/OpenTTD
1
0
Fork 1
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-08-12 09:09:09 +00:00
Code Issues Activity

Fix 2db88953: default Network Server List sorter put compatible servers in wrong order (#8626)

Browse Source 
If a server is compatible, it falls back to sorting by clients.
This used to be in reverse, so full servers are on top. With
the codechange commit, this was removed by accident, and as
such empty servers were on top. This is silly.
This commit is contained in:
Patric Stout
2021-01-31 10:36:07 +01:00
committed by GitHub
parent 1dda7d6486
commit 7fbf705c41
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/network/network_gui.cpp
View File

@@ -330,10 +330,9 @@ protected:
if (r == 0) r = b->info.compatible - a->info.compatible; if (r == 0) r = b->info.compatible - a->info.compatible;
/* Passworded servers should be below unpassworded servers */ /* Passworded servers should be below unpassworded servers */
if (r == 0) r = a->info.use_password - b->info.use_password; if (r == 0) r = a->info.use_password - b->info.use_password;
/* Finally sort on the number of clients of the server */
if (r == 0) return NGameClientSorter(a, b);
return r < 0; /* Finally sort on the number of clients of the server in reverse order. */
return (r != 0) ? r < 0: !NGameClientSorter(a, b);
} }
/** Sort the server list */ /** Sort the server list */