mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Codechange: Don't mark tiles dirty when deleting from animated tile list. 

The callers of DeleteAnimatedTile already know if the tile needs refreshing, so it is redundant for DeleteAnimatedTile to do so.

Loosely backported from JGRPP.
pull/12883/head
Peter Nelson 2024-08-01 20:15:56 +01:00 committed by Peter Nelson
parent 88110e9b2e
commit 79369a886a
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/animated_tile.cpp
View File

@ -28,7 +28,6 @@ void DeleteAnimatedTile(TileIndex tile)
if (to_remove != _animated_tiles.end()) {
/* The order of the remaining elements must stay the same, otherwise the animation loop may miss a tile. */
_animated_tiles.erase(to_remove);
MarkTileDirtyByTile(tile);
}
}

5
src/industry_cmd.cpp
View File

@ -603,8 +603,8 @@ static void AnimatePowerPlantSparks(TileIndex tile)
DeleteAnimatedTile(tile);
} else {
SetAnimationFrame(tile, m + 1);
MarkTileDirtyByTile(tile);
}
MarkTileDirtyByTile(tile);
}
static void AnimateToyFactory(TileIndex tile)
@ -649,8 +649,8 @@ static void AnimateOilWell(TileIndex tile, IndustryGfx gfx)
} else {
SetAnimationFrame(tile, m);
SetIndustryGfx(tile, gfx);
MarkTileDirtyByTile(tile);
}
MarkTileDirtyByTile(tile);
}
static void AnimateMineTower(TileIndex tile)
@ -906,6 +906,7 @@ static void TileLoop_Industry(TileIndex tile)
SetIndustryCompleted(tile);
SetIndustryConstructionStage(tile, 3);
DeleteAnimatedTile(tile);
MarkTileDirtyByTile(tile);
}
break;