mirror/OpenTTD
1
0
Fork 1
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-08-30 09:59:10 +00:00
Code Issues Activity

(svn r13700) -Fix: possible buffer overflow in string truncation code.

Browse Source
This commit is contained in:
rubidium
2008-07-14 18:22:15 +00:00
parent b7c69ba5f0
commit 71820bf129
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/gfx.cpp
View File

@@ -256,9 +256,10 @@ static int TruncateString(char *str, int maxw)
w += GetCharacterWidth(size, c); w += GetCharacterWidth(size, c);
if (w >= maxw) { if (w >= maxw) {
/* string got too big... insert dotdotdot */ /* string got too big... insert dotdotdot, but make sure we do not
ddd_pos[0] = ddd_pos[1] = ddd_pos[2] = '.'; * print anything beyond the string termination character. */
ddd_pos[3] = '\0'; for (int i = 0; *ddd_pos != '\0' && i < 3; i++, ddd_pos++) *ddd_pos = '.';
*ddd_pos = '\0';
return ddd_w; return ddd_w;
} }
} else { } else {