1
0
Fork 0

Codechange: Use correct type for linkgraph company mask.

pull/10612/head
Peter Nelson 2023-04-07 10:12:29 +01:00 committed by PeterN
parent 65e0b0dcb7
commit 5199881a8d
4 changed files with 9 additions and 9 deletions

View File

@ -444,7 +444,7 @@ void LinkGraphOverlay::SetCargoMask(CargoTypes cargo_mask)
* Set a new company mask and rebuild the cache. * Set a new company mask and rebuild the cache.
* @param company_mask New company mask. * @param company_mask New company mask.
*/ */
void LinkGraphOverlay::SetCompanyMask(uint32 company_mask) void LinkGraphOverlay::SetCompanyMask(CompanyMask company_mask)
{ {
this->company_mask = company_mask; this->company_mask = company_mask;
this->RebuildCache(); this->RebuildCache();
@ -564,7 +564,7 @@ LinkGraphLegendWindow::LinkGraphLegendWindow(WindowDesc *desc, int window_number
*/ */
void LinkGraphLegendWindow::SetOverlay(std::shared_ptr<LinkGraphOverlay> overlay) { void LinkGraphLegendWindow::SetOverlay(std::shared_ptr<LinkGraphOverlay> overlay) {
this->overlay = overlay; this->overlay = overlay;
uint32 companies = this->overlay->GetCompanyMask(); CompanyMask companies = this->overlay->GetCompanyMask();
for (uint c = 0; c < MAX_COMPANIES; c++) { for (uint c = 0; c < MAX_COMPANIES; c++) {
if (!this->IsWidgetDisabled(WID_LGL_COMPANY_FIRST + c)) { if (!this->IsWidgetDisabled(WID_LGL_COMPANY_FIRST + c)) {
this->SetWidgetLoweredState(WID_LGL_COMPANY_FIRST + c, HasBit(companies, c)); this->SetWidgetLoweredState(WID_LGL_COMPANY_FIRST + c, HasBit(companies, c));

View File

@ -56,13 +56,13 @@ public:
* @param company_mask Bitmask of companies to be shown. * @param company_mask Bitmask of companies to be shown.
* @param scale Desired thickness of lines and size of station dots. * @param scale Desired thickness of lines and size of station dots.
*/ */
LinkGraphOverlay(Window *w, uint wid, CargoTypes cargo_mask, uint32 company_mask, uint scale) : LinkGraphOverlay(Window *w, uint wid, CargoTypes cargo_mask, CompanyMask company_mask, uint scale) :
window(w), widget_id(wid), cargo_mask(cargo_mask), company_mask(company_mask), scale(scale) window(w), widget_id(wid), cargo_mask(cargo_mask), company_mask(company_mask), scale(scale)
{} {}
void Draw(const DrawPixelInfo *dpi); void Draw(const DrawPixelInfo *dpi);
void SetCargoMask(CargoTypes cargo_mask); void SetCargoMask(CargoTypes cargo_mask);
void SetCompanyMask(uint32 company_mask); void SetCompanyMask(CompanyMask company_mask);
bool ShowTooltip(Point pt, TooltipCloseCondition close_cond); bool ShowTooltip(Point pt, TooltipCloseCondition close_cond);
@ -73,13 +73,13 @@ public:
CargoTypes GetCargoMask() { return this->cargo_mask; } CargoTypes GetCargoMask() { return this->cargo_mask; }
/** Get a bitmask of the currently shown companies. */ /** Get a bitmask of the currently shown companies. */
uint32 GetCompanyMask() { return this->company_mask; } CompanyMask GetCompanyMask() { return this->company_mask; }
protected: protected:
Window *window; ///< Window to be drawn into. Window *window; ///< Window to be drawn into.
const uint widget_id; ///< ID of Widget in Window to be drawn to. const uint widget_id; ///< ID of Widget in Window to be drawn to.
CargoTypes cargo_mask; ///< Bitmask of cargos to be displayed. CargoTypes cargo_mask; ///< Bitmask of cargos to be displayed.
uint32 company_mask; ///< Bitmask of companies to be displayed. CompanyMask company_mask; ///< Bitmask of companies to be displayed.
LinkMap cached_links; ///< Cache for links to reduce recalculation. LinkMap cached_links; ///< Cache for links to reduce recalculation.
StationSupplyList cached_stations; ///< Cache for stations to be drawn. StationSupplyList cached_stations; ///< Cache for stations to be drawn.
uint scale; ///< Width of link lines. uint scale; ///< Width of link lines.

View File

@ -1594,7 +1594,7 @@ int SmallMapWindow::GetPositionOnLegend(Point pt)
if (!this->refresh.Elapsed(delta_ms)) return; if (!this->refresh.Elapsed(delta_ms)) return;
if (this->map_type == SMT_LINKSTATS) { if (this->map_type == SMT_LINKSTATS) {
uint32 company_mask = this->GetOverlayCompanyMask(); CompanyMask company_mask = this->GetOverlayCompanyMask();
if (this->overlay->GetCompanyMask() != company_mask) { if (this->overlay->GetCompanyMask() != company_mask) {
this->overlay->SetCompanyMask(company_mask); this->overlay->SetCompanyMask(company_mask);
} else { } else {

View File

@ -151,9 +151,9 @@ protected:
* the _local_company. Spectators get to see all companies' links. * the _local_company. Spectators get to see all companies' links.
* @return Company mask. * @return Company mask.
*/ */
inline uint32 GetOverlayCompanyMask() const inline CompanyMask GetOverlayCompanyMask() const
{ {
return Company::IsValidID(_local_company) ? 1U << _local_company : 0xffffffff; return Company::IsValidID(_local_company) ? 1U << _local_company : MAX_UVALUE(CompanyMask);
} }
void RebuildColourIndexIfNecessary(); void RebuildColourIndexIfNecessary();