diff --git a/src/script/api/script_engine.cpp b/src/script/api/script_engine.cpp index 22caa1fad9..bc0071301a 100644 --- a/src/script/api/script_engine.cpp +++ b/src/script/api/script_engine.cpp @@ -94,9 +94,8 @@ case VEH_ROAD: case VEH_TRAIN: { CargoArray capacities = GetCapacityOfArticulatedParts(engine_id); - for (CargoID c = 0; c < NUM_CARGO; c++) { - if (capacities[c] == 0) continue; - return capacities[c]; + for (uint &cap : capacities) { + if (cap != 0) return cap; } return -1; } diff --git a/src/script/api/script_event_types.cpp b/src/script/api/script_event_types.cpp index 5b5f432379..64b6acb3bc 100644 --- a/src/script/api/script_event_types.cpp +++ b/src/script/api/script_event_types.cpp @@ -62,9 +62,8 @@ int32_t ScriptEventEnginePreview::GetCapacity() case VEH_ROAD: case VEH_TRAIN: { CargoArray capacities = GetCapacityOfArticulatedParts(this->engine); - for (CargoID c = 0; c < NUM_CARGO; c++) { - if (capacities[c] == 0) continue; - return capacities[c]; + for (uint &cap : capacities) { + if (cap != 0) return cap; } return -1; } diff --git a/src/vehicle_gui.cpp b/src/vehicle_gui.cpp index 3a9ddbdc8a..dff391c8a9 100644 --- a/src/vehicle_gui.cpp +++ b/src/vehicle_gui.cpp @@ -1373,8 +1373,8 @@ static bool VehicleCargoSorter(const Vehicle * const &a, const Vehicle * const & for (v = b; v != nullptr; v = v->Next()) diff[v->cargo_type] -= v->cargo_cap; int r = 0; - for (CargoID i = 0; i < NUM_CARGO; i++) { - r = diff[i]; + for (uint d : diff) { + r = d; if (r != 0) break; }