From 292f4baf462107847c9b00bda6c6c94536ed5d70 Mon Sep 17 00:00:00 2001 From: Rubidium Date: Sun, 2 Feb 2025 06:57:47 +0100 Subject: [PATCH] Doc: cross-reference Emscripten version number locations --- .github/workflows/ci-emscripten.yml | 5 ++++- .github/workflows/preview-build.yml | 5 ++++- os/emscripten/Dockerfile | 2 ++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-emscripten.yml b/.github/workflows/ci-emscripten.yml index 30cd2e8449..d115ea9e56 100644 --- a/.github/workflows/ci-emscripten.yml +++ b/.github/workflows/ci-emscripten.yml @@ -12,7 +12,8 @@ jobs: runs-on: ubuntu-latest container: - # If you change this version, change the number in the cache step too. + # If you change this version, change the numbers in the cache step, + # .github/workflows/preview-build.yml (2x) and os/emscripten/Dockerfile too. image: emscripten/emsdk:3.1.57 steps: @@ -33,6 +34,8 @@ jobs: - name: Setup cache uses: actions/cache@v4 with: + # If you change this version, change the numbers in the image configuration step, + # .github/workflows/preview-build.yml (2x) and os/emscripten/Dockerfile too. path: /emsdk/upstream/emscripten/cache key: 3.1.57-${{ runner.os }} diff --git a/.github/workflows/preview-build.yml b/.github/workflows/preview-build.yml index 9cf6e9573c..1a3a3ddc80 100644 --- a/.github/workflows/preview-build.yml +++ b/.github/workflows/preview-build.yml @@ -20,7 +20,8 @@ jobs: runs-on: ubuntu-latest container: - # If you change this version, change the number in the cache step too. + # If you change this version, change the numbers in the cache step, + # .github/workflows/ci-emscripten.yml (2x) and os/emscripten/Dockerfile too. image: emscripten/emsdk:3.1.57 steps: @@ -38,6 +39,8 @@ jobs: uses: actions/cache@v4 with: path: /emsdk/upstream/emscripten/cache + # If you change this version, change the numbers in the image configuration step, + # .github/workflows/ci-emscripten.yml (2x) and os/emscripten/Dockerfile too. key: 3.1.57-${{ runner.os }} - name: Add liblzma support diff --git a/os/emscripten/Dockerfile b/os/emscripten/Dockerfile index 57c332b1e3..e429867f1d 100644 --- a/os/emscripten/Dockerfile +++ b/os/emscripten/Dockerfile @@ -1,3 +1,5 @@ +# If you change this version, change the numbers in .github/workflows/ci-emscripten.yml (2x) +# and .github/workflows/preview-build.yml (2x) too. FROM emscripten/emsdk:3.1.57 RUN apt-get update \