From 0abebfce1cfc935e2d18700c83cf941ec75e08c0 Mon Sep 17 00:00:00 2001 From: Peter Nelson Date: Tue, 29 Apr 2025 23:52:46 +0100 Subject: [PATCH] Codechange: Use result of .find() instead of looking up multiple times. (#14154) --- src/script/script_scanner.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/script/script_scanner.cpp b/src/script/script_scanner.cpp index c685a6ee7b..65a8120a67 100644 --- a/src/script/script_scanner.cpp +++ b/src/script/script_scanner.cpp @@ -103,20 +103,20 @@ void ScriptScanner::RegisterScript(ScriptInfo *info) return; } - if (this->info_list.find(script_name) != this->info_list.end()) { + if (auto it = this->info_list.find(script_name); it != this->info_list.end()) { /* This script was already registered */ #ifdef _WIN32 /* Windows doesn't care about the case */ - if (StrEqualsIgnoreCase(this->info_list[script_name]->GetMainScript(), info->GetMainScript())) { + if (StrEqualsIgnoreCase(it->second->GetMainScript(), info->GetMainScript())) { #else - if (this->info_list[script_name]->GetMainScript() == info->GetMainScript()) { + if (it->second->GetMainScript() == info->GetMainScript()) { #endif delete info; return; } Debug(script, 1, "Registering two scripts with the same name and version"); - Debug(script, 1, " 1: {}", this->info_list[script_name]->GetMainScript()); + Debug(script, 1, " 1: {}", it->second->GetMainScript()); Debug(script, 1, " 2: {}", info->GetMainScript()); Debug(script, 1, "The first is taking precedence.");