mirror
/
OpenTTD
mirror of https://github.com/OpenTTD/OpenTTD
1
0
Fork 0
Code Issues

Fix: virtual call from constructor 

That fills an instance variable that is only read from the Game Options window
and that is overwritten when the video driver is started. Since you cannot get
into the Game Options window without starting the video driver, it is just
pointless and wrong code that would never be noticed by the end user.
pull/10326/head
Rubidium 2023-01-06 18:31:29 +01:00 committed by rubidium42
parent c1ff471c77
commit 0251786f46
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/video/sdl2_v.h
View File

@ -17,7 +17,7 @@
/** The SDL video driver. */
class VideoDriver_SDL_Base : public VideoDriver {
public:
VideoDriver_SDL_Base() : sdl_window(nullptr), buffer_locked(false), driver_info(this->GetName()) {}
VideoDriver_SDL_Base() : sdl_window(nullptr), buffer_locked(false) {}
const char *Start(const StringList &param) override;
@ -41,8 +41,6 @@ public:
std::vector<int> GetListOfMonitorRefreshRates() override;
const char *GetName() const override { return "sdl"; }
const char *GetInfoString() const override { return this->driver_info.c_str(); }
protected: